Dear Chris Ball,
Hi,
On Wed, Aug 22 2012, Marek Vasut wrote:
Signed-off-by: Marek Vasut ma...@denx.de
Cc: Chris Ball c...@laptop.org
Cc: Shawn Guo shawn@linaro.org
Cc: Mark Brown broo...@opensource.wolfsonmicro.com
Cc: Fabio Estevam fabio.este...@freescale.com
---
drivers/spi/spi-mxs.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/spi/spi-mxs.c b/drivers/spi/spi-mxs.c
index 331f600..c965cc6 100644
--- a/drivers/spi/spi-mxs.c
+++ b/drivers/spi/spi-mxs.c
@@ -230,7 +230,7 @@ static int mxs_spi_txrx_dma(struct mxs_spi *spi, int
cs,
return -EINVAL;
}
- init_completion(spi-c);
+ INIT_COMPLETION(spi-c);
if (*first)
pio |= BM_SSP_CTRL0_LOCK_CS;
@@ -560,6 +560,8 @@ static int __devinit mxs_spi_probe(struct
platform_device *pdev)
ssp-devid = devid;
ssp-dma_channel = dma_channel;
+ init_completion(spi-c);
+
ret = devm_request_irq(pdev-dev, irq_err, mxs_ssp_irq_handler, 0,
DRIVER_NAME, ssp);
if (ret)
Please be more specific with commit messages
I kind of expected this change was pretty obvious.
is there an observed symptom that this fixes?
None. I noticed this misuse, so I fixed it.
Does the patch need to go to stable@, too?
No, this driver is in -next currently.
Thanks,
- Chris.
Best regards,
Marek Vasut
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
