Re: [Spice-devel] [PATCH 2/9] build: require c99
Why do you want to require c99? Do the compilers we use on windows have good enough c99 support? Christophe On Tue, Jan 25, 2011 at 07:17:21PM +0100, Marc-André Lureau wrote: --- configure.ac |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/configure.ac b/configure.ac index 02ec331..2af3647 100644 --- a/configure.ac +++ b/configure.ac @@ -18,6 +18,10 @@ SPICE_COMMON_SRCDIR='$(top_srcdir)'/common AS_IF([test $CFLAGS = ], [], [_cflags_is_set=yes]) AC_PROG_CC +AC_PROG_CC_C99 +if test x$ac_cv_prog_cc_c99 = xno; then +AC_MSG_ERROR([C99 compiler is required.]) +fi AS_IF([test $CXXFLAGS = ], [], [_cxxflags_is_set=yes]) AC_PROG_CXX AC_PROG_INSTALL -- 1.7.3.4 pgpvFO8pV7Ar7.pgp Description: PGP signature ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [PATCH 2/9] build: require c99
- Original Message - Why do you want to require c99? Do the compilers we use on windows have good enough c99 support? Because we use c99: stdbool.h, inttypes.h, bool, variadic macros, // comments, ... Actually, I wonder if 43c5b4f97334f0f4ca61bdd679b68d079575deac is redundant if we use that patch. regards -- Marc-André Lureau ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [PATCH 2/9] build: require c99
On Wed, Apr 27, 2011 at 07:22:34AM -0400, Marc-André Lureau wrote: - Original Message - Why do you want to require c99? Do the compilers we use on windows have good enough c99 support? Because we use c99: stdbool.h, inttypes.h, bool, variadic macros, // comments, ... Actually, I wonder if 43c5b4f97334f0f4ca61bdd679b68d079575deac is redundant if we use that patch. Your patch looks better though if autoconf has dedicated macros to switch to c99 Christophe pgpxwgd8RBRCE.pgp Description: PGP signature ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
