Re: [Spice-devel] [PATCH spice-gtk] spice-channel: Fix usbredir being broken since commit 159c6ebf

2013-09-30 Thread Hans de Goede

Hi,

On 09/30/2013 02:13 AM, Marc-André Lureau wrote:

ack,

can you add bug ref to commit msg?
https://bugs.freedesktop.org/show_bug.cgi?id=69935


Done and pushed.


thanks for tracking this down.


You're welcome.


I'll update the fedora packages.


Thanks.

Regards,

Hans




- Original Message -

The usbredir channel uses spice_msg_in_raw to get its data, which uses
in-dpos to determine the msg size and that was no longer being set for
non sub-messages.

Signed-off-by: Hans de Goede hdego...@redhat.com
---
  gtk/spice-channel.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/gtk/spice-channel.c b/gtk/spice-channel.c
index b01b820..150636e 100644
--- a/gtk/spice-channel.c
+++ b/gtk/spice-channel.c
@@ -1790,6 +1790,7 @@ void spice_channel_recv_msg(SpiceChannel *channel,
  spice_channel_read(channel, in-data, msg_size);
  if (c-has_error)
  goto end;
+in-dpos = msg_size;

  msg_type = spice_header_get_msg_type(in-header, c-use_mini_header);
  sub_list_offset = spice_header_get_msg_sub_list(in-header,
  c-use_mini_header);
--
1.8.3.1

___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel


___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel


[Spice-devel] [PATCH spice-gtk] spice-channel: Fix usbredir being broken since commit 159c6ebf

2013-09-29 Thread Hans de Goede
The usbredir channel uses spice_msg_in_raw to get its data, which uses
in-dpos to determine the msg size and that was no longer being set for
non sub-messages.

Signed-off-by: Hans de Goede hdego...@redhat.com
---
 gtk/spice-channel.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gtk/spice-channel.c b/gtk/spice-channel.c
index b01b820..150636e 100644
--- a/gtk/spice-channel.c
+++ b/gtk/spice-channel.c
@@ -1790,6 +1790,7 @@ void spice_channel_recv_msg(SpiceChannel *channel,
 spice_channel_read(channel, in-data, msg_size);
 if (c-has_error)
 goto end;
+in-dpos = msg_size;
 
 msg_type = spice_header_get_msg_type(in-header, c-use_mini_header);
 sub_list_offset = spice_header_get_msg_sub_list(in-header, 
c-use_mini_header);
-- 
1.8.3.1

___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel


Re: [Spice-devel] [PATCH spice-gtk] spice-channel: Fix usbredir being broken since commit 159c6ebf

2013-09-29 Thread Marc-André Lureau
ack,

can you add bug ref to commit msg?
https://bugs.freedesktop.org/show_bug.cgi?id=69935

thanks for tracking this down.
I'll update the fedora packages.

- Original Message -
 The usbredir channel uses spice_msg_in_raw to get its data, which uses
 in-dpos to determine the msg size and that was no longer being set for
 non sub-messages.
 
 Signed-off-by: Hans de Goede hdego...@redhat.com
 ---
  gtk/spice-channel.c | 1 +
  1 file changed, 1 insertion(+)
 
 diff --git a/gtk/spice-channel.c b/gtk/spice-channel.c
 index b01b820..150636e 100644
 --- a/gtk/spice-channel.c
 +++ b/gtk/spice-channel.c
 @@ -1790,6 +1790,7 @@ void spice_channel_recv_msg(SpiceChannel *channel,
  spice_channel_read(channel, in-data, msg_size);
  if (c-has_error)
  goto end;
 +in-dpos = msg_size;
  
  msg_type = spice_header_get_msg_type(in-header, c-use_mini_header);
  sub_list_offset = spice_header_get_msg_sub_list(in-header,
  c-use_mini_header);
 --
 1.8.3.1
 
 ___
 Spice-devel mailing list
 Spice-devel@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/spice-devel
 
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel