Re: [Spice-devel] [PATCH spice-gtk 00/14] USB fail early on win32 without usbclerk v2
Hi After a rebase, I finally pushed this series. thanks On Fri, Jun 27, 2014 at 5:16 PM, Jonathon Jongsma wrote: > Oops, that last message wasn't intended to go to the list. Oh well. I > found some time to look yesterday, and I'm comfortable ACKing the v2 > series. Sorry it took so long. > > Cheers, > Jonathon > > > - Original Message - > > From: "Jonathon Jongsma" > > To: "Marc-André Lureau" > > Cc: spice-de...@freedesktop.org > > Sent: Thursday, June 26, 2014 3:15:15 PM > > Subject: Re: [Spice-devel] [PATCH spice-gtk 00/14] USB fail early on > win32 without usbclerk v2 > > > > Whoa, that's a bit old, eh? Give me a little time and I'll take a look. > > > > > > > > > > > > On Thu, 2014-06-26 at 16:45 +0200, Marc-André Lureau wrote: > > > Jonathon, ack this version? > > > > > > > > > > > > On Mon, Apr 28, 2014 at 4:29 PM, Cody Chan wrote: > > > Hi, thx for your great work, I wonder when these patches will > > > be in git upstream? > > > > > > > > > On Thu, Apr 24, 2014 at 11:50 PM, Marc-André Lureau > > > wrote: > > > > > > Hi, > > > > > > Here is a small series, of little cleanups, and of > > > goal to throw early > > > an error when the win32 usbclerk can't be reached. In > > > turn, the error > > > can be catched by client code to show a useful dialog. > > > > > > In v2: > > > - fixes after Jonathon Jongsma review > > > > > > Marc-André Lureau (14): > > > usb: remove useless declaration > > > win-usb: introduce a spice_win_usb_driver_op_finish > > > win-usb: rename async functions > > > usb: use win-usb uninstall_finish() > > > win-usb: throw an error if reply.status == 0 > > > win-usb: get rid of status code return in async ops > > > usb: remove useless device ref/unref > > > usb: remove useless assignment > > > usb: use SPICE_CLIENT_ERROR_ prefix > > > usb: call win_usb_driver_new() during > > > initable_init() > > > usb: misc code formatting > > > win-usb: remove useless function > > > usb: do not return GError on programmer > > > pre-condition checks > > > win-usb: try to connect to usbclerk during init > > > > > > gtk/channel-usbredir.c | 4 +- > > > gtk/spice-client.h | 13 +++- > > > gtk/usb-device-manager.c | 127 > > > --- > > > gtk/win-usb-driver-install.c | 140 > > > ++- > > > gtk/win-usb-driver-install.h | 28 + > > > 5 files changed, 162 insertions(+), 150 deletions(-) > > > > > > > > > -- > > > 1.8.5.3 > > > > > > ___ > > > Spice-devel mailing list > > > Spice-devel@lists.freedesktop.org > > > > http://lists.freedesktop.org/mailman/listinfo/spice-devel > > > > > > > > > > > > > > > > > > -- > > > Marc-André Lureau > > > > > > ___ > > Spice-devel mailing list > > Spice-devel@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/spice-devel > > > -- Marc-André Lureau ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [PATCH spice-gtk 00/14] USB fail early on win32 without usbclerk v2
Oops, that last message wasn't intended to go to the list. Oh well. I found some time to look yesterday, and I'm comfortable ACKing the v2 series. Sorry it took so long. Cheers, Jonathon - Original Message - > From: "Jonathon Jongsma" > To: "Marc-André Lureau" > Cc: spice-de...@freedesktop.org > Sent: Thursday, June 26, 2014 3:15:15 PM > Subject: Re: [Spice-devel] [PATCH spice-gtk 00/14] USB fail early on win32 > without usbclerk v2 > > Whoa, that's a bit old, eh? Give me a little time and I'll take a look. > > > > > > On Thu, 2014-06-26 at 16:45 +0200, Marc-André Lureau wrote: > > Jonathon, ack this version? > > > > > > > > On Mon, Apr 28, 2014 at 4:29 PM, Cody Chan wrote: > > Hi, thx for your great work, I wonder when these patches will > > be in git upstream? > > > > > > On Thu, Apr 24, 2014 at 11:50 PM, Marc-André Lureau > > wrote: > > > > Hi, > > > > Here is a small series, of little cleanups, and of > > goal to throw early > > an error when the win32 usbclerk can't be reached. In > > turn, the error > > can be catched by client code to show a useful dialog. > > > > In v2: > > - fixes after Jonathon Jongsma review > > > > Marc-André Lureau (14): > > usb: remove useless declaration > > win-usb: introduce a spice_win_usb_driver_op_finish > > win-usb: rename async functions > > usb: use win-usb uninstall_finish() > > win-usb: throw an error if reply.status == 0 > > win-usb: get rid of status code return in async ops > > usb: remove useless device ref/unref > > usb: remove useless assignment > > usb: use SPICE_CLIENT_ERROR_ prefix > > usb: call win_usb_driver_new() during > > initable_init() > > usb: misc code formatting > > win-usb: remove useless function > > usb: do not return GError on programmer > > pre-condition checks > > win-usb: try to connect to usbclerk during init > > > > gtk/channel-usbredir.c | 4 +- > > gtk/spice-client.h | 13 +++- > > gtk/usb-device-manager.c | 127 > > --- > > gtk/win-usb-driver-install.c | 140 > > ++- > > gtk/win-usb-driver-install.h | 28 + > > 5 files changed, 162 insertions(+), 150 deletions(-) > > > > > > -- > > 1.8.5.3 > > > > ___ > > Spice-devel mailing list > > Spice-devel@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/spice-devel > > > > > > > > > > > > -- > > Marc-André Lureau > > > ___ > Spice-devel mailing list > Spice-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/spice-devel > ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [PATCH spice-gtk 00/14] USB fail early on win32 without usbclerk v2
Whoa, that's a bit old, eh? Give me a little time and I'll take a look. On Thu, 2014-06-26 at 16:45 +0200, Marc-André Lureau wrote: > Jonathon, ack this version? > > > > On Mon, Apr 28, 2014 at 4:29 PM, Cody Chan wrote: > Hi, thx for your great work, I wonder when these patches will > be in git upstream? > > > On Thu, Apr 24, 2014 at 11:50 PM, Marc-André Lureau > wrote: > > Hi, > > Here is a small series, of little cleanups, and of > goal to throw early > an error when the win32 usbclerk can't be reached. In > turn, the error > can be catched by client code to show a useful dialog. > > In v2: > - fixes after Jonathon Jongsma review > > Marc-André Lureau (14): > usb: remove useless declaration > win-usb: introduce a spice_win_usb_driver_op_finish > win-usb: rename async functions > usb: use win-usb uninstall_finish() > win-usb: throw an error if reply.status == 0 > win-usb: get rid of status code return in async ops > usb: remove useless device ref/unref > usb: remove useless assignment > usb: use SPICE_CLIENT_ERROR_ prefix > usb: call win_usb_driver_new() during > initable_init() > usb: misc code formatting > win-usb: remove useless function > usb: do not return GError on programmer > pre-condition checks > win-usb: try to connect to usbclerk during init > > gtk/channel-usbredir.c | 4 +- > gtk/spice-client.h | 13 +++- > gtk/usb-device-manager.c | 127 > --- > gtk/win-usb-driver-install.c | 140 > ++- > gtk/win-usb-driver-install.h | 28 + > 5 files changed, 162 insertions(+), 150 deletions(-) > > > -- > 1.8.5.3 > > ___ > Spice-devel mailing list > Spice-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/spice-devel > > > > > > -- > Marc-André Lureau ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [PATCH spice-gtk 00/14] USB fail early on win32 without usbclerk v2
Jonathon, ack this version? On Mon, Apr 28, 2014 at 4:29 PM, Cody Chan wrote: > Hi, thx for your great work, I wonder when these patches will be in git > upstream? > > > On Thu, Apr 24, 2014 at 11:50 PM, Marc-André Lureau < > marcandre.lur...@gmail.com> wrote: > >> Hi, >> >> Here is a small series, of little cleanups, and of goal to throw early >> an error when the win32 usbclerk can't be reached. In turn, the error >> can be catched by client code to show a useful dialog. >> >> In v2: >> - fixes after Jonathon Jongsma review >> >> Marc-André Lureau (14): >> usb: remove useless declaration >> win-usb: introduce a spice_win_usb_driver_op_finish >> win-usb: rename async functions >> usb: use win-usb uninstall_finish() >> win-usb: throw an error if reply.status == 0 >> win-usb: get rid of status code return in async ops >> usb: remove useless device ref/unref >> usb: remove useless assignment >> usb: use SPICE_CLIENT_ERROR_ prefix >> usb: call win_usb_driver_new() during initable_init() >> usb: misc code formatting >> win-usb: remove useless function >> usb: do not return GError on programmer pre-condition checks >> win-usb: try to connect to usbclerk during init >> >> gtk/channel-usbredir.c | 4 +- >> gtk/spice-client.h | 13 +++- >> gtk/usb-device-manager.c | 127 >> --- >> gtk/win-usb-driver-install.c | 140 >> ++- >> gtk/win-usb-driver-install.h | 28 + >> 5 files changed, 162 insertions(+), 150 deletions(-) >> >> -- >> 1.8.5.3 >> >> ___ >> Spice-devel mailing list >> Spice-devel@lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/spice-devel >> > > -- Marc-André Lureau ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [PATCH spice-gtk 00/14] USB fail early on win32 without usbclerk v2
Hi, thx for your great work, I wonder when these patches will be in git upstream? On Thu, Apr 24, 2014 at 11:50 PM, Marc-André Lureau < marcandre.lur...@gmail.com> wrote: > Hi, > > Here is a small series, of little cleanups, and of goal to throw early > an error when the win32 usbclerk can't be reached. In turn, the error > can be catched by client code to show a useful dialog. > > In v2: > - fixes after Jonathon Jongsma review > > Marc-André Lureau (14): > usb: remove useless declaration > win-usb: introduce a spice_win_usb_driver_op_finish > win-usb: rename async functions > usb: use win-usb uninstall_finish() > win-usb: throw an error if reply.status == 0 > win-usb: get rid of status code return in async ops > usb: remove useless device ref/unref > usb: remove useless assignment > usb: use SPICE_CLIENT_ERROR_ prefix > usb: call win_usb_driver_new() during initable_init() > usb: misc code formatting > win-usb: remove useless function > usb: do not return GError on programmer pre-condition checks > win-usb: try to connect to usbclerk during init > > gtk/channel-usbredir.c | 4 +- > gtk/spice-client.h | 13 +++- > gtk/usb-device-manager.c | 127 --- > gtk/win-usb-driver-install.c | 140 > ++- > gtk/win-usb-driver-install.h | 28 + > 5 files changed, 162 insertions(+), 150 deletions(-) > > -- > 1.8.5.3 > > ___ > Spice-devel mailing list > Spice-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/spice-devel > ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
[Spice-devel] [PATCH spice-gtk 00/14] USB fail early on win32 without usbclerk v2
Hi, Here is a small series, of little cleanups, and of goal to throw early an error when the win32 usbclerk can't be reached. In turn, the error can be catched by client code to show a useful dialog. In v2: - fixes after Jonathon Jongsma review Marc-André Lureau (14): usb: remove useless declaration win-usb: introduce a spice_win_usb_driver_op_finish win-usb: rename async functions usb: use win-usb uninstall_finish() win-usb: throw an error if reply.status == 0 win-usb: get rid of status code return in async ops usb: remove useless device ref/unref usb: remove useless assignment usb: use SPICE_CLIENT_ERROR_ prefix usb: call win_usb_driver_new() during initable_init() usb: misc code formatting win-usb: remove useless function usb: do not return GError on programmer pre-condition checks win-usb: try to connect to usbclerk during init gtk/channel-usbredir.c | 4 +- gtk/spice-client.h | 13 +++- gtk/usb-device-manager.c | 127 --- gtk/win-usb-driver-install.c | 140 ++- gtk/win-usb-driver-install.h | 28 + 5 files changed, 162 insertions(+), 150 deletions(-) -- 1.8.5.3 ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
