Re: [Spice-devel] [PATCH spice-protocol 2/8 v3] Add the StreamMsgGraphicsDeviceInfo message
Hi,
On Thu, 2019-01-17 at 11:23 -0600, Jonathon Jongsma wrote:
> Accidentally sent this on the v2 series, but I'll repeat it here:
>
> Commit subject mentions the wrong type name?
> StreamMsgGraphicsDeviceInfo != StreamMsgDeviceDisplayInfo
You're right, I'll fix it.
> On Wed, 2019-01-16 at 13:52 +0100, Lukáš Hrázký wrote:
> > The message contains information about the graphics device and
> > monitor
> > belonging to a particular video stream (which maps to a channel) from
> > the streaming agent.
> >
> > Signed-off-by: Lukáš Hrázký
> > Acked-by: Frediano Ziglio
> > ---
> > spice/stream-device.h | 31 +++
> > 1 file changed, 31 insertions(+)
> >
> > diff --git a/spice/stream-device.h b/spice/stream-device.h
> > index 6add42b..c70690a 100644
> > --- a/spice/stream-device.h
> > +++ b/spice/stream-device.h
> > @@ -90,6 +90,8 @@ typedef enum StreamMsgType {
> > STREAM_TYPE_CURSOR_SET,
> > /* guest cursor position */
> > STREAM_TYPE_CURSOR_MOVE,
> > +/* the graphics device display information message (device
> > address and display id) */
> > +STREAM_TYPE_DEVICE_DISPLAY_INFO,
> > } StreamMsgType;
> >
> > typedef enum StreamCapabilities {
> > @@ -140,6 +142,35 @@ typedef struct StreamMsgData {
> > uint8_t data[0];
> > } StreamMsgData;
> >
> > +/* This message contains information about the graphics device and
> > monitor
> > + * belonging to a particular video stream (which maps to a channel)
> > from
> > + * the streaming agent.
> > + *
> > + * The device_address is the hardware address of the device (e.g.
> > PCI),
> > + * device_display_id is the id of the monitor on the device.
> > + *
> > + * The supported device address format is:
> > + * "pci//./.../."
> > + *
> > + * The "pci" identifies the rest of the string as a PCI address. It
> > is the only
> > + * supported address at the moment, other identifiers can be
> > introduced later.
> > + * is the PCI domain, followed by . of any
> > PCI bridges
> > + * in the chain leading to the device. The last . is
> > the
> > + * graphics device. All of , , are
> > hexadecimal numbers
> > + * with the following number of digits:
> > + * : 4
> > + * : 2
> > + * : 1
> > + *
> > + * Sent from the streaming agent to the server.
> > + */
> > +typedef struct StreamMsgDeviceDisplayInfo {
> > +uint32_t stream_id;
> > +uint32_t device_display_id;
> > +uint32_t device_address_len;
> > +uint8_t device_address[0]; // a zero-terminated string
> > +} StreamMsgDeviceDisplayInfo;
> > +
> > /* Tell to stop current stream and possibly start a new one.
> > * This message is sent by the host to the guest.
> > * Allows to communicate the codecs supported by the clients.
>
>
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [PATCH spice-protocol 2/8 v3] Add the StreamMsgGraphicsDeviceInfo message
Accidentally sent this on the v2 series, but I'll repeat it here:
Commit subject mentions the wrong type name?
StreamMsgGraphicsDeviceInfo != StreamMsgDeviceDisplayInfo
On Wed, 2019-01-16 at 13:52 +0100, Lukáš Hrázký wrote:
> The message contains information about the graphics device and
> monitor
> belonging to a particular video stream (which maps to a channel) from
> the streaming agent.
>
> Signed-off-by: Lukáš Hrázký
> Acked-by: Frediano Ziglio
> ---
> spice/stream-device.h | 31 +++
> 1 file changed, 31 insertions(+)
>
> diff --git a/spice/stream-device.h b/spice/stream-device.h
> index 6add42b..c70690a 100644
> --- a/spice/stream-device.h
> +++ b/spice/stream-device.h
> @@ -90,6 +90,8 @@ typedef enum StreamMsgType {
> STREAM_TYPE_CURSOR_SET,
> /* guest cursor position */
> STREAM_TYPE_CURSOR_MOVE,
> +/* the graphics device display information message (device
> address and display id) */
> +STREAM_TYPE_DEVICE_DISPLAY_INFO,
> } StreamMsgType;
>
> typedef enum StreamCapabilities {
> @@ -140,6 +142,35 @@ typedef struct StreamMsgData {
> uint8_t data[0];
> } StreamMsgData;
>
> +/* This message contains information about the graphics device and
> monitor
> + * belonging to a particular video stream (which maps to a channel)
> from
> + * the streaming agent.
> + *
> + * The device_address is the hardware address of the device (e.g.
> PCI),
> + * device_display_id is the id of the monitor on the device.
> + *
> + * The supported device address format is:
> + * "pci//./.../."
> + *
> + * The "pci" identifies the rest of the string as a PCI address. It
> is the only
> + * supported address at the moment, other identifiers can be
> introduced later.
> + * is the PCI domain, followed by . of any
> PCI bridges
> + * in the chain leading to the device. The last . is
> the
> + * graphics device. All of , , are
> hexadecimal numbers
> + * with the following number of digits:
> + * : 4
> + * : 2
> + * : 1
> + *
> + * Sent from the streaming agent to the server.
> + */
> +typedef struct StreamMsgDeviceDisplayInfo {
> +uint32_t stream_id;
> +uint32_t device_display_id;
> +uint32_t device_address_len;
> +uint8_t device_address[0]; // a zero-terminated string
> +} StreamMsgDeviceDisplayInfo;
> +
> /* Tell to stop current stream and possibly start a new one.
> * This message is sent by the host to the guest.
> * Allows to communicate the codecs supported by the clients.
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
[Spice-devel] [PATCH spice-protocol 2/8 v3] Add the StreamMsgGraphicsDeviceInfo message
The message contains information about the graphics device and monitor
belonging to a particular video stream (which maps to a channel) from
the streaming agent.
Signed-off-by: Lukáš Hrázký
Acked-by: Frediano Ziglio
---
spice/stream-device.h | 31 +++
1 file changed, 31 insertions(+)
diff --git a/spice/stream-device.h b/spice/stream-device.h
index 6add42b..c70690a 100644
--- a/spice/stream-device.h
+++ b/spice/stream-device.h
@@ -90,6 +90,8 @@ typedef enum StreamMsgType {
STREAM_TYPE_CURSOR_SET,
/* guest cursor position */
STREAM_TYPE_CURSOR_MOVE,
+/* the graphics device display information message (device address and
display id) */
+STREAM_TYPE_DEVICE_DISPLAY_INFO,
} StreamMsgType;
typedef enum StreamCapabilities {
@@ -140,6 +142,35 @@ typedef struct StreamMsgData {
uint8_t data[0];
} StreamMsgData;
+/* This message contains information about the graphics device and monitor
+ * belonging to a particular video stream (which maps to a channel) from
+ * the streaming agent.
+ *
+ * The device_address is the hardware address of the device (e.g. PCI),
+ * device_display_id is the id of the monitor on the device.
+ *
+ * The supported device address format is:
+ * "pci//./.../."
+ *
+ * The "pci" identifies the rest of the string as a PCI address. It is the only
+ * supported address at the moment, other identifiers can be introduced later.
+ * is the PCI domain, followed by . of any PCI bridges
+ * in the chain leading to the device. The last . is the
+ * graphics device. All of , , are hexadecimal numbers
+ * with the following number of digits:
+ * : 4
+ * : 2
+ * : 1
+ *
+ * Sent from the streaming agent to the server.
+ */
+typedef struct StreamMsgDeviceDisplayInfo {
+uint32_t stream_id;
+uint32_t device_display_id;
+uint32_t device_address_len;
+uint8_t device_address[0]; // a zero-terminated string
+} StreamMsgDeviceDisplayInfo;
+
/* Tell to stop current stream and possibly start a new one.
* This message is sent by the host to the guest.
* Allows to communicate the codecs supported by the clients.
--
2.20.1
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
