Re: [Spice-devel] [PATCH spice-protocol v2] vdagent: add keyboard description message

2014-11-05 Thread Marc-André Lureau
Hi

- Original Message -
 The message will be used for transferring the keyboard layout
 from the client to the guest. When the agent receives this message,
 it tries to set the specified keyboard layout.
 

Your commit message is all we have as a reference for the protocol:
you need to give more details about the content of the message.

If possible examples too.


 RFE: https://bugs.freedesktop.org/show_bug.cgi?id=85332
 ---
 v2:
  - the message is a string which is based on xkb symbols or on windows locale
(eg pc+us+inet(evdev))
 ---
  spice/vd_agent.h | 1 +
  1 file changed, 1 insertion(+)
 
 diff --git a/spice/vd_agent.h b/spice/vd_agent.h
 index 7464661..4dacb25 100644
 --- a/spice/vd_agent.h
 +++ b/spice/vd_agent.h
 @@ -77,6 +77,7 @@ enum {
  VD_AGENT_FILE_XFER_DATA,
  VD_AGENT_CLIENT_DISCONNECTED,
  VD_AGENT_MAX_CLIPBOARD,
 +VD_AGENT_KEYBOARD_DESCRIPTION,
  VD_AGENT_END_MESSAGE,
  };
  
 --
 1.9.3
 
 ___
 Spice-devel mailing list
 Spice-devel@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/spice-devel
 
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel


[Spice-devel] [PATCH spice-protocol v2] vdagent: add keyboard description message

2014-11-04 Thread Pavel Grunt
The message will be used for transferring the keyboard layout
from the client to the guest. When the agent receives this message,
it tries to set the specified keyboard layout.

RFE: https://bugs.freedesktop.org/show_bug.cgi?id=85332
---
v2:
 - the message is a string which is based on xkb symbols or on windows locale
   (eg pc+us+inet(evdev))
---
 spice/vd_agent.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/spice/vd_agent.h b/spice/vd_agent.h
index 7464661..4dacb25 100644
--- a/spice/vd_agent.h
+++ b/spice/vd_agent.h
@@ -77,6 +77,7 @@ enum {
 VD_AGENT_FILE_XFER_DATA,
 VD_AGENT_CLIENT_DISCONNECTED,
 VD_AGENT_MAX_CLIPBOARD,
+VD_AGENT_KEYBOARD_DESCRIPTION,
 VD_AGENT_END_MESSAGE,
 };
 
-- 
1.9.3

___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel