Re: [Spice-devel] [PATCH spice-streaming-agent 0/3] Add an Error to the API
> > Hello, > > this series adds an Error class to the plugin API, to be thrown across > the API boundary. It also makes sure the symbols are properly exported > and the class has RTTI (or more precisely the information used to > identify the exceptions equivalent to RTTI) so that the exception can be > properly caught. > > Cheers, > Lukas > Acked the entire series > Lukáš Hrázký (3): > Make error.hpp and the Error class a public API > Move the syslog() helper for errors to a new utils module > Export symbols in the binary to use by the plugins > > include/spice-streaming-agent/Makefile.am | 1 + > include/spice-streaming-agent/error.hpp | 25 +++ > src/Makefile.am | 7 ++- > src/cursor-updater.cpp| 3 +- > src/error.cpp | 21 - > src/error.hpp | 53 --- > src/frame-log.cpp | 2 +- > src/spice-streaming-agent.cpp | 5 ++- > src/stream-port.cpp | 5 ++- > src/stream-port.hpp | 22 ++ > src/unittests/Makefile.am | 1 - > src/unittests/test-stream-port.cpp| 2 +- > src/utils.hpp | 24 ++ > 13 files changed, 88 insertions(+), 83 deletions(-) > create mode 100644 include/spice-streaming-agent/error.hpp > delete mode 100644 src/error.cpp > delete mode 100644 src/error.hpp > create mode 100644 src/utils.hpp > Frediano ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel
[Spice-devel] [PATCH spice-streaming-agent 0/3] Add an Error to the API
Hello, this series adds an Error class to the plugin API, to be thrown across the API boundary. It also makes sure the symbols are properly exported and the class has RTTI (or more precisely the information used to identify the exceptions equivalent to RTTI) so that the exception can be properly caught. Cheers, Lukas Lukáš Hrázký (3): Make error.hpp and the Error class a public API Move the syslog() helper for errors to a new utils module Export symbols in the binary to use by the plugins include/spice-streaming-agent/Makefile.am | 1 + include/spice-streaming-agent/error.hpp | 25 +++ src/Makefile.am | 7 ++- src/cursor-updater.cpp| 3 +- src/error.cpp | 21 - src/error.hpp | 53 --- src/frame-log.cpp | 2 +- src/spice-streaming-agent.cpp | 5 ++- src/stream-port.cpp | 5 ++- src/stream-port.hpp | 22 ++ src/unittests/Makefile.am | 1 - src/unittests/test-stream-port.cpp| 2 +- src/utils.hpp | 24 ++ 13 files changed, 88 insertions(+), 83 deletions(-) create mode 100644 include/spice-streaming-agent/error.hpp delete mode 100644 src/error.cpp delete mode 100644 src/error.hpp create mode 100644 src/utils.hpp -- 2.19.2 ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel
