Re: [Spice-devel] [PATCH v2 09/13] Add mention of fall-through comments

[Frediano Ziglio]

> 
> > On 7 Feb 2018, at 14:58, Frediano Ziglio  wrote:
> > 
> >> 
> >> From: Christophe de Dinechin 
> >> 
> >> Signed-off-by: Christophe de Dinechin 
> >> ---
> >> docs/spice_style.txt | 2 ++
> >> 1 file changed, 2 insertions(+)
> >> 
> >> diff --git a/docs/spice_style.txt b/docs/spice_style.txt
> >> index ccc60bb3..e35272ec 100644
> >> --- a/docs/spice_style.txt
> >> +++ b/docs/spice_style.txt
> >> @@ -293,6 +293,8 @@ default:
> >> }
> >> 
> >> 
> >> +Use /* Fall through */ comments when there is no break (compilers will
> >> emit
> >> a warning otherwise)
> >> +
> >> Types indentation
> >> ~
> >> 
> > 
> > This comment has not much to do with the "Branching indentation" section
> > beside is under a switch example
> 
> Any other place where you would put it?
> 

Was looking but it does not seem to be a good section for this.
I would add a new section kind of "switch" ? Maybe after "goto"?
I really didn't find any better place.

Frediano
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [PATCH v2 09/13] Add mention of fall-through comments

[Christophe de Dinechin]

> On 7 Feb 2018, at 14:58, Frediano Ziglio  wrote:
> 
>> 
>> From: Christophe de Dinechin 
>> 
>> Signed-off-by: Christophe de Dinechin 
>> ---
>> docs/spice_style.txt | 2 ++
>> 1 file changed, 2 insertions(+)
>> 
>> diff --git a/docs/spice_style.txt b/docs/spice_style.txt
>> index ccc60bb3..e35272ec 100644
>> --- a/docs/spice_style.txt
>> +++ b/docs/spice_style.txt
>> @@ -293,6 +293,8 @@ default:
>> }
>> 
>> 
>> +Use /* Fall through */ comments when there is no break (compilers will emit
>> a warning otherwise)
>> +
>> Types indentation
>> ~
>> 
> 
> This comment has not much to do with the "Branching indentation" section
> beside is under a switch example

Any other place where you would put it?

> 
> Frediano
> ___
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel

___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [PATCH v2 09/13] Add mention of fall-through comments

[Frediano Ziglio]

> 
> From: Christophe de Dinechin 
> 
> Signed-off-by: Christophe de Dinechin 
> ---
>  docs/spice_style.txt | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/docs/spice_style.txt b/docs/spice_style.txt
> index ccc60bb3..e35272ec 100644
> --- a/docs/spice_style.txt
> +++ b/docs/spice_style.txt
> @@ -293,6 +293,8 @@ default:
>  }
>  
>  
> +Use /* Fall through */ comments when there is no break (compilers will emit
> a warning otherwise)
> +
>  Types indentation
>  ~
>  

This comment has not much to do with the "Branching indentation" section
beside is under a switch example

Frediano
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Spice-devel] [PATCH v2 09/13] Add mention of fall-through comments

[Christophe de Dinechin]

From: Christophe de Dinechin 

Signed-off-by: Christophe de Dinechin 
---
 docs/spice_style.txt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/docs/spice_style.txt b/docs/spice_style.txt
index ccc60bb3..e35272ec 100644
--- a/docs/spice_style.txt
+++ b/docs/spice_style.txt
@@ -293,6 +293,8 @@ default:
 }
 
 
+Use /* Fall through */ comments when there is no break (compilers will emit a 
warning otherwise)
+
 Types indentation
 ~
 
-- 
2.13.5 (Apple Git-94)

___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel