Re: [Spice-devel] [PATCH vdagent 01/11] Bump GLib version to 2.34

[Victor Toso]

Hi,

I mostly agree with Daniel, I don't think there is a huge need to
support RHEL 6 upstream at this time.

On Wed, Sep 27, 2017 at 10:23:36AM +, Frediano Ziglio wrote:
> >
> > This is required for the following GMainLoop integration,
> > which utilizes some of the new functions/definitions, namely:
> >
> > [definition][GLib version]
> > g_clear_pointer()   2.34
> > G_SOURCE_REMOVE 2.32
> > G_SOURCE_CONTINUE   2.32
> > g_unix_signal_add() 2.30
>
> Which distribution are we going to not support?
> Surely RHEL 6 which we should support till 2021 (not considering
> extended support).

From spice-gtk:

  commit b312ca0809a7940d6127608e13f21cb48abf
  Author: Victor Toso 
  Date:   Tue Aug 1 11:32:00 2017 +0200

  build-sys: bump glib requirement 2.36 -> 2.46

  At the moment:
  - Fedora 26 has 2.52
  - Fedora 25 has 2.50
  - Fedora 24 has 2.48
  - CentOS 7 has 2.46
  - Debian 9 has 2.50

  Signed-off-by: Victor Toso 
  Acked-by: Marc-André Lureau 

Maybe we could do a release and bump after it and maybe target bigger
release even.

> Can we write some compatibility code?
> g_clear_pointer is just a macro, we have a compatible macro in
> spice-server.
> G_SOURCE_REMOVE and G_SOURCE_CONTINUE are just TRUE/FALSE renamed
> in recent GLib.
> g_unix_signal_add maybe not too difficult to write a compatible
> GSource.

Also, another goal of gtk integration is Wayland. I assume we will need
gtk 3.20 or higher which requires 2.45.8 already...

Cheers,
Victor

>
> > ---
> >  configure.ac | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/configure.ac b/configure.ac
> > index fbc20a9..d92b527 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -85,7 +85,7 @@ AC_ARG_ENABLE([static-uinput],
> >[enable_static_uinput="$enableval"],
> >[enable_static_uinput="no"])
> >  
> > -PKG_CHECK_MODULES([GLIB2], [glib-2.0 >= 2.28])
> > +PKG_CHECK_MODULES([GLIB2], [glib-2.0 >= 2.34])
> >  PKG_CHECK_MODULES(X, [xfixes xrandr >= 1.3 xinerama x11])
> >  PKG_CHECK_MODULES(SPICE, [spice-protocol >= 0.12.13])
> >  PKG_CHECK_MODULES(ALSA, [alsa >= 1.0.22])
> 
> Frediano
> ___
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel


signature.asc
Description: PGP signature
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [PATCH vdagent 01/11] Bump GLib version to 2.34

[Frediano Ziglio]

> 
> This is required for the following GMainLoop integration,
> which utilizes some of the new functions/definitions, namely:
> 
> [definition][GLib version]
> g_clear_pointer()   2.34
> G_SOURCE_REMOVE 2.32
> G_SOURCE_CONTINUE   2.32
> g_unix_signal_add() 2.30

Which distribution are we going to not support?
Surely RHEL 6 which we should support till 2021 (not considering
extended support).

Can we write some compatibility code?
g_clear_pointer is just a macro, we have a compatible macro in
spice-server.
G_SOURCE_REMOVE and G_SOURCE_CONTINUE are just TRUE/FALSE renamed
in recent GLib.
g_unix_signal_add maybe not too difficult to write a compatible
GSource.

> ---
>  configure.ac | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure.ac b/configure.ac
> index fbc20a9..d92b527 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -85,7 +85,7 @@ AC_ARG_ENABLE([static-uinput],
>[enable_static_uinput="$enableval"],
>[enable_static_uinput="no"])
>  
> -PKG_CHECK_MODULES([GLIB2], [glib-2.0 >= 2.28])
> +PKG_CHECK_MODULES([GLIB2], [glib-2.0 >= 2.34])
>  PKG_CHECK_MODULES(X, [xfixes xrandr >= 1.3 xinerama x11])
>  PKG_CHECK_MODULES(SPICE, [spice-protocol >= 0.12.13])
>  PKG_CHECK_MODULES(ALSA, [alsa >= 1.0.22])

Frediano
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Spice-devel] [PATCH vdagent 01/11] Bump GLib version to 2.34

[Jakub Janků]

This is required for the following GMainLoop integration,
which utilizes some of the new functions/definitions, namely:

[definition][GLib version]
g_clear_pointer()   2.34
G_SOURCE_REMOVE 2.32
G_SOURCE_CONTINUE   2.32
g_unix_signal_add() 2.30
---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index fbc20a9..d92b527 100644
--- a/configure.ac
+++ b/configure.ac
@@ -85,7 +85,7 @@ AC_ARG_ENABLE([static-uinput],
   [enable_static_uinput="$enableval"],
   [enable_static_uinput="no"])
 
-PKG_CHECK_MODULES([GLIB2], [glib-2.0 >= 2.28])
+PKG_CHECK_MODULES([GLIB2], [glib-2.0 >= 2.34])
 PKG_CHECK_MODULES(X, [xfixes xrandr >= 1.3 xinerama x11])
 PKG_CHECK_MODULES(SPICE, [spice-protocol >= 0.12.13])
 PKG_CHECK_MODULES(ALSA, [alsa >= 1.0.22])
-- 
2.13.5

___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel