Re: [Spice-devel] [qxl 4/5] build: Error out when enabling xspice with X.Org 1.19

2016-11-07 Thread Christophe Fergeau 
Hi,

On Fri, Nov 04, 2016 at 10:42:17AM -0500, Jeremy White wrote:
> 
> On 10/28/2016 05:18 AM, Christophe Fergeau wrote:
> > xspice needs to be updated to cope with some X.Org 1.19 API changes,
> > better to make that explicit at configure time rather than letting
> > people discover the hard way (it builds with warnings but will not work)
> > that it's broken.
> > ---
> >  configure.ac | 8 ++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)
> > 
> > diff --git a/configure.ac b/configure.ac
> > index 451d42a..2c7bbf7 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -68,7 +68,8 @@ PKG_CHECK_EXISTS(xfont2,
> >  
> >  # Obtain compiler/linker options for the driver dependencies
> >  PKG_CHECK_MODULES(XORG, [xorg-server >= 1.0.99.901] xproto fontsproto 
> > $xfont_pc $REQUIRED_MODULES)
> > -
> > +# Check for xorg 1.19 as XSpice is currently not working with it
> > +PKG_CHECK_EXISTS([XORG119], [xorg-server >= 1.18.99], [has_xorg119=yes], 
> > [:])
> 
> This does not work on my Debian Jessie system with xorg 1.16.
> 
> Shouldn't it be just:
> 
> PKG_CHECK_EXISTS([xorg-server >= 1.18.99], [has_xorg119=yes])

Definitely looks much more correct, though I remember testing this
patch, dunno what happened /o\ I changed it (and retested ;) locally.

Thanks!

Christophe


signature.asc
Description: PGP signature
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [qxl 4/5] build: Error out when enabling xspice with X.Org 1.19

2016-11-04 Thread Jeremy White 
Hey Christophe,

Thanks for driving for a release; it is much appreciated.

On 10/28/2016 05:18 AM, Christophe Fergeau wrote:
> xspice needs to be updated to cope with some X.Org 1.19 API changes,
> better to make that explicit at configure time rather than letting
> people discover the hard way (it builds with warnings but will not work)
> that it's broken.
> ---
>  configure.ac | 8 ++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 451d42a..2c7bbf7 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -68,7 +68,8 @@ PKG_CHECK_EXISTS(xfont2,
>  
>  # Obtain compiler/linker options for the driver dependencies
>  PKG_CHECK_MODULES(XORG, [xorg-server >= 1.0.99.901] xproto fontsproto 
> $xfont_pc $REQUIRED_MODULES)
> -
> +# Check for xorg 1.19 as XSpice is currently not working with it
> +PKG_CHECK_EXISTS([XORG119], [xorg-server >= 1.18.99], [has_xorg119=yes], [:])

This does not work on my Debian Jessie system with xorg 1.16.

Shouldn't it be just:

PKG_CHECK_EXISTS([xorg-server >= 1.18.99], [has_xorg119=yes])

Cheers,

Jeremy


>  
>  save_CFLAGS="$CFLAGS"
>  CFLAGS="$XORG_CFLAGS"
> @@ -139,7 +140,10 @@ if test "x$enable_xspice" = "xyes"; then
>  AC_SUBST(SPICE_CFLAGS)
>  AC_SUBST(SPICE_LIBS)
>  ],
> -)
> +)
> +if test x"${enable_xspice}" = "xyes" && test x"${has_xorg119}" = "xyes"; 
> then
> +AC_MSG_ERROR("XSpice cannot currently work against X.Org 1.19")
> +fi
>  else
>  enable_xspice=no
>  fi
> 

___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Spice-devel] [qxl 4/5] build: Error out when enabling xspice with X.Org 1.19

2016-10-28 Thread Christophe Fergeau 
xspice needs to be updated to cope with some X.Org 1.19 API changes,
better to make that explicit at configure time rather than letting
people discover the hard way (it builds with warnings but will not work)
that it's broken.
---
 configure.ac | 8 ++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/configure.ac b/configure.ac
index 451d42a..2c7bbf7 100644
--- a/configure.ac
+++ b/configure.ac
@@ -68,7 +68,8 @@ PKG_CHECK_EXISTS(xfont2,
 
 # Obtain compiler/linker options for the driver dependencies
 PKG_CHECK_MODULES(XORG, [xorg-server >= 1.0.99.901] xproto fontsproto 
$xfont_pc $REQUIRED_MODULES)
-
+# Check for xorg 1.19 as XSpice is currently not working with it
+PKG_CHECK_EXISTS([XORG119], [xorg-server >= 1.18.99], [has_xorg119=yes], [:])
 
 save_CFLAGS="$CFLAGS"
 CFLAGS="$XORG_CFLAGS"
@@ -139,7 +140,10 @@ if test "x$enable_xspice" = "xyes"; then
 AC_SUBST(SPICE_CFLAGS)
 AC_SUBST(SPICE_LIBS)
 ],
-)
+)
+if test x"${enable_xspice}" = "xyes" && test x"${has_xorg119}" = "xyes"; 
then
+AC_MSG_ERROR("XSpice cannot currently work against X.Org 1.19")
+fi
 else
 enable_xspice=no
 fi
-- 
2.9.3

___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel