Re: [Spice-devel] [spice-common 6/8] test-marshallers: Fix header guard

[Christophe Fergeau]

On Thu, Mar 28, 2019 at 01:54:01PM -0400, Frediano Ziglio wrote:
> > 
> > test-marshallers.h is missing a #define _H_TEST_MARSHALLERS in order to
> > prevent multiple #include for the same header.
> > 
> > Signed-off-by: Christophe Fergeau 
> > ---
> >  tests/test-marshallers.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/tests/test-marshallers.h b/tests/test-marshallers.h
> > index 4eab90f..5b113b7 100644
> > --- a/tests/test-marshallers.h
> > +++ b/tests/test-marshallers.h
> > @@ -1,6 +1,7 @@
> >  #include 
> >  
> 
> OT: why this is outside the guard?
> 
> >  #ifndef _H_TEST_MARSHALLERS
> > +#define _H_TEST_MARSHALLERS
> >  
> 
> OT 2: Why not H_SPICE_COMMON_ prefix?

I'll update the patch to fix these as well.

Christophe


signature.asc
Description: PGP signature
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [spice-common 6/8] test-marshallers: Fix header guard

[Frediano Ziglio]

> 
> test-marshallers.h is missing a #define _H_TEST_MARSHALLERS in order to
> prevent multiple #include for the same header.
> 
> Signed-off-by: Christophe Fergeau 
> ---
>  tests/test-marshallers.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/test-marshallers.h b/tests/test-marshallers.h
> index 4eab90f..5b113b7 100644
> --- a/tests/test-marshallers.h
> +++ b/tests/test-marshallers.h
> @@ -1,6 +1,7 @@
>  #include 
>  

OT: why this is outside the guard?

>  #ifndef _H_TEST_MARSHALLERS
> +#define _H_TEST_MARSHALLERS
>  

OT 2: Why not H_SPICE_COMMON_ prefix?

>  typedef struct {
>  uint32_t data_size;

beside, 

acked

Frediano
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Spice-devel] [spice-common 6/8] test-marshallers: Fix header guard

[Christophe Fergeau]

test-marshallers.h is missing a #define _H_TEST_MARSHALLERS in order to
prevent multiple #include for the same header.

Signed-off-by: Christophe Fergeau 
---
 tests/test-marshallers.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/test-marshallers.h b/tests/test-marshallers.h
index 4eab90f..5b113b7 100644
--- a/tests/test-marshallers.h
+++ b/tests/test-marshallers.h
@@ -1,6 +1,7 @@
 #include 
 
 #ifndef _H_TEST_MARSHALLERS
+#define _H_TEST_MARSHALLERS
 
 typedef struct {
 uint32_t data_size;
-- 
2.21.0

___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel