Re: [Spice-devel] [spice-protocol v1] enums: Move auto generated SpiceDataCompressionType

[Victor Toso]

Hi,

On Wed, Oct 19, 2016 at 03:40:18PM -0500, Jonathon Jongsma wrote:
> On Tue, 2016-10-18 at 14:59 +0200, Victor Toso wrote:
> > From: Victor Toso 
> >
> > This header is auto generated from spice_codegen.py tool in
> > spice-common repository and thus, it changes what was included
> > manually.
>
> I'm afraid I don't really understand this description.

Hehe, sorry. I tried :)

Pavel told me that spice/enums.h should be generated with
spice_codegen.py (spice-common) [0] - when I do that in the current
version, it moves this SpiceDataCompressionType struct to a different
position - meaning that this struct was included manually.

This patch fixes that.

[0]
https://lists.freedesktop.org/archives/spice-devel/2016-October/032708.html

Cheers,
  toso

>
> > 
> > Move SpiceDataCompressionType struct to comply with spice_codegen.py.
> > This header was generated with:
> > 
> >  ./spice_codegen.py -e spice.proto ../spice-protocol/spice/enums.h
> > 
> > Signed-off-by: Victor Toso 
> > ---
> >  spice/enums.h | 14 +++---
> >  1 file changed, 7 insertions(+), 7 deletions(-)
> > 
> > diff --git a/spice/enums.h b/spice/enums.h
> > index 1d0c2db..743a4a8 100644
> > --- a/spice/enums.h
> > +++ b/spice/enums.h
> > @@ -106,13 +106,6 @@ typedef enum SpiceMouseMode {
> >  SPICE_MOUSE_MODE_MASK = 0x3
> >  } SpiceMouseMode;
> >  
> > -typedef enum SpiceDataCompressionType {
> > -SPICE_DATA_COMPRESSION_TYPE_NONE,
> > -SPICE_DATA_COMPRESSION_TYPE_LZ4,
> > -
> > -SPICE_DATA_COMPRESSION_TYPE_ENUM_END
> > -} SpiceDataCompressionType;
> > -
> >  typedef enum SpicePubkeyType {
> >  SPICE_PUBKEY_TYPE_INVALID,
> >  SPICE_PUBKEY_TYPE_RSA,
> > @@ -128,6 +121,13 @@ typedef enum SpicePubkeyType {
> >  SPICE_PUBKEY_TYPE_ENUM_END
> >  } SpicePubkeyType;
> >  
> > +typedef enum SpiceDataCompressionType {
> > +SPICE_DATA_COMPRESSION_TYPE_NONE,
> > +SPICE_DATA_COMPRESSION_TYPE_LZ4,
> > +
> > +SPICE_DATA_COMPRESSION_TYPE_ENUM_END
> > +} SpiceDataCompressionType;
> > +
> >  typedef enum SpiceClipType {
> >  SPICE_CLIP_TYPE_NONE,
> >  SPICE_CLIP_TYPE_RECTS,
> ___
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel


signature.asc
Description: PGP signature
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [spice-protocol v1] enums: Move auto generated SpiceDataCompressionType

[Jonathon Jongsma]

On Tue, 2016-10-18 at 14:59 +0200, Victor Toso wrote:
> From: Victor Toso 
> 
> This header is auto generated from spice_codegen.py tool in
> spice-common repository and thus, it changes what was included
> manually.

I'm afraid I don't really understand this description.

> 
> Move SpiceDataCompressionType struct to comply with spice_codegen.py.
> This header was generated with:
> 
>  ./spice_codegen.py -e spice.proto ../spice-protocol/spice/enums.h
> 
> Signed-off-by: Victor Toso 
> ---
>  spice/enums.h | 14 +++---
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/spice/enums.h b/spice/enums.h
> index 1d0c2db..743a4a8 100644
> --- a/spice/enums.h
> +++ b/spice/enums.h
> @@ -106,13 +106,6 @@ typedef enum SpiceMouseMode {
>  SPICE_MOUSE_MODE_MASK = 0x3
>  } SpiceMouseMode;
>  
> -typedef enum SpiceDataCompressionType {
> -SPICE_DATA_COMPRESSION_TYPE_NONE,
> -SPICE_DATA_COMPRESSION_TYPE_LZ4,
> -
> -SPICE_DATA_COMPRESSION_TYPE_ENUM_END
> -} SpiceDataCompressionType;
> -
>  typedef enum SpicePubkeyType {
>  SPICE_PUBKEY_TYPE_INVALID,
>  SPICE_PUBKEY_TYPE_RSA,
> @@ -128,6 +121,13 @@ typedef enum SpicePubkeyType {
>  SPICE_PUBKEY_TYPE_ENUM_END
>  } SpicePubkeyType;
>  
> +typedef enum SpiceDataCompressionType {
> +SPICE_DATA_COMPRESSION_TYPE_NONE,
> +SPICE_DATA_COMPRESSION_TYPE_LZ4,
> +
> +SPICE_DATA_COMPRESSION_TYPE_ENUM_END
> +} SpiceDataCompressionType;
> +
>  typedef enum SpiceClipType {
>  SPICE_CLIP_TYPE_NONE,
>  SPICE_CLIP_TYPE_RECTS,
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Spice-devel] [spice-protocol v1] enums: Move auto generated SpiceDataCompressionType

[Victor Toso]

From: Victor Toso 

This header is auto generated from spice_codegen.py tool in
spice-common repository and thus, it changes what was included
manually.

Move SpiceDataCompressionType struct to comply with spice_codegen.py.
This header was generated with:

 ./spice_codegen.py -e spice.proto ../spice-protocol/spice/enums.h

Signed-off-by: Victor Toso 
---
 spice/enums.h | 14 +++---
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/spice/enums.h b/spice/enums.h
index 1d0c2db..743a4a8 100644
--- a/spice/enums.h
+++ b/spice/enums.h
@@ -106,13 +106,6 @@ typedef enum SpiceMouseMode {
 SPICE_MOUSE_MODE_MASK = 0x3
 } SpiceMouseMode;
 
-typedef enum SpiceDataCompressionType {
-SPICE_DATA_COMPRESSION_TYPE_NONE,
-SPICE_DATA_COMPRESSION_TYPE_LZ4,
-
-SPICE_DATA_COMPRESSION_TYPE_ENUM_END
-} SpiceDataCompressionType;
-
 typedef enum SpicePubkeyType {
 SPICE_PUBKEY_TYPE_INVALID,
 SPICE_PUBKEY_TYPE_RSA,
@@ -128,6 +121,13 @@ typedef enum SpicePubkeyType {
 SPICE_PUBKEY_TYPE_ENUM_END
 } SpicePubkeyType;
 
+typedef enum SpiceDataCompressionType {
+SPICE_DATA_COMPRESSION_TYPE_NONE,
+SPICE_DATA_COMPRESSION_TYPE_LZ4,
+
+SPICE_DATA_COMPRESSION_TYPE_ENUM_END
+} SpiceDataCompressionType;
+
 typedef enum SpiceClipType {
 SPICE_CLIP_TYPE_NONE,
 SPICE_CLIP_TYPE_RECTS,
-- 
2.9.3

___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel