Re: [Spice-devel] [spice-server 01/17] channel: Remove commented out function prototype

2017-01-11 Thread Frediano Ziglio 

> This became obsolete when RedChannel became GObject-based.
> 
> Signed-off-by: Christophe Fergeau 
> ---
>  server/red-channel.h | 12 
>  1 file changed, 12 deletions(-)
> 
> diff --git a/server/red-channel.h b/server/red-channel.h
> index 11a4088..f2866f5 100644
> --- a/server/red-channel.h
> +++ b/server/red-channel.h
> @@ -204,18 +204,6 @@ typedef struct RedChannelCapabilities {
>  
>  GType red_channel_get_type(void) G_GNUC_CONST;
>  
> -/* alternative constructor, meant for marshaller based (inputs,main)
> channels,
> - * will become default eventually */
> -/*
> -RedChannel *red_channel_create_parser(int size,
> -  RedsState *reds,
> -  const SpiceCoreInterfaceInternal
> *core,
> -  uint32_t type, uint32_t id,
> -  gboolean handle_acks,
> -  spice_parse_channel_func_t parser,
> -  channel_handle_parsed_proc
> handle_parsed,
> -  uint32_t migration_flags);
> -  */
>  void red_channel_add_client(RedChannel *channel, RedChannelClient *rcc);
>  void red_channel_remove_client(RedChannel *channel, RedChannelClient *rcc);
>  

OT but 

Acked-by: Frediano Ziglio 

Frediano
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Spice-devel] [spice-server 01/17] channel: Remove commented out function prototype

2017-01-11 Thread Christophe Fergeau 
This became obsolete when RedChannel became GObject-based.

Signed-off-by: Christophe Fergeau 
---
 server/red-channel.h | 12 
 1 file changed, 12 deletions(-)

diff --git a/server/red-channel.h b/server/red-channel.h
index 11a4088..f2866f5 100644
--- a/server/red-channel.h
+++ b/server/red-channel.h
@@ -204,18 +204,6 @@ typedef struct RedChannelCapabilities {
 
 GType red_channel_get_type(void) G_GNUC_CONST;
 
-/* alternative constructor, meant for marshaller based (inputs,main) channels,
- * will become default eventually */
-/*
-RedChannel *red_channel_create_parser(int size,
-  RedsState *reds,
-  const SpiceCoreInterfaceInternal *core,
-  uint32_t type, uint32_t id,
-  gboolean handle_acks,
-  spice_parse_channel_func_t parser,
-  channel_handle_parsed_proc handle_parsed,
-  uint32_t migration_flags);
-  */
 void red_channel_add_client(RedChannel *channel, RedChannelClient *rcc);
 void red_channel_remove_client(RedChannel *channel, RedChannelClient *rcc);
 
-- 
2.9.3

___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel