Re: [sqlite] Sqlite 3.3.7 intel compiler warnings

[Christian Smith]

Jay Sprenkle uttered:


hidden variables might very well not be a problem, if it was done that
way on purpose.



It should never be done on purpose. It is obfuscation pure and simple. 
There is never a good reason to do this, other than perhaps hiding a 
global variable (and even that is not a good idea.)


Just use a different variable name if it has a different use.

MHO.




On 8/30/06, Miguel Angel Latorre Díaz <[EMAIL PROTECTED]> wrote:

I already filtered out all the "common" warnings but these:

build.c(1969): remark #1599: declaration hides variable "v" (declared at
line 1883)
Vdbe *v = sqlite3GetVdbe(pParse);
  ^



-
To unsubscribe, send email to [EMAIL PROTECTED]
-



--
/"\
\ /ASCII RIBBON CAMPAIGN - AGAINST HTML MAIL
 X   - AGAINST MS ATTACHMENTS
/ \
-
To unsubscribe, send email to [EMAIL PROTECTED]
-

Re: [sqlite] Sqlite 3.3.7 intel compiler warnings

[Miguel Angel Latorre Díaz]

I know.
I checked them all and at least they are dangerous and probably not obvious.
I think the one in os_win.c is really a bug unless the intention were to 
always return OK. 



-
To unsubscribe, send email to [EMAIL PROTECTED]
-

Re: [sqlite] Sqlite 3.3.7 intel compiler warnings

[Jay Sprenkle]

hidden variables might very well not be a problem, if it was done that
way on purpose.

On 8/30/06, Miguel Angel Latorre Díaz <[EMAIL PROTECTED]> wrote:

I already filtered out all the "common" warnings but these:

build.c(1969): remark #1599: declaration hides variable "v" (declared at
line 1883)
Vdbe *v = sqlite3GetVdbe(pParse);
  ^



-
To unsubscribe, send email to [EMAIL PROTECTED]
-

[sqlite] Sqlite 3.3.7 intel compiler warnings

[Miguel Angel Latorre Díaz]

I already filtered out all the "common" warnings but these:

build.c(1969): remark #1599: declaration hides variable "v" (declared at 
line 1883)

   Vdbe *v = sqlite3GetVdbe(pParse);
 ^

expr.c(1520): remark #1599: declaration hides variable "op" (declared at 
line 1489)

 int op = (pTab && IsVirtual(pTab)) ? OP_VColumn : OP_Column;
 ^

expr.c(1530): remark #1599: declaration hides variable "op" (declared at 
line 1489)

 int op = (pTab && IsVirtual(pTab)) ? OP_VRowid : OP_Rowid;
 ^
I think this one is a bug:
os_win.c(840): remark #1599: declaration hides variable "rc" (declared at 
line 838)

 int rc, cnt = 0;
 ^

vtab.c(326): remark #1599: declaration hides variable "zModule" (declared at 
line 316)

 const char *zModule = pTab->azModuleArg[0];
 ^

where.c(1043): remark #1599: declaration hides variable "pTerm" (declared at 
line 1032)

 WhereTerm *pTerm;
^

where.c(2040): remark #1599: declaration hides variable "j" (declared at 
line 2002)

   int j;
   ^



-
To unsubscribe, send email to [EMAIL PROTECTED]
-