Re: [sqlite] [OS/2] Update OS/2 support in sqlite 3.7.x

[Walter Meinl]

Just in case this has slipped thru cause it took a while for me to
register, here is my reply again.

On 10/09/29 23:41, Walter Meinl wrote:
>>
>> If the underlying VFS does not support shared-memory (which the OS/2 VFS
>> does not) then SQLite simply will not go into WAL mode.  No patching is
>> needed for this.  Everything should work as delivered.
>>
>> What exactly is malfunctioning?  What is the problem that this patch
>> attempts to fix?
> The mozilla bug was originally filed against 3.7.1. In pager.c was a
> function: static int pagerPagecount in an #ifndef SQLITE_OMIT_WAL block.
> The last 3 hunks of the original patch moved the exclusion of omit_wal
> further down, because all sqlite databases in a new profile had zero
> size on OS/2 and a warning was issued from firefox that history and
> bookmarks won't work, because the data bases were in use by another program.
>>> https://bugzilla.mozilla.org/attachment.cgi?id=474575
> However, this issue has been fixed already in 3.7.2 [d1ed743b6e].
> (Hopefully mozilla will update to 3.7.2 soon).
> 
> The rest of the patch contained (in fossil format) in
 https://bugzilla.mozilla.org/attachment.cgi?id=477692
> is intended to explicitly disable WAL on OS/2
> and bring the OS/2 related files up to date.
> That involves:
> - adding a new function, os2CurrentTimeInt64(), and refining the
>   existing os2CurrentTime();
> - adding new members to the "os2Vfs" structure, and explicitly
>   defining them as NULL pointers since they support WAL;
> - updating the OS/2 semaphore documentation to match other platforms.
> It would be nice if these changes could be considered to get checked-in.
> Thanks, Walter
> 
> ___
> sqlite-users mailing list
> sqlite-users@sqlite.org
> http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users
> 
___
sqlite-users mailing list
sqlite-users@sqlite.org
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users

Re: [sqlite] [OS/2] Update OS/2 support in sqlite 3.7.x

[Richard Hipp]

On Wed, Sep 22, 2010 at 6:56 PM, Walter Meinl  wrote:

> This defect report is cloned from mozilla bug595599
> RW: "This patch disables WAL journalling on OS/2 since that feature
> requires memory-mapped file i/o which OS/2 doesn't support, and makes
> other small changes where needed."
> The patch was originally created by Rich Walsh against the amalgamation
> file in the mozilla-tree (SQlite v 3.7.1)
> I've installed fossil and broke up the patch to apply against current
> trunk files (src/os.h, src/os_os2.c and src/mutex_os2.c)
> The patch can be downloaded from this link.
> https://bugzilla.mozilla.org/attachment.cgi?id=477692
> The original patch:
> https://bugzilla.mozilla.org/attachment.cgi?id=474575
>

If the underlying VFS does not support shared-memory (which the OS/2 VFS
does not) then SQLite simply will not go into WAL mode.  No patching is
needed for this.  Everything should work as delivered.

What exactly is malfunctioning?  What is the problem that this patch
attempts to fix?



> Additional question for future reports: Is it possible to add
> attachments to the mailing list?
> Thanks, Walter
> ___
> sqlite-users mailing list
> sqlite-users@sqlite.org
> http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users
>



-- 
D. Richard Hipp
d...@sqlite.org
___
sqlite-users mailing list
sqlite-users@sqlite.org
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users