Re: [sqlite] SQLite bug on AFP?

2008-06-11 Thread BareFeet
Following up:

>>> I think the solution might be as simple as compiling with - 
>>> DSQLITE_ENABLE_LOCKING_STYLE=1.  This option only works on a Mac.   
>>> It enables some Apple-contributed code that does file locking that  
>>> works on AFP as well as on other network filesystems that the Mac  
>>> supports.
>>

AFAIK, this option is:

1. Enabled in the SQLite bundled on Mac OS X systems.

2. Disabled in the SQLite binary for Mac OS X on the SQLite web site:
http://www.sqlite.org/download.html
http://www.sqlite.org/sqlite3-3_5_9-osx-x86.bin.gz

3. Disabled in the source code.

Can you please tell me:

Can you please enable this by default in the Mac OS X binary and  
source code? This would help with compatibility between the behavior  
of the default SQLite install and any updates. For instance, at least  
one JDBC developer (which affects at least a dozen SQLite GUI tools on  
the Mac) will only include the locking fix if the "standard" Mac OS  
binary also includes it.

Thanks,
Tom
BareFeet

  --
SQLite GUI tools for Mac OS X compared at:
http://www.tandb.com.au/sqlite/compare/

___
sqlite-users mailing list
sqlite-users@sqlite.org
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users


Re: [sqlite] SQLite bug on AFP?

2008-06-07 Thread D. Richard Hipp

On Jun 7, 2008, at 4:40 PM, Peter K. Stys wrote:

> On Thu, Jun 5, 2008 at 2:04 PM, D. Richard Hipp <[EMAIL PROTECTED]> wrote:
>
>>
>> On Jun 5, 2008, at 12:09 PM, Shawn Wilsher wrote:
>>
>>> Hey all,
>>>
>>> We are getting reports that sqlite is not working for users of AFP
>>> (Apple Filing Protocol) in Bug 417037 [1].  I was wondering if this
>>> was a known issue, and what we could do to help get this resolved.
>>
>>
>> I think the solution might be as simple as compiling with -
>> DSQLITE_ENABLE_LOCKING_STYLE=1.  This option only works on a Mac.  It
>> enables some Apple-contributed code that does file locking that works
>> on AFP as well as on other network filesystems that the Mac supports.
>>
>
> would this switch in any way affect the dismal R/W speeds for network
> volumes that were discussed a few weeks ago?
>

No.

D. Richard Hipp
[EMAIL PROTECTED]



___
sqlite-users mailing list
sqlite-users@sqlite.org
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users


Re: [sqlite] SQLite bug on AFP?

2008-06-07 Thread Peter K. Stys
On Thu, Jun 5, 2008 at 2:04 PM, D. Richard Hipp <[EMAIL PROTECTED]> wrote:

>
> On Jun 5, 2008, at 12:09 PM, Shawn Wilsher wrote:
>
> > Hey all,
> >
> > We are getting reports that sqlite is not working for users of AFP
> > (Apple Filing Protocol) in Bug 417037 [1].  I was wondering if this
> > was a known issue, and what we could do to help get this resolved.
>
>
> I think the solution might be as simple as compiling with -
> DSQLITE_ENABLE_LOCKING_STYLE=1.  This option only works on a Mac.  It
> enables some Apple-contributed code that does file locking that works
> on AFP as well as on other network filesystems that the Mac supports.
>

would this switch in any way affect the dismal R/W speeds for network
volumes that were discussed a few weeks ago?

P.


-- 
-
Peter K. Stys, MD
Dept. of Clinical Neurosciences
Hotchkiss Brain Institute
University of Calgary
tel (403) 210-8646
-
___
sqlite-users mailing list
sqlite-users@sqlite.org
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users


Re: [sqlite] SQLite bug on AFP?

2008-06-05 Thread D. Richard Hipp

On Jun 5, 2008, at 1:32 PM, Shawn Wilsher wrote:

> On Thu, Jun 5, 2008 at 4:04 PM, D. Richard Hipp <[EMAIL PROTECTED]> wrote:
>> I think the solution might be as simple as compiling with -
>> DSQLITE_ENABLE_LOCKING_STYLE=1.  This option only works on a Mac.  It
>> enables some Apple-contributed code that does file locking that works
>> on AFP as well as on other network filesystems that the Mac supports.
> Would this change out locking works on a normal local file system?
>>

With SQLITE_ENABLE_LOCKING_STYLE turned on, SQLite calls statfs() to  
figure out what type of filesystem the database is found on and uses a  
locking style appropriate for that filesystem.  It prefers to use  
posix advisory locks if at all possible, so for most systems there  
would be no change in behavior.

The bug here is that the same file might be on AFP for one machine but  
a local mount on another machine.  If both machines try to use the  
database at the same time, they will use different and incompatible  
locking styles and will step on each other.  This is a theoretical  
problem which in practice it appears to never occur, so I won't worry  
too much about it.  But you should be aware of it.

SQLITE_ENABLE_LOCK_STYLE is not a setting we habitually test prior to  
a release, so if you decide to use it, please let me know so that I  
can make sure we start testing it more thoroughly.

D. Richard Hipp
[EMAIL PROTECTED]



___
sqlite-users mailing list
sqlite-users@sqlite.org
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users


Re: [sqlite] SQLite bug on AFP?

2008-06-05 Thread Shawn Wilsher
On Thu, Jun 5, 2008 at 4:04 PM, D. Richard Hipp <[EMAIL PROTECTED]> wrote:
> I think the solution might be as simple as compiling with -
> DSQLITE_ENABLE_LOCKING_STYLE=1.  This option only works on a Mac.  It
> enables some Apple-contributed code that does file locking that works
> on AFP as well as on other network filesystems that the Mac supports.
Would this change out locking works on a normal local file system?

> At one time it was the case that FF handled all of its own locking
> such that the SQLite database locking was really unnecessary.  Is that
> still the case?  If so, then perhaps the simplest solution here would
> be to provide a new compile-time option to disable all of the locking
> logic on all systems.
We lock the profile so more than one instance cannot access it,
however consumers could access a database anywhere.  Additionally, it
wouldn't prevent other sqlite consumers from accessing these
databases.

Cheers,

Shawn
___
sqlite-users mailing list
sqlite-users@sqlite.org
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users


Re: [sqlite] SQLite bug on AFP?

2008-06-05 Thread D. Richard Hipp

On Jun 5, 2008, at 12:09 PM, Shawn Wilsher wrote:

> Hey all,
>
> We are getting reports that sqlite is not working for users of AFP
> (Apple Filing Protocol) in Bug 417037 [1].  I was wondering if this
> was a known issue, and what we could do to help get this resolved.


I think the solution might be as simple as compiling with - 
DSQLITE_ENABLE_LOCKING_STYLE=1.  This option only works on a Mac.  It  
enables some Apple-contributed code that does file locking that works  
on AFP as well as on other network filesystems that the Mac supports.

At one time it was the case that FF handled all of its own locking  
such that the SQLite database locking was really unnecessary.  Is that  
still the case?  If so, then perhaps the simplest solution here would  
be to provide a new compile-time option to disable all of the locking  
logic on all systems.

D. Richard Hipp
[EMAIL PROTECTED]



___
sqlite-users mailing list
sqlite-users@sqlite.org
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users