[squid-dev] Build failed in Jenkins: trunk-full-matrix ยป clang,d-debian-unstable #115

2016-02-25 Thread noc
See 


--
[...truncated 6835 lines...]
Making dvi in RADIUS
make[5]: Entering directory 
'
make[5]: Nothing to be done for 'dvi'.
make[5]: Leaving directory 
'
Making dvi in SMB
make[5]: Entering directory 
'
make[5]: Nothing to be done for 'dvi'.
make[5]: Leaving directory 
'
Making dvi in SMB_LM
make[5]: Entering directory 
'
make[5]: Nothing to be done for 'dvi'.
make[5]: Leaving directory 
'
Making dvi in fake
make[5]: Entering directory 
'
make[5]: Nothing to be done for 'dvi'.
make[5]: Leaving directory 
'
Making dvi in getpwnam
make[5]: Entering directory 
'
make[5]: Nothing to be done for 'dvi'.
make[5]: Leaving directory 
'
make[5]: Entering directory 
'
make[5]: Nothing to be done for 'dvi-am'.
make[5]: Leaving directory 
'
make[4]: Leaving directory 
'
Making dvi in digest
make[4]: Entering directory 
'
Making dvi in file
make[5]: Entering directory 
'
make[5]: Nothing to be done for 'dvi'.
make[5]: Leaving directory 
'
make[5]: Entering directory 
'
make[5]: Nothing to be done for 'dvi-am'.
make[5]: Leaving directory 
'
make[4]: Leaving directory 
'
Making dvi in negotiate
make[4]: Entering directory 
'
Making dvi in wrapper
make[5]: Entering directory 
'
make[5]: Nothing to be done for 'dvi'.
make[5]: Leaving directory 
'
make[5]: Entering directory 

Re: [squid-dev] [PATCH] libsbuf

2016-02-25 Thread Kinkie
On Thu, Feb 25, 2016 at 6:50 PM, Amos Jeffries  wrote:
> On 26/02/2016 6:01 a.m., Kinkie wrote:
>> Hi all,
>>   please find attached a the bundle implementing libsbuf (merge
>> proposal from lp:~squid/squid/sbuflab).
>>
>> It:
>> - shuffles SBuf core files into src/sbuf and implements sbuf/libsbuf.la
>> - refactors SBuf <-> String adaption functions into a separate header,
>> increasing decoupling
>> - reduces the list of stubs and libraries needed for SBuf unit tests
>> - removes _DEPENDENCIES clauses from affected unit tests' Makefile.am
>>
>> It has to be a bundle to carry information about file moves; this
>> means no long-context diff, I'm sorry.
>> Code builds fine in-tree. I'll perform a full test before possibly
>> merging if you approve the patch, of course.
>>
>
> I think all the stats.allocFromString accounting could stay. It would
> just be for std::string now instead of combined std::string and SquidString.
>
> OR, maybe the String to/from counting could be done by the
> SBufStringConvert.h functions instead of the SBuf.

As part of my discussion with Alex we talked about reducing the number
of statistics taken. I believe that number not to be  very relevant
and thus removed it. Other such statistics will follow

> in src/Makefile.am:
> * tests_testSBuf_LDADD needs to include $(SQUID_CPPUNIT_LA)
>  - same for tests_testSBufList_LDADD and tests_testLookupTable_LDADD

Done.

> in src/mk-string-arrays.awk:
> * can you take advantage of the edit to s/namesapce/namespace/ please?

Done

> in src/sbuf/SBufStringConvert.h:
> * use:  #include "sbuf/SBuf.h"

ok

> in src/tests/testSBuf.cc:
> * use: #include "tests/SBufFindTest.h"

Done.


-- 
Francesco
___
squid-dev mailing list
squid-dev@lists.squid-cache.org
http://lists.squid-cache.org/listinfo/squid-dev


Re: [squid-dev] [PATCH] libsbuf

2016-02-25 Thread Amos Jeffries
On 26/02/2016 6:01 a.m., Kinkie wrote:
> Hi all,
>   please find attached a the bundle implementing libsbuf (merge
> proposal from lp:~squid/squid/sbuflab).
> 
> It:
> - shuffles SBuf core files into src/sbuf and implements sbuf/libsbuf.la
> - refactors SBuf <-> String adaption functions into a separate header,
> increasing decoupling
> - reduces the list of stubs and libraries needed for SBuf unit tests
> - removes _DEPENDENCIES clauses from affected unit tests' Makefile.am
> 
> It has to be a bundle to carry information about file moves; this
> means no long-context diff, I'm sorry.
> Code builds fine in-tree. I'll perform a full test before possibly
> merging if you approve the patch, of course.
> 

I think all the stats.allocFromString accounting could stay. It would
just be for std::string now instead of combined std::string and SquidString.

OR, maybe the String to/from counting could be done by the
SBufStringConvert.h functions instead of the SBuf.


in src/Makefile.am:
* tests_testSBuf_LDADD needs to include $(SQUID_CPPUNIT_LA)
 - same for tests_testSBufList_LDADD and tests_testLookupTable_LDADD


in src/mk-string-arrays.awk:
* can you take advantage of the edit to s/namesapce/namespace/ please?


in src/sbuf/SBufStringConvert.h:
* use:  #include "sbuf/SBuf.h"


in src/tests/testSBuf.cc:
* use: #include "tests/SBufFindTest.h"


Amos

___
squid-dev mailing list
squid-dev@lists.squid-cache.org
http://lists.squid-cache.org/listinfo/squid-dev


[squid-dev] [PATCH] libsbuf

2016-02-25 Thread Kinkie
Hi all,
  please find attached a the bundle implementing libsbuf (merge
proposal from lp:~squid/squid/sbuflab).

It:
- shuffles SBuf core files into src/sbuf and implements sbuf/libsbuf.la
- refactors SBuf <-> String adaption functions into a separate header,
increasing decoupling
- reduces the list of stubs and libraries needed for SBuf unit tests
- removes _DEPENDENCIES clauses from affected unit tests' Makefile.am

It has to be a bundle to carry information about file moves; this
means no long-context diff, I'm sorry.
Code builds fine in-tree. I'll perform a full test before possibly
merging if you approve the patch, of course.

Thanks

-- 
Francesco


sbuflib.bundle
Description: Binary data
___
squid-dev mailing list
squid-dev@lists.squid-cache.org
http://lists.squid-cache.org/listinfo/squid-dev