Re: Alternate http repository for squid3

[Robert Collins]

On Thu, 2009-08-20 at 14:07 +0200, Kinkie wrote:
> As part of the ongoing buildfarm work, I've published onto http the
> (read-only) repository mirror that's hosted on eu.
> It's available at http://www.eu.squid-cache.org/bzr/squid3/

How often is this synced?

-Rob


signature.asc
Description: This is a digitally signed message part

Re: [PATCH] hier_code ACL (port from 2.7)

[Amos Jeffries]

Henrik Nordstrom wrote:

fre 2009-08-21 klockan 13:55 +1200 skrev Amos Jeffries:
Aye, spent some time looking for such in the code before discovering we 
did not already do it.


Anyone have good ideas how to do that?


We already have mk-string-arrays.awk converting selected enums from
enum.h to string arrays. Should be possible to reuse this with minor
changes as some values should have simpler strings here than the enum
defined value.

Regards
Herik



Aha! yes that was what I was looking for.
I'll pick this one up...

Amos
--
Please be using
  Current Stable Squid 2.7.STABLE6 or 3.0.STABLE18
  Current Beta Squid 3.1.0.13

Re: Build failed in Hudson: 3.0-i386-OpenBSD-4.5 #1

[Amos Jeffries]

n...@squid-cache.org wrote:

See 

--
Started by user kinkie
Building remotely on vobsd
Branched 9096 revision(s).
+ ./test-builds.sh --verbose
TESTING: layer-00-bootstrap
chmod: btlayer-00-bootstrap: No such file or directory
BUILD: .././test-suite/buildtests/layer-00-bootstrap.opts
automake : -1.9
autoconfg: -2.62
libtool  : 
Bootstrapping 
autoheader-2.62: error: AC_CONFIG_HEADERS not found in configure.in

autoheader-2.62 failed
Autotool bootstrapping failed. You will need to investigate and correct
before you can develop on this source tree
buildtest.sh result is 1
BUILD: .././test-suite/buildtests/layer-00-bootstrap.opts
autoheader-2.62: error: AC_CONFIG_HEADERS not found in configure.in
Build Failed. Last log lines are:
BUILD: .././test-suite/buildtests/layer-00-bootstrap.opts
automake : -1.9
autoconfg: -2.62
libtool  : 
Bootstrapping 
autoheader-2.62: error: AC_CONFIG_HEADERS not found in configure.in

autoheader-2.62 failed
Autotool bootstrapping failed. You will need to investigate and correct
before you can develop on this source tree
buildtest.sh result is 1



Kinkie (and everyone doing build-farm admin),

  please use the test-builds job or a clone of it on new nodes until 
they are confirmed working. It will save us from many reports and other 
issues while setting up and checking a new node is actually usable. 
Particularly if there is already or about to be other nodes of the same 
OS that would cause conflicting status reports.


Amos
--
Please be using
  Current Stable Squid 2.7.STABLE6 or 3.0.STABLE18
  Current Beta Squid 3.1.0.13

Re: [PATCH] hier_code ACL (port from 2.7)

[Henrik Nordstrom]

fre 2009-08-21 klockan 13:55 +1200 skrev Amos Jeffries:
> Aye, spent some time looking for such in the code before discovering we 
> did not already do it.
> 
> Anyone have good ideas how to do that?

We already have mk-string-arrays.awk converting selected enums from
enum.h to string arrays. Should be possible to reuse this with minor
changes as some values should have simpler strings here than the enum
defined value.

Regards
Herik

Re: [PATCH] hier_code ACL (port from 2.7)

[Amos Jeffries]

Henrik Nordstrom wrote:

hnordstrom has voted approve.
Status is now: Approved
Comment:
Looks fine.

But the patch highlighted another minor issue.. we should get the hier 
strings autogenerated from the enum. Having lists like that in the 
source is quite errorprone.




Aye, spent some time looking for such in the code before discovering we 
did not already do it.


Anyone have good ideas how to do that?

It looks from a short search like the best ways are to have a data file 
and generate both enum and string array code at build-time from those.


Something that does a general:
  X.codes -> X_code.h + X_code.cc   process.

creating a X_strings array in the .cc and X_code enum + extras in the .h.

Possibly automatically appending MAX_X at the end for safety and 
iterator limit usage.



Amos
--
Please be using
  Current Stable Squid 2.7.STABLE6 or 3.0.STABLE18
  Current Beta Squid 3.1.0.13

Re: [PATCH] Cache-Control overwriting hack

[Amos Jeffries]

Henrik Nordstrom wrote:

hnordstrom has voted tweak.
Status is now: Semi-approved
Comment:
Better to turn it the other way around. Add a new header to be used as 
substitute for Cache-Control by the reverse proxy.


For details, see: 
http://bundlebuggy.aaronbentley.com/project/squid/request/%3CE8FE3C35-0CBA-4272-9194-DEF885267638%40semihuman.com%3E 


Project: Squid


That would be the ESI Surrogate-Control: header Robert brought up.

As indicated to earlier. Implementing Surrogate-Control: for 
reverse-proxy mode would be acceptable. Adding new headers to do the 
same purpose in worse ways is not.


Amos
--
Please be using
  Current Stable Squid 2.7.STABLE6 or 3.0.STABLE18
  Current Beta Squid 3.1.0.13

Re: excessive RAM growth due to unlimited adapted body data consumption

[Alex Rousskov]

On 08/18/2009 02:11 AM, Martin Huter wrote:
> squids ICAP adaptation implementation does not check adapted body-pipes 
> buffer 
> size before reading from an ICAP-server.
> 
> If the client does not read from the open connection (i.e. the user does not
> confirm the browsers download-message-box in microsofts IE), squid keeps on
> reading data from the ICAP server into the body pipe, whilst no more data
> can be delivered to the client. 
> Thus the adapted body pipes buffer is growing unlimited which causes 
> excessive 
> RAM growth.
> 
> this issue was reported as bugzilla bug 2619 and the attached patch (applies 
> to 3.1 and 3.HEAD) should fix the issue.
> 
> please review the patch and feel free to comment it.

+1

I have reviewed the functional changes in the patches for this bug and
agree with them.

Ideally, a few things should be renamed and polished, but I do not have
the time to work on that right now. If nobody else has the time, the
patches can be committed without polishing as they do fix a rather
important and difficult to track bug.

Thank you,

Alex.
P.S. Please subscribe Martin if you can.


> ---
> 
> i would like to subscribe the squid-dev  mailing list.
> my name is martin huter. i'm working as progammer at phion AG in austria.
> i'm mainly working with C and C++ and among others i am responsible for our 
> squid service. currently i'm updating squid to version 3.1.
> 
> p.s.: many thanks to alex rousskov for his patient help on the appended patch.
> 
> cheers
> martin huter
> 
> 
> 

Re: [Bug 2541] Never ending loop while processing external acls using %{header: member} other than comma

[Matt W. Benjamin]

The value in our original patch was to ensure that the key invariant of the 
loop--termination--was guaranteed.  Of course, we sent this patch for what was 
(at our site) a critical bug in, what, February?  That's 6 months from 
submitted fix, to fix thrown out and (apparently) still nothing committed.

Matt


- bugzilla-dae...@squid-cache.org wrote:

> http://www.squid-cache.org/bugs/show_bug.cgi?id=2541
> 
> 
> 
> 
> 
> --- Comment #5 from Henrik Nordstrom   2009-08-20
> 05:28:37 ---
> The bug is that , is meant to always be considered as a delimiter even
> if the
> arguments says otherwise (from HTTP header requirements), but the loop
> fails to
> handle this and only looks for the specified delimiter.
> 
> Neither patch is correct.
> 
> The simplest change is to add  || **pos == ',' in the if statement
> looking for
> the delimiter but I'll rewrite it for clarity.
> 
> 
> -- 
> Configure bugmail:
> http://www.squid-cache.org/bugs/userprefs.cgi?tab=email
> --- You are receiving this mail because: ---
> You reported the bug.

-- 

Matt Benjamin

The Linux Box
206 South Fifth Ave. Suite 150
Ann Arbor, MI  48104

http://linuxbox.com

tel. 734-761-4689
fax. 734-769-8938
cel. 734-216-5309

Re: [PATCH] helper closing sequence cleanup

[Henrik Nordstrom]

hnordstrom has voted comment.
Status is now: Semi-approved
Comment:
Is this still relevant?

For details, see: 
http://bundlebuggy.aaronbentley.com/project/squid/request/%3C4A003331.1050406%40treenet.co.nz%3E

Project: Squid

Re: [PATCH] Cache-Control overwriting hack

[Henrik Nordstrom]

hnordstrom has voted tweak.
Status is now: Semi-approved
Comment:
Better to turn it the other way around. Add a new header to be used as 
substitute for Cache-Control by the reverse proxy.


For details, see: 
http://bundlebuggy.aaronbentley.com/project/squid/request/%3CE8FE3C35-0CBA-4272-9194-DEF885267638%40semihuman.com%3E

Project: Squid

Build failed in Hudson: 3.0-i386-OpenBSD-4.5 #1

[noc]

See 

--
Started by user kinkie
Building remotely on vobsd
Branched 9096 revision(s).
+ ./test-builds.sh --verbose
TESTING: layer-00-bootstrap
chmod: btlayer-00-bootstrap: No such file or directory
BUILD: .././test-suite/buildtests/layer-00-bootstrap.opts
automake : -1.9
autoconfg: -2.62
libtool  : 
Bootstrapping 
autoheader-2.62: error: AC_CONFIG_HEADERS not found in configure.in
autoheader-2.62 failed
Autotool bootstrapping failed. You will need to investigate and correct
before you can develop on this source tree
buildtest.sh result is 1
BUILD: .././test-suite/buildtests/layer-00-bootstrap.opts
autoheader-2.62: error: AC_CONFIG_HEADERS not found in configure.in
Build Failed. Last log lines are:
BUILD: .././test-suite/buildtests/layer-00-bootstrap.opts
automake : -1.9
autoconfg: -2.62
libtool  : 
Bootstrapping 
autoheader-2.62: error: AC_CONFIG_HEADERS not found in configure.in
autoheader-2.62 failed
Autotool bootstrapping failed. You will need to investigate and correct
before you can develop on this source tree
buildtest.sh result is 1

Alternate http repository for squid3

[Kinkie]

As part of the ongoing buildfarm work, I've published onto http the
(read-only) repository mirror that's hosted on eu.
It's available at http://www.eu.squid-cache.org/bzr/squid3/


-- 
/kinkie

Build failed in Hudson: 3.HEAD-i386-OpenBSD-4.5 #6

[noc]

See 

Changes:

[Henrik Nordstrom ] Revert an evil optimization 
from the memcache change

--
Started by user kinkie
Building remotely on vobsd
Using saved location: http://www.squid-cache.org/bzr/squid3/trunk/
No revisions to pull.
+ ./test-builds.sh --verbose
TESTING: layer-00-bootstrap
BUILD: .././test-suite/buildtests/layer-00-bootstrap.opts
automake : -1.9
autoconfg: -2.62
libtool  : 
Bootstrapping 
rm: unknown option -- v
usage: rm [-dfiPRr] file ...
Creating lib/libLtdl from libltdl.
configure.in: no proper invocation of AM_INIT_AUTOMAKE was found.
configure.in: You should verify that configure.in invokes AM_INIT_AUTOMAKE,
configure.in: that aclocal.m4 is present in the top-level directory,
configure.in: and that aclocal.m4 was recently regenerated (using aclocal).
configure.in: installing `cfgaux/install-sh'
configure.in: installing `cfgaux/missing'
compat/Makefile.am:12: Libtool library used but `LIBTOOL' is undefined
compat/Makefile.am:12: 
compat/Makefile.am:12: The usual way to define `LIBTOOL' is to add 
`AC_PROG_LIBTOOL'
compat/Makefile.am:12: to `configure.in' and run `aclocal' and `autoconf' again.
compat/Makefile.am: installing `cfgaux/depcomp'
/usr/local/share/automake-1.9/am/depend2.am: am__fastdepCC does not appear in 
AM_CONDITIONAL
/usr/local/share/automake-1.9/am/depend2.am: AMDEP does not appear in 
AM_CONDITIONAL
/usr/local/share/automake-1.9/am/depend2.am: am__fastdepCXX does not appear in 
AM_CONDITIONAL
/usr/local/share/automake-1.9/am/depend2.am: am__fastdepCC does not appear in 
AM_CONDITIONAL
/usr/local/share/automake-1.9/am/depend2.am: AMDEP does not appear in 
AM_CONDITIONAL
/usr/local/share/automake-1.9/am/depend2.am: am__fastdepCC does not appear in 
AM_CONDITIONAL
/usr/local/share/automake-1.9/am/depend2.am: AMDEP does not appear in 
AM_CONDITIONAL
/usr/local/share/automake-1.9/am/depend2.am: am__fastdepCC does not appear in 
AM_CONDITIONAL
/usr/local/share/automake-1.9/am/depend2.am: AMDEP does not appear in 
AM_CONDITIONAL
/usr/local/share/automake-1.9/am/depend2.am: am__fastdepCC does not appear in 
AM_CONDITIONAL
/usr/local/share/automake-1.9/am/depend2.am: AMDEP does not appear in 
AM_CONDITIONAL
/usr/local/share/automake-1.9/am/depend2.am: am__fastdepCC does not appear in 
AM_CONDITIONAL
/usr/local/share/automake-1.9/am/depend2.am: AMDEP does not appear in 
AM_CONDITIONAL
helpers/basic_auth/SMB/Makefile.am: installing `cfgaux/compile'
/usr/local/share/automake-1.9/am/depend2.am: am__fastdepCC does not appear in 
AM_CONDITIONAL
/usr/local/share/automake-1.9/am/depend2.am: AMDEP does not appear in 
AM_CONDITIONAL
/usr/local/share/automake-1.9/am/depend2.am: am__fastdepCC does not appear in 
AM_CONDITIONAL
/usr/local/share/automake-1.9/am/depend2.am: AMDEP does not appear in 
AM_CONDITIONAL
/usr/local/share/automake-1.9/am/depend2.am: am__fastdepCC does not appear in 
AM_CONDITIONAL
/usr/local/share/automake-1.9/am/depend2.am: AMDEP does not appear in 
AM_CONDITIONAL
/usr/local/share/automake-1.9/am/depend2.am: am__fastdepCC does not appear in 
AM_CONDITIONAL
/usr/local/share/automake-1.9/am/depend2.am: AMDEP does not appear in 
AM_CONDITIONAL
/usr/local/share/automake-1.9/am/depend2.am: am__fastdepCC does not appear in 
AM_CONDITIONAL
/usr/local/share/automake-1.9/am/depend2.am: AMDEP does not appear in 
AM_CONDITIONAL
/usr/local/share/automake-1.9/am/depend2.am: am__fastdepCC does not appear in 
AM_CONDITIONAL
/usr/local/share/automake-1.9/am/depend2.am: AMDEP does not appear in 
AM_CONDITIONAL
/usr/local/share/automake-1.9/am/depend2.am: am__fastdepCC does not appear in 
AM_CONDITIONAL
/usr/local/share/automake-1.9/am/depend2.am: AMDEP does not appear in 
AM_CONDITIONAL
/usr/local/share/automake-1.9/am/depend2.am: am__fastdepCC does not appear in 
AM_CONDITIONAL
/usr/local/share/automake-1.9/am/depend2.am: AMDEP does not appear in 
AM_CONDITIONAL
/usr/local/share/automake-1.9/am/depend2.am: am__fastdepCC does not appear in 
AM_CONDITIONAL
/usr/local/share/automake-1.9/am/depend2.am: AMDEP does not appear in 
AM_CONDITIONAL
/usr/local/share/automake-1.9/am/depend2.am: am__fastdepCC does not appear in 
AM_CONDITIONAL
/usr/local/share/automake-1.9/am/depend2.am: AMDEP does not appear in 
AM_CONDITIONAL
/usr/local/share/automake-1.9/am/depend2.am: am__fastdepCC does not appear in 
AM_CONDITIONAL
/usr/local/share/automake-1.9/am/depend2.am: AMDEP does not appear in 
AM_CONDITIONAL
/usr/local/share/automake-1.9/am/depend2.am: am__fastdepCC does not appear in 
AM_CONDITIONAL
/usr/local/share/automake-1.9/am/depend2.am: AMDEP does not appear in 
AM_CONDITIONAL
/usr/local/share/automake-1.9/am/depend2.am: am__fastdepCC does not appear in 
AM_CONDITIONAL
/usr/local/share/automake-1.9/am/depend2.am: AMDEP does not appear in 
AM_CONDITIONAL
/usr/local/share/automake-1.9/am/depend2.am: am__fastdepCC does not appear in 
AM_CONDITIONAL
/usr/local/share/automake-1.9/am/depen

Build failed in Hudson: 3.HEAD-i386-OpenBSD-4.5 #5

[noc]

See 

--
Started by user kinkie
Building remotely on vobsd
Branched 9919 revision(s).
+ ./test-builds.sh --verbose
TESTING: layer-00-bootstrap
chmod: btlayer-00-bootstrap: No such file or directory
BUILD: .././test-suite/buildtests/layer-00-bootstrap.opts
WARNING: Cannot find automake version 1.11 1.10 1.9
./bootstrap.sh[103]: automake: not found
Trying 
WARNING: Cannot find autoconf version 2.63 2.62 2.61
./bootstrap.sh[104]: autoconf: not found
Trying 
WARNING: Cannot find libtool version 2 1.5 1.4
./bootstrap.sh[105]: libtool: not found
Trying 
automake : 
autoconfg: 
libtool  : 
Bootstrapping 
./bootstrap.sh[141]: aclocal: not found
aclocal failed
Autotool bootstrapping failed. You will need to investigate and correct
before you can develop on this source tree
buildtest.sh result is 1
BUILD: .././test-suite/buildtests/layer-00-bootstrap.opts
Build Failed. Last log lines are:
BUILD: .././test-suite/buildtests/layer-00-bootstrap.opts
WARNING: Cannot find automake version 1.11 1.10 1.9
./bootstrap.sh[103]: automake: not found
Trying 
WARNING: Cannot find autoconf version 2.63 2.62 2.61
./bootstrap.sh[104]: autoconf: not found
Trying 
WARNING: Cannot find libtool version 2 1.5 1.4
./bootstrap.sh[105]: libtool: not found
Trying 
automake : 
autoconfg: 
libtool  : 
Bootstrapping 
./bootstrap.sh[141]: aclocal: not found
aclocal failed
Autotool bootstrapping failed. You will need to investigate and correct
before you can develop on this source tree
buildtest.sh result is 1

Re: [PATCH] hier_code ACL (port from 2.7)

[Henrik Nordstrom]

hnordstrom has voted approve.
Status is now: Approved
Comment:
Looks fine.

But the patch highlighted another minor issue.. we should get the hier 
strings autogenerated from the enum. Having lists like that in the 
source is quite errorprone.


For details, see: 
http://bundlebuggy.aaronbentley.com/project/squid/request/%3C4A85668C.1020006%40treenet.co.nz%3E

Project: Squid

Re: RFC: infrastructure product in bugzilla

[Henrik Nordstrom]

tor 2009-08-20 klockan 09:00 +1000 skrev Robert Collins:
> I think we should have an infrastructure product in bugzilla, for
> tracking list/server/buildfarm etc issues.

My vote is for an "other" product.

Regards
Henrik

Build failed in Hudson: 3.HEAD-i386-OpenBSD-4.5 #4

[noc]

See 

--
Started by user kinkie
Building remotely on vobsd
Unable to obtain lock 
file:///home/hudson/workspace/3.HEAD-i386-OpenBSD-4.5/.bzr/branch/lock
held by hud...@vobsd.squid-cache.org on host vobsd.squid-cache.org [process 
#17928]
locked 65 minutes, 48 seconds ago
Will continue to try until 13:44:14

bzr: ERROR: Could not acquire lock 
"LockDir(file:///home/hudson/workspace/3.HEAD-i386-OpenBSD-4.5/.bzr/branch/lock)"
Using saved location: http://www.squid-cache.org/bzr/squid3/trunk/
ERROR: Failed to pull

Build failed in Hudson: 3.HEAD-i386-OpenBSD-4.5 #3

[noc]

See 

--
Started by user kinkie
Building remotely on vobsd
SCM check out aborted

Build failed in Hudson: 3.HEAD-i386-OpenBSD-4.5 #2

[noc]

See 

--
Started by user kinkie
Building remotely on vobsd
Branched 9919 revision(s).
+ ./test-builds.sh --verbose
/tmp/hudson19340.sh[2]: ./test-builds.sh: not found

Re: [PATCH] hier_code ACL (port from 2.7)

[Bundle Buggy]

Bundle Buggy has detected this merge request.

For details, see: 
http://bundlebuggy.aaronbentley.com/project/squid/request/%3C4A856635.4080809%40treenet.co.nz%3E

Project: Squid

Re: [MERGE] 1/2: Populate cache_mem on disk hits

[Bundle Buggy]

Bundle Buggy has detected this merge request.

For details, see: 
http://bundlebuggy.aaronbentley.com/project/squid/request/%3C1250159729.26060.6.camel%40henriknordstrom.net%3E

Project: Squid

Re: [PATCH] hier_code ACL (port from 2.7)

[Bundle Buggy]

Bundle Buggy has detected this merge request.

For details, see: 
http://bundlebuggy.aaronbentley.com/project/squid/request/%3C4A85668C.1020006%40treenet.co.nz%3E

Project: Squid