Re: [PATCH] Setting SO_KEEPALIVE on outbound connections

2014-02-10 Thread Amos Jeffries
Do you have an updated patch on this?

Amos



Fwd: HTTP/1.1 revision status [was: HTTP/1.1bis draft -26]

2014-02-10 Thread Amos Jeffries
FYI for anyone interested in the HTTP/1.1 compliance project or related
work. The HTTPbis drafts are now etched in stone.

You can find links to the HTTPbis work on 1.1 and 2.0 protocols here:
 http://trac.tools.ietf.org/wg/httpbis/trac/wiki

Amos

On 10/02/2014 3:56 p.m., Mark Nottingham wrote:
 …and the final DISCUSS has been marked as resolved, so the -26 drafts
 will go forward. We have a few more process things to go through
 (e.g., final checks on the changes by IANA, as well as handling any
 issues at the RFC editor stage), but essentially the revision of
 HTTP/1.1 is done.
 
 Thanks to everyone who contributed (there’s a long list at the end of
 p1), especially Julian Reschke and Roy Fielding, as well as our four
 (!) sponsoring Area Directors over the years - Lisa Dusseault, Alexey
 Melnikov, Peter Saint-Andre and Barry Leiba.
 
 We’ll keep the WG informed as the specs progress through these final
 stages.
 
 Cheers,
 
 P.S. You can see all six-plus years of repository commits visualised
 here: http://www.youtube.com/watch?v=YLoyitA-g10
 



Re: [PATCH] refactor Vector

2014-02-10 Thread Kinkie
On Sun, Feb 9, 2014 at 2:08 AM, Alex Rousskov
rouss...@measurement-factory.com wrote:
 On 02/08/2014 03:44 PM, Kinkie wrote:

 And I don't see how to reliably get to vector[0] in pre-11 STL. Do you
 have any clue?

 My understanding is that you just do vector_object[0], but I have not
 tested that.

Confirmed, that or vector_obj.front() seems to be the standard way.
I'll leave a TODO postc++11, as it seems hackish.

Thanks, I guess that after some testing it's time to merge and then
work on the actual std:: replacement.


-- 
Francesco


Re: [PATCH] refactor Vector

2014-02-10 Thread Kinkie
 The kind of cast appears to be wrong here: Const_cast is normally used
 to remove const, not add it. It is not used to change the type.

It is currently a c-style cast.
Attributes is built over push_back(), so the only way to cleanly make
it const would be to copy it after it's built.
Without it,
CustomParser.cc:209:83: error: invalid conversion from 'char**' to
'const char**' [-fpermissive]



-- 
Francesco


Build failed in Jenkins: 3.HEAD-amd64-centos-6 #213

2014-02-10 Thread noc
See http://build.squid-cache.org/job/3.HEAD-amd64-centos-6/213/changes

Changes:

[Amos Jeffries] Bug 3969: user credentials cache lookup for Digest 
authentication broken

Changes to the username credentials cache were made in Basic auth but
the matching changes were not duplicated to Digest auth. Since the
lookup is identical move it to generic Auth::Config.

Also fixes assertion auth_digest.cc:759:
(nonce-user == NULL) || (nonce-user == user)

--
[...truncated 4431 lines...]
/bin/sh ../../libtool  --tag=CXX   --mode=compile ccache g++ -DHAVE_CONFIG_H  
-I../../.. -I../../../include -I../../../lib -I../../../src -I../../include
-I../../../src/fs   -Wall -Wpointer-arith -Wwrite-strings -Wcomments -Wshadow 
-Werror -pipe -D_REENTRANT -g -O2 -std=c++0x -MT RockIoRequests.lo -MD -MP -MF 
.deps/RockIoRequests.Tpo -c -o RockIoRequests.lo `test -f 
'rock/RockIoRequests.cc' || echo '../../../src/fs/'`rock/RockIoRequests.cc
mv -f .deps/StoreFSdiskd.Tpo .deps/StoreFSdiskd.Plo
/bin/sh ../../libtool  --tag=CXX   --mode=compile ccache g++ -DHAVE_CONFIG_H  
-I../../.. -I../../../include -I../../../lib -I../../../src -I../../include
-I../../../src/fs   -Wall -Wpointer-arith -Wwrite-strings -Wcomments -Wshadow 
-Werror -pipe -D_REENTRANT -g -O2 -std=c++0x -MT RockRebuild.lo -MD -MP -MF 
.deps/RockRebuild.Tpo -c -o RockRebuild.lo `test -f 'rock/RockRebuild.cc' || 
echo '../../../src/fs/'`rock/RockRebuild.cc
mv -f .deps/StoreFSaufs.Tpo .deps/StoreFSaufs.Plo
/bin/sh ../../libtool  --tag=CXX   --mode=compile ccache g++ -DHAVE_CONFIG_H  
-I../../.. -I../../../include -I../../../lib -I../../../src -I../../include
-I../../../src/fs   -Wall -Wpointer-arith -Wwrite-strings -Wcomments -Wshadow 
-Werror -pipe -D_REENTRANT -g -O2 -std=c++0x -MT RockStoreFileSystem.lo -MD -MP 
-MF .deps/RockStoreFileSystem.Tpo -c -o RockStoreFileSystem.lo `test -f 
'rock/RockStoreFileSystem.cc' || echo 
'../../../src/fs/'`rock/RockStoreFileSystem.cc
mv -f .deps/RockIoState.Tpo .deps/RockIoState.Plo
/bin/sh ../../libtool  --tag=CXX   --mode=compile ccache g++ -DHAVE_CONFIG_H  
-I../../.. -I../../../include -I../../../lib -I../../../src -I../../include
-I../../../src/fs   -Wall -Wpointer-arith -Wwrite-strings -Wcomments -Wshadow 
-Werror -pipe -D_REENTRANT -g -O2 -std=c++0x -MT RockSwapDir.lo -MD -MP -MF 
.deps/RockSwapDir.Tpo -c -o RockSwapDir.lo `test -f 'rock/RockSwapDir.cc' || 
echo '../../../src/fs/'`rock/RockSwapDir.cc
libtool: compile:  ccache g++ -DHAVE_CONFIG_H -I../../.. -I../../../include 
-I../../../lib -I../../../src -I../../include -I../../../src/fs -Wall 
-Wpointer-arith -Wwrite-strings -Wcomments -Wshadow -Werror -pipe -D_REENTRANT 
-g -O2 -std=c++0x -MT RockIoRequests.lo -MD -MP -MF .deps/RockIoRequests.Tpo -c 
../../../src/fs/rock/RockIoRequests.cc  -fPIC -DPIC -o .libs/RockIoRequests.o
libtool: compile:  ccache g++ -DHAVE_CONFIG_H -I../../.. -I../../../include 
-I../../../lib -I../../../src -I../../include -I../../../src/fs -Wall 
-Wpointer-arith -Wwrite-strings -Wcomments -Wshadow -Werror -pipe -D_REENTRANT 
-g -O2 -std=c++0x -MT RockRebuild.lo -MD -MP -MF .deps/RockRebuild.Tpo -c 
../../../src/fs/rock/RockRebuild.cc  -fPIC -DPIC -o .libs/RockRebuild.o
libtool: compile:  ccache g++ -DHAVE_CONFIG_H -I../../.. -I../../../include 
-I../../../lib -I../../../src -I../../include -I../../../src/fs -Wall 
-Wpointer-arith -Wwrite-strings -Wcomments -Wshadow -Werror -pipe -D_REENTRANT 
-g -O2 -std=c++0x -MT RockStoreFileSystem.lo -MD -MP -MF 
.deps/RockStoreFileSystem.Tpo -c ../../../src/fs/rock/RockStoreFileSystem.cc  
-fPIC -DPIC -o .libs/RockStoreFileSystem.o
libtool: compile:  ccache g++ -DHAVE_CONFIG_H -I../../.. -I../../../include 
-I../../../lib -I../../../src -I../../include -I../../../src/fs -Wall 
-Wpointer-arith -Wwrite-strings -Wcomments -Wshadow -Werror -pipe -D_REENTRANT 
-g -O2 -std=c++0x -MT RockSwapDir.lo -MD -MP -MF .deps/RockSwapDir.Tpo -c 
../../../src/fs/rock/RockSwapDir.cc  -fPIC -DPIC -o .libs/RockSwapDir.o
libtool: compile:  ccache g++ -DHAVE_CONFIG_H -I../../.. -I../../../include 
-I../../../lib -I../../../src -I../../include -I../../../src/fs -Wall 
-Wpointer-arith -Wwrite-strings -Wcomments -Wshadow -Werror -pipe -D_REENTRANT 
-g -O2 -std=c++0x -MT RockIoRequests.lo -MD -MP -MF .deps/RockIoRequests.Tpo -c 
../../../src/fs/rock/RockIoRequests.cc -o RockIoRequests.o /dev/null 21
libtool: compile:  ccache g++ -DHAVE_CONFIG_H -I../../.. -I../../../include 
-I../../../lib -I../../../src -I../../include -I../../../src/fs -Wall 
-Wpointer-arith -Wwrite-strings -Wcomments -Wshadow -Werror -pipe -D_REENTRANT 
-g -O2 -std=c++0x -MT RockRebuild.lo -MD -MP -MF .deps/RockRebuild.Tpo -c 
../../../src/fs/rock/RockRebuild.cc -o RockRebuild.o /dev/null 21
libtool: compile:  ccache g++ -DHAVE_CONFIG_H -I../../.. -I../../../include 
-I../../../lib -I../../../src -I../../include -I../../../src/fs -Wall 
-Wpointer-arith -Wwrite-strings -Wcomments -Wshadow -Werror -pipe 

Build failed in Jenkins: 3.HEAD-coadvisor #199

2014-02-10 Thread noc
See http://build.squid-cache.org/job/3.HEAD-coadvisor/199/

--
Started by an SCM change
Building remotely on co-advisor in workspace 
http://build.squid-cache.org/job/3.HEAD-coadvisor/ws/
Cleaning workspace...
$ bzr checkout --lightweight http://bzr.squid-cache.org/bzr/squid3/trunk/ 
http://build.squid-cache.org/job/3.HEAD-coadvisor/ws/
Getting local revision...
$ bzr revision-info -d http://build.squid-cache.org/job/3.HEAD-coadvisor/ws/
info result: bzr revision-info -d 
http://build.squid-cache.org/job/3.HEAD-coadvisor/ws/ returned 0. Command 
output: 13265 squ...@treenet.co.nz-20140210110858-j9qhjothxmn9y1b1
 stderr: 
RevisionState revno:13265 
revid:squ...@treenet.co.nz-20140210110858-j9qhjothxmn9y1b1
[3.HEAD-coadvisor] $ /bin/sh -xe /tmp/hudson7534386812019135750.sh
+ /home/jenkins/script/makeOneTest.pl --config=/home/jenkins/script/config.cfg 
--audited=http://eu.kinkie.it/coadvisor-artifacts/52/archive/result --jjid=199
Make has failed:  at /home/jenkins/script/makeOneTest.pl line 152.
Build step 'Execute shell' marked build as failure
Archiving artifacts


Jenkins build is back to normal : 3.HEAD-amd64-centos-6 #214

2014-02-10 Thread noc
See http://build.squid-cache.org/job/3.HEAD-amd64-centos-6/214/changes



Jenkins build is back to normal : 3.HEAD-coadvisor #200

2014-02-10 Thread noc
See http://build.squid-cache.org/job/3.HEAD-coadvisor/200/



Re: [PATCH] refactor Vector

2014-02-10 Thread Alex Rousskov
On 02/10/2014 02:20 AM, Kinkie wrote:
 The kind of cast appears to be wrong here: Const_cast is normally used
 to remove const, not add it. It is not used to change the type.
 
 It is currently a c-style cast.
 Attributes is built over push_back(), so the only way to cleanly make
 it const would be to copy it after it's built.
 Without it,
 CustomParser.cc:209:83: error: invalid conversion from 'char**' to
 'const char**' [-fpermissive]

My bad: I did not realize the type before casting is char**.
Const_cast is the right thing to do here.

Alex.



Re: [PATCH] refactor Vector

2014-02-10 Thread Kinkie
On Mon, Feb 10, 2014 at 5:16 PM, Alex Rousskov
rouss...@measurement-factory.com wrote:
 On 02/10/2014 02:20 AM, Kinkie wrote:
 The kind of cast appears to be wrong here: Const_cast is normally used
 to remove const, not add it. It is not used to change the type.

 It is currently a c-style cast.
 Attributes is built over push_back(), so the only way to cleanly make
 it const would be to copy it after it's built.
 Without it,
 CustomParser.cc:209:83: error: invalid conversion from 'char**' to
 'const char**' [-fpermissive]

 My bad: I did not realize the type before casting is char**.
 Const_cast is the right thing to do here.

NP :)
Merged to trunk, now moving on to refactoring Vector-std::vector


-- 
Francesco


Re: [PATCH] Setting SO_KEEPALIVE on outbound connections

2014-02-10 Thread eam
On Mon, Feb 10, 2014 at 09:35:02PM +1300, Amos Jeffries wrote:
 Do you have an updated patch on this?

Sorry, I haven't had time to dig into the configuration end of this. I do
intend to when I get a chance, but I won't be offended if someone else
does it first.



Re: Fwd: HTTP/1.1 revision status [was: HTTP/1.1bis draft -26]

2014-02-10 Thread Henrik Nordström
mån 2014-02-10 klockan 21:48 +1300 skrev Amos Jeffries:
 FYI for anyone interested in the HTTP/1.1 compliance project or related
 work. The HTTPbis drafts are now etched in stone.
 
 You can find links to the HTTPbis work on 1.1 and 2.0 protocols here:
  http://trac.tools.ietf.org/wg/httpbis/trac/wiki


Is the HTTP/2.0 work also finished? Or is that still work in progress?

Have any analysis been made on the impact of HTTP/1.1bis and maybe even
HTTP/2.0 on Squid code?

Regards
Henrik



Jenkins build is back to normal : anybranch-wholefarm-matrix » gcc,rs-ubuntu-saucy #59

2014-02-10 Thread noc
See 
http://build.squid-cache.org/job/anybranch-wholefarm-matrix/compiler=gcc,label=rs-ubuntu-saucy/59/



Jenkins build is back to normal : anybranch-wholefarm-matrix » clang,rs-ubuntu-saucy #59

2014-02-10 Thread noc
See 
http://build.squid-cache.org/job/anybranch-wholefarm-matrix/compiler=clang,label=rs-ubuntu-saucy/59/



Build failed in Jenkins: anybranch-wholefarm-matrix » icc,master #59

2014-02-10 Thread noc
See 
http://build.squid-cache.org/job/anybranch-wholefarm-matrix/compiler=icc,label=master/59/

--
[...truncated 57781 lines...]
 ( cd 
'/tmp/am-dc-21393/http://build.squid-cache.org/job/anybranch-wholefarm-matrix/compiler=icc,label=master/ws/btlayer-05-nodeps-esi/squid-3.4.3-BZR/_inst/share/man/man8'
  rm -f ext_session_acl.8 )
make[4]: Leaving directory 
`http://build.squid-cache.org/job/anybranch-wholefarm-matrix/compiler=icc,label=master/ws/btlayer-05-nodeps-esi/squid-3.4.3-BZR/_build/helpers/external_acl/session'
Making uninstall in time_quota
make[4]: Entering directory 
`http://build.squid-cache.org/job/anybranch-wholefarm-matrix/compiler=icc,label=master/ws/btlayer-05-nodeps-esi/squid-3.4.3-BZR/_build/helpers/external_acl/time_quota'
 ( cd 
'/tmp/am-dc-21393/http://build.squid-cache.org/job/anybranch-wholefarm-matrix/compiler=icc,label=master/ws/btlayer-05-nodeps-esi/squid-3.4.3-BZR/_inst/libexec'
  rm -f ext_time_quota_acl )
 ( cd 
'/tmp/am-dc-21393/http://build.squid-cache.org/job/anybranch-wholefarm-matrix/compiler=icc,label=master/ws/btlayer-05-nodeps-esi/squid-3.4.3-BZR/_inst/share/man/man8'
  rm -f ext_time_quota_acl.8 )
make[4]: Leaving directory 
`http://build.squid-cache.org/job/anybranch-wholefarm-matrix/compiler=icc,label=master/ws/btlayer-05-nodeps-esi/squid-3.4.3-BZR/_build/helpers/external_acl/time_quota'
Making uninstall in unix_group
make[4]: Entering directory 
`http://build.squid-cache.org/job/anybranch-wholefarm-matrix/compiler=icc,label=master/ws/btlayer-05-nodeps-esi/squid-3.4.3-BZR/_build/helpers/external_acl/unix_group'
 ( cd 
'/tmp/am-dc-21393/http://build.squid-cache.org/job/anybranch-wholefarm-matrix/compiler=icc,label=master/ws/btlayer-05-nodeps-esi/squid-3.4.3-BZR/_inst/libexec'
  rm -f ext_unix_group_acl )
 ( cd 
'/tmp/am-dc-21393/http://build.squid-cache.org/job/anybranch-wholefarm-matrix/compiler=icc,label=master/ws/btlayer-05-nodeps-esi/squid-3.4.3-BZR/_inst/share/man/man8'
  rm -f ext_unix_group_acl.8 )
make[4]: Leaving directory 
`http://build.squid-cache.org/job/anybranch-wholefarm-matrix/compiler=icc,label=master/ws/btlayer-05-nodeps-esi/squid-3.4.3-BZR/_build/helpers/external_acl/unix_group'
Making uninstall in wbinfo_group
make[4]: Entering directory 
`http://build.squid-cache.org/job/anybranch-wholefarm-matrix/compiler=icc,label=master/ws/btlayer-05-nodeps-esi/squid-3.4.3-BZR/_build/helpers/external_acl/wbinfo_group'
 ( cd 
'/tmp/am-dc-21393/http://build.squid-cache.org/job/anybranch-wholefarm-matrix/compiler=icc,label=master/ws/btlayer-05-nodeps-esi/squid-3.4.3-BZR/_inst/libexec'
  rm -f ext_wbinfo_group_acl )
 ( cd 
'/tmp/am-dc-21393/http://build.squid-cache.org/job/anybranch-wholefarm-matrix/compiler=icc,label=master/ws/btlayer-05-nodeps-esi/squid-3.4.3-BZR/_inst/share/man/man8'
  rm -f ext_wbinfo_group_acl.8 )
make[4]: Leaving directory 
`http://build.squid-cache.org/job/anybranch-wholefarm-matrix/compiler=icc,label=master/ws/btlayer-05-nodeps-esi/squid-3.4.3-BZR/_build/helpers/external_acl/wbinfo_group'
make[4]: Entering directory 
`http://build.squid-cache.org/job/anybranch-wholefarm-matrix/compiler=icc,label=master/ws/btlayer-05-nodeps-esi/squid-3.4.3-BZR/_build/helpers/external_acl'
make[4]: Nothing to be done for `uninstall-am'.
make[4]: Leaving directory 
`http://build.squid-cache.org/job/anybranch-wholefarm-matrix/compiler=icc,label=master/ws/btlayer-05-nodeps-esi/squid-3.4.3-BZR/_build/helpers/external_acl'
make[3]: Leaving directory 
`http://build.squid-cache.org/job/anybranch-wholefarm-matrix/compiler=icc,label=master/ws/btlayer-05-nodeps-esi/squid-3.4.3-BZR/_build/helpers/external_acl'
Making uninstall in log_daemon
make[3]: Entering directory 
`http://build.squid-cache.org/job/anybranch-wholefarm-matrix/compiler=icc,label=master/ws/btlayer-05-nodeps-esi/squid-3.4.3-BZR/_build/helpers/log_daemon'
Making uninstall in DB
make[4]: Entering directory 
`http://build.squid-cache.org/job/anybranch-wholefarm-matrix/compiler=icc,label=master/ws/btlayer-05-nodeps-esi/squid-3.4.3-BZR/_build/helpers/log_daemon/DB'
 ( cd 
'/tmp/am-dc-21393/http://build.squid-cache.org/job/anybranch-wholefarm-matrix/compiler=icc,label=master/ws/btlayer-05-nodeps-esi/squid-3.4.3-BZR/_inst/libexec'
  rm -f log_db_daemon )
 ( cd 
'/tmp/am-dc-21393/http://build.squid-cache.org/job/anybranch-wholefarm-matrix/compiler=icc,label=master/ws/btlayer-05-nodeps-esi/squid-3.4.3-BZR/_inst/share/man/man8'
  rm -f log_db_daemon.8 )
make[4]: Leaving directory 
`http://build.squid-cache.org/job/anybranch-wholefarm-matrix/compiler=icc,label=master/ws/btlayer-05-nodeps-esi/squid-3.4.3-BZR/_build/helpers/log_daemon/DB'
Making uninstall in file
make[4]: Entering directory 
`http://build.squid-cache.org/job/anybranch-wholefarm-matrix/compiler=icc,label=master/ws/btlayer-05-nodeps-esi/squid-3.4.3-BZR/_build/helpers/log_daemon/file'
 ( cd 

Jenkins build is back to normal : anybranch-wholefarm-matrix » gcc,master #59

2014-02-10 Thread noc
See 
http://build.squid-cache.org/job/anybranch-wholefarm-matrix/compiler=gcc,label=master/59/