Re: Autoconf-refactor bugs?
Hi! > Unless you tell me otherwise, I plan on keeping it where I had it > previously (around about line 1115 after SSL checks), but changing it as > Amos said, so that it adds in the functionality if the libraries are > present unless disabled. Unless there is a reason, I'd suggest to leave it close to the other netfilter stuff (option handling @1250, if there's dependencies to manage those can be handled @3030.. The general behaviour of configure options should be "default auto (which means enable if all pieces are available), can be force-enabled or force-disabled. If it is force-enabled and some library is missing, fail the build" Thanks! -- /kinkie
Re: Autoconf-refactor bugs?
> > Firstly, I'm slightly confused as to whether I am seeing the > > autoconf-refactor work in my copy of trunk (I have run bzr update). I > > didn't think I'd seen it go in, but delving into configure.in I think it > > might be in there... what should I look for to check whether it's > > definitely what I'm looking at? > > It is, it was merged two days ago. Ah yes, I've just realised that I misread Amos's "2 days ago" as "2 days to go"... > And you're right, it does have a few bugs. > Sorry about those. > > > Secondly, assuming it is in, there appear to be 2 small problems: > > > > 1. --disable-inline doesn't work for me. On investigation, this seems to > > be because enable_inline is set to "yes" at line 296, which overrides > > the later AC_ARG_ENABLE(inline), regardless of the setting. Also, I had > > to add in enable_inline=$enableval after the AC_ARG_ENABLE check (once > > I'd removed the enable_inline=yes) to get it to work. > > Fixed, in a slightly different way. > > > 2. Line 1344 (if "$squid_host_os" = "solaris" ; then) appears to be > > missing a 'test'. > > Fixed. > > > Sorry if I've jumped the gun and am actually looking at old code. > > You have not, and thank you for checking things out. > There is one more bug, related to the default hosts file and default > http and icp ports handling. > I've also fixed those. Great, thanks. I shall work on adding in the --with-netfilter-conntrack stuff :-) Unless you tell me otherwise, I plan on keeping it where I had it previously (around about line 1115 after SSL checks), but changing it as Amos said, so that it adds in the functionality if the libraries are present unless disabled. Andy
Re: Autoconf-refactor bugs?
On Fri, Aug 13, 2010 at 11:32 PM, Andrew Beverley wrote: > Hi, > > Firstly, I'm slightly confused as to whether I am seeing the > autoconf-refactor work in my copy of trunk (I have run bzr update). I > didn't think I'd seen it go in, but delving into configure.in I think it > might be in there... what should I look for to check whether it's > definitely what I'm looking at? It is, it was merged two days ago. And you're right, it does have a few bugs. Sorry about those. > Secondly, assuming it is in, there appear to be 2 small problems: > > 1. --disable-inline doesn't work for me. On investigation, this seems to > be because enable_inline is set to "yes" at line 296, which overrides > the later AC_ARG_ENABLE(inline), regardless of the setting. Also, I had > to add in enable_inline=$enableval after the AC_ARG_ENABLE check (once > I'd removed the enable_inline=yes) to get it to work. Fixed, in a slightly different way. > 2. Line 1344 (if "$squid_host_os" = "solaris" ; then) appears to be > missing a 'test'. Fixed. > Sorry if I've jumped the gun and am actually looking at old code. You have not, and thank you for checking things out. There is one more bug, related to the default hosts file and default http and icp ports handling. I've also fixed those. -- /kinkie
Autoconf-refactor bugs?
Hi, Firstly, I'm slightly confused as to whether I am seeing the autoconf-refactor work in my copy of trunk (I have run bzr update). I didn't think I'd seen it go in, but delving into configure.in I think it might be in there... what should I look for to check whether it's definitely what I'm looking at? Secondly, assuming it is in, there appear to be 2 small problems: 1. --disable-inline doesn't work for me. On investigation, this seems to be because enable_inline is set to "yes" at line 296, which overrides the later AC_ARG_ENABLE(inline), regardless of the setting. Also, I had to add in enable_inline=$enableval after the AC_ARG_ENABLE check (once I'd removed the enable_inline=yes) to get it to work. 2. Line 1344 (if "$squid_host_os" = "solaris" ; then) appears to be missing a 'test'. Sorry if I've jumped the gun and am actually looking at old code. Regards, Andy
