Re: DEBUG Section for IPAddress

2007-04-04 Thread Alex Rousskov
On Wed, 2007-04-04 at 13:02 +1200, Amos Jeffries wrote:
 Gah! I diffed the files backwards.
 
 Here is the actual patch for doc/debug-sections.txt

Amos,

The doc/mk-debugs.sh script you were using (or equivalent) needs to be
fixed. It needs to grep files in subdirectories of src/. For example, it
currently misses:

DEBUG: section 93  ICAP (RFC 3507) Client

Using 'find src -name *.cc -o -name *.h' instead of a src/*.cc mask
may work.

Alex.




Re: DEBUG Section for IPAddress

2007-04-04 Thread Amos Jeffries

Alex Rousskov wrote:

On Wed, 2007-04-04 at 13:02 +1200, Amos Jeffries wrote:

Gah! I diffed the files backwards.

Here is the actual patch for doc/debug-sections.txt


Amos,

The doc/mk-debugs.sh script you were using (or equivalent) needs to be
fixed. It needs to grep files in subdirectories of src/. For example, it
currently misses:

DEBUG: section 93  ICAP (RFC 3507) Client

Using 'find src -name *.cc -o -name *.h' instead of a src/*.cc mask
may work.

Alex.



You looking at my first copy of the patch? That was badly mangled.

Its there in the amended patch I re-posted:

+section 90HTTP Cache Control Header
+section 90Storage Manager Client-Side Interface
+
+section 92Storage File System
+section 93ICAP (RFC 3507) Client
+
+
+section ? Common Removal policy
+section --External DISKD process implementation.
+section ?? FDE
+section ? HEAP based removal policies


Amos


Re: DEBUG Section for IPAddress

2007-04-03 Thread Amos Jeffries

Alex Rousskov wrote:

On Mon, 2007-03-26 at 23:59 +1200, Amos Jeffries wrote:
I have so far not placed any permanent debug statements in the IPAddress 
object.
It's come about time I should be making some more permanent ones and so 
need a section number. Is there some method I don't know yet for 
assigning a unique level or do I just pick an unused number and write it in?


If you have not received better instructions yet, just use the next
unused number for the debug section and add it to your file(s) prefix
just like most other source files do. 


The stale doc/debug-sections.txt is (or should be) generated based on
the source code. Do not update that file unless you are willing to
freshen it up first.

Cheers,

Alex.



Thank you Alex,
  No I have not received any further instructions and assumed that was 
the best action to take. I picked level 36, but that turns out to be 
cache dir processing and I expect its in use own another branch.


If by 'freshen up' you mean rebuild the file from source using a grep of 
the source files headers for DEBUG section and a manual massage. I did 
that earlier before seeing the doc/ file. The update patch resulting is 
attached.


FYI to all:  IP Handling will join IP Cache in section 14, unless there 
are any objections by easter.



Amos
--- DEBUG_levels.txt	2007-04-04 12:56:03.0 +1200
+++ doc/debug-sections.txt	2007-03-27 20:12:49.0 +1200
@@ -3,14 +3,11 @@
 section 0 Client Database
 section 0 Debug Routines
 section 0 DNS Resolver
-section 0 Hash Tables
-section 0 UFS Store Dump
 section 0 WWW Client
 section 1 Startup and Main Loop
 section 2 Unlink Daemon
 section 3 Configuration File Parsing
 section 4 Error Generation
-section 5 Comms
 section 5 Socket Functions
 section 6 Disk I/O Routines
 section 7 Multicast
@@ -21,35 +18,21 @@
 section 12Internet Cache Protocol
 section 13High Level Memory Pool Management
 section 14IP Cache
-section 14IP Storage and Handling
 section 15Neighbor Routines
 section 16Cache Manager Objects
 section 17Request Forwarding
 section 18Cache Manager Statistics
 section 19Store Memory Primitives
 section 20Storage Manager
-section 20Storage Manager Heap-based replacement
-section 20Storage Manager Logging Functions
-section 20Storage Manager MD5 Cache Keys
-section 20Storage Manager Swapfile Metadata
-section 20Storage Manager Swapfile Unpacker
-section 20Storage Manager Swapin Functions
-section 20Storage Manager Swapout Functions
-section 20Store Rebuild Routines
-section 21Integer functions
 section 21Misc Functions
-section 21Time Functions
 section 22Refresh Calculation
 section 23URL Parsing
-section 23URL Scheme parsing
-
+section 24WAIS Relay
 section 25MIME Parsing
 section 26Secure Sockets Layer Proxy
 section 27Cache Announcer
 section 28Access Control
 section 29Authenticator
-section 29Negotiate Authenticator
-section 29NTLM Authenticator
 section 30Ident (RFC 931)
 section 31Hypertext Caching Protocol
 section 32Asynchronous Disk I/O
@@ -61,26 +44,20 @@
 section 38Network Measurement Database
 section 39Cache Array Routing Protocol
 section 40User-Agent and Referer logging
-section 40User-Agent logging
 section 41Event Processing
 section 42ICMP Pinger program
 section 43AIOPS
-section 43Windows AIOPS
 section 44Peer Selection Algorithm
 section 45Callback Data Registry
 section 46Access Log
-section 47Store COSS Directory Routines
 section 47Store Directory Routines
 section 48Persistent Connections
-section 49SNMP Interface
-section 49SNMP support
+section 49SNMP
 section 50Log file handling
 section 51Filedescriptor Functions
 section 52URN Parsing
 section 53AS Number handling
-section 53 Radix tree data structure implementation
 section 54Interprocess Communication
-section 54Windows Interprocess Communication
 section 55HTTP Header
 section 56HTTP Message Body
 section 57HTTP Status-line
@@ -89,7 +66,7 @@
 section 60Packer: A uniform interface to store-like modules
 section 61Redirector
 section 62Generic Histogram
-section 63Low Level Memory Pool Management
+section 63-
 section 64HTTP Range Header
 section 65HTTP Cache Control Header
 section 66HTTP Header Tools
@@ -104,38 +81,18 @@
 section 75WHOIS protocol
 section 76Internal Squid Object handling
 section 77Delay Pools
-section 78DNS lookups; interacts with lib/rfc1035.c
-section 79Disk IO Routines
-section 79Squid-side DISKD I/O functions.
-section 79Squid-side Disk I/O functions.
-section 79Storage Manager COSS Interface
-section 79Storage Manager UFS Interface
-section 80WCCP Support
-section 81aio_xxx() POSIX emulation on Windows
-section 81 CPU Profiling 

Re: DEBUG Section for IPAddress

2007-04-03 Thread Amos Jeffries

Gah! I diffed the files backwards.

Here is the actual patch for doc/debug-sections.txt

Amos
--- doc/debug-sections.txt	2007-03-27 20:12:49.0 +1200
+++ DEBUG_levels.txt	2007-04-04 12:56:03.0 +1200
@@ -3,11 +3,14 @@
 section 0 Client Database
 section 0 Debug Routines
 section 0 DNS Resolver
+section 0 Hash Tables
+section 0 UFS Store Dump
 section 0 WWW Client
 section 1 Startup and Main Loop
 section 2 Unlink Daemon
 section 3 Configuration File Parsing
 section 4 Error Generation
+section 5 Comms
 section 5 Socket Functions
 section 6 Disk I/O Routines
 section 7 Multicast
@@ -18,21 +21,35 @@
 section 12Internet Cache Protocol
 section 13High Level Memory Pool Management
 section 14IP Cache
+section 14IP Storage and Handling
 section 15Neighbor Routines
 section 16Cache Manager Objects
 section 17Request Forwarding
 section 18Cache Manager Statistics
 section 19Store Memory Primitives
 section 20Storage Manager
+section 20Storage Manager Heap-based replacement
+section 20Storage Manager Logging Functions
+section 20Storage Manager MD5 Cache Keys
+section 20Storage Manager Swapfile Metadata
+section 20Storage Manager Swapfile Unpacker
+section 20Storage Manager Swapin Functions
+section 20Storage Manager Swapout Functions
+section 20Store Rebuild Routines
+section 21Integer functions
 section 21Misc Functions
+section 21Time Functions
 section 22Refresh Calculation
 section 23URL Parsing
-section 24WAIS Relay
+section 23URL Scheme parsing
+
 section 25MIME Parsing
 section 26Secure Sockets Layer Proxy
 section 27Cache Announcer
 section 28Access Control
 section 29Authenticator
+section 29Negotiate Authenticator
+section 29NTLM Authenticator
 section 30Ident (RFC 931)
 section 31Hypertext Caching Protocol
 section 32Asynchronous Disk I/O
@@ -44,20 +61,26 @@
 section 38Network Measurement Database
 section 39Cache Array Routing Protocol
 section 40User-Agent and Referer logging
+section 40User-Agent logging
 section 41Event Processing
 section 42ICMP Pinger program
 section 43AIOPS
+section 43Windows AIOPS
 section 44Peer Selection Algorithm
 section 45Callback Data Registry
 section 46Access Log
+section 47Store COSS Directory Routines
 section 47Store Directory Routines
 section 48Persistent Connections
-section 49SNMP
+section 49SNMP Interface
+section 49SNMP support
 section 50Log file handling
 section 51Filedescriptor Functions
 section 52URN Parsing
 section 53AS Number handling
+section 53 Radix tree data structure implementation
 section 54Interprocess Communication
+section 54Windows Interprocess Communication
 section 55HTTP Header
 section 56HTTP Message Body
 section 57HTTP Status-line
@@ -66,7 +89,7 @@
 section 60Packer: A uniform interface to store-like modules
 section 61Redirector
 section 62Generic Histogram
-section 63-
+section 63Low Level Memory Pool Management
 section 64HTTP Range Header
 section 65HTTP Cache Control Header
 section 66HTTP Header Tools
@@ -81,18 +104,38 @@
 section 75WHOIS protocol
 section 76Internal Squid Object handling
 section 77Delay Pools
-section 78DNS lookups
-section 79Lowlevel store I/O
-section 80WCCP
-section 81Cache Store
+section 78DNS lookups; interacts with lib/rfc1035.c
+section 79Disk IO Routines
+section 79Squid-side DISKD I/O functions.
+section 79Squid-side Disk I/O functions.
+section 79Storage Manager COSS Interface
+section 79Storage Manager UFS Interface
+section 80WCCP Support
+section 81aio_xxx() POSIX emulation on Windows
+section 81 CPU Profiling Routines
 section 82External ACL
 section 83SSL accelerator support
 section 84Helper process maintenance
-section 85Client side request management - after parsing, before caching
-section 86ESI processing
-section 87client side stream management
-section 88Client side reply management - from store to stream
-section 89NAT / IP Interception
-section 90Store Client
-section 91Http Surrogate-Control Header
-section 92Store File System
+section 85Client-side Request Routines
+section 86ESI Expressions
+section 86ESI Processing
+section 87Client-side Stream routines.
+section 88Client-side Reply Routines
+section 89NAT / IP Interception 
+section 90HTTP Cache Control Header
+section 90Storage Manager Client-Side Interface
+
+section 92Storage File System
+section 93ICAP (RFC 3507) Client
+
+
+section ? Common Removal policy
+section --External DISKD process implementation.
+section ??	FDE
+section ? HEAP based removal policies
+section ??Linked list functions 
+section ? LRU Removal 

DEBUG Section for IPAddress

2007-03-26 Thread Amos Jeffries
I have so far not placed any permanent debug statements in the IPAddress 
object.
It's come about time I should be making some more permanent ones and so 
need a section number. Is there some method I don't know yet for 
assigning a unique level or do I just pick an unused number and write it in?


Amos