Re: /dev/poll support for squid-2
On Tue, May 22, 2007, Michael Pye wrote: Adrian Chadd wrote: On Mon, May 21, 2007, Henrik Nordstrom wrote: What's left to make it a full /dev/poll support? Just testing, or is something missing? Testing. I will test this on a ~200 request per second solaris 10 box in the next day or two and give you some feedback. Looks promising :) ! Thanks! Just don't use the patch - use the Squid-2 tree. The patch is very very busted. Adrian
Re: /dev/poll support for squid-2
sön 2007-05-20 klockan 17:43 +0800 skrev Adrian Chadd: I've written some initial /dev/poll support for squid-2: http://www.creative.net.au/diffs/2007-05-20-squid2-devpoll.diff The notable change to the rest of the codebase is exposing commOpen() and commClose() functions. commOpen() to initialise the per-fd state, the commClose() to be a bit more explicit about how FD's are being removed. Comments? Looks fine. What's left to make it a full /dev/poll support? Just testing, or is something missing? Regards Henrik signature.asc Description: Detta är en digitalt signerad meddelandedel
Re: /dev/poll support for squid-2
On Mon, May 21, 2007, Henrik Nordstrom wrote: What's left to make it a full /dev/poll support? Just testing, or is something missing? Testing. Well, the stuff I first committed was an attempt to be friendly and bunch up event updates a-la kqueue - but delete entries when the FD closes so we don't try to queue them on an invalid FD - but i wasn't deleting entries right. For now it does the epoll style - one update per commSetEvents() which requires an actual update, and a POLLREMOVE when the FD is closed. Its not as optimal as it can be, but it should work much better than poll(). Adrian
