Re: auth_ntlm broken?
On Fri, 27 Apr 2007, Gernot Tenchio wrote: Hi developers, I've noticed that auth_ntlm does not work in current squid3-icap branch. As far as I remember squid crashed right after printing "AuthNTLMUserRequest::authenticate: authenticated user XYZ". I have a possible patch at http://www.squid-cache.org/bugs/attachment.cgi?id=1379&action=view care to try it out? Duane W.
Re: auth_ntlm broken?
On Sun, 2007-04-29 at 19:22 +0200, Henrik Nordstrom wrote: > lör 2007-04-28 klockan 22:00 -0600 skrev Alex Rousskov: > > > Thank you for reporting the problem! It sounds like the changes you are > > talking about came from the Squid HEAD branch. Perhaps they created a > > conflict and the conflict was not resolved correctly. I will investigate > > and try to fix. > > That probablly the fixes for Bug #1792 and #1873. > http://www.squid-cache.org/Versions/v3/3.0/changesets/10626.patch #1873 > http://www.squid-cache.org/Versions/v3/3.0/changesets/10632.patch #1792 > > Probably some other NTLM fix from Squid-2 is missing, or there was some > error introduced forwardporting these changes. > > The Squid-2 versions look like > http://www.squid-cache.org/Versions/v2/2.6/changesets/11170.patch #1873 > http://www.squid-cache.org/Versions/v2/2.6/changesets/11147.patch #1792 take 2 > http://www.squid-cache.org/Versions/v2/2.6/changesets/11145.patch #1792 take 1 > > Hmm.. Squid-2 has one more change not yet in Squid-3. Might be relevant > even if that only showed it's ugly head while using Negotiate in > Squid-2. > > http://www.squid-cache.org/Versions/v2/2.6/changesets/11280.patch Wow. This is very helpful, but I should probably not try to fix this complicated code as I do not fully understand the subtleties involved, like the difference between DONE and FINISHED states. I have filed a bug report and pasted your hints there: http://www.squid-cache.org/bugs/show_bug.cgi?id=1951 Could somebody more familiar with the authentication code fix this? Thank you, Alex.
Re: auth_ntlm broken?
lör 2007-04-28 klockan 22:00 -0600 skrev Alex Rousskov: > Thank you for reporting the problem! It sounds like the changes you are > talking about came from the Squid HEAD branch. Perhaps they created a > conflict and the conflict was not resolved correctly. I will investigate > and try to fix. That probablly the fixes for Bug #1792 and #1873. http://www.squid-cache.org/Versions/v3/3.0/changesets/10626.patch #1873 http://www.squid-cache.org/Versions/v3/3.0/changesets/10632.patch #1792 Probably some other NTLM fix from Squid-2 is missing, or there was some error introduced forwardporting these changes. The Squid-2 versions look like http://www.squid-cache.org/Versions/v2/2.6/changesets/11170.patch #1873 http://www.squid-cache.org/Versions/v2/2.6/changesets/11147.patch #1792 take 2 http://www.squid-cache.org/Versions/v2/2.6/changesets/11145.patch #1792 take 1 Hmm.. Squid-2 has one more change not yet in Squid-3. Might be relevant even if that only showed it's ugly head while using Negotiate in Squid-2. http://www.squid-cache.org/Versions/v2/2.6/changesets/11280.patch Regards Henrik signature.asc Description: Detta är en digitalt signerad meddelandedel
Re: auth_ntlm broken?
On Fri, 2007-04-27 at 21:11 +0200, Gernot Tenchio wrote: > Hi developers, > > I've noticed that auth_ntlm does not work in current squid3-icap branch. As > far as I remember squid crashed right after printing > "AuthNTLMUserRequest::authenticate: authenticated user XYZ". > > After looking into sources i saw two changes to auth_ntlm.cc. One is dated > 03-Jan-07 and the other is dated 20-Jan-07. They changing the way > AUTHENTICATE_STATE_xxx is handled. After reverting these changes back to the > version before 03-Jan-07, auth_ntlm works again as expected. What was the > reason for these changes? Hello, Thank you for reporting the problem! It sounds like the changes you are talking about came from the Squid HEAD branch. Perhaps they created a conflict and the conflict was not resolved correctly. I will investigate and try to fix. Thank you, Alex. P.S. For the future, please post a diff of changes as it usually speeds things up considerably.
auth_ntlm broken?
Hi developers, I've noticed that auth_ntlm does not work in current squid3-icap branch. As far as I remember squid crashed right after printing "AuthNTLMUserRequest::authenticate: authenticated user XYZ". After looking into sources i saw two changes to auth_ntlm.cc. One is dated 03-Jan-07 and the other is dated 20-Jan-07. They changing the way AUTHENTICATE_STATE_xxx is handled. After reverting these changes back to the version before 03-Jan-07, auth_ntlm works again as expected. What was the reason for these changes? Gernot -- Mahatma Glück, Mahatma Pech, Mahatma Gandhi. -- indian proverb signature.asc Description: PGP signature
