Re: disable-loadable-modules
Alex Rousskov wrote:
On 07/09/2009 01:40 AM, Amos Jeffries wrote:
Amos Jeffries wrote:
Well, I've found a possible reason to disable them by default.
The Debian Lenny/Ubuntu Jaunty libtool 2.2 appears broken with its
handling of the libtool convenience library. Giving build failures
unless they are configured to off.
Since I made the change to testbed "distcheck" I've been fighting with
them. Something inside distcheck seems to be running configure with
the defaults regardless of what the master test is run with. Probably
the dist "configure --silent" packaging or a sub-test of the package
it makes.
If anyone is able to help I'd be very grateful. If we can't find a
solution to that one I think we are going to have to disable loadable
modules unless adaptation needs them.
Amos
Confirmed:
c_install_base=`CDPATH="${ZSH_VERSION+.}:" && cd squid-3.HEAD-BZR/_inst
&& pwd | sed -e 's,^[^:\\/]:[\\/],/,'` \
&& dc_destdir="${TMPDIR-/tmp}/am-dc-$$/" \
&& cd squid-3.HEAD-BZR/_build \
&& ../configure --srcdir=.. --prefix="$dc_install_base" \
\
&& make \
&& make dvi \
&& make check \
&& make install \
&& make installcheck \
&& make uninstall \
...
&& make dist \
&& rm -rf squid-3.HEAD-BZR.tar.gz squid-3.HEAD-BZR.tar.bz2 \
&& make distcleancheck
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
...
checking whether to use loadable modules... yes, implicitly
Will setting DISTCHECK_CONFIGURE_FLAGS in top Makefile.am help with this?
Alex.
That worked for the distcheck breakage.
Now only to fix the libtool bug that brought it to attention.
Amos
--
Please be using
Current Stable Squid 2.7.STABLE6 or 3.0.STABLE16
Current Beta Squid 3.1.0.9
Re: disable-loadable-modules
On Fri, 2009-07-10 at 23:33 +1200, Amos Jeffries wrote:
> I thought I had something adding ${srcdir} to the path we pass it.
> But builddir does not seem to be available, and srcdir is the wrong
> place to find the built convenience lib.
Neither should be done. The lib should be added (the .la file), and the
wrapper script for runtime execution sets LD_LIBRARY_PATH for us.
-Rob
signature.asc
Description: This is a digitally signed message part
Re: disable-loadable-modules
Robert Collins wrote:
On Thu, 2009-07-09 at 20:22 +1200, Amos Jeffries wrote:
Robert Collins wrote:
On Thu, 2009-07-09 at 19:40 +1200, Amos Jeffries wrote:
...
checking whether to use loadable modules... yes, implicitly
Is the test for whether to use them broken?
The code is to always enables them by default unless forced not to.
Everything would work just fine if libtool would only add the
$(builddir) to the path its trying to locate locally built things on.
It will if its been told that its using local libraries. I suspect we're
misusing something in libtool/automake to generate these symptoms.
-Rob
I thought I had something adding ${srcdir} to the path we pass it.
But builddir does not seem to be available, and srcdir is the wrong
place to find the built convenience lib.
Amos
--
Please be using
Current Stable Squid 2.7.STABLE6 or 3.0.STABLE16
Current Beta Squid 3.1.0.9
Re: disable-loadable-modules
On Thu, 2009-07-09 at 20:22 +1200, Amos Jeffries wrote: > Robert Collins wrote: > > On Thu, 2009-07-09 at 19:40 +1200, Amos Jeffries wrote: > > > >> ... > >> checking whether to use loadable modules... yes, implicitly > > > > Is the test for whether to use them broken? > > > > The code is to always enables them by default unless forced not to. > > Everything would work just fine if libtool would only add the > $(builddir) to the path its trying to locate locally built things on. It will if its been told that its using local libraries. I suspect we're misusing something in libtool/automake to generate these symptoms. -Rob signature.asc Description: This is a digitally signed message part
Re: disable-loadable-modules
On 07/09/2009 01:40 AM, Amos Jeffries wrote:
> Amos Jeffries wrote:
>> Well, I've found a possible reason to disable them by default.
>>
>> The Debian Lenny/Ubuntu Jaunty libtool 2.2 appears broken with its
>> handling of the libtool convenience library. Giving build failures
>> unless they are configured to off.
>>
>> Since I made the change to testbed "distcheck" I've been fighting with
>> them. Something inside distcheck seems to be running configure with
>> the defaults regardless of what the master test is run with. Probably
>> the dist "configure --silent" packaging or a sub-test of the package
>> it makes.
>>
>> If anyone is able to help I'd be very grateful. If we can't find a
>> solution to that one I think we are going to have to disable loadable
>> modules unless adaptation needs them.
>>
>> Amos
>
> Confirmed:
>
> c_install_base=`CDPATH="${ZSH_VERSION+.}:" && cd squid-3.HEAD-BZR/_inst
> && pwd | sed -e 's,^[^:\\/]:[\\/],/,'` \
> && dc_destdir="${TMPDIR-/tmp}/am-dc-$$/" \
> && cd squid-3.HEAD-BZR/_build \
> && ../configure --srcdir=.. --prefix="$dc_install_base" \
> \
> && make \
> && make dvi \
> && make check \
> && make install \
> && make installcheck \
> && make uninstall \
> ...
> && make dist \
> && rm -rf squid-3.HEAD-BZR.tar.gz squid-3.HEAD-BZR.tar.bz2 \
> && make distcleancheck
> checking for a BSD-compatible install... /usr/bin/install -c
> checking whether build environment is sane... yes
> ...
> checking whether to use loadable modules... yes, implicitly
Will setting DISTCHECK_CONFIGURE_FLAGS in top Makefile.am help with this?
Alex.
Re: disable-loadable-modules
Robert Collins wrote: On Thu, 2009-07-09 at 19:40 +1200, Amos Jeffries wrote: ... checking whether to use loadable modules... yes, implicitly Is the test for whether to use them broken? The code is to always enables them by default unless forced not to. Everything would work just fine if libtool would only add the $(builddir) to the path its trying to locate locally built things on. As it is we either have to add a hack to detect the broken OS and disable. Or shuffle the adaptation stuff around and default disable if its not actually needed. Amos -- Please be using Current Stable Squid 2.7.STABLE6 or 3.0.STABLE16 Current Beta Squid 3.1.0.9
Re: disable-loadable-modules
On Thu, 2009-07-09 at 19:40 +1200, Amos Jeffries wrote: > ... > checking whether to use loadable modules... yes, implicitly Is the test for whether to use them broken? -Rob signature.asc Description: This is a digitally signed message part
Re: disable-loadable-modules
Amos Jeffries wrote:
Well, I've found a possible reason to disable them by default.
The Debian Lenny/Ubuntu Jaunty libtool 2.2 appears broken with its
handling of the libtool convenience library. Giving build failures
unless they are configured to off.
Since I made the change to testbed "distcheck" I've been fighting with
them. Something inside distcheck seems to be running configure with the
defaults regardless of what the master test is run with. Probably the
dist "configure --silent" packaging or a sub-test of the package it makes.
If anyone is able to help I'd be very grateful. If we can't find a
solution to that one I think we are going to have to disable loadable
modules unless adaptation needs them.
Amos
Confirmed:
c_install_base=`CDPATH="${ZSH_VERSION+.}:" && cd squid-3.HEAD-BZR/_inst
&& pwd | sed -e 's,^[^:\\/]:[\\/],/,'` \
&& dc_destdir="${TMPDIR-/tmp}/am-dc-$$/" \
&& cd squid-3.HEAD-BZR/_build \
&& ../configure --srcdir=.. --prefix="$dc_install_base" \
\
&& make \
&& make dvi \
&& make check \
&& make install \
&& make installcheck \
&& make uninstall \
...
&& make dist \
&& rm -rf squid-3.HEAD-BZR.tar.gz squid-3.HEAD-BZR.tar.bz2 \
&& make distcleancheck
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
...
checking whether to use loadable modules... yes, implicitly
Fubar.
Amos
disable-loadable-modules
Well, I've found a possible reason to disable them by default. The Debian Lenny/Ubuntu Jaunty libtool 2.2 appears broken with its handling of the libtool convenience library. Giving build failures unless they are configured to off. Since I made the change to testbed "distcheck" I've been fighting with them. Something inside distcheck seems to be running configure with the defaults regardless of what the master test is run with. Probably the dist "configure --silent" packaging or a sub-test of the package it makes. If anyone is able to help I'd be very grateful. If we can't find a solution to that one I think we are going to have to disable loadable modules unless adaptation needs them. Amos -- Please be using Current Stable Squid 2.7.STABLE6 or 3.0.STABLE16 Current Beta Squid 3.1.0.9
