Re: [sr-dev] [kamailio/kamailio] jansson: can't extract values from string-only json array (#1171)

2017-06-28 Thread Sebastian Damm
Argh! I looked at it a couple times, and didn't see it. When calling the 
correct variable name, it works. Doesn't explain my real life problems, but I 
guess it's not a bug.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1171#issuecomment-311876463___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] jansson: can't extract values from string-only json array (#1171)

2017-06-28 Thread Sebastian Damm
Closed #1171.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1171#event-1143628073___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] radius : Fixes use of freeradiusclient library (#1170)

2017-06-28 Thread Daniel-Constantin Mierla
Something has to been done wrong in your system. I tried and works as expected 
here. Also debian and rpm packaging are using same mechanism and the packages 
build fine.

Are you sure you don't have other changes done there or something else setting 
FREERADIUS to 0?

Try to add FREERADIUS=1 to src/Makefile.radius and see if goes ok.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1170#issuecomment-311876298___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] radius : Fixes use of freeradiusclient library (#1170)

2017-06-28 Thread Yasin CANER
Hello @miconda ,
I am sorry for my english isnt enough for explain it.
if i set "export FREERADIUS=1" Makefile.radius selecting "freeradius-client.h" 
but radius.h selects radiusclient-ng.h .
if i dont set FREERADIUS Makefile.radius  selects "radiusclient-ng.h" but 
radius.h selects ""freeradius-client.h"
Here is results,

`
 export FREERADIUS=1
 make all
make -C src/ all
make[1]: Entering directory `/usr/src/kamailio-5.0.2/src'
make[3]: `libsrdb2.so.1.0' is up to date.
make[3]: `libsrdb1.so.1.0' is up to date.
CC (gcc) [M acc_radius.so]  acc_radius_mod.o
In file included from acc_radius_mod.c:44:
../misc_radius/radius.h:43:30: warning: radiusclient-ng.h: No such file or 
directory
acc_radius_mod.c: In function ‘init_acc_rad’:

`
`
 make clean
make -C src/ clean
make[1]: Entering directory `/usr/src/kamailio-5.0.2/src'
make[2]: *** No rule to make target `clean'.  Stop.
make --no-print-directory -C lib clean
Making clean in binrpc
Making clean in cds
Making clean in ims
Making clean in presence
Making clean in print
Making clean in shm_regex
Making clean in srdb1
Making clean in srdb2
Making clean in srutils
Making clean in trie
Making clean in xcap
make[1]: Leaving directory `/usr/src/kamailio-5.0.2/src'
make include_modules="db_mysql acc_radius auth_radius misc_radius carrierroute 
utils " cfg
make -C src/ cfg
target architecture , host architecture 
make[1]: Entering directory `/usr/src/kamailio-5.0.2/src'
making config...
rm -f modules.lst
make --no-print-directory modules.lst
saving modules list...
make[1]: Leaving directory `/usr/src/kamailio-5.0.2/src'
make all
make -C src/ all
make[1]: Entering directory `/usr/src/kamailio-5.0.2/src'
CC (gcc) [kamailio] main.o

LD (gcc) [M db_mysql.so]db_mysql.so
CC (gcc) [M acc_radius.so]  acc_radius_mod.o
In file included from acc_radius_mod.c:44:
../misc_radius/radius.h:43:30: warning: radiusclient-ng.h: No such file or 
directory
acc_radius_mod.c: In function ‘init_acc_rad’:

`



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1170#issuecomment-311873404___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] Kamailio 5.0.2 suddenly stops processing traffic, then generates a core when restarting. (#1172)

2017-06-28 Thread Daniel-Constantin Mierla
The segfault happens at shutdown, which should be avoided if possible, but it 
is not relevant for what happens at runtime.

>From the log messages, it seems that you use dispatcher (or some other routing 
>module) and there is no active gateway where the sip request should be sent.

What you have seen in the packet capture? Are the SIP requests replied? Or no 
response from Kamailio?

Do you have any monitoring tool that may stop kamailio? The signal 15 (TERM) is 
the usual way to stop an application.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1172#issuecomment-311872602___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] jansson: can't extract values from string-only json array (#1171)

2017-06-28 Thread Daniel-Constantin Mierla
Is this a typo in your config or in the pasted example here? Because you set 
`$var(myStringList)` and then you use `$var(myStrList)`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1171#issuecomment-311871922___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] radius : Fixes use of freeradiusclient library (#1170)

2017-06-28 Thread Daniel-Constantin Mierla
The default is to use radiusclient-ng library. To use freeradius-client, then 
you have to set FREERADIUS=1 in the make command. Am I missing something? Have 
you set FREERADIUS=1 and doesn't work?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1170#issuecomment-311871434___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] radius : Fixes use of freeradiusclient library (#1170)

2017-06-28 Thread Yasin CANER
Hello @miconda ,
there is conflict with Makefile.radius .  this file selects freeradiusclient 
without settting freeradius, but makefile.radius needs to FREERADIUS  for using 
freeradiusclient.h . so compiling couldnt find .h file, gives error.
Could you check it again , please.

ERROR :
 `In file included from acc_radius_mod.c:44:
../misc_radius/radius.h:38:31: warning: radiusclient-ng.h: No such file or 
directory
`

Thanks.

`
INCLUDES+=-I$(LOCALBASE)/include

ifeq ($(FREERADIUS),1)

# - freeradius-client library
DEFS+= -DUSE_FREERADIUS
RADIUSCLIENT_LIB=freeradius-client

else
ifeq ($(RADCLI),1)

# - radcli library
DEFS+= -DUSE_RADCLI
RADIUSCLIENT_LIB=radcli

else
# - radiusclient-ng v5 or v4 library
ifneq ($(radiusclient_ng), 4)

# radiusclient-ng 5+
# DEFS+=-DRADIUSCLIENT_NG_5P
RADIUSCLIENT_LIB=radiusclient-ng

else

DEFS+=-DRADIUSCLIENT_NG_4
RADIUSCLIENT_LIB=radiusclient

endif
endif

endif

LIBS=-L$(LOCALBASE)/lib -l$(RADIUSCLIENT_LIB)
`


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1170#issuecomment-311870676___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] Kamailio 5.0.2 suddenly stops processing traffic, then generates a core when restarting. (#1172)

2017-06-28 Thread Joel Serrano
The same problem occurred on the second SBC, I have the packet capture from 
that moment. Please let me know what information you need. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1172#issuecomment-311835421___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] kamctl: added DBPORT option (18e3327)

2017-06-28 Thread Joseph F. Berghof III
When DBENGINE=PGSQL and  DBPORT is set in kamctlrc the DBHOST is used instead 
of DBPORT (typo in utils/kamctl/kamdbctl.pgsql lines 58-59) when issuing the 
'psql' command.  This introduces a bug that appears to be fixed in the master 
branch.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/commit/18e3327bedc1647a5abe0d377b15b74b2e860ef4#commitcomment-22818952___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] Kamailio 5.0.2 suddenly stops processing traffic, then generates a core when restarting. (#1172)

2017-06-28 Thread Joel Serrano
I'm wondering, is this a kamailio issue or a debian stretch libssl1.1 issue?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1172#issuecomment-311788848___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] Kamailio 5.0.2 suddenly stops processing traffic, then generates a core when restarting. (#1172)

2017-06-28 Thread Joel Serrano
I'm now capturing traffic in case it happens again.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1172#issuecomment-311779093___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] radius : Fixes use of freeradiusclient library (#1170)

2017-06-28 Thread Daniel-Constantin Mierla
If I got it right, you interchanged the freeradius client with radiusclient-ng, 
but the condition at the top is negated, respectively `#ifndef USE_FREERADIUS`. 
With the patch it seems that when USE_FREERADIUS is defined, the 
radiusclient-ng is going to be used -- that's not right.

Have you encountered any issue and this patch is fixing it?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1170#issuecomment-311711541___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] resolve an issue found by cppcheck (#1169)

2017-06-28 Thread Victor Seva
Thanks for your contribution

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1169#issuecomment-311707059___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] resolve an issue found by cppcheck (#1169)

2017-06-28 Thread Daniel-Constantin Mierla
The wiki page was there before github added the options for templates and many 
still refer to it being used to that.

I expected that github points to CONTRIBUTING.md when a pull request is 
created, as I don't do PRs, but commit directly, so I couldn't check myself.

Anyhow, I just pushed a pull request template to make it more visible.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1169#issuecomment-311700783___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] resolve an issue found by cppcheck (#1169)

2017-06-28 Thread Ilya Shipitsin
@miconda  - yes, I noticed .github subfolder a bit later. I was somewhat 
surprized "why do they point me to contribution guide in such weird way", I was 
ok to see contribution guide during PR process (and I meant that exactly)

sorry for that.

thank you for pushing the patch anyway

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1169#issuecomment-311698005___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


[sr-dev] git:master:5e8f84e9: .github: added pull request template

2017-06-28 Thread Daniel-Constantin Mierla
Module: kamailio
Branch: master
Commit: 5e8f84e9c7d3ef792ea8b0520087ae3e933fda39
URL: 
https://github.com/kamailio/kamailio/commit/5e8f84e9c7d3ef792ea8b0520087ae3e933fda39

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2017-06-28T17:22:34+02:00

.github: added pull request template

---

Added: .github/PULL_REQUEST_TEMPLATE.md

---

Diff:  
https://github.com/kamailio/kamailio/commit/5e8f84e9c7d3ef792ea8b0520087ae3e933fda39.diff
Patch: 
https://github.com/kamailio/kamailio/commit/5e8f84e9c7d3ef792ea8b0520087ae3e933fda39.patch

---

diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
new file mode 100644
index 00..2ce2261892
--- /dev/null
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -0,0 +1,37 @@
+
+
+
+
+ Pre-Submission Checklist
+
+
+
+- [ ] Commit message has the format required by CONTRIBUTING guide
+- [ ] Commits are split per component (core, individual modules, libs, utils, 
...)
+- [ ] Each component has a single commit (if not, squash them into one commit)
+- [ ] No commits to README files for modules (changes must be done to docbook 
files
+in `doc/` subfolder, the README file is autogenerated)
+
+ Type Of Change
+- [ ] Small bug fix (non-breaking change which fixes an issue)
+- [ ] New feature (non-breaking change which adds new functionality)
+- [ ] Breaking change (fix or feature that would change existing functionality)
+
+ Checklist:
+
+- [ ] PR should be backported to stable branches
+- [ ] Tested changes locally
+- [ ] Related to issue # (replace  with an open issue number)
+
+ Description
+


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] resolve an issue found by cppcheck (#1169)

2017-06-28 Thread Daniel-Constantin Mierla
@chipitsine - if you have read the block post you pointed above, you would see 
the reference to .github/ subfolder, and CONTRIBUTING.md file is already there, 
with section for commit message:

  * 
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md#commit-message-format

I will push the patch manually.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1169#issuecomment-311681684___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] resolve an issue found by cppcheck (#1169)

2017-06-28 Thread Daniel-Constantin Mierla
Closed #1169.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1169#event-1142504734___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


[sr-dev] [kamailio/kamailio] Kamailio 5.0.2 suddenly stops processing traffic, then generates a core when restarting. (#1172)

2017-06-28 Thread Joel Serrano
### Description

Kamailio suddenly stops working (this is a production server so debug logging 
is disabled), when we restart it a core is generated and a segfault is logged.

### Troubleshooting

The only thing I have seen is some reference to IPv6 in the backtrace. But no 
idea where to start looking. I'm pretty sure we will need more information, but 
I don't know how to read or understand backtraces, please let me know what you 
see in it so I can dig deeper into this problem.

 Reproduction

I don't know how to reproduce yet, first I have to understand the cause.

 Debugging Data

Backtrace:
```
[New LWP 12052]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/usr/sbin/kamailio -P /var/run/kamailio/kamailio.pid -f 
/etc/kamailio/sbc.cfg -'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x7efcf3b5df69 in ?? () from /usr/lib/x86_64-linux-gnu/libcrypto.so.1.1
#0  0x7efcf3b5df69 in ?? () from /usr/lib/x86_64-linux-gnu/libcrypto.so.1.1
No symbol table info available.
#1  0x7efcf3b5e234 in OPENSSL_cleanup () from 
/usr/lib/x86_64-linux-gnu/libcrypto.so.1.1
No symbol table info available.
#2  0x7efcf7721910 in __run_exit_handlers (status=0, listp=0x7efcf7a855d8 
<__exit_funcs>, run_list_atexit=run_list_atexit@entry=true, 
run_dtors=run_dtors@entry=true) at exit.c:83
atfct = 
onfct = 
cxafct = 
f = 
#3  0x7efcf772196a in __GI_exit (status=) at exit.c:105
No locals.
#4  0x55f0a9483d54 in handle_sigs () at main.c:699
chld = 845005216
chld_status = 845005248
any_chld_stopped = 32766
memlog = 0
__func__ = "handle_sigs"
#5  0x55f0a948ea43 in main_loop () at main.c:1758
i = 8
pid = 12091
si = 0x0
si_desc = "udp receiver child=7 
sock=[2602:FF37:0:1:0:0:C601:377A]:5060\000\367v\215\200\262+\363\372~\000\000\025\067\236\003\000\000\000\000\300\017H\251\360U\000\000\340\305]2\376\177",
 '\000' , "\020\303]2\376\177\000\000a\202g\251\360U\000"
nrprocs = 8
woneinit = 1
__func__ = "main_loop"
#6  0x55f0a9494fb9 in main (argc=13, argv=0x7ffe325dc5e8) at main.c:2646
cfg_stream = 0x55f0aa7fb010
c = -1
r = 0
tmp = 0x7ffe325dceb6 ""
tmp_len = -133383536
port = 32508
proto = 845006016
options = 0x55f0a97d80e8 
":f:cm:M:dVIhEeb:l:L:n:vKrRDTN:W:w:t:u:g:P:G:SQ:O:a:A:x:X:Y:"
ret = -1
seed = 3679304743
rfd = 4
debug_save = 0
debug_flag = 0
dont_fork_cnt = 0
n_lst = 0x0
p = 0x 
st = {st_dev = 19, st_ino = 14769, st_nlink = 2, st_mode = 16832, 
st_uid = 109, st_gid = 113, __pad0 = 0, st_rdev = 0, st_size = 40, st_blksize = 
4096, st_blocks = 0, st_atim = {tv_sec = 1498523393, tv_nsec = 731915583}, 
st_mtim = {tv_sec = 1498533865, tv_nsec = 274210743}, st_ctim = {tv_sec = 
1498533865, tv_nsec = 274210743}, __glibc_reserved = {0, 0, 0}}
__func__ = "main"
```

Info locals:
```
[New LWP 12052]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/usr/sbin/kamailio -P /var/run/kamailio/kamailio.pid -f 
/etc/kamailio/sbc.cfg -'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x7efcf3b5df69 in ?? () from /usr/lib/x86_64-linux-gnu/libcrypto.so.1.1
No symbol table info available.
```

List:
```
[New LWP 12052]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/usr/sbin/kamailio -P /var/run/kamailio/kamailio.pid -f 
/etc/kamailio/sbc.cfg -'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x7efcf3b5df69 in ?? () from /usr/lib/x86_64-linux-gnu/libcrypto.so.1.1
```

 Log Messages

We have regular logging with no issues, then suddenly we get:

```
Jun 28 01:57:51 kam-1 sbc[12075]: WARNING: 

[sr-dev] git:master:bbe03709: utils/db_berkeley: access variable after null pointer check

2017-06-28 Thread Daniel-Constantin Mierla
Module: kamailio
Branch: master
Commit: bbe0370939ff8a14e931595389b6678817ff1056
URL: 
https://github.com/kamailio/kamailio/commit/bbe0370939ff8a14e931595389b6678817ff1056

Author: Ilya Shipitsin 
Committer: Daniel-Constantin Mierla 
Date: 2017-06-28T16:45:54+02:00

utils/db_berkeley: access variable after null pointer check

---

Modified: utils/db_berkeley/kambdb_recover.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/bbe0370939ff8a14e931595389b6678817ff1056.diff
Patch: 
https://github.com/kamailio/kamailio/commit/bbe0370939ff8a14e931595389b6678817ff1056.patch

---

diff --git a/utils/db_berkeley/kambdb_recover.c 
b/utils/db_berkeley/kambdb_recover.c
index 891cf2cfdc..30733a01ff 100644
--- a/utils/db_berkeley/kambdb_recover.c
+++ b/utils/db_berkeley/kambdb_recover.c
@@ -336,14 +336,14 @@ int recover(char* jfn)
return 2;
}

-   tp  = tbc->dtp;
-   
-   if(!tbc || !tp)
+   if(!tbc || !tbc->dtp)
{
fprintf(stderr, "[recover]: FAILED to get find metadata for : 
%s.\n", tn);
fclose(fp);
return 3;
}
+
+   tp  = tbc->dtp;

while ( fgets(line , MAX_ROW_SIZE, fp) != NULL )
{


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] Segfault when calling $sel(cfg_get...) (#1159)

2017-06-28 Thread Sebastian Damm
Adding `desc` does not change anything.

```config.foo = "hello Daniel" desc "foo config var"```

And I at first stumbled upon it when using `sipgate.foo` variables. Just tried 
again with

```wurst.wasser = "mic check 123" desc "bla"```

and it immediately crashed again when trying to access the value.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1159#issuecomment-311670440___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


[sr-dev] [kamailio/kamailio] jansson: can't extract values from string-only json array (#1171)

2017-06-28 Thread Sebastian Damm
### Description

I have a json string stored in a variable, and I want to iterate over the 
values in it. This works if there are integer values in the json string. But if 
it consists only of string values, jansson_get throws an error.

According to jsonlint, all my json strings are valid.

### Troubleshooting

 Reproduction

This is the part of kamailio.cfg leading to the error:

```
# Integer json array
$var(myIntList) = '[2,3,4,5]';
xlog("L_INFO", "Integer json string is  $var(myIntList) ");
jansson_get('[0]', $var(myIntList), "$var(intValue)");
xlog("L_INFO", "First Int Element: >> $var(intValue) <<");
jansson_get('[1]', $var(myIntList), "$var(intValue)");
xlog("L_INFO", "Second Int Element: >> $var(intValue) <<");
# String json array
$var(myStringList) = '["foo", "bar", "baz"]';
xlog("L_INFO", "String json string is  $var(myStringList) ");
jansson_get('[0]', $var(myStrList), "$var(strValue)");
xlog("L_INFO", "First Str Element: >> $var(strValue) <<");
jansson_get('[1]', $var(myStrList), "$var(strValue)");
xlog("L_INFO", "Second Str Element: >> $var(strValue) <<");
# Mixed json array
$var(myMixedList) = '[2, "bar"]';
xlog("L_INFO", "Mixed json string (int first) is  $var(myMixedList) 
");
jansson_get('[0]', $var(myMixedList), "$var(mixedValue)");
xlog("L_INFO", "First Mixed Element: >> $var(mixedValue) <<");
jansson_get('[1]', $var(myMixedList), "$var(mixedValue)");
xlog("L_INFO", "Second Mixed Element: >> $var(mixedValue) <<");
$var(myMixedList) = '["bar", 2]';
xlog("L_INFO", "Mixed json string (string first) is  
$var(myMixedList) ");
jansson_get('[0]', $var(myMixedList), "$var(mixedValue)");
xlog("L_INFO", "First Mixed Element: >> $var(mixedValue) <<");
jansson_get('[1]', $var(myMixedList), "$var(mixedValue)");
xlog("L_INFO", "Second Mixed Element: >> $var(mixedValue) <<");
```

 Log Messages

This is the output generated by the above kamailio.cfg snippet.

```
Jun 28 15:31:12 busch /usr/sbin/kamailio[29961]: INFO: 

Re: [sr-dev] [kamailio/kamailio] radius : Fixes use of freeradiusclient library (#1170)

2017-06-28 Thread Yasin CANER
Hello, Because there is confict between Makefile.radius . Makefile.radius need 
to setting freeradius value to use.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1170#issuecomment-311647153___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] radius : Fixes use of freeradiusclient library (#1170)

2017-06-28 Thread Olle E. Johansson
You are dropping backwards portability. Any particular reason for that?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1170#issuecomment-311644670___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


[sr-dev] Developing charging module for kamailio-ims

2017-06-28 Thread Prasannakumar Merugu
Hi all,

We are developing charging module for kamailio-ims.
We need events
event_route[dialog:start]
event_route[dialog:end]
for detecting call begin and call end.

We have to use ims_dialog module for IMS implementation. But observed that
ims_dialog module
doesnt have the above said events [dialog:start and end].

How do we implement those events using ims_dialog. Is there any other way
out.

Kindly suggest.

Thanks,
Prasannakumar Merugu.
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] radius : Fixes use of freeradiusclient library (#1170)

2017-06-28 Thread Yasin CANER
i hope my commit message is enough for explanation

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1170#issuecomment-311641408___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


[sr-dev] [kamailio/kamailio] radius : Fixes use of freeradiusclient library (#1170)

2017-06-28 Thread Yasin CANER
Fixes use of freeradiusclient library for radius modules. Setting right path.
You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/1170

-- Commit Summary --

  * radius : Fixes freeradiusclient library

-- File Changes --

M src/modules/misc_radius/radius.h (11)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/1170.patch
https://github.com/kamailio/kamailio/pull/1170.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1170
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] resolve an issue found by cppcheck (#1169)

2017-06-28 Thread Ilya Shipitsin
Please read https://github.com/blog/2111-issue-and-pull-request-templates

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1169#issuecomment-311633625___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] resolve an issue found by cppcheck (#1169)

2017-06-28 Thread Victor Seva
Please read 
https://www.kamailio.org/wiki/devel/git-commit-guidelines#commit_message

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1169#issuecomment-311631303___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


[sr-dev] [kamailio/kamailio] resolve an issue found by cppcheck (#1169)

2017-06-28 Thread Ilya Shipitsin
[utils/db_berkeley/kambdb_recover.c:339] -> 
[utils/db_berkeley/kambdb_recover.c:341]: (warning) Either the condition '!tbc' 
is redundant or there is possible null pointer dereference: tbc.
You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/1169

-- Commit Summary --

  * resolve an issue found by cppcheck:

-- File Changes --

M utils/db_berkeley/kambdb_recover.c (6)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/1169.patch
https://github.com/kamailio/kamailio/pull/1169.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1169
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


[sr-dev] git:5.0:d5d15e6c: kazoo: add $kzRK to accdess routing key of the payload

2017-06-28 Thread Luis Azedo
Module: kamailio
Branch: 5.0
Commit: d5d15e6c9f67e5a64bb5c3ec6926b39dc8e3b779
URL: 
https://github.com/kamailio/kamailio/commit/d5d15e6c9f67e5a64bb5c3ec6926b39dc8e3b779

Author: lazedo 
Committer: Luis Azedo 
Date: 2017-06-28T12:11:20+01:00

kazoo: add $kzRK to accdess routing key of the payload

(cherry picked from commit d5c602454a9af6ebce852f44dc88c4efa4bf036f)

---

Modified: src/modules/kazoo/kazoo.c
Modified: src/modules/kazoo/kz_amqp.c
Modified: src/modules/kazoo/kz_amqp.h

---

Diff:  
https://github.com/kamailio/kamailio/commit/d5d15e6c9f67e5a64bb5c3ec6926b39dc8e3b779.diff
Patch: 
https://github.com/kamailio/kamailio/commit/d5d15e6c9f67e5a64bb5c3ec6926b39dc8e3b779.patch


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


[sr-dev] git:5.0:2ccf97c2: kazoo: add json.count transformation

2017-06-28 Thread Luis Azedo
Module: kamailio
Branch: 5.0
Commit: 2ccf97c2932dcd5242f7997c3230427dfe6b4417
URL: 
https://github.com/kamailio/kamailio/commit/2ccf97c2932dcd5242f7997c3230427dfe6b4417

Author: lazedo 
Committer: Luis Azedo 
Date: 2017-06-28T12:11:42+01:00

kazoo: add json.count transformation

(cherry picked from commit 551413f0952429c3a360b5ccdeaeac48ea15ff8a)

---

Modified: src/modules/kazoo/kz_json.c
Modified: src/modules/kazoo/kz_json.h
Modified: src/modules/kazoo/kz_trans.c
Modified: src/modules/kazoo/kz_trans.h

---

Diff:  
https://github.com/kamailio/kamailio/commit/2ccf97c2932dcd5242f7997c3230427dfe6b4417.diff
Patch: 
https://github.com/kamailio/kamailio/commit/2ccf97c2932dcd5242f7997c3230427dfe6b4417.patch


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


[sr-dev] git:5.0:e3f69bf1: kazoo: max size of routing key

2017-06-28 Thread Luis Azedo
Module: kamailio
Branch: 5.0
Commit: e3f69bf10c09c9817d3839bc58e2f17f8dbeaded
URL: 
https://github.com/kamailio/kamailio/commit/e3f69bf10c09c9817d3839bc58e2f17f8dbeaded

Author: lazedo 
Committer: Luis Azedo 
Date: 2017-06-28T12:10:33+01:00

kazoo: max size of routing key

(cherry picked from commit 56e07cf2bb281d0aa78517e919055de640468020)

---

Modified: src/modules/kazoo/kazoo.c
Modified: src/modules/kazoo/kz_amqp.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/e3f69bf10c09c9817d3839bc58e2f17f8dbeaded.diff
Patch: 
https://github.com/kamailio/kamailio/commit/e3f69bf10c09c9817d3839bc58e2f17f8dbeaded.patch


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


[sr-dev] git:5.0:3c6e9e02: kazoo: use hardcoded max size of routing key

2017-06-28 Thread Luis Azedo
Module: kamailio
Branch: 5.0
Commit: 3c6e9e02d124ceb1227c8481042ac221ff79bd8d
URL: 
https://github.com/kamailio/kamailio/commit/3c6e9e02d124ceb1227c8481042ac221ff79bd8d

Author: lazedo 
Committer: Luis Azedo 
Date: 2017-06-28T12:10:52+01:00

kazoo: use hardcoded max size of routing key
(cherry picked from commit f18da4c9d6cc8d1ab061d68cbd8e9d988ebf2be6)

---

Modified: src/modules/kazoo/defs.h
Modified: src/modules/kazoo/kazoo.c
Modified: src/modules/kazoo/kz_amqp.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/3c6e9e02d124ceb1227c8481042ac221ff79bd8d.diff
Patch: 
https://github.com/kamailio/kamailio/commit/3c6e9e02d124ceb1227c8481042ac221ff79bd8d.patch


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] tls compiler warnings (#1075)

2017-06-28 Thread Daniel-Constantin Mierla
The patches e7c03ce6ce61119fbf5cb9f41b7abcd4c7138d58 and 
76efc9b7a1489007f9ff431e730ce4e86b446a6c should fix this warnings specific for 
libssl 1.1.0 (or newer).

Testing and feedback will be appreciated, specially to see if the requests tls 
version (or range) is working file.

If issues are found, open a new bug report.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1075#issuecomment-311611409___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] tls compiler warnings (#1075)

2017-06-28 Thread Daniel-Constantin Mierla
Closed #1075.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1075#event-1142039907___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


[sr-dev] git:master:76efc9b7: tls: updated tls version selection for libssl 1.1.0 api

2017-06-28 Thread Daniel-Constantin Mierla
Module: kamailio
Branch: master
Commit: 76efc9b7a1489007f9ff431e730ce4e86b446a6c
URL: 
https://github.com/kamailio/kamailio/commit/76efc9b7a1489007f9ff431e730ce4e86b446a6c

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2017-06-28T11:41:15+02:00

tls: updated tls version selection for libssl 1.1.0 api

- fixes compile warnings for deprecated TLSXY_method() functions

---

Modified: src/modules/tls/tls_domain.c
Modified: src/modules/tls/tls_domain.h
Modified: src/modules/tls/tls_init.c
Modified: src/modules/tls/tls_init.h

---

Diff:  
https://github.com/kamailio/kamailio/commit/76efc9b7a1489007f9ff431e730ce4e86b446a6c.diff
Patch: 
https://github.com/kamailio/kamailio/commit/76efc9b7a1489007f9ff431e730ce4e86b446a6c.patch


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


[sr-dev] git:master:e7c03ce6: tls: dynamic locks not needed for openssl v1.1.0+

2017-06-28 Thread Daniel-Constantin Mierla
Module: kamailio
Branch: master
Commit: e7c03ce6ce61119fbf5cb9f41b7abcd4c7138d58
URL: 
https://github.com/kamailio/kamailio/commit/e7c03ce6ce61119fbf5cb9f41b7abcd4c7138d58

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2017-06-28T10:26:43+02:00

tls: dynamic locks not needed for openssl v1.1.0+

- openssl v1.1.0 is thread safe
- fixes the compile warnings for libssl 1.1.0

---

Modified: src/modules/tls/tls_locking.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/e7c03ce6ce61119fbf5cb9f41b7abcd4c7138d58.diff
Patch: 
https://github.com/kamailio/kamailio/commit/e7c03ce6ce61119fbf5cb9f41b7abcd4c7138d58.patch

---

diff --git a/src/modules/tls/tls_locking.c b/src/modules/tls/tls_locking.c
index 9d8e8acec5..38c028fd2f 100644
--- a/src/modules/tls/tls_locking.c
+++ b/src/modules/tls/tls_locking.c
@@ -32,6 +32,9 @@
 static int n_static_locks=0;
 static gen_lock_set_t* static_locks=0;
 
+/* OpenSSL is thread-safe since 1.1.0 */
+#if OPENSSL_VERSION_NUMBER < 0x1010L
+
 /* "dynamic" locks */
 
 struct CRYPTO_dynlock_value{
@@ -61,7 +64,6 @@ static struct CRYPTO_dynlock_value* dyn_create_f(const char* 
file, int line)
 }
 
 
-
 static void dyn_lock_f(int mode, struct CRYPTO_dynlock_value* l,
const char* file, int line)
 {
@@ -116,6 +118,7 @@ static void locking_f(int mode, int n, const char* file, 
int line)
}
 }
 
+#endif /* openssl < 0x1010L (1.1.0) */
 
 
 void tls_destroy_locks()
@@ -163,10 +166,14 @@ int tls_init_locks()
}
CRYPTO_set_locking_callback(locking_f);
}
+
+/* OpenSSL is thread-safe since 1.1.0 */
+#if OPENSSL_VERSION_NUMBER < 0x1010L
/* set "dynamic" locks callbacks */
CRYPTO_set_dynlock_create_callback(dyn_create_f);
CRYPTO_set_dynlock_lock_callback(dyn_lock_f);
CRYPTO_set_dynlock_destroy_callback(dyn_destroy_f);
+#endif
 
/* starting with v1.0.0 openssl does not use anymore getpid(), but 
address
 * of errno which can point to same virtual address in a multi-process


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev