[sr-dev] Development for Kamailio v5.1 series is frozen
Hello, short note to mark the freezing of development for Kamailio v5.1 series. For few weeks, please do not push new features in the master branch. Once the branch 5.1 is created (expected to happen in 3-4 weeks from now), the master branch becomes again open for new feature. Meanwhile the focus has to be on testing current code. Work on related tools (e.g., kamctl) or documentation can still be done as well as getting the new modules in 5.1 in good shape, plus adding exports to kemi interface (which should not interfere with old code). The entire testing phase is expected to be 4 to 6 weeks, then the release of v5.1.0 -- likely by end of November should be out. Cheers, Daniel -- Daniel-Constantin Mierla www.twitter.com/miconda -- www.linkedin.com/in/miconda Kamailio Advanced Training, Nov 13-15, 2017, in Berlin - www.asipto.com Kamailio World Conference - www.kamailioworld.com ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] git:master:02074c81: Merge branch 'master' of github.com:kamailio/kamailio
Victor Seva writes: > git pull --rebase is the missing step there. I have set pull rebase in > ~/.gitconfig [0] > > [pull] > rebase = true > > so git pull --rebase is automatic for me Thanks, Juha ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] git:master:02074c81: Merge branch 'master' of github.com:kamailio/kamailio
2017-10-16 13:30 GMT+02:00 Juha Heinanen: > Victor Seva writes: > >> rebase before pushing > > This is what I did (taken from shell history): > > 2060 emacs sipdump_mod.c > 2061 git diff > 2062 git commit -a > 2063 git push > 2064 git pull > 2065 git push > > If I remember correctly, first git push failed with message asking to do > pull first, which I did and then pushed again. > > What would have been the correct command sequence provided that I didn't > remember to do 'git rebase'? git pull --rebase is the missing step there. I have set pull rebase in ~/.gitconfig [0] [pull] rebase = true so git pull --rebase is automatic for me [0] https://coderwall.com/p/tnoiug/rebase-by-default-when-doing-git-pull ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] git:master:02074c81: Merge branch 'master' of github.com:kamailio/kamailio
Victor Seva writes: > rebase before pushing This is what I did (taken from shell history): 2060 emacs sipdump_mod.c 2061 git diff 2062 git commit -a 2063 git push 2064 git pull 2065 git push If I remember correctly, first git push failed with message asking to do pull first, which I did and then pushed again. What would have been the correct command sequence provided that I didn't remember to do 'git rebase'? -- Juha ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] git:master:02074c81: Merge branch 'master' of github.com:kamailio/kamailio
2017-10-16 13:00 GMT+02:00 Juha Heinanen: > Victor Seva writes: > >> rebase before pushing > > Hard to remember. Is it possible to configure git so that it cancels > push if local repo is not up to date? See pull.rebase, branch..rebase and branch.autoSetupRebase in git-config[1] if you want to make git pull always use --rebase instead of merging. > And even if had remembered to rebase, there would still be a cap between > push during which a new commit could have occurred. Sound broken system > to me. You can't push in that case. I would say git is not broken ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] git:master:02074c81: Merge branch 'master' of github.com:kamailio/kamailio
Victor Seva writes: > rebase before pushing Hard to remember. Is it possible to configure git so that it cancels push if local repo is not up to date? And even if had remembered to rebase, there would still be a cap between push during which a new commit could have occurred. Sound broken system to me. -- Juha ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] git:master:02074c81: Merge branch 'master' of github.com:kamailio/kamailio
Please Juha, rebase before pushing 2017-10-16 11:42 GMT+02:00 Juha Heinanen: > Module: kamailio > Branch: master > Commit: 02074c81158b0927778e5f2daaae8da953580f2f > URL: > https://github.com/kamailio/kamailio/commit/02074c81158b0927778e5f2daaae8da953580f2f > > Author: Juha Heinanen > Committer: Juha Heinanen > Date: 2017-10-16T12:41:48+03:00 > > Merge branch 'master' of github.com:kamailio/kamailio > > --- > > Added: src/modules/phonenum/Makefile > Added: src/modules/phonenum/README > Added: src/modules/phonenum/cphonenumber.cpp > Added: src/modules/phonenum/cphonenumber.h > Added: src/modules/phonenum/doc/Makefile > Added: src/modules/phonenum/doc/phonenum.xml > Added: src/modules/phonenum/doc/phonenum_admin.xml > Added: src/modules/phonenum/phonenum_mod.c > Added: src/modules/phonenum/phonenum_pv.c > Added: src/modules/phonenum/phonenum_pv.h > Modified: src/Makefile.defs > Modified: src/Makefile.groups > Modified: src/modules/sipdump/sipdump_mod.c > Modified: src/modules/sipdump/sipdump_write.c > > --- > > Diff: > https://github.com/kamailio/kamailio/commit/02074c81158b0927778e5f2daaae8da953580f2f.diff > Patch: > https://github.com/kamailio/kamailio/commit/02074c81158b0927778e5f2daaae8da953580f2f.patch > > > ___ > Kamailio (SER) - Development Mailing List > sr-dev@lists.kamailio.org > https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
[sr-dev] git:master:9c064ff6: pkg/kamailio/deb: set version 5.1.0~dev8
Module: kamailio Branch: master Commit: 9c064ff672df7c3e65b4b2891899bfaa460469dd URL: https://github.com/kamailio/kamailio/commit/9c064ff672df7c3e65b4b2891899bfaa460469dd Author: Victor SevaCommitter: Victor Seva Date: 2017-10-16T12:11:13+02:00 pkg/kamailio/deb: set version 5.1.0~dev8 --- Modified: pkg/kamailio/deb/debian/changelog Modified: pkg/kamailio/deb/jessie/changelog Modified: pkg/kamailio/deb/precise/changelog Modified: pkg/kamailio/deb/sid/changelog Modified: pkg/kamailio/deb/stretch/changelog Modified: pkg/kamailio/deb/trusty/changelog Modified: pkg/kamailio/deb/wheezy/changelog Modified: pkg/kamailio/deb/xenial/changelog --- Diff: https://github.com/kamailio/kamailio/commit/9c064ff672df7c3e65b4b2891899bfaa460469dd.diff Patch: https://github.com/kamailio/kamailio/commit/9c064ff672df7c3e65b4b2891899bfaa460469dd.patch --- diff --git a/pkg/kamailio/deb/debian/changelog b/pkg/kamailio/deb/debian/changelog index 358ae895cc..c141ede2f5 100644 --- a/pkg/kamailio/deb/debian/changelog +++ b/pkg/kamailio/deb/debian/changelog @@ -1,3 +1,9 @@ +kamailio (5.1.0~dev8) unstable; urgency=medium + + * version set to 5.1.0~dev8 + + -- Victor Seva Mon, 16 Oct 2017 12:09:55 +0200 + kamailio (5.1.0~dev7) unstable; urgency=medium * version set to 5.1.0-dev7 diff --git a/pkg/kamailio/deb/jessie/changelog b/pkg/kamailio/deb/jessie/changelog index 358ae895cc..c141ede2f5 100644 --- a/pkg/kamailio/deb/jessie/changelog +++ b/pkg/kamailio/deb/jessie/changelog @@ -1,3 +1,9 @@ +kamailio (5.1.0~dev8) unstable; urgency=medium + + * version set to 5.1.0~dev8 + + -- Victor Seva Mon, 16 Oct 2017 12:09:55 +0200 + kamailio (5.1.0~dev7) unstable; urgency=medium * version set to 5.1.0-dev7 diff --git a/pkg/kamailio/deb/precise/changelog b/pkg/kamailio/deb/precise/changelog index 358ae895cc..c141ede2f5 100644 --- a/pkg/kamailio/deb/precise/changelog +++ b/pkg/kamailio/deb/precise/changelog @@ -1,3 +1,9 @@ +kamailio (5.1.0~dev8) unstable; urgency=medium + + * version set to 5.1.0~dev8 + + -- Victor Seva Mon, 16 Oct 2017 12:09:55 +0200 + kamailio (5.1.0~dev7) unstable; urgency=medium * version set to 5.1.0-dev7 diff --git a/pkg/kamailio/deb/sid/changelog b/pkg/kamailio/deb/sid/changelog index 358ae895cc..c141ede2f5 100644 --- a/pkg/kamailio/deb/sid/changelog +++ b/pkg/kamailio/deb/sid/changelog @@ -1,3 +1,9 @@ +kamailio (5.1.0~dev8) unstable; urgency=medium + + * version set to 5.1.0~dev8 + + -- Victor Seva Mon, 16 Oct 2017 12:09:55 +0200 + kamailio (5.1.0~dev7) unstable; urgency=medium * version set to 5.1.0-dev7 diff --git a/pkg/kamailio/deb/stretch/changelog b/pkg/kamailio/deb/stretch/changelog index 358ae895cc..c141ede2f5 100644 --- a/pkg/kamailio/deb/stretch/changelog +++ b/pkg/kamailio/deb/stretch/changelog @@ -1,3 +1,9 @@ +kamailio (5.1.0~dev8) unstable; urgency=medium + + * version set to 5.1.0~dev8 + + -- Victor Seva Mon, 16 Oct 2017 12:09:55 +0200 + kamailio (5.1.0~dev7) unstable; urgency=medium * version set to 5.1.0-dev7 diff --git a/pkg/kamailio/deb/trusty/changelog b/pkg/kamailio/deb/trusty/changelog index 358ae895cc..c141ede2f5 100644 --- a/pkg/kamailio/deb/trusty/changelog +++ b/pkg/kamailio/deb/trusty/changelog @@ -1,3 +1,9 @@ +kamailio (5.1.0~dev8) unstable; urgency=medium + + * version set to 5.1.0~dev8 + + -- Victor Seva Mon, 16 Oct 2017 12:09:55 +0200 + kamailio (5.1.0~dev7) unstable; urgency=medium * version set to 5.1.0-dev7 diff --git a/pkg/kamailio/deb/wheezy/changelog b/pkg/kamailio/deb/wheezy/changelog index 358ae895cc..c141ede2f5 100644 --- a/pkg/kamailio/deb/wheezy/changelog +++ b/pkg/kamailio/deb/wheezy/changelog @@ -1,3 +1,9 @@ +kamailio (5.1.0~dev8) unstable; urgency=medium + + * version set to 5.1.0~dev8 + + -- Victor Seva Mon, 16 Oct 2017 12:09:55 +0200 + kamailio (5.1.0~dev7) unstable; urgency=medium * version set to 5.1.0-dev7 diff --git a/pkg/kamailio/deb/xenial/changelog b/pkg/kamailio/deb/xenial/changelog index 358ae895cc..c141ede2f5 100644 --- a/pkg/kamailio/deb/xenial/changelog +++ b/pkg/kamailio/deb/xenial/changelog @@ -1,3 +1,9 @@ +kamailio (5.1.0~dev8) unstable; urgency=medium + + * version set to 5.1.0~dev8 + + -- Victor Seva Mon, 16 Oct 2017 12:09:55 +0200 + kamailio (5.1.0~dev7) unstable; urgency=medium * version set to 5.1.0-dev7 ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
[sr-dev] git:master:f8198900: modules: readme files regenerated - sipdump ... [skip ci]
Module: kamailio Branch: master Commit: f819890018e339ce416b9da51fb44bd719449228 URL: https://github.com/kamailio/kamailio/commit/f819890018e339ce416b9da51fb44bd719449228 Author: Kamailio DevCommitter: Kamailio Dev Date: 2017-10-16T11:46:21+02:00 modules: readme files regenerated - sipdump ... [skip ci] --- Modified: src/modules/sipdump/README --- Diff: https://github.com/kamailio/kamailio/commit/f819890018e339ce416b9da51fb44bd719449228.diff Patch: https://github.com/kamailio/kamailio/commit/f819890018e339ce416b9da51fb44bd719449228.patch --- diff --git a/src/modules/sipdump/README b/src/modules/sipdump/README index 2ec9d58953..e1408cec6f 100644 --- a/src/modules/sipdump/README +++ b/src/modules/sipdump/README @@ -10,7 +10,7 @@ Daniel-Constantin Mierla - Copyright © 2017 asipto.com + Copyright © 2017 asipto.com __ Table of Contents @@ -124,11 +124,11 @@ Chapter 1. Admin Guide Enable storage. - Default value is 1 (0 - off; 1 - on). + Default value is 0 (0 - off; 1 - on). Example 1.1. Set enable parameter ... -modparam("sipdump", "enable", 0) +modparam("sipdump", "enable", 1) ... 3.2. wait (int) @@ -180,7 +180,7 @@ modparam("sipdump", "fprefix", "ksipdump-") 4.1. sipdump_send(tag) -4.1. sipdump_send(tag) +4.1. sipdump_send(tag) Send the details of the current SIP message to the writter process and get it stored in the file. @@ -199,7 +199,7 @@ sipdump_send("cfg"); 5.1. sipdump.enable -5.1. sipdump.enable +5.1. sipdump.enable Control the value for "enable" parameter. ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
[sr-dev] git:master:02074c81: Merge branch 'master' of github.com:kamailio/kamailio
Module: kamailio Branch: master Commit: 02074c81158b0927778e5f2daaae8da953580f2f URL: https://github.com/kamailio/kamailio/commit/02074c81158b0927778e5f2daaae8da953580f2f Author: Juha HeinanenCommitter: Juha Heinanen Date: 2017-10-16T12:41:48+03:00 Merge branch 'master' of github.com:kamailio/kamailio --- Added: src/modules/phonenum/Makefile Added: src/modules/phonenum/README Added: src/modules/phonenum/cphonenumber.cpp Added: src/modules/phonenum/cphonenumber.h Added: src/modules/phonenum/doc/Makefile Added: src/modules/phonenum/doc/phonenum.xml Added: src/modules/phonenum/doc/phonenum_admin.xml Added: src/modules/phonenum/phonenum_mod.c Added: src/modules/phonenum/phonenum_pv.c Added: src/modules/phonenum/phonenum_pv.h Modified: src/Makefile.defs Modified: src/Makefile.groups Modified: src/modules/sipdump/sipdump_mod.c Modified: src/modules/sipdump/sipdump_write.c --- Diff: https://github.com/kamailio/kamailio/commit/02074c81158b0927778e5f2daaae8da953580f2f.diff Patch: https://github.com/kamailio/kamailio/commit/02074c81158b0927778e5f2daaae8da953580f2f.patch ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
[sr-dev] git:master:8596e84b: sipdump: enable param now defaults to 0
Module: kamailio Branch: master Commit: 8596e84b20f93cf73963b0c61e15dbb049b2276a URL: https://github.com/kamailio/kamailio/commit/8596e84b20f93cf73963b0c61e15dbb049b2276a Author: Juha HeinanenCommitter: Juha Heinanen Date: 2017-10-16T12:40:43+03:00 sipdump: enable param now defaults to 0 --- Modified: src/modules/sipdump/doc/sipdump_admin.xml Modified: src/modules/sipdump/sipdump_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/8596e84b20f93cf73963b0c61e15dbb049b2276a.diff Patch: https://github.com/kamailio/kamailio/commit/8596e84b20f93cf73963b0c61e15dbb049b2276a.patch --- diff --git a/src/modules/sipdump/doc/sipdump_admin.xml b/src/modules/sipdump/doc/sipdump_admin.xml index 8cffb7284a..b490c57b88 100644 --- a/src/modules/sipdump/doc/sipdump_admin.xml +++ b/src/modules/sipdump/doc/sipdump_admin.xml @@ -80,14 +80,14 @@ - Default value is 1 (0 - off; 1 - on). + Default value is 0 (0 - off; 1 - on). Set enable parameter ... -modparam("sipdump", "enable", 0) +modparam("sipdump", "enable", 1) ... diff --git a/src/modules/sipdump/sipdump_mod.c b/src/modules/sipdump/sipdump_mod.c index cb8651e0b0..a7f1c3bea5 100644 --- a/src/modules/sipdump/sipdump_mod.c +++ b/src/modules/sipdump/sipdump_mod.c @@ -41,7 +41,7 @@ MODULE_VERSION -static int sipdump_enable = 1; +static int sipdump_enable = 0; int sipdump_rotate = 7200; static int sipdump_wait = 100; static str sipdump_folder = str_init("/tmp"); ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] git:master:12b2a249: phonenum: new module to do lookup on phone numbers
fyi: this is not completed yet, wait a bit if you plan to play with it, more commits will follow up. Cheers, Daniel On 16.10.17 11:04, Daniel-Constantin Mierla wrote: > Module: kamailio > Branch: master > Commit: 12b2a249577ad175692c49d040891fa1ffae7244 > URL: > https://github.com/kamailio/kamailio/commit/12b2a249577ad175692c49d040891fa1ffae7244 > > Author: Daniel-Constantin Mierla> Committer: Daniel-Constantin Mierla > Date: 2017-10-16T10:54:44+02:00 > > phonenum: new module to do lookup on phone numbers > > - relies on libphonenumber to get the attributes associated with the > phone number > > --- > > Added: src/modules/phonenum/Makefile > Added: src/modules/phonenum/README > Added: src/modules/phonenum/cphonenumber.cpp > Added: src/modules/phonenum/cphonenumber.h > Added: src/modules/phonenum/doc/Makefile > Added: src/modules/phonenum/doc/phonenum.xml > Added: src/modules/phonenum/doc/phonenum_admin.xml > Added: src/modules/phonenum/phonenum_mod.c > Added: src/modules/phonenum/phonenum_pv.c > Added: src/modules/phonenum/phonenum_pv.h > > --- > > Diff: > https://github.com/kamailio/kamailio/commit/12b2a249577ad175692c49d040891fa1ffae7244.diff > Patch: > https://github.com/kamailio/kamailio/commit/12b2a249577ad175692c49d040891fa1ffae7244.patch > > > ___ > Kamailio (SER) - Development Mailing List > sr-dev@lists.kamailio.org > https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev -- Daniel-Constantin Mierla www.twitter.com/miconda -- www.linkedin.com/in/miconda Kamailio Advanced Training - www.asipto.com Kamailio World Conference - www.kamailioworld.com ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] sipdump comment/question
On 16.10.17 10:44, Juha Heinanen wrote: > Perhaps 0 would be better choice as "enable" param default value, > since dumping is likely to be done only if some need arises. I am fine with it, you can go ahead and change it or I will do as I get a chance in the next days. > > What is meaning of wait param, i.e., what is it that is waited for? > > 3.2. wait (int) > > Wait time (microseconds) when no SIP traffic is received. > > Writing is to file is done by a dedicated process, all other processes handling sip traffic are pushing the data to this process via a shared memory queue. This parameter is for the writer process, how long to wait before checking again if there is something in the write queue after emptying the queue. Cheers, Daniel -- Daniel-Constantin Mierla www.twitter.com/miconda -- www.linkedin.com/in/miconda Kamailio Advanced Training - www.asipto.com Kamailio World Conference - www.kamailioworld.com ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] sipdump compile trouble
Thanks, fixed. Daniel On 16.10.17 10:35, Juha Heinanen wrote: > CC (gcc) [M sipdump.so] sipdump_mod.o > In file included from ../../core/parser/../ut.h:42:0, > from ../../core/parser/../ip_addr.h:39, > from ../../core/parser/msg_parser.h:37, > from ../../core/sr_module.h:34, > from sipdump_mod.c:30: > sipdump_mod.c: In function 'child_init': > ../../core/parser/../dprint.h:302:8: warning: 'i' may be used uninitialized > in this function [-Wmaybe-uninitialized] > fprintf(stderr, "%.*s%2d(%d) %s: %s" fmt, \ > ^~~ > sipdump_mod.c:124:6: note: 'i' was declared here > int i; > ^ > CC (gcc) [M sipdump.so] sipdump_write.o > sipdump_write.c: In function 'sipdump_rotate_file': > sipdump_write.c:135:6: warning: variable 'n' set but not used > [-Wunused-but-set-variable] > int n; > ^ > > ___ > Kamailio (SER) - Development Mailing List > sr-dev@lists.kamailio.org > https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev -- Daniel-Constantin Mierla www.twitter.com/miconda -- www.linkedin.com/in/miconda Kamailio Advanced Training - www.asipto.com Kamailio World Conference - www.kamailioworld.com ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
[sr-dev] git:master:cf0814d0: Makefile.defs: version set to 5.1.0-dev8
Module: kamailio Branch: master Commit: cf0814d06bbb1fcd88020d2bce27482142ed7b7e URL: https://github.com/kamailio/kamailio/commit/cf0814d06bbb1fcd88020d2bce27482142ed7b7e Author: Daniel-Constantin MierlaCommitter: Daniel-Constantin Mierla Date: 2017-10-16T11:04:17+02:00 Makefile.defs: version set to 5.1.0-dev8 --- Modified: src/Makefile.defs --- Diff: https://github.com/kamailio/kamailio/commit/cf0814d06bbb1fcd88020d2bce27482142ed7b7e.diff Patch: https://github.com/kamailio/kamailio/commit/cf0814d06bbb1fcd88020d2bce27482142ed7b7e.patch --- diff --git a/src/Makefile.defs b/src/Makefile.defs index a7a66c4ed9..a2027a3a92 100644 --- a/src/Makefile.defs +++ b/src/Makefile.defs @@ -107,7 +107,7 @@ INSTALL_FLAVOUR=$(FLAVOUR) VERSION = 5 PATCHLEVEL = 1 SUBLEVEL = 0 -EXTRAVERSION = -dev7 +EXTRAVERSION = -dev8 # memory manager switcher # 0 - f_malloc (fast malloc) ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
[sr-dev] git:master:cb4f97b4: sipdump: fixed compile warnings on unused variables
Module: kamailio Branch: master Commit: cb4f97b4eb985727182c0ce8f595d3affe663cff URL: https://github.com/kamailio/kamailio/commit/cb4f97b4eb985727182c0ce8f595d3affe663cff Author: Daniel-Constantin MierlaCommitter: Daniel-Constantin Mierla Date: 2017-10-16T11:03:14+02:00 sipdump: fixed compile warnings on unused variables - reported by Juha Heinanen --- Modified: src/modules/sipdump/sipdump_mod.c Modified: src/modules/sipdump/sipdump_write.c --- Diff: https://github.com/kamailio/kamailio/commit/cb4f97b4eb985727182c0ce8f595d3affe663cff.diff Patch: https://github.com/kamailio/kamailio/commit/cb4f97b4eb985727182c0ce8f595d3affe663cff.patch --- diff --git a/src/modules/sipdump/sipdump_mod.c b/src/modules/sipdump/sipdump_mod.c index cb8651e0b0..4f1e83b5f8 100644 --- a/src/modules/sipdump/sipdump_mod.c +++ b/src/modules/sipdump/sipdump_mod.c @@ -121,7 +121,6 @@ static int mod_init(void) */ static int child_init(int rank) { - int i; if(rank != PROC_MAIN) return 0; @@ -129,7 +128,7 @@ static int child_init(int rank) if(fork_basic_utimer(PROC_TIMER, "SIPDUMP WRITE TIMER", 1 /*socks flag*/, sipdump_timer_exec, NULL, sipdump_wait /*usec*/) < 0) { - LM_ERR("failed to register timer routine as process (%d)\n", i); + LM_ERR("failed to register timer routine as process\n"); return -1; /* error */ } diff --git a/src/modules/sipdump/sipdump_write.c b/src/modules/sipdump/sipdump_write.c index 8d8c890721..4a566e9ff5 100644 --- a/src/modules/sipdump/sipdump_write.c +++ b/src/modules/sipdump/sipdump_write.c @@ -152,6 +152,7 @@ static int sipdump_rotate_file(void) "%d-%02d-%02d--%02d-%02d-%02d.data", 1900+ti->tm_year, ti->tm_mon, ti->tm_mday, ti->tm_hour, ti->tm_min, ti->tm_sec); + LM_DBG("writing to file: %s (%d)\n", _sipdump_fpath, n); _sipdump_file = fopen( _sipdump_fpath , "w" ); if(_sipdump_file==NULL) { LM_ERR("failed to open file %s\n", _sipdump_fpath); ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
[sr-dev] git:master:12b2a249: phonenum: new module to do lookup on phone numbers
Module: kamailio Branch: master Commit: 12b2a249577ad175692c49d040891fa1ffae7244 URL: https://github.com/kamailio/kamailio/commit/12b2a249577ad175692c49d040891fa1ffae7244 Author: Daniel-Constantin MierlaCommitter: Daniel-Constantin Mierla Date: 2017-10-16T10:54:44+02:00 phonenum: new module to do lookup on phone numbers - relies on libphonenumber to get the attributes associated with the phone number --- Added: src/modules/phonenum/Makefile Added: src/modules/phonenum/README Added: src/modules/phonenum/cphonenumber.cpp Added: src/modules/phonenum/cphonenumber.h Added: src/modules/phonenum/doc/Makefile Added: src/modules/phonenum/doc/phonenum.xml Added: src/modules/phonenum/doc/phonenum_admin.xml Added: src/modules/phonenum/phonenum_mod.c Added: src/modules/phonenum/phonenum_pv.c Added: src/modules/phonenum/phonenum_pv.h --- Diff: https://github.com/kamailio/kamailio/commit/12b2a249577ad175692c49d040891fa1ffae7244.diff Patch: https://github.com/kamailio/kamailio/commit/12b2a249577ad175692c49d040891fa1ffae7244.patch ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
[sr-dev] sipdump comment/question
Perhaps 0 would be better choice as "enable" param default value, since dumping is likely to be done only if some need arises. What is meaning of wait param, i.e., what is it that is waited for? 3.2. wait (int) Wait time (microseconds) when no SIP traffic is received. -- Juha ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
[sr-dev] sipdump compile trouble
CC (gcc) [M sipdump.so] sipdump_mod.o In file included from ../../core/parser/../ut.h:42:0, from ../../core/parser/../ip_addr.h:39, from ../../core/parser/msg_parser.h:37, from ../../core/sr_module.h:34, from sipdump_mod.c:30: sipdump_mod.c: In function 'child_init': ../../core/parser/../dprint.h:302:8: warning: 'i' may be used uninitialized in this function [-Wmaybe-uninitialized] fprintf(stderr, "%.*s%2d(%d) %s: %s" fmt, \ ^~~ sipdump_mod.c:124:6: note: 'i' was declared here int i; ^ CC (gcc) [M sipdump.so] sipdump_write.o sipdump_write.c: In function 'sipdump_rotate_file': sipdump_write.c:135:6: warning: variable 'n' set but not used [-Wunused-but-set-variable] int n; ^ ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] Roadmap to Kamailio v5.1
Hello, at the end of the day, the development of new features for next major release v5.1.0 is going to be frozen. If you have new features already developed by then and want to be included in v5.1 series, push them to master branch or make a pull request on github project. Work on related tools (e.g., kamctl) or documentation can still be done as well as getting the new modules in 5.1 in good shape, plus adding exports to kemi interface (which should not interfere with old code). Testing phase is expected to be 4 to 6 weeks, then the release of v5.1. Master branch will be unfrozen in 3 to 4 weeks, a matter of how testing goes, at that moment the dedicated branch 5.1 will be created. Cheers, Daniel On 09.10.17 11:56, Daniel-Constantin Mierla wrote: > Hello, > > the dates for next major release were confirmed during the IRC devel > meeting, so I am now following up to remind that we are one week before > freezing the development for next major release, v5.1.0. > > If you plan to add new modules or new features for existing components, > you'd have to hurry a bit. > > Cheers, > Daniel > > > On 18.09.17 10:38, Daniel-Constantin Mierla wrote: >> Hello, >> >> being discussed at the previous IRC devel meeting before the summer, >> it's time to plan the preparation for next major release, respectively >> Kamailio 5.1 series. >> >> As an initial proposal, a timeline can be: >> >> - Mon, Oct 16, 2017 - freeze the development >> - in 3-4 weeks after that, create the branch 5.1 >> - 2-3 weeks after, do the release of v5.1.0 >> >> That means more or less by end of November we will have first version of >> 5.1 series. >> >> There are still 4 weeks of development, hopefully enough to get ongoing >> work finished. I know from github tracker that there are people working >> on redis support for usrloc. I will focus on exporting more functions to >> kemi, right now should be around 60%, by freeze should be more than 80% >> (likely that means all of what most of people use these days, because >> there are some modules that I guess are not much used). Maybe one or two >> modules will be pushed as well from my side. >> >> I think we should also do an IRC devel meeting to try to sync better on >> this. Maybe by mid of next week, I will send another email shortly. >> >> Should anyone have more details to add or adjust the proposal, do not >> hesitate to reply to mailing list! >> >> Cheers, >> Daniel >> -- Daniel-Constantin Mierla www.twitter.com/miconda -- www.linkedin.com/in/miconda Kamailio Advanced Training - www.asipto.com Kamailio World Conference - www.kamailioworld.com ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev