[sr-dev] Jenkins build is back to normal : kamailiodev-nightly-binaries » amd64,jessie,slave #1042

[jenkins]

See 



___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] Jenkins build is back to normal : kamailiodev-nightly-binaries » amd64,wheezy,slave #1042

[jenkins]

See 



___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] Jenkins build is back to normal : kamailiodev-nightly-binaries » amd64,trusty,slave #1042

[jenkins]

See 



___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] Jenkins build is back to normal : kamailiodev-nightly-binaries » i386,jessie,slave #1042

[jenkins]

See 



___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] Jenkins build is back to normal : kamailiodev-nightly-binaries » i386,precise,slave #1042

[jenkins]

See 



___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] Jenkins build is back to normal : kamailiodev-nightly-binaries » i386,trusty,slave #1042

[jenkins]

See 



___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] Jenkins build is back to normal : kamailiodev-nightly-binaries » amd64,precise,slave #1042

[jenkins]

See 



___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] acc_json: adding module (#1440)

[Julien Chavanton]

Packet Type 1 - load tests

```
Total 250 INVITE calls sent in 2522028 ms at rate of 991/sec
Total 250 responses received in 2522826 ms at rate of 990/sec:

Detailed responses received:
 - 200 responses:  250 (OK)
--
 TOTAL responses:  250 (rate=990/sec)
```

rsyslog
```
wc -l /var/log/json_acc.log 
7500012 /var/log/json_acc.log
```
nsqd
```
nsqd v1.0.0-compat (built w/go1.8)
start_time 2018-02-16T22:36:24Z
uptime 2h1m51.901973386s

Health: OK

   [acc] depth: 0 be-depth: 0 msgs: 7500012  e2e%: 
  [nsq_to_file  ] depth: 7500012 be-depth: 7490012 inflt: 0
def: 0re-q: 0 timeout: 0 msgs: 7500012  e2e%: 
```
voip_perf client
```
./voip_perf -m INVITE -p 7075 sip:+1??@10.10.10.10:5060 \
--interval=1 \ 
--count=250 \  
--call-per-second=1000 \   
--thread-count=1 \ 
--timeout 17200  
```
voip_perf server
```
./voip_perf  -p 5072 --trying --ringing --thread-count=4 -d 500 
```

Latency graph showing stable response time
![image](https://user-images.githubusercontent.com/3736014/36335999-f11c213c-1338-11e8-9fa7-8df341df947f.png)


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1440#issuecomment-366399532___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] dmq_usrloc: contacts not deleted while 0x04 flag set in save() function (#1445)

[Guillaume Bour]

thanks @charlesrchance. I'll check and let you know

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1445#issuecomment-366298209___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] dmq_usrloc: contacts not deleted while 0x04 flag set in save() function (#1445)

[Charles Chance]

It looks like the new register has been received on server2 but the original 
one was received on server1 - therefore the presence of the FL_RPL flag is 
preventing the update from being replicated. This was intended behaviour at the 
time of 4.4.

As of b5f94a9 (currently only in 5.1 and above), FL_RPL has been removed and 
this behaviour modified so that updates made locally on any server are always 
replicated to others. Can you try with a later version and let me know if you 
still see the same?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1445#issuecomment-366278775___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] registrar: function "registered(...)" different workers integrity (#1267)

[Dmitri Savolainen]

with this path  it seems ok
```
diff --git a/src/modules/registrar/lookup.c b/src/modules/registrar/lookup.c
index b18fe99..84c0f40 100644
--- a/src/modules/registrar/lookup.c
+++ b/src/modules/registrar/lookup.c
@@ -759,6 +759,7 @@ int registered4(struct sip_msg* _m, udomain_t* _d, str* 
_uri, int match_flag,
}
}
 
+   get_act_time();
for (ptr = r->contacts; ptr; ptr = ptr->next) {
if(!VALID_CONTACT(ptr, act_time)) continue;
if (match_callid.s && /* optionally enforce tighter 
matching w/ Call-ID */
```


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1267#issuecomment-366275132___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] dmq_usrloc: contacts not deleted while 0x04 flag set in save() function (#1445)

[Guillaume Bour]

I finally found the delete event on server2 (generated by usrloc):
> DEBUG: usrloc [ul_callback.h:84]: run_ul_callbacks(): contact=0x7f87b6dd0de8, 
> callback type 4/15, id 0 entered
> DEBUG: dmq_usrloc [usrloc_sync.c:578]: dmq_ul_cb_contact(): Callback from 
> usrloc with type=4
> DEBUG: dmq_usrloc [usrloc_sync.c:600]: dmq_ul_cb_contact(): Contact received 
> from DMQ... skip

I guess the problem comes from usrloc_sync.c, line 582:
> if (!(ptr->flags & FL_RPL)) [

My understanding is usrloc delete event is not propagated through DMQ if the 
contact was not not previously registered from the exact same server.
Why is it like that ?


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1445#issuecomment-366271566___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] rtpengine: setting tos value for the control commands (#1442)

[Richard Fuchs]

rfuchs commented on this pull request.



> @@ -1675,6 +1677,19 @@ static int build_rtpp_socks() {
LM_WARN("Failed enable set MTU discovery socket 
option\n");
 #endif
 
+   if((0 <= control_cmd_tos) && (control_cmd_tos < 256)) {
+   if (pnode->rn_umode == 6) {
+   setsockopt(rtpp_socks[pnode->idx], 
IPPROTO_IPV6,
+   IPV6_TCLASS, 
_cmd_tos,
+   
sizeof(control_cmd_tos));
+
+   } else {
+   setsockopt(rtpp_socks[pnode->idx], 
IPPROTO_IP,
+   IP_TOS, 
_cmd_tos,
+   
sizeof(control_cmd_tos));

If memory serves right, the argument to IP_TOS should be a single byte 
`unsigned char`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1442#pullrequestreview-97163352___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] ndb_redis: fix check on server name len when adding a new server to t… (#1444)

[Federico Cabiddu]

Merged #1444.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1444#event-1477742658___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] git:master:62b00fc8: Merge pull request #1444 from grumvalski/redis_server_len_fix

[GitHub]

Module: kamailio
Branch: master
Commit: 62b00fc883b552cc2c1270f5f50a51da753710d5
URL: 
https://github.com/kamailio/kamailio/commit/62b00fc883b552cc2c1270f5f50a51da753710d5

Author: Federico Cabiddu 
Committer: GitHub 
Date: 2018-02-16T13:00:04+01:00

Merge pull request #1444 from grumvalski/redis_server_len_fix

ndb_redis: fix check on server name len when adding a new server to t…

---

Modified: src/modules/ndb_redis/redis_client.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/62b00fc883b552cc2c1270f5f50a51da753710d5.diff
Patch: 
https://github.com/kamailio/kamailio/commit/62b00fc883b552cc2c1270f5f50a51da753710d5.patch

---

diff --git a/src/modules/ndb_redis/redis_client.c 
b/src/modules/ndb_redis/redis_client.c
index 90d9865241..dd4ccd0a7a 100644
--- a/src/modules/ndb_redis/redis_client.c
+++ b/src/modules/ndb_redis/redis_client.c
@@ -707,7 +707,7 @@ int check_cluster_reply(redisReply *reply, redisc_server_t 
**rsrv)
"name=%.*s;addr=%.*s;port=%i", 
name.len, name.s,
addr.len, addr.s, port);
 
-   if(server_len>0 || server_len>sizeof(spec_new) 
- 1) {
+   if(server_len<0 || server_len>sizeof(spec_new) 
- 1) {
LM_ERR("failed to print server spec 
string\n");
return 0;
}


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] git:master:744be5a9: ndb_redis: fix check on server name len when adding a new server to the cluster

[grumvalski]

Module: kamailio
Branch: master
Commit: 744be5a9315687bf632d35d68cdfc6d913368477
URL: 
https://github.com/kamailio/kamailio/commit/744be5a9315687bf632d35d68cdfc6d913368477

Author: grumvalski 
Committer: grumvalski 
Date: 2018-02-16T11:26:00+01:00

ndb_redis: fix check on server name len when adding a new server to the cluster

---

Modified: src/modules/ndb_redis/redis_client.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/744be5a9315687bf632d35d68cdfc6d913368477.diff
Patch: 
https://github.com/kamailio/kamailio/commit/744be5a9315687bf632d35d68cdfc6d913368477.patch

---

diff --git a/src/modules/ndb_redis/redis_client.c 
b/src/modules/ndb_redis/redis_client.c
index 90d9865241..dd4ccd0a7a 100644
--- a/src/modules/ndb_redis/redis_client.c
+++ b/src/modules/ndb_redis/redis_client.c
@@ -707,7 +707,7 @@ int check_cluster_reply(redisReply *reply, redisc_server_t 
**rsrv)
"name=%.*s;addr=%.*s;port=%i", 
name.len, name.s,
addr.len, addr.s, port);
 
-   if(server_len>0 || server_len>sizeof(spec_new) 
- 1) {
+   if(server_len<0 || server_len>sizeof(spec_new) 
- 1) {
LM_ERR("failed to print server spec 
string\n");
return 0;
}


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Cnxcc doesn't update values in redis (#1387)

[Daniel-Constantin Mierla]

Closed #1387.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1387#event-1477728385___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Cnxcc doesn't update values in redis (#1387)

[Daniel-Constantin Mierla]

Thanks for the update! Closing.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1387#issuecomment-366215656___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] [kamailio/kamailio] dmq_usrloc: contacts not deleted while 0x04 flag set in save() function (#1445)

[Guillaume Bour]

### Description

Hello,

related to #265 ,
I can reproduce the issue, with kamailio 4.4.6+jessie from kamailio debian 
repository

- 0x04 flag is set on save()
- old contacts are deleted on the server receiving the REGISTER message
- old contacts are not deleted on servers being notified via DMQ
 





### Troubleshooting

 Reproduction

- Setup 2 servers with dmq & dmq_usrloc replication between each other, and 
with registration on 1st
- Use 0x04 flag on save() function
- Register your softphones a 1st time  on 1 server: registration is replicated 
on 2d server, contact is on both servers 
- Reregister (with different contact) on same server: 
  - previous contact is deleted on 1st server
  - new contact is replicated to 2d server
  - previous contact is *NOT* delete on 2d server

 Log Messages

server1 (REGISTER message):

DEBUG: usrloc [ucontact.c:1692]: update_ucontact(): exists callback for 
type= UL_CONTACT_UPDATE
DEBUG: usrloc [ul_callback.h:84]: run_ul_callbacks(): 
contact=0x7f0096e0b548, callback type 2/15, id 0 entered
DEBUG: dmq_usrloc [usrloc_sync.c:578]: dmq_ul_cb_contact(): Callback from 
usrloc with type=2
DEBUG: dmq_usrloc [usrloc_sync.c:548]: usrloc_dmq_send_contact(): sending 
serialized data 
{"action":1,"aor":"+33564093848","ruid":"uloc-5a86b8c5-31e0-2","c":"sip:+33564093848@xxx:41502;ob","received":"","path":"","callid":"ntoWjs3R3WpP9Z5rsi7Npmr2rRGKstls","user_agent":"CSipSimple_porridge-23/r2457","instance":"","expires":1518779539,"cseq":55952,"flags":0,"cflags":0,"q":-1,"last_modified":1518778639,"methods":8159,"reg_id":0}
DEBUG: dmq_usrloc [usrloc_sync.c:299]: usrloc_dmq_send(): sending dmq 
broadcast...

server2 (DMQ recipient):

DEBUG: dmq_usrloc [usrloc_sync.c:327]: usrloc_dmq_handle_msg(): dmq message 
received from sip:usrloc@172.16.67.15:5060
DEBUG: dmq_usrloc [usrloc_sync.c:429]: usrloc_dmq_handle_msg(): Received 
DMQ_UPDATE. Update contact info...
DEBUG: dmq_usrloc [usrloc_sync.c:64]: add_contact(): aor: +33564093848
DEBUG: dmq_usrloc [usrloc_sync.c:65]: add_contact(): ci->ruid: 
uloc-5a86b8c5-31e0-2
DEBUG: dmq_usrloc [usrloc_sync.c:66]: add_contact(): aorhash: -1799456359
DEBUG: dmq_usrloc [usrloc_sync.c:72]: add_contact(): Found contact
DEBUG: usrloc [ucontact.c:1692]: update_ucontact(): exists callback for 
type= UL_CONTACT_UPDATE
DEBUG: usrloc [ul_callback.h:84]: run_ul_callbacks(): 
contact=0x7f3900243bd0, callback type 2/15, id 0 entered
DEBUG: dmq_usrloc [usrloc_sync.c:578]: dmq_ul_cb_contact(): Callback from 
usrloc with type=2
DEBUG: dmq_usrloc [usrloc_sync.c:600]: dmq_ul_cb_contact(): Contact 
received from DMQ... skip
DEBUG: usrloc [ucontact.c:1004]: db_update_ucontact_ruid(): 
ruid:uloc-5a86b8c5-31e0-2
DEBUG: usrloc [ucontact.c:1133]: db_update_ucontact_ruid(): 
contact:sip:+33564093848@xxx:41502;ob
DEBUG: dmq_usrloc [usrloc_sync.c:74]: add_contact(): Release record
DEBUG: dmq_usrloc [usrloc_sync.c:76]: add_contact(): Unlock udomain

the recipient receive an UPDATE message only.
according to usrloc_sync.c:usrloc_dmq_handle_msg(), UPDATE message add the new 
contact only (execute add_contact()), but the other one is not deleted

and there is no DMQ_RM message generated from the emitter

 
### Possible Solutions



### Additional Information

```
version: kamailio 4.4.6 (x86_64/linux) 
flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, DISABLE_NAGLE, 
USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, 
TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, 
USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES
ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, 
MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: unknown 
compiled with gcc 4.9.2
```

* **Operating System**:


```
3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u2 (2017-06-26) x86_64 GNU/Linux
```


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1445___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] dmq_usrloc replication and max_contacts (Kamailio v4.3.1) (#265)

[Daniel-Constantin Mierla]

Open a new issue, the item here is for another version. Thanks!

-- 
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/265#issuecomment-366211845___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] dmq_usrloc replication and max_contacts (Kamailio v4.3.1) (#265)

[Daniel-Constantin Mierla]

Closed #265.

-- 
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/265#event-1477701119___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] dmq_usrloc replication and max_contacts (Kamailio v4.3.1) (#265)

[Guillaume Bour]

Hello,

I can reproduce the issue, with kamailio 4.4.6+jessie from kamailio debian 
repository:
* 0x04 flag is set on save()
* old contacts are deleted on the server receiving the REGISTER message
* old contacts are not deleted on servers being notified via DMQ




server1 (REGISTER message):
> DEBUG: usrloc [ucontact.c:1692]: update_ucontact(): exists callback for type= 
> UL_CONTACT_UPDATE
> DEBUG: usrloc [ul_callback.h:84]: run_ul_callbacks(): contact=0x7f0096e0b548, 
> callback type 2/15, id 0 entered
> DEBUG: dmq_usrloc [usrloc_sync.c:578]: dmq_ul_cb_contact(): Callback from 
> usrloc with type=2
> DEBUG: dmq_usrloc [usrloc_sync.c:548]: usrloc_dmq_send_contact(): sending 
> serialized data 
> {"action":1,"aor":"+33564093848","ruid":"uloc-5a86b8c5-31e0-2","c":"sip:+33564093848@xxx:41502;ob","received":"","path":"","callid":"ntoWjs3R3WpP9Z5rsi7Npmr2rRGKstls","user_agent":"CSipSimple_porridge-23/r2457","instance":"","expires":1518779539,"cseq":55952,"flags":0,"cflags":0,"q":-1,"last_modified":1518778639,"methods":8159,"reg_id":0}
> DEBUG: dmq_usrloc [usrloc_sync.c:299]: usrloc_dmq_send(): sending dmq 
> broadcast...

server2 (DMQ recipient):
> DEBUG: dmq_usrloc [usrloc_sync.c:327]: usrloc_dmq_handle_msg(): dmq message 
> received from sip:usrloc@172.16.67.15:5060
> DEBUG: dmq_usrloc [usrloc_sync.c:429]: usrloc_dmq_handle_msg(): Received 
> DMQ_UPDATE. Update contact info...
> DEBUG: dmq_usrloc [usrloc_sync.c:64]: add_contact(): aor: +33564093848
> DEBUG: dmq_usrloc [usrloc_sync.c:65]: add_contact(): ci->ruid: 
> uloc-5a86b8c5-31e0-2
> DEBUG: dmq_usrloc [usrloc_sync.c:66]: add_contact(): aorhash: -1799456359
> DEBUG: dmq_usrloc [usrloc_sync.c:72]: add_contact(): Found contact
> DEBUG: usrloc [ucontact.c:1692]: update_ucontact(): exists callback for type= 
> UL_CONTACT_UPDATE
> DEBUG: usrloc [ul_callback.h:84]: run_ul_callbacks(): contact=0x7f3900243bd0, 
> callback type 2/15, id 0 entered
> DEBUG: dmq_usrloc [usrloc_sync.c:578]: dmq_ul_cb_contact(): Callback from 
> usrloc with type=2
> DEBUG: dmq_usrloc [usrloc_sync.c:600]: dmq_ul_cb_contact(): Contact received 
> from DMQ... skip
> DEBUG: usrloc [ucontact.c:1004]: db_update_ucontact_ruid(): 
> ruid:uloc-5a86b8c5-31e0-2
> DEBUG: usrloc [ucontact.c:1133]: db_update_ucontact_ruid(): 
> contact:sip:+33564093848@xxx:41502;ob
> DEBUG: dmq_usrloc [usrloc_sync.c:74]: add_contact(): Release record
> DEBUG: dmq_usrloc [usrloc_sync.c:76]: add_contact(): Unlock udomain


the recipient receive an UPDATE message only.
according to usrloc_sync.c:usrloc_dmq_handle_msg(), UPDATE message add the new 
contact only (execute add_contact()), but the other one is not deleted

and there is no DMQ_RM message generated from the emitter

-- 
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/265#issuecomment-366211445___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] dmq_usrloc replication and max_contacts (Kamailio v4.3.1) (#265)

[Guillaume Bour]

Reopened #265.

-- 
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/265#event-1477698412___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] ndb_redis: fix check on server name len when adding a new server to t… (#1444)

[Giacomo Vacca]

giavac approved this pull request.





-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1444#pullrequestreview-97148334___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] [kamailio/kamailio] ndb_redis: fix check on server name len when adding a new server to t… (#1444)

[Federico Cabiddu]

…he cluster





 Pre-Submission Checklist



- [X ] Commit message has the format required by CONTRIBUTING guide
- [X] Commits are split per component (core, individual modules, libs, utils, 
...)
- [X] Each component has a single commit (if not, squash them into one commit)
- [X] No commits to README files for modules (changes must be done to docbook 
files
in `doc/` subfolder, the README file is autogenerated)

 Type Of Change
- [X] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

 Checklist:

- [ ] PR should be backported to stable branches
- [X ] Tested changes locally
- [ ] Related to issue # (replace  with an open issue number)

 Description


You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/1444

-- Commit Summary --

  * ndb_redis: fix check on server name len when adding a new server to the 
cluster

-- File Changes --

M src/modules/ndb_redis/redis_client.c (2)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/1444.patch
https://github.com/kamailio/kamailio/pull/1444.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1444
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Cnxcc doesn't update values in redis (#1387)

[zenichev]

Sorry for the delayed response.
Problem is solved by recompiling the cnxcc module.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1387#issuecomment-366190928___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] presence: incorrect dialog state for multiple dialogs xml body (#1427)

[Vasiliy Ganchev]

thanks for the last patch, I tried it.
Making the fast check the match of multiple dialog body works as expected.
Let me do deeper testing today. Will report results later.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1427#issuecomment-366179888___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Crash on receiving incorrect REGISTER request? (#1420)

[kbdfck]

@miconda thanks, got it. For some reason I can't reproduce this yet, maybe due 
to absence of production load.
I activated core dumps, will update issue in case of reproduction.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1420#issuecomment-366172020___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] sequence breaking DMQ bus (#1349)

[Daniel-Constantin Mierla]

Closed #1349.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1349#event-1477417229___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] sequence breaking DMQ bus (#1349)

[Daniel-Constantin Mierla]

Closing this one, following the patch referenced above. If still an issue, 
reopen or create a new issue as the module got new code inside it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1349#issuecomment-366169243___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] [4.2] Websockets was blocked when multiple WebRTC clients were disconnected from a MCU (#1419)

[Daniel-Constantin Mierla]

Closed #1419.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1419#event-1477415655___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] presence: incorrect dialog state for multiple dialogs xml body (#1427)

[Daniel-Constantin Mierla]

I just pushed patch 29d09b38fab5a1ee8d7f6f82818e3d3446d4dd8b for it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1427#issuecomment-366168714___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] git:master:29d09b38: presence: keep first dialog node reference to compare name with next nodes

[Daniel-Constantin Mierla]

Module: kamailio
Branch: master
Commit: 29d09b38fab5a1ee8d7f6f82818e3d3446d4dd8b
URL: 
https://github.com/kamailio/kamailio/commit/29d09b38fab5a1ee8d7f6f82818e3d3446d4dd8b

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2018-02-16T09:04:14+01:00

presence: keep first dialog node reference to compare name with next nodes

- there can be intermediary nodes of other type making the match fail
- related to GH #1425

---

Modified: src/modules/presence/presentity.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/29d09b38fab5a1ee8d7f6f82818e3d3446d4dd8b.diff
Patch: 
https://github.com/kamailio/kamailio/commit/29d09b38fab5a1ee8d7f6f82818e3d3446d4dd8b.patch

---

diff --git a/src/modules/presence/presentity.c 
b/src/modules/presence/presentity.c
index 4674f0ad49..785c58546d 100644
--- a/src/modules/presence/presentity.c
+++ b/src/modules/presence/presentity.c
@@ -313,6 +313,7 @@ int ps_match_dialog_state_from_body(str body, int 
*is_dialog, char *vstate)
 {
xmlDocPtr doc;
xmlNodePtr node;
+   xmlNodePtr fnode;
xmlNodePtr childNode;
char *tmp_state;
int rmatch = 0;
@@ -326,7 +327,7 @@ int ps_match_dialog_state_from_body(str body, int 
*is_dialog, char *vstate)
return -1;
}
 
-   node = xmlNodeGetChildByName(doc->children, "dialog");
+   fnode = node = xmlNodeGetChildByName(doc->children, "dialog");
 
while(node != NULL)
{
@@ -349,7 +350,7 @@ int ps_match_dialog_state_from_body(str body, int 
*is_dialog, char *vstate)
/* search for next dialog node */
do {
if(node->next != NULL && node->next->name != NULL
-   && xmlStrcmp(node->name, 
node->next->name) == 0) {
+   && xmlStrcmp(fnode->name, 
node->next->name) == 0) {
node = node->next;
break;
}


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] presence: incorrect dialog state for multiple dialogs xml body (#1427)

[Vasiliy Ganchev]

my shame... I did not do NULL check and that was the reason for crash.
With your logging added (processing same body and input PUBLISH as before):

```
Feb 16 08:54:16 0050562c117c /usr/sbin/kamailio[30264]: ERROR: presence 
[presentity.c:361]: ps_match_dialog_state_from_body(): vstate is terminated, 
tmp_state is terminated
Feb 16 08:54:16 0050562c117c /usr/sbin/kamailio[30264]: ERROR: presence 
[presentity.c:388]: ps_match_dialog_state_from_body(): do entered 
Feb 16 08:54:16 0050562c117c /usr/sbin/kamailio[30264]: ERROR: presence 
[presentity.c:396]: ps_match_dialog_state_from_body(): compared [dialog] with 
[text]
Feb 16 08:54:16 0050562c117c /usr/sbin/kamailio[30264]: ERROR: presence 
[presentity.c:399]: ps_match_dialog_state_from_body(): node->next 
Feb 16 08:54:16 0050562c117c /usr/sbin/kamailio[30264]: ERROR: presence 
[presentity.c:388]: ps_match_dialog_state_from_body(): do entered 
Feb 16 08:54:16 0050562c117c /usr/sbin/kamailio[30264]: ERROR: presence 
[presentity.c:396]: ps_match_dialog_state_from_body(): compared [text] with 
[dialog]
Feb 16 08:54:16 0050562c117c /usr/sbin/kamailio[30264]: ERROR: presence 
[presentity.c:399]: ps_match_dialog_state_from_body(): node->next 
Feb 16 08:54:16 0050562c117c /usr/sbin/kamailio[30264]: ERROR: presence 
[presentity.c:388]: ps_match_dialog_state_from_body(): do entered 
Feb 16 08:54:16 0050562c117c /usr/sbin/kamailio[30264]: ERROR: presence 
[presentity.c:396]: ps_match_dialog_state_from_body(): compared [dialog] with 
[text]
Feb 16 08:54:16 0050562c117c /usr/sbin/kamailio[30264]: ERROR: presence 
[presentity.c:399]: ps_match_dialog_state_from_body(): node->next 
Feb 16 08:54:16 0050562c117c /usr/sbin/kamailio[30264]: ERROR: presence 
[presentity.c:388]: ps_match_dialog_state_from_body(): do entered 
Feb 16 08:54:16 0050562c117c /usr/sbin/kamailio[30264]: ERROR: presence 
[presentity.c:399]: ps_match_dialog_state_from_body(): node->next 
Feb 16 08:54:16 0050562c117c /usr/sbin/kamailio[30264]: ERROR: presence 
[presentity.c:406]: ps_match_dialog_state_from_body(): going to return rmatch 1
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1427#issuecomment-366167097___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev