Re: [sr-dev] [kamailio/kamailio] RPC command stats.get_statistics randomly reporting 9223372036854776000 for current active/early dialogs (#1591)
Could it have something to do with "old-non-expired-non-removed" dialogs? So today I applied latest @charlesrchance patch, and what I normally do (so I don't lose dialogs) is: 1- Restart one node 2- Wait for DMQ replication dialog sync 3- Restart other node Right after restarting both nodes in that sequence, I already could see values close to ULONG_MAX, so I did a `watch` every second and I could see the values move around. I decided to compare the dialogs to see if I could find anything interesting, what I found is that there were a lot of dialogs with the `init_ts` from like 11th and 13th July and being today 28th, those dialogs should not be there. So I wonder if those "bad" dialogs could be the cause of the counters going below 0. Maybe some timer to remove those dialogs didn't happen? and because of the way I perform restarts to not lose dialogs, they were constantly there replicated backwards and forwards... That said, I did a full restart (both nodes at the same time, losing dialogs) and since then the metrics are looking good. I hope this info helps. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1591#issuecomment-408629258___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] ims_ipsec_pcscf: sec-agree implementation for IMS (#1605)
Hello, thank you for your contribution! I did a quick look to the code and noticed a few simple areas that should refined before going looking deeper in the functionality. * Please remove the README file from the commit. This is auto-generated and should not be commited to git * You mentioned that your work is based on OpenIMScore. Do you actually use code from this project in your implementation? Then you need to add proper copyright notices that refer to this code. * With regards to copyright - you need to also choose a copyright to your code. Most modules choose "GPLv2 and later", but BSD would be also ok if you prefer this. Have a look to other modules for an example copyright header. Best regards, Henning -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1605#issuecomment-408609505___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] Broken Kamailio repository for CentOS 7 (#1604)
+1 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1604#issuecomment-408586109___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
