[sr-dev] [kamailio/kamailio] tls: fix raw vs urlencoded behavior in sel_ssl_cert() (#2291)

[Armen Babikyan]

* Small bugfix
* Changes Tested locally

In addressing Daniels comments on 
https://github.com/kamailio/kamailio/pull/2268#issuecomment-609935161, I 
realized that I misunderstood how select variables get resolved to data 
structures.

This patch fixes the sel_ssl_cert() implementation so that 
$sel(@tls.my.raw_cert), $sel(@tls.my.urlencoded_cert), 
$sel(@tls.peer.raw_cert), and $sel(@tls.peer.urlencoded_cert) all evaluate to 
expected outputs.
You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/2291

-- Commit Summary --

  * tls: fix raw vs urlencoded behavior in sel_ssl_cert()

-- File Changes --

M src/modules/tls/tls_select.c (28)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/2291.patch
https://github.com/kamailio/kamailio/pull/2291.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2291
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] async_http_client crash (#2286)

[Federico Cabiddu]

Sorry the mail was sent before ending by accident.

Thanks for looking into it and fixing it Daniel. For sure it should be
backported.

Cheers,

Federico

On Sat, Apr 18, 2020 at 9:23 AM Federico Cabiddu 
wrote:

> Hi Daniel,
> you are absolutely right and that part of code is for sure wrong. Those
> lines have been there since the beginning and for sure due to my lack of
> understanding of transactions's internals and avps (don't remember why
> sincerely).
> For the records, I've been using mixed suspended/not suspended from the
> beginning but I've always used separate return routes for suspended and not
> suspended queries. That could explain why I never had it.
> Thanks for looking into it
>
> On Sat, Apr 18, 2020 at 3:13 AM Alex Balashov 
> wrote:
>
>> @miconda  To answer a few other questions:
>>
>>1.
>>
>>I always set $http_req(suspend) = 1 on async HTTP client transactions;
>>2.
>>
>>There are no event_routes anywhere;
>>3.
>>
>>The flow is complex, though. After this async HTTP query, there is
>>another *synchronous* HTTP query using the normal http_client module
>>+ mqueue + rtimer -- it was implemented this way because of some
>>problems with transaction-persistent variables (ironically) when 
>> suspending
>>the same TM transaction twice, and a desire for more granular control over
>>the request pipelines given the high and somewhat unpredictable latency of
>>what's being queried.
>>
>> Nevertheless, all this takes place long after the crash point.
>>
>> —
>> You are receiving this because you are subscribed to this thread.
>> Reply to this email directly, view it on GitHub
>> ,
>> or unsubscribe
>> 
>> .
>> ___
>> Kamailio (SER) - Development Mailing List
>> sr-dev@lists.kamailio.org
>> https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
>>
>
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] async_http_client crash (#2286)

[Federico Cabiddu]

Hi Daniel,
you are absolutely right and that part of code is for sure wrong. Those
lines have been there since the beginning and for sure due to my lack of
understanding of transactions's internals and avps (don't remember why
sincerely).
For the records, I've been using mixed suspended/not suspended from the
beginning but I've always used separate return routes for suspended and not
suspended queries. That could explain why I never had it.
Thanks for looking into it

On Sat, Apr 18, 2020 at 3:13 AM Alex Balashov 
wrote:

> @miconda  To answer a few other questions:
>
>1.
>
>I always set $http_req(suspend) = 1 on async HTTP client transactions;
>2.
>
>There are no event_routes anywhere;
>3.
>
>The flow is complex, though. After this async HTTP query, there is
>another *synchronous* HTTP query using the normal http_client module +
>mqueue + rtimer -- it was implemented this way because of some
>problems with transaction-persistent variables (ironically) when suspending
>the same TM transaction twice, and a desire for more granular control over
>the request pipelines given the high and somewhat unpredictable latency of
>what's being queried.
>
> Nevertheless, all this takes place long after the crash point.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> ,
> or unsubscribe
> 
> .
> ___
> Kamailio (SER) - Development Mailing List
> sr-dev@lists.kamailio.org
> https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
>
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev