Re: [sr-dev] RTPEngine - Support for Unified Plan SDP Format

2020-05-18 Thread Daniel-Constantin Mierla 
Hello,

what are the differences in building the SDP for the two types (plan-b
vs unified-plan)? Can you (someone else) summarize? it will be useful to
see what can be done for sdpops module.

On the other hand, rtpengine gets full SDP body from Kamailio and
returns the new full SDP back, so here I do not think Kamailio's RTP
engine needs update, maybe new flags to control if the change should be
done or not (e.g., between two webrtc endpoints, one with old format and
the other with the new format).

Cheers,
Daniel

On 17.05.20 06:31, M S wrote:
> Hi,
>
> Since Chrome M72, the default format of SDP generated by Chrome's
> WebRTC stack has been changed to "unified-plan" instead of  Google's
> old "plan-b" format, which has no been deprecated and planned to be
> removed sometime in mid 2020. Here are more details about it.
>
> https://webrtc.org/getting-started/unified-plan-transition-guide
>
> This poses a big problem for non-web WebRTC clients, servers and
> proxies (such as RTPEngine) which will stop working as soon as Google
> Chrome removes support for legacy "plan-b" SDP format.
>
> In kmaialio's RTPEngine module, so far I have seen no support for this
> new "unified-plan" SDP format. 
>
> Are there any support planed for future? 
>
> Meanwhile, if there any way to add support for it in Kamailio via SDP
> manipulation e.g. SDPOPS module etc.
>
> Thank you.
>
> --
> Muhammad Shahzad Shafi
> Tel: +49 176 24 73 85 20
>
>
> ___
> Kamailio (SER) - Development Mailing List
> sr-dev@lists.kamailio.org
> https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

-- 
Daniel-Constantin Mierla -- www.asipto.com
www.twitter.com/miconda -- www.linkedin.com/in/miconda
Funding: https://www.paypal.me/dcmierla

___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] Jenkins build is back to normal : kamailiodev-nightly-binaries » i386,jessie #1669

2020-05-18 Thread kamailio 
See 



___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] Fwd: RPC command to close all WS connections.

2020-05-18 Thread Andrey Deykunov 
-- Forwarded message -
От: Andrey Deykunov 
Date: пн, 18 мая 2020 г. в 12:24
Subject: RPC command to close all WS connections.
To: Daniel-Constantin Mierla 


Hi Daniel,

We're using two nodes (active and passive) of our PBX server in production.
When an active node becomes passive, we should forcibly close all WS
connections, established by clients on this node. So, I've added
'ws.close_all' command to websocket module to let our failover service be
able closing WS connections remotely.

I've added the following code to ws_frame.c:

void ws_rpc_close_all(rpc_t *rpc, void *ctx)
{
ws_connection_t **list = NULL, **list_head = NULL;
ws_connection_t *wsc = NULL;
int ret;

list_head = wsconn_get_list();
if(!list_head)
return;

list = list_head;
wsc = *list_head;
while(wsc) {
LM_WARN("Closing connection\n");
ret = close_connection(, LOCAL_CLOSE, 1000
, str_status_normal_closure);
wsc = *(++list);
}
wsconn_put_list(list_head);
}

but I think this code may be unsafe and could corrupt shared
memory, because I've got some segfaults during failovers after adding this
command.

What do you think? Is it possible to close connections properly
and safety for shared memory?

Thanks,
Andrey
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] git:master:d500589d: dmq: use module prefix for global variables

2020-05-18 Thread Daniel-Constantin Mierla 
Module: kamailio
Branch: master
Commit: d500589d1503b62df0db9a837f1a80ae8425b840
URL: 
https://github.com/kamailio/kamailio/commit/d500589d1503b62df0db9a837f1a80ae8425b840

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2020-05-18T12:06:05+02:00

dmq: use module prefix for global variables

- avoid potential conflicts with other globals, given that this module
is used by other modules to perform replication

---

Modified: src/modules/dmq/bind_dmq.h
Modified: src/modules/dmq/dmq.c
Modified: src/modules/dmq/dmq.h
Modified: src/modules/dmq/dmq_funcs.c
Modified: src/modules/dmq/dmq_funcs.h
Modified: src/modules/dmq/dmqnode.c
Modified: src/modules/dmq/dmqnode.h
Modified: src/modules/dmq/message.h
Modified: src/modules/dmq/notification_peer.c
Modified: src/modules/dmq/notification_peer.h
Modified: src/modules/dmq/peer.c
Modified: src/modules/dmq/peer.h
Modified: src/modules/dmq/worker.c
Modified: src/modules/dmq/worker.h

---

Diff:  
https://github.com/kamailio/kamailio/commit/d500589d1503b62df0db9a837f1a80ae8425b840.diff
Patch: 
https://github.com/kamailio/kamailio/commit/d500589d1503b62df0db9a837f1a80ae8425b840.patch


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] git:master:17d30403: core: kemi - added KSR.is_KDQM()

2020-05-18 Thread Daniel-Constantin Mierla 
Module: kamailio
Branch: master
Commit: 17d3040365400d14d251247c9c3319fc003f2cb2
URL: 
https://github.com/kamailio/kamailio/commit/17d3040365400d14d251247c9c3319fc003f2cb2

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2020-05-18T11:28:20+02:00

core: kemi - added KSR.is_KDQM()

---

Modified: src/core/kemi.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/17d3040365400d14d251247c9c3319fc003f2cb2.diff
Patch: 
https://github.com/kamailio/kamailio/commit/17d3040365400d14d251247c9c3319fc003f2cb2.patch

---

diff --git a/src/core/kemi.c b/src/core/kemi.c
index 7a5ba1068d..c15621690a 100644
--- a/src/core/kemi.c
+++ b/src/core/kemi.c
@@ -1067,6 +1067,15 @@ static int sr_kemi_core_is_method_message(sip_msg_t *msg)
 }
 
 
+/**
+ *
+ */
+static int sr_kemi_core_is_method_kdmq(sip_msg_t *msg)
+{
+   return sr_kemi_core_is_method_type(msg, METHOD_KDMQ);
+}
+
+
 /**
  *
  */
@@ -1755,6 +1764,11 @@ static sr_kemi_t _sr_kemi_core[] = {
{ SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE,
SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE }
},
+   { str_init(""), str_init("is_KDMQ"),
+   SR_KEMIP_BOOL, sr_kemi_core_is_method_kdmq,
+   { SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE,
+   SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE }
+   },
{ str_init(""), str_init("is_UDP"),
SR_KEMIP_BOOL, sr_kemi_core_is_proto_udp,
{ SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE,


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] KSR.is_MESSAGE() Not implemented (#2331)

2020-05-18 Thread Daniel-Constantin Mierla 
Closed #2331.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2331#event-3345745936___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] KSR.is_MESSAGE() Not implemented (#2331)

2020-05-18 Thread Daniel-Constantin Mierla 
Thanks, I pushed the implementation in master branch, to be backported soon.

There is also the alternative of using KSR.is_method_in("m")

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2331#issuecomment-629974972___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] git:master:8db5a12f: core: kemi - added missing is_MESSAGE()

2020-05-18 Thread Daniel-Constantin Mierla 
Module: kamailio
Branch: master
Commit: 8db5a12f7fab1a1fc7d50c87bbf1aee325b067c2
URL: 
https://github.com/kamailio/kamailio/commit/8db5a12f7fab1a1fc7d50c87bbf1aee325b067c2

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2020-05-18T08:29:09+02:00

core: kemi - added missing is_MESSAGE()

- GH #2331

---

Modified: src/core/kemi.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/8db5a12f7fab1a1fc7d50c87bbf1aee325b067c2.diff
Patch: 
https://github.com/kamailio/kamailio/commit/8db5a12f7fab1a1fc7d50c87bbf1aee325b067c2.patch

---

diff --git a/src/core/kemi.c b/src/core/kemi.c
index 8a77c227b7..7a5ba1068d 100644
--- a/src/core/kemi.c
+++ b/src/core/kemi.c
@@ -1057,6 +1057,16 @@ static int sr_kemi_core_is_method_prack(sip_msg_t *msg)
return sr_kemi_core_is_method_type(msg, METHOD_PRACK);
 }
 
+
+/**
+ *
+ */
+static int sr_kemi_core_is_method_message(sip_msg_t *msg)
+{
+   return sr_kemi_core_is_method_type(msg, METHOD_MESSAGE);
+}
+
+
 /**
  *
  */
@@ -1740,6 +1750,11 @@ static sr_kemi_t _sr_kemi_core[] = {
{ SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE,
SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE }
},
+   { str_init(""), str_init("is_MESSAGE"),
+   SR_KEMIP_BOOL, sr_kemi_core_is_method_message,
+   { SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE,
+   SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE }
+   },
{ str_init(""), str_init("is_UDP"),
SR_KEMIP_BOOL, sr_kemi_core_is_proto_udp,
{ SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE,


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] git:master:7749069c: uid_uri_db: use file specific include guard

2020-05-18 Thread Daniel-Constantin Mierla 
Module: kamailio
Branch: master
Commit: 7749069cd05b9619ee32237773097441e241bac4
URL: 
https://github.com/kamailio/kamailio/commit/7749069cd05b9619ee32237773097441e241bac4

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2020-05-17T10:01:18+02:00

uid_uri_db: use file specific include guard

---

Modified: src/modules/uid_uri_db/uid_uri_db_mod.h

---

Diff:  
https://github.com/kamailio/kamailio/commit/7749069cd05b9619ee32237773097441e241bac4.diff
Patch: 
https://github.com/kamailio/kamailio/commit/7749069cd05b9619ee32237773097441e241bac4.patch

---

diff --git a/src/modules/uid_uri_db/uid_uri_db_mod.h 
b/src/modules/uid_uri_db/uid_uri_db_mod.h
index e4848ecd93..aa72a2aa5b 100644
--- a/src/modules/uid_uri_db/uid_uri_db_mod.h
+++ b/src/modules/uid_uri_db/uid_uri_db_mod.h
@@ -27,8 +27,8 @@
  */
 
 
-#ifndef URIDB_MOD_H
-#define URIDB_MOD_H
+#ifndef _UID_URI_DB_MOD_H_
+#define _UID_URI_DB_MOD_H_
 
 #include "../../lib/srdb2/db.h"
 #include "../../core/str.h"


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] git:master:3d73e8cb: acc_diameter: use file specific include guard

2020-05-18 Thread Daniel-Constantin Mierla 
Module: kamailio
Branch: master
Commit: 3d73e8cb9f7431383c5a4ce798e2610f37ff92dc
URL: 
https://github.com/kamailio/kamailio/commit/3d73e8cb9f7431383c5a4ce798e2610f37ff92dc

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2020-05-17T10:00:28+02:00

acc_diameter: use file specific include guard

---

Modified: src/modules/acc_diameter/diam_message.h

---

Diff:  
https://github.com/kamailio/kamailio/commit/3d73e8cb9f7431383c5a4ce798e2610f37ff92dc.diff
Patch: 
https://github.com/kamailio/kamailio/commit/3d73e8cb9f7431383c5a4ce798e2610f37ff92dc.patch

---

diff --git a/src/modules/acc_diameter/diam_message.h 
b/src/modules/acc_diameter/diam_message.h
index 9051f0f7a1..7ca1caf27e 100644
--- a/src/modules/acc_diameter/diam_message.h
+++ b/src/modules/acc_diameter/diam_message.h
@@ -26,8 +26,8 @@
  * - Module: \ref acc
  */
 
-#ifndef _AAA_DIAMETER_MSG_H
-#define _AAA_DIAMETER_MSG_H
+#ifndef _ACC_DIAM_MESSAGE_H_
+#define _ACC_DIAM_MESSAGE_H_
 
 #include "../../core/str.h"
 #include "../../core/mem/mem.h"


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] git:master:9053c70f: auth_diameter: use file specific include guard

2020-05-18 Thread Daniel-Constantin Mierla 
Module: kamailio
Branch: master
Commit: 9053c70fe7e147b784c53a57014796282701c74d
URL: 
https://github.com/kamailio/kamailio/commit/9053c70fe7e147b784c53a57014796282701c74d

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2020-05-17T10:01:00+02:00

auth_diameter: use file specific include guard

---

Modified: src/modules/auth_diameter/diameter_msg.h

---

Diff:  
https://github.com/kamailio/kamailio/commit/9053c70fe7e147b784c53a57014796282701c74d.diff
Patch: 
https://github.com/kamailio/kamailio/commit/9053c70fe7e147b784c53a57014796282701c74d.patch

---

diff --git a/src/modules/auth_diameter/diameter_msg.h 
b/src/modules/auth_diameter/diameter_msg.h
index 7ab5a8c383..e8e7eea875 100644
--- a/src/modules/auth_diameter/diameter_msg.h
+++ b/src/modules/auth_diameter/diameter_msg.h
@@ -13,15 +13,15 @@
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
- * You should have received a copy of the GNU General Public License 
- * along with this program; if not, write to the Free Software 
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  
USA
  */
 
 
 
-#ifndef _AAA_DIAMETER_MSG_H
-#define _AAA_DIAMETER_MSG_H
+#ifndef _AUTH_DIAM_MESSAGE_H_
+#define _AUTH_DIAM_MESSAGE_H_
 
 #include "../../core/str.h"
 #include "../../core/mem/mem.h"


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] [kamailio/kamailio] KSR.is_MESSAGE() Not implemented (#2331)

2020-05-18 Thread hance2010 


### Description

KSR.is_MESSAGE()  Not implemented.
kamailio v5.3.4



### Troubleshooting

 Reproduction



 Debugging Data



```
(paste your debugging data here)
```

 Log Messages



```
(paste your log messages here)
```

 SIP Traffic



```
(paste your sip traffic here)
```

### Possible Solutions



### Additional Information

  * **Kamailio Version** - output of `kamailio -v`

```
(paste your output here)
```

* **Operating System**:



```
(paste your output here)
```


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2331___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev