Re: [sr-dev] [kamailio/kamailio] Kamailio 5.4.1 - Crash on startup when TLS is enabled after upgrading from stretch to buster (#2466)
Hi Joey, I've tried to investigate the issue with http_async_client initialization, but I've not been able to reproduce it in buster. Anyway looking at the logs I've found something that might be not good, the place(s) where curl memory callbacks are set. I've created a branch with a change on this https://github.com/kamailio/kamailio/tree/hac_curl_mem_callbacks, do you have any chance to try it? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2466#issuecomment-688854979___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] Kamailio 5.4.1 - Crash on startup when TLS is enabled after upgrading from stretch to buster (#2466)
Yes, tls module loaded first.
I created a minimal config file that reproduces the problem.
The crash is because of this line: modparam("http_async_client", "workers", 4)
comment out this line makes the crash disappear.
#!KAMAILIO
### Global Parameters #
/* LOG Levels: 3=DBG, 2=INFO, 1=NOTICE, 0=WARN, -1=ERR, ... */
debug=2
log_stderror=no
memdbg=5
memlog=5
log_facility=LOG_LOCAL0
log_prefix="{$mt $hdr(CSeq) $ci} "
children=8
tcp_children=16
auto_aliases=no
alias="example.com"
listen=udp:eth0
server_signature=no
tcp_connection_lifetime=3605
tcp_max_connections=40960
tcp_accept_no_cl=yes
enable_tls=yes
listen=tls:eth0
tls_max_connections=4
enable_sctp=no
### Modules Section
loadmodule "kex.so"
loadmodule "corex.so"
loadmodule "tm.so"
loadmodule "tmx.so"
loadmodule "sl.so"
loadmodule "rr.so"
loadmodule "pv.so"
loadmodule "tls.so"
loadmodule "http_async_client.so"
# - setting module-specific parameters ---
# - tls params -
modparam("tls", "config", "/etc/kamailio/tls.cfg")
# - http client
modparam("http_async_client", "workers", 4)
### Routing Logic
request_route {
exit;
}
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2466#issuecomment-688831449___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] uac: contact_addr field added into db uacreg table (#2470)
Thanks! I will do another review soon and if all ok, I will merge manually to have the proper commit message format and commits per components. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2470#issuecomment-688805907___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] msrp: fixed IPv6 address parsing (#2472)
Thanks for the details. I will have to check the code and see if this patch covers it properly, somehow I am not confident in just jumping to `]` for the case of ipv6 in the uri. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2472#issuecomment-688805206___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
[sr-dev] git:master:c644d311: core: events - return after SREV_TCP_WS_CLOSE callbacks are executed
Module: kamailio
Branch: master
Commit: c644d311100e52e83f7ddf54a3a0b7be83525184
URL:
https://github.com/kamailio/kamailio/commit/c644d311100e52e83f7ddf54a3a0b7be83525184
Author: Daniel-Constantin Mierla
Committer: Daniel-Constantin Mierla
Date: 2020-09-08T13:09:59+02:00
core: events - return after SREV_TCP_WS_CLOSE callbacks are executed
---
Modified: src/core/events.c
---
Diff:
https://github.com/kamailio/kamailio/commit/c644d311100e52e83f7ddf54a3a0b7be83525184.diff
Patch:
https://github.com/kamailio/kamailio/commit/c644d311100e52e83f7ddf54a3a0b7be83525184.patch
---
diff --git a/src/core/events.c b/src/core/events.c
index b9df7dcf2d..69a496df31 100644
--- a/src/core/events.c
+++ b/src/core/events.c
@@ -353,6 +353,7 @@ int sr_event_exec(int type, sr_event_param_t *evp)
&&
_sr_events_list.tcp_ws_close[i]; i++) {
ret =
_sr_events_list.tcp_ws_close[i](evp);
}
+ return ret;
} else return 1;
default:
return -1;
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
[sr-dev] git:5.4:c7a07121: core: events - return once SREV_SIP_REPLY_OUT callbacks are executed
Module: kamailio
Branch: 5.4
Commit: c7a07121012b23299331b22426852d9af534582f
URL:
https://github.com/kamailio/kamailio/commit/c7a07121012b23299331b22426852d9af534582f
Author: Daniel-Constantin Mierla
Committer: Daniel-Constantin Mierla
Date: 2020-09-08T13:09:10+02:00
core: events - return once SREV_SIP_REPLY_OUT callbacks are executed
(cherry picked from commit 1910432ce3af56af1e6d4c4c124c2af2925c5b9a)
---
Modified: src/core/events.c
---
Diff:
https://github.com/kamailio/kamailio/commit/c7a07121012b23299331b22426852d9af534582f.diff
Patch:
https://github.com/kamailio/kamailio/commit/c7a07121012b23299331b22426852d9af534582f.patch
---
diff --git a/src/core/events.c b/src/core/events.c
index 91df673996..d48d7a7819 100644
--- a/src/core/events.c
+++ b/src/core/events.c
@@ -334,6 +334,7 @@ int sr_event_exec(int type, sr_event_param_t *evp)
&&
_sr_events_list.sip_reply_out[i]; i++) {
ret |=
_sr_events_list.sip_reply_out[i](evp);
}
+ return ret;
} else return 1;
default:
return -1;
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
[sr-dev] git:master:1910432c: core: events - return once SREV_SIP_REPLY_OUT callbacks are executed
Module: kamailio
Branch: master
Commit: 1910432ce3af56af1e6d4c4c124c2af2925c5b9a
URL:
https://github.com/kamailio/kamailio/commit/1910432ce3af56af1e6d4c4c124c2af2925c5b9a
Author: Daniel-Constantin Mierla
Committer: Daniel-Constantin Mierla
Date: 2020-09-08T13:08:01+02:00
core: events - return once SREV_SIP_REPLY_OUT callbacks are executed
---
Modified: src/core/events.c
---
Diff:
https://github.com/kamailio/kamailio/commit/1910432ce3af56af1e6d4c4c124c2af2925c5b9a.diff
Patch:
https://github.com/kamailio/kamailio/commit/1910432ce3af56af1e6d4c4c124c2af2925c5b9a.patch
---
diff --git a/src/core/events.c b/src/core/events.c
index 2d8400f829..b9df7dcf2d 100644
--- a/src/core/events.c
+++ b/src/core/events.c
@@ -343,6 +343,7 @@ int sr_event_exec(int type, sr_event_param_t *evp)
&&
_sr_events_list.sip_reply_out[i]; i++) {
ret |=
_sr_events_list.sip_reply_out[i](evp);
}
+ return ret;
} else return 1;
case SREV_TCP_WS_CLOSE:
if(unlikely(_sr_events_list.tcp_ws_close[0]!=0))
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
[sr-dev] Releasing v5.3.6
Hello, I am considering to release v5.3.6 from the branch 5.3 in the next days, aiming from Thursday (Sep 10, 2020) if everything goes as planned at this moment, or on Monday (Sep 14, 2020) if a little bit of time is needed. Should you be aware of any issue that needs to be addressed in the branch 5.3 (e.g., a bug, or a missing backport), inform us as soon as possible to try to sort it out in time. Cheers, Daniel -- Daniel-Constantin Mierla -- www.asipto.com www.twitter.com/miconda -- www.linkedin.com/in/miconda Funding: https://www.paypal.me/dcmierla ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
[sr-dev] git:master:9132a4bb: sipdump: move use of spd fields after safety check
Module: kamailio
Branch: master
Commit: 9132a4bbd39c0302204dd053bd1e563c02afed8e
URL:
https://github.com/kamailio/kamailio/commit/9132a4bbd39c0302204dd053bd1e563c02afed8e
Author: Daniel-Constantin Mierla
Committer: Daniel-Constantin Mierla
Date: 2020-09-08T12:52:53+02:00
sipdump: move use of spd fields after safety check
---
Modified: src/modules/sipdump/sipdump_pcap.c
---
Diff:
https://github.com/kamailio/kamailio/commit/9132a4bbd39c0302204dd053bd1e563c02afed8e.diff
Patch:
https://github.com/kamailio/kamailio/commit/9132a4bbd39c0302204dd053bd1e563c02afed8e.patch
---
diff --git a/src/modules/sipdump/sipdump_pcap.c
b/src/modules/sipdump/sipdump_pcap.c
index 52ef7b3b92..e808ff23fe 100644
--- a/src/modules/sipdump/sipdump_pcap.c
+++ b/src/modules/sipdump/sipdump_pcap.c
@@ -125,8 +125,8 @@ void sipdump_write_pcap(FILE *fs, sipdump_data_t *spd)
char *p = NULL;
struct pcap_record_header v_pcap_record_header = {
- .ts_sec = spd->tv.tv_sec,
- .ts_usec = spd->tv.tv_usec,
+ .ts_sec = 0,
+ .ts_usec = 0,
};
struct pcap_ethernet_header v_pcap_ethernet_header = {
.type = 0,
@@ -148,6 +148,9 @@ void sipdump_write_pcap(FILE *fs, sipdump_data_t *spd)
return;
}
+ v_pcap_record_header.ts_sec = spd->tv.tv_sec;
+ v_pcap_record_header.ts_usec = spd->tv.tv_usec;
+
data = spd->data;
if((sipdump_mode & SIPDUMP_MODE_WPCAPEX) && (spd->data.len < BUF_SIZE -
256)) {
if(_sipdump_pcap_data_buf == NULL) {
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
[sr-dev] git:master:68f93d27: sipdump: init checksum filed
Module: kamailio
Branch: master
Commit: 68f93d27b9ee40cfce8c52304eac4ad9c83ee4b1
URL:
https://github.com/kamailio/kamailio/commit/68f93d27b9ee40cfce8c52304eac4ad9c83ee4b1
Author: Daniel-Constantin Mierla
Committer: Daniel-Constantin Mierla
Date: 2020-09-08T12:48:15+02:00
sipdump: init checksum filed
- silent analyzer
---
Modified: src/modules/sipdump/sipdump_pcap.c
---
Diff:
https://github.com/kamailio/kamailio/commit/68f93d27b9ee40cfce8c52304eac4ad9c83ee4b1.diff
Patch:
https://github.com/kamailio/kamailio/commit/68f93d27b9ee40cfce8c52304eac4ad9c83ee4b1.patch
---
diff --git a/src/modules/sipdump/sipdump_pcap.c
b/src/modules/sipdump/sipdump_pcap.c
index 1a559cea59..52ef7b3b92 100644
--- a/src/modules/sipdump/sipdump_pcap.c
+++ b/src/modules/sipdump/sipdump_pcap.c
@@ -182,6 +182,7 @@ void sipdump_write_pcap(FILE *fs, sipdump_data_t *spd)
v_pcap_udp_header.src = ntohs(spd->src_port);
v_pcap_udp_header.dst = ntohs(spd->dst_port);
v_pcap_udp_header.length = ntohs(sizeof(struct pcap_udp_header) +
data.len);
+ v_pcap_udp_header.checksum = 0;
/* IP header */
if (spd->afid == AF_INET6) {
@@ -243,4 +244,4 @@ void sipdump_write_pcap(FILE *fs, sipdump_data_t *spd)
LM_ERR("writing UDP payload to pcap failed: %s\n",
strerror(errno));
}
fflush(fs);
-}
\ No newline at end of file
+}
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
[sr-dev] git:5.3:e1dc051e: modules: readme files regenerated - modules ... [skip ci]
Module: kamailio
Branch: 5.3
Commit: e1dc051e4171cb7a441987d0c184fc210fa57063
URL:
https://github.com/kamailio/kamailio/commit/e1dc051e4171cb7a441987d0c184fc210fa57063
Author: Kamailio Dev
Committer: Kamailio Dev
Date: 2020-09-08T12:47:01+02:00
modules: readme files regenerated - modules ... [skip ci]
---
Modified: src/modules/app_lua/README
Modified: src/modules/pike/README
Modified: src/modules/tls/README
---
Diff:
https://github.com/kamailio/kamailio/commit/e1dc051e4171cb7a441987d0c184fc210fa57063.diff
Patch:
https://github.com/kamailio/kamailio/commit/e1dc051e4171cb7a441987d0c184fc210fa57063.patch
---
diff --git a/src/modules/app_lua/README b/src/modules/app_lua/README
index a1f0c05984..545fb78f14 100644
--- a/src/modules/app_lua/README
+++ b/src/modules/app_lua/README
@@ -94,6 +94,9 @@ Chapter 1. Admin Guide
To read more about KEMI exports and available KSR submodules, see:
* http://kamailio.org/docs/tutorials/devel/kamailio-kemi-framework/
+ Note: to have the old Lua module 'sr' available, load the 'app_lua_sr'
+ Kamailio module.
+
Lua (http://www.lua.org) is a fast and easy to embed scripting
language. Exported API from SIP router to Lua is documented in the
dokuwiki.
@@ -203,7 +206,7 @@ lua_dofile("/usr/local/etc/kamailio/lua/myscript.lua");
Example 1.6. lua_dostring usage
...
-if(!lua_dostring("sr.log([[err]], [[--- Hello World from $fU\n]])"))
+if(!lua_dostring("KSR.log([[err]], [[--- Hello World from $fU\n]])"))
{
xdbg("SCRIPT: failed to execute lua script!\n");
}
@@ -237,7 +240,7 @@ lua_run("lua_func3", "$rU", "2", "$si");
Example 1.8. lua_runstring usage
...
-if(!lua_runstring("sr.log([[err]], [[--- Hello World from $fU\n]])"))
+if(!lua_runstring("KSR.log([[err]], [[--- Hello World from $fU\n]])"))
{
xdbg("SCRIPT: failed to execute lua script!\n");
}
@@ -297,7 +300,7 @@ if(!lua_runstring("sr.log([[err]], [[--- Hello
World from $fU\n]])"))
'/usr/local/etc/kamailio/lua/myscript.lua'.
...
function sr_append_fu_to_reply()
-sr.hdr.append_to_reply("P-From: " .. sr.pv.get("$fu") .. "\r\n");
+KSR.hdr.append_to_reply("P-From: " .. KSR.pv.get("$fu") .. "\r\n");
end
...
diff --git a/src/modules/pike/README b/src/modules/pike/README
index a7f66697e7..beea746f45 100644
--- a/src/modules/pike/README
+++ b/src/modules/pike/README
@@ -39,6 +39,7 @@ Bogdan-Andrei Iancu
2. RPC calls
1. pike.top
+2. pike.list
3. Developer Guide
@@ -49,6 +50,7 @@ Bogdan-Andrei Iancu
1.3. Set remove_latency parameter
1.4. Set pike_log_level parameter
1.5. pike_check_req usage
+ 2.1. Using pike.top
3.1. Tree of IP addresses
Chapter 1. Admin Guide
@@ -219,6 +221,7 @@ Chapter 2. RPC calls
Table of Contents
1. pike.top
+ 2. pike.list
1. pike.top
@@ -230,9 +233,9 @@ Chapter 2. RPC calls
Some IPs could be marked as HOT depending on theirs request rates.
- pike.top command takes one string parameter which specifies what kind
- of nodes you are interested in. Possible values are HOT or ALL. If no
- argument is given, it behaves as HOT was used.
+ pike.top command can take one string parameter which specifies what
+ kind of nodes you are interested in. Possible values are HOT or ALL. If
+ no argument is given, it behaves as HOT was used.
Marking nodes HOT is done on server side, client only presents given
data and make some postprocessing like sorting.
@@ -240,6 +243,15 @@ Chapter 2. RPC calls
Output of this command is a simple dump of ip_tree nodes marked as
ip-leafs.
+ Example 2.1. Using pike.top
+...
+kamcli rpc pike.top ALL
+...
+
+2. pike.list
+
+ Alias for "pike.top" command.
+
Chapter 3. Developer Guide
One single tree (for both IPv4 and IPv6) is used. Each node contains a
diff --git a/src/modules/tls/README b/src/modules/tls/README
index 0a0e6650d7..99f05e22c5 100644
--- a/src/modules/tls/README
+++ b/src/modules/tls/README
@@ -1426,7 +1426,7 @@ end
10.34. rand_engine (str)
- Set the ranondom number generator engine for libssl.
+ Set the random number generator engine for libssl.
Note: the default random number generator (PRNG) engine of libssl
v1.1.x is not designed for multi-process applications and can result in
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
[sr-dev] git: new commits in branch 5.3
- URL: https://github.com/kamailio/kamailio/commit/fa7042676c0dc2ea8760c928ef70fd187eedc3a4 Author: Daniel-Constantin Mierla Date: 2020-09-08T09:52:35+02:00 kamctl: added pstrap command - use ps to get list of PIDs for Kamailio instance, instead of RPC core.psx (cherry picked from commit 97ec85559f1e33405fff2320443dc86d2df13456) - URL: https://github.com/kamailio/kamailio/commit/12aecb27779637b90ef83efea4dfaf095b5b2b13 Author: Daniel-Constantin Mierla Date: 2020-09-08T09:52:44+02:00 kamctl: print process details in pstrap output (cherry picked from commit 904a1590dbcdbb0fda9f676b4768596f797e9e27) - URL: https://github.com/kamailio/kamailio/commit/7ac48ca1a6bd0462199ebb6cf1be61bc2c865353 Author: Daniel-Constantin Mierla Date: 2020-09-08T09:52:57+02:00 kamctl: skip tracing kamctl itself in pstrap (cherry picked from commit 626c0dee863fa517e473148ca8010d737a8f7ffe) - URL: https://github.com/kamailio/kamailio/commit/c79cc69ac27bd1d6b506634e8a9d768001648762 Author: Daniel-Constantin Mierla Date: 2020-09-08T09:56:49+02:00 tls: docs - fixed typo - GH #2410 (cherry picked from commit a12064696ac37cadf954a89b58daa1e05e182180) (cherry picked from commit eb2abae40b36ad123528cddb25e0ddd217b68b22) - URL: https://github.com/kamailio/kamailio/commit/5896f8e31078ff9b5d704c7393d7a7acac29db96 Author: Luis Martin Gil Date: 2020-09-08T09:57:08+02:00 tm - remove not used route_mode var (cherry picked from commit 6619be46249dfe0b2f2cbc863cb8b2f44716122b) - URL: https://github.com/kamailio/kamailio/commit/647f12b15b443f9f0ed96e509b2df6cb7d44 Author: Daniel-Constantin Mierla Date: 2020-09-08T09:57:50+02:00 log_custom: print to stderror if sending log message fails - help troubleshooting while avoiding looping to same function in case the log engine is set to log custom module (cherry picked from commit f16d046f6330f897b374d9bb7dab3b2ce8eab3a7) (cherry picked from commit 1ecade5cbd323e1ab45ec6f83236e1d389739d3b) - URL: https://github.com/kamailio/kamailio/commit/9db407d0ad2a2e48725ddc2fd37026978f56132a Author: Daniel-Constantin Mierla Date: 2020-09-08T09:58:18+02:00 app_lua: docs - note about availability of 'sr' Lua module - use KSR in the examples (cherry picked from commit 34efa83569bedb1f36c3661ee063ff6334633e4a) (cherry picked from commit c98d9e8c6687f2311f51016ed9cc2e089d4eb242) - URL: https://github.com/kamailio/kamailio/commit/4f9a5cdefb8d6baf9c069e277012d6d616137393 Author: Daniel-Constantin Mierla Date: 2020-09-08T09:58:30+02:00 xcap_server: check before going to the end of the buffer - use marcros to set and restore char for ending 0 (cherry picked from commit 6ce5c0bdf136ecffd7917f2d60093e1b2c49fa54) (cherry picked from commit 4aeb071b26df08e1dfc902340475c077e468c661) - URL: https://github.com/kamailio/kamailio/commit/2d581622496e2141401a00a47011cf11156317e0 Author: Daniel-Constantin Mierla Date: 2020-09-08T09:58:58+02:00 db_text: free pointer in case of error (cherry picked from commit bddf16db74ea779bb01805fc2cbabfdaf8f4d62b) (cherry picked from commit aabb2b2cfab6dc664ebc4b3d15db0d2ecb3cafd5) - URL: https://github.com/kamailio/kamailio/commit/0f8528d4705e0e7060708f6108c47bcc599f743a Author: Daniel-Constantin Mierla Date: 2020-09-08T09:59:07+02:00 Makefile.defs: get clang version only from --version output - the full version with stderr output included has a different first line on MacOS, making head -n 1 not extract the version number line (cherry picked from commit bff689cfedca70149e17b6ec3584ca9ecab71418) (cherry picked from commit b14b0a116791b85f2048e5fc863e50b7f7d93405) - URL: https://github.com/kamailio/kamailio/commit/148cf4bb35cb94e111cf8ade1294519c556f4b7c Author: Daniel-Constantin Mierla Date: 2020-09-08T09:59:17+02:00 Makefile.defs: map gcc v10.x to 9.0+ options - detect properly the 10.x gcc version number, GH #2425 (cherry picked from commit 79e7738027a40affa4c7f606bf55a3ad0fe31bc4) (cherry picked from commit 6d79c954469082aeb8518fdcca80217ce4826992) - URL: https://github.com/kamailio/kamailio/commit/58043293132efa043a1d9ebfb2473d1efe319a35 Author: Daniel-Constantin Mierla Date: 2020-09-08T09:59:27+02:00 pike: docs - section for pike.list rpc command (cherry picked from commit 720e929a87c6d3ee29c316ca63886c7142320f43) (cherry picked from commit c783f19708bfd1d8c2334f739c8960b2de5f4fb3) - URL: https://github.com/kamailio/kamailio/commit/0567c42a324deaa8dfe60cf1d8281aa22f5f4e1d Author: Daniel-Constantin Mierla Date: 2020-09-08T09:59:39+02:00 topoh: check if via param has the expected prefix, otherwise skip - GH #2437 (cherry picked from commit 046126b4a90090bf5b8f9b517ba5218793e6b973) (cherry picked from commit c8c884c4db353d4fac83752a494989e699fc36ff) - URL: https://github.com/kamailio/kamailio/commit/e956b3c7dbb931f719e11a44887c5eeb8ffa878d Author: Dmitry Date: 2020-09-08T09:59:55+02:00 Makefile.defs: Fixed libs option for FreeBSD (cherry picked from commit
