[sr-dev] Re: [kamailio/kamailio] kazoo: SIGSEGV on module unload (Issue #3648)
Closed #3648 as not planned. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3648#event-11505806238 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] Kamailio 5.6 do not execute "event_route[websocket:closed]" when tcp reset (Issue #3389)
Closed #3389 as not planned. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3389#event-11505806001 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] core/cfg refactoring to free quicker the old values from inactive processes (#2094)
Closed #2094 as not planned. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2094#event-11505805846 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] app_jsdt: add support for LoongArch (PR #3715)
Get it,thanks. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3715#issuecomment-1894768836 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] RFE: RPM packaging of wolfSSL 5.6.6 for upcoming freeze/5.7 release (Issue #3713)
And update dependent wolfssl RPM package? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3713#issuecomment-1894028756 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] RFE: RPM packaging of wolfSSL 5.6.6 for upcoming freeze/5.7 release (Issue #3713)
@space88man do I understand properly you want package wolfssl module in the 5.6.6 release? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3713#issuecomment-1894025884 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] app_jsdt: add support for LoongArch (PR #3715)
The file `duk_config.h` is imported as it is from duktape project, any change to it has to be pushed to that project: - https://github.com/svaarala/duktape -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3715#issuecomment-1894009466 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:5.7:784bb3b3: tls: set parameter name for tls_h_mod_randctx()
Module: kamailio Branch: 5.7 Commit: 784bb3b397cc1922d06054c611c443dd19216504 URL: https://github.com/kamailio/kamailio/commit/784bb3b397cc1922d06054c611c443dd19216504 Author: Elena-Ramona Modroiu Committer: Elena-Ramona Modroiu Date: 2024-01-16T16:13:19+01:00 tls: set parameter name for tls_h_mod_randctx() - without it fails to compile on Unbuntu 22.04 with low latency kernel (cherry picked from commit 03456e5e5983e2236b8e182cf3317d14ebf34e18) --- Modified: src/modules/tls/tls_init.c --- Diff: https://github.com/kamailio/kamailio/commit/784bb3b397cc1922d06054c611c443dd19216504.diff Patch: https://github.com/kamailio/kamailio/commit/784bb3b397cc1922d06054c611c443dd19216504.patch --- diff --git a/src/modules/tls/tls_init.c b/src/modules/tls/tls_init.c index 629f69ad6b3..1c6b19f560e 100644 --- a/src/modules/tls/tls_init.c +++ b/src/modules/tls/tls_init.c @@ -737,7 +737,8 @@ int tls_pre_init(void) * left here in case more complex requirements arise in * OpenSSL >= 3.2. */ -long tls_h_mod_randctx(void *) { +long tls_h_mod_randctx(void *param) +{ do { OSSL_LIB_CTX *osslglobal = NULL; EVP_RAND_CTX *randctx = NULL; ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:03456e5e: tls: set parameter name for tls_h_mod_randctx()
Module: kamailio Branch: master Commit: 03456e5e5983e2236b8e182cf3317d14ebf34e18 URL: https://github.com/kamailio/kamailio/commit/03456e5e5983e2236b8e182cf3317d14ebf34e18 Author: Elena-Ramona Modroiu Committer: GitHub Date: 2024-01-16T16:07:43+01:00 tls: set parameter name for tls_h_mod_randctx() - without it fails to compile on Unbuntu 22.04 with low latency kernel --- Modified: src/modules/tls/tls_init.c --- Diff: https://github.com/kamailio/kamailio/commit/03456e5e5983e2236b8e182cf3317d14ebf34e18.diff Patch: https://github.com/kamailio/kamailio/commit/03456e5e5983e2236b8e182cf3317d14ebf34e18.patch --- diff --git a/src/modules/tls/tls_init.c b/src/modules/tls/tls_init.c index bb1d0f19207..6992d4a65e2 100644 --- a/src/modules/tls/tls_init.c +++ b/src/modules/tls/tls_init.c @@ -739,7 +739,8 @@ int tls_pre_init(void) * left here in case more complex requirements arise in * OpenSSL >= 3.2. */ -long tls_h_mod_randctx(void *) { +long tls_h_mod_randctx(void *param) +{ do { OSSL_LIB_CTX *osslglobal = NULL; EVP_RAND_CTX *randctx = NULL; ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] [kamailio/kamailio] Consider adding socket options SO_BINDTODEVICE when the interface name is given for listen in the config file (Issue #3716)
### Description Consider adding socket options SO_BINDTODEVICE when the interface name is given for listening in the config file. This will be useful in listening to linux VRF interfaces, especially when there are two different VRFs and it is required to proxy SIP messages between the VRFs -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3716 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: git:master:a752fde2: tls_wolfssl: update to v5.6.6-stable
Good point Daniel - I recommend that we keep the submodule in for one more kamailio release cycle (5.8?) and wait until the dust settles from the new OpenSSL 3 commits. wolfSSL is also less packaged in some of the RPM based distros. Also OpenSSL 3 has (relative to 1.1.1) poor performance (although with each point release they claw back some losses). Earlier Henning had brought up the cooperation with HAProxy and wolfSSL so this can be a useful way to reap collateral benefit. Supporting distro versions may lead to #ifdef'ing and this is something I hope to avoid. On Tue, 16 Jan 2024 at 17:05, Daniel-Constantin Mierla wrote: > Hello, > > is wolfssl git sub-module still needed to be included in Kamailio tree > now that master branch has memory managers with 16bytes alignment? > > It would be good to just use libwolfssl from the OS distro. > > Cheers, > Daniel > > On 16.01.24 09:12, S-P Chan via sr-dev wrote: > > Module: kamailio > > Branch: master > > Commit: a752fde2fd2eb3615d16eb8940364ceea2f7d79c > > URL: > https://github.com/kamailio/kamailio/commit/a752fde2fd2eb3615d16eb8940364ceea2f7d79c > > > > Author: S-P Chan > > Committer: S-P Chan > > Date: 2024-01-16T16:06:45+08:00 > > > > tls_wolfssl: update to v5.6.6-stable > > > > --- > > > > Modified: misc/external/wolfssl/wolfssl > > > > --- > > > > Diff: > https://github.com/kamailio/kamailio/commit/a752fde2fd2eb3615d16eb8940364ceea2f7d79c.diff > > Patch: > https://github.com/kamailio/kamailio/commit/a752fde2fd2eb3615d16eb8940364ceea2f7d79c.patch > > > > --- > > > > diff --git a/misc/external/wolfssl/wolfssl > b/misc/external/wolfssl/wolfssl > > index 37884f864d6..66596ad9e1d 16 > > --- a/misc/external/wolfssl/wolfssl > > +++ b/misc/external/wolfssl/wolfssl > > @@ -1 +1 @@ > > -Subproject commit 37884f864d6fd9b04f44677cb04da15d0c9d6526 > > +Subproject commit 66596ad9e1d7efa8479656872cf09c9c1870a02e > > > > ___ > > Kamailio (SER) - Development Mailing List > > To unsubscribe send an email to sr-dev-le...@lists.kamailio.org > > > -- > Daniel-Constantin Mierla (@ asipto.com) > twitter.com/miconda -- linkedin.com/in/miconda > Kamailio Consultancy, Training and Development Services -- asipto.com > Kamailio Advanced Training, February 20-22, 2024 -- asipto.com > Kamailio World Conference, April 18-19, 2024, Berlin -- kamailioworld.com > > ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] [kamailio/kamailio] Add support for LoongArch. (PR #3715)
Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) Checklist: - [x] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue # (replace with an open issue number) Description Add support for LoongArch.The LoongArch architecture (LoongArch) is an Instruction Set Architecture (ISA) that has a RISC style. Documentations: ISA: https://loongson.github.io/LoongArch-Documentation/LoongArch-Vol1-EN.html ABI: https://loongson.github.io/LoongArch-Documentation/LoongArch-ELF-ABI-EN.html More docs can be found at: https://loongson.github.io/LoongArch-Documentation/README-EN.html You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3715 -- Commit Summary -- * Add support for LoongArch. -- File Changes -- M src/modules/app_jsdt/duk_config.h (11) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3715.patch https://github.com/kamailio/kamailio/pull/3715.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3715 You are receiving this because you are subscribed to this thread. Message ID:___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git: new commits in branch 5.7
- URL: https://github.com/kamailio/kamailio/commit/18fead63dca0982df500b35b7c4e2d06550d9b40 Author: Daniel-Constantin Mierla Date: 2024-01-16T11:10:53+01:00 core: set proto on fixing forward actions (cherry picked from commit e51ccd11fe51f2d53dd7719b8fdec561a6ba7494) - URL: https://github.com/kamailio/kamailio/commit/065203150aaf2f99bd6fe40ce5ffb960bd430c16 Author: Daniel-Constantin Mierla Date: 2024-01-16T11:16:40+01:00 dialog: prevent duplicate of leg1 attributes in json for dmq - reported by #3656 (cherry picked from commit ca7e1e49aecd3e0f12cc783e3b97868980f1d3d2) - URL: https://github.com/kamailio/kamailio/commit/3046d01bed4bdd0fe763fd770ffc8f7aeeae3418 Author: Peter Barabas Date: 2024-01-16T11:18:24+01:00 uac: fix socket length settings - set _uac_req.s_sock.len value to 0 in pv_set_uac_req() method in case of "all" case - change setting of _uac_req.s_apasswd.len to _uac_req.s_sock.len in pv_set_uac_req() method in case of "sock" case (cherry picked from commit 10519d199f6cac116399f4473bd82f2b08de72ba) - URL: https://github.com/kamailio/kamailio/commit/81dce4e5003f3c00301671144ac67877f5824b72 Author: Daniel-Constantin Mierla Date: 2024-01-16T11:20:20+01:00 core: xavp - info long when skipping serializing a field (cherry picked from commit 5d97afefd2a8f53072a36b6eb8927c180fb984c9) - URL: https://github.com/kamailio/kamailio/commit/37621005e38a0191a93fbaf4f39b8b88c7486c9d Author: Daniel-Constantin Mierla Date: 2024-01-16T11:21:55+01:00 dialog: check first the size (cherry picked from commit 9db18bc48bff0d230e66973a45c8e72e1b7744e8) - URL: https://github.com/kamailio/kamailio/commit/1189bb2962dd80c21a1d497125f3199ccc018270 Author: Daniel-Constantin Mierla Date: 2024-01-16T11:23:24+01:00 tm: check get_t() result for consistency (cherry picked from commit 1191ab4e5e03b35714ec1ad9d9bf2dd9665c71fd) - URL: https://github.com/kamailio/kamailio/commit/0712576dc4d57ba41e45012486dd206d955c35e6 Author: Daniel-Constantin Mierla Date: 2024-01-16T11:23:49+01:00 registrar: check returned branch pointer (cherry picked from commit 5d641f56fc1bc342d9be008ecd96959e114fef66) - URL: https://github.com/kamailio/kamailio/commit/62b76c076ff0f36b847a13c180b7d5090e98d94e Author: Daniel-Constantin Mierla Date: 2024-01-16T11:24:10+01:00 core: check if conversion could not be done (cherry picked from commit 077651fa3bfd50e0f654c907f3783b1421497bd5) - URL: https://github.com/kamailio/kamailio/commit/4371adffc07bb555e2a52dedd6cd5afa2631287a Author: Daniel-Constantin Mierla Date: 2024-01-16T11:24:20+01:00 app_python3: check allocated pointer (cherry picked from commit 49b3b90cd229b7c4da06b61cdfd782450d383cc9) - URL: https://github.com/kamailio/kamailio/commit/0ca30e87655798e3841c005abb63ca66bb2ca0aa Author: Daniel-Constantin Mierla Date: 2024-01-16T11:24:53+01:00 core: srjson - init vars and check scanned values (cherry picked from commit 678b1a68de86d9539adeaf0262d9735b8d435077) - URL: https://github.com/kamailio/kamailio/commit/2d385c1983a921a95fb392e8aea0332fdc10a387 Author: Daniel-Constantin Mierla Date: 2024-01-16T11:25:18+01:00 pv: typo in transformation log message (cherry picked from commit ca2a9479adf720e67bf50c9d2795cc8937e223dc) - URL: https://github.com/kamailio/kamailio/commit/5a26d9e9fba36a49a93bb3b886836615f62ed3d1 Author: Daniel-Constantin Mierla Date: 2024-01-16T11:25:38+01:00 pv: removed unnecessary condition (cherry picked from commit 2f43510be37c157f800389dfb432b6c52d7435a7) - URL: https://github.com/kamailio/kamailio/commit/916d02d883dc938247576bdf8f5c5b23a588cb9c Author: Daniel-Constantin Mierla Date: 2024-01-16T11:27:30+01:00 tm: make lookup event_route[tm:local-response] only once - related to issue #3064 and PR #3687 (cherry picked from commit 1f5444fd2e25d227ffd70f1087d057a3b8002558) - URL: https://github.com/kamailio/kamailio/commit/6cd8f2acc0601fbd040999d776f15b828d6e4946 Author: Daniel-Constantin Mierla Date: 2024-01-16T11:28:03+01:00 tmx: rework cleaning up on init failure (cherry picked from commit 5192e5d275761ccd1af49d4bf9dd12e1438947b7) - URL: https://github.com/kamailio/kamailio/commit/fc0bd88b55121e3588f5793480f0594e44bf2b17 Author: Daniel-Constantin Mierla Date: 2024-01-16T11:28:34+01:00 statsd: use bool type for local variable to match return of function (cherry picked from commit 0186246fce8f0e4bb46b30c05174983cd957a3ba) - URL: https://github.com/kamailio/kamailio/commit/be5b4b160ecff8dc398735fbd28ceb71845f1bef Author: Nikolay Ivanuschak Date: 2024-01-16T11:29:08+01:00 core: fixed haproxy protocol parser fixes GH #3683 (cherry picked from commit c5237830f3e7fbeec403a0190471a066081c1117) - URL: https://github.com/kamailio/kamailio/commit/37a07037b6e3485f3ddd1b27b1998af6e4283bcb Author: Dennis Yurasov Date: 2024-01-16T11:29:22+01:00 dialog: fixed saving dialogs on shutdown that are already loaded at startup when using db_mode 3 - The dialogs that loa
[sr-dev] git:master:14828091: rtp_media_server: use local user for building contact
Module: kamailio Branch: master Commit: 14828091b06dca86c91659d705a4f58a6fead4d3 URL: https://github.com/kamailio/kamailio/commit/14828091b06dca86c91659d705a4f58a6fead4d3 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-01-16T13:10:34+01:00 rtp_media_server: use local user for building contact - GH #3380 --- Modified: src/modules/rtp_media_server/rtp_media_server.c --- Diff: https://github.com/kamailio/kamailio/commit/14828091b06dca86c91659d705a4f58a6fead4d3.diff Patch: https://github.com/kamailio/kamailio/commit/14828091b06dca86c91659d705a4f58a6fead4d3.patch --- diff --git a/src/modules/rtp_media_server/rtp_media_server.c b/src/modules/rtp_media_server/rtp_media_server.c index 0026c2e0fff..a41b5715022 100644 --- a/src/modules/rtp_media_server/rtp_media_server.c +++ b/src/modules/rtp_media_server/rtp_media_server.c @@ -408,12 +408,27 @@ static int rms_sip_reply( return 1; } +static str _rms_default_user = str_init("rms"); +static void rms_link_user(str *suri, str *suser) +{ + sip_uri_t puri; + if(parse_uri(suri->s, suri->len, &puri) < 0 || puri.user.s == NULL + || puri.user.len <= 0) { + suser->s = _rms_default_user.s; + suser->len = _rms_default_user.len; + return; + } + suser->s = puri.user.s; + suser->len = puri.user.len; +} + static int rms_answer_call( struct cell *cell, rms_dialog_info_t *di, rms_sdp_info_t *sdp_info) { - char buffer[128]; + char buffer[256]; str reason = str_init("OK"); str contact_hdr; + str luser; if(di->state == RMS_ST_CONNECTED) { return 1; } @@ -428,9 +443,10 @@ static int rms_answer_call( sdp_info->local_ip.s = di->local_ip.s; sdp_info->local_ip.len = di->local_ip.len; - snprintf(buffer, 128, - "Contact: \r\nContent-Type: application/sdp\r\n", - di->local_ip.s, di->local_port); + rms_link_user(&di->local_uri, &luser); + snprintf(buffer, 256, + "Contact: \r\nContent-Type: application/sdp\r\n", + luser.len, luser.s, di->local_ip.s, di->local_port); contact_hdr.len = strlen(buffer); contact_hdr.s = buffer; @@ -592,6 +608,7 @@ static int rms_bridging_call(rms_dialog_info_t *di, rms_action_t *a) int result; str method_invite = str_init("INVITE"); str headers; + str luser; struct sip_uri ruri_t; str *param_uri = &a->param; @@ -609,10 +626,11 @@ static int rms_bridging_call(rms_dialog_info_t *di, rms_action_t *a) goto error; } + rms_link_user(&di->local_uri, &luser); snprintf(buff, 256, "Max-Forwards: 70\r\nContact: " - "\r\nContent-Type: application/sdp\r\n", - di->local_ip.s, di->local_port); + "\r\nContent-Type: application/sdp\r\n", + luser.len, luser.s, di->local_ip.s, di->local_port); headers.len = strlen(buff); headers.s = buff; LM_INFO("si[%p]call-id[%.*s]cseq[%d]ruri[%d|%s]remote_uri[%s]local_uri[%s]" @@ -997,6 +1015,7 @@ static int rms_sip_forward( int result; str headers; char buff[1024]; + str luser; if(!rms_create_trans(msg)) return 0; @@ -1020,10 +1039,11 @@ static int rms_sip_forward( return 0; } + rms_link_user(&di->local_uri, &luser); snprintf(buff, 256, "Max-Forwards: 70\r\nContact: " - "\r\nContent-Type: application/sdp\r\n", - di->local_ip.s, di->local_port); + "\r\nContent-Type: application/sdp\r\n", + luser.len, luser.s, di->local_ip.s, di->local_port); headers.len = strlen(buff); headers.s = buff; ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] dmq_usrloc not replicating contact attributes (#1968)
Closed #1968 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1968#event-11497276431 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] dmq_usrloc not replicating contact attributes (#1968)
PR was merged, close -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1968#issuecomment-1893503466 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:167d8af9: core: snexpr - rename some inner blocks variables
Module: kamailio Branch: master Commit: 167d8af9ff1c55804a66cc948670ab1d3069e063 URL: https://github.com/kamailio/kamailio/commit/167d8af9ff1c55804a66cc948670ab1d3069e063 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-01-16T11:03:02+01:00 core: snexpr - rename some inner blocks variables --- Modified: src/core/utils/snexpr.h --- Diff: https://github.com/kamailio/kamailio/commit/167d8af9ff1c55804a66cc948670ab1d3069e063.diff Patch: https://github.com/kamailio/kamailio/commit/167d8af9ff1c55804a66cc948670ab1d3069e063.patch --- diff --git a/src/core/utils/snexpr.h b/src/core/utils/snexpr.h index cdfe55c45d8..5b159a256e3 100644 --- a/src/core/utils/snexpr.h +++ b/src/core/utils/snexpr.h @@ -1254,10 +1254,10 @@ extern "C" sne_vec_free(&arg.args); goto cleanup; /* first argument is not a variable */ } - struct snexpr_var *v; - for(v = vars->head; v; v = v->next) { - if(v == u->param.var.vref) { - struct macro m = {v->name, arg.args}; + struct snexpr_var *v1; + for(v1 = vars->head; v1; v1 = v1->next) { + if(v1 == u->param.var.vref) { + struct macro m = {v1->name, arg.args}; sne_vec_push(¯os, m); break; } @@ -1284,9 +1284,9 @@ extern "C" char varname[14]; snprintf(varname, sizeof(varname) - 1, "$%d", (j + 1)); - struct snexpr_var *v = snexpr_var_find( + struct snexpr_var *v1 = snexpr_var_find( vars, varname, strlen(varname)); - struct snexpr ev = snexpr_varref(v); + struct snexpr ev = snexpr_varref(v1); struct snexpr assign = snexpr_binary(SNE_OP_ASSIGN, ev, sne_vec_nth(&arg.args, j)); @@ -1409,10 +1409,10 @@ extern "C" cleanup: sne_vec_foreach(¯os, m, i) { - struct snexpr e; - sne_vec_foreach(&m.body, e, j) + struct snexpr e1; + sne_vec_foreach(&m.body, e1, j) { - snexpr_destroy_args(&e); + snexpr_destroy_args(&e1); } sne_vec_free(&m.body); } ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:6ebe3b61: ss7ops: rename local variable that hides the function parameter
Module: kamailio Branch: master Commit: 6ebe3b612d60e02854c7b88cd241615b50666b00 URL: https://github.com/kamailio/kamailio/commit/6ebe3b612d60e02854c7b88cd241615b50666b00 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-01-16T11:03:02+01:00 ss7ops: rename local variable that hides the function parameter --- Modified: src/modules/ss7ops/isup_parsed.c --- Diff: https://github.com/kamailio/kamailio/commit/6ebe3b612d60e02854c7b88cd241615b50666b00.diff Patch: https://github.com/kamailio/kamailio/commit/6ebe3b612d60e02854c7b88cd241615b50666b00.patch --- diff --git a/src/modules/ss7ops/isup_parsed.c b/src/modules/ss7ops/isup_parsed.c index 5ebc2d7f348..75a132435f8 100644 --- a/src/modules/ss7ops/isup_parsed.c +++ b/src/modules/ss7ops/isup_parsed.c @@ -1067,7 +1067,7 @@ static int do_parse( while(opt_left > 0) { uint8_t ie = opt_data[0]; - size_t len; + size_t len1; opt_data += 1; opt_left -= 1; @@ -1078,20 +1078,20 @@ static int do_parse( LM_ERR("ISUP no space for len %zu\n", opt_left); return -1; } - len = opt_data[0]; + len1 = opt_data[0]; opt_left -= 1; opt_data += 1; - if(opt_left < len) { + if(opt_left < len1) { LM_ERR("ISUP no space optional data %zu vs. %zu\n", opt_left, - len); + len1); return -1; } - visitor(ie, opt_data, len, ptr); + visitor(ie, opt_data, len1, ptr); - opt_data += len; - opt_left -= len; + opt_data += len1; + opt_left -= len1; } } ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] uac_req_send crash Kamailio (Issue #3522)
Hello, is there any news, update, investigation about this issue? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3522#issuecomment-1893343770 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: git:master:a752fde2: tls_wolfssl: update to v5.6.6-stable
Hello, is wolfssl git sub-module still needed to be included in Kamailio tree now that master branch has memory managers with 16bytes alignment? It would be good to just use libwolfssl from the OS distro. Cheers, Daniel On 16.01.24 09:12, S-P Chan via sr-dev wrote: > Module: kamailio > Branch: master > Commit: a752fde2fd2eb3615d16eb8940364ceea2f7d79c > URL: > https://github.com/kamailio/kamailio/commit/a752fde2fd2eb3615d16eb8940364ceea2f7d79c > > Author: S-P Chan > Committer: S-P Chan > Date: 2024-01-16T16:06:45+08:00 > > tls_wolfssl: update to v5.6.6-stable > > --- > > Modified: misc/external/wolfssl/wolfssl > > --- > > Diff: > https://github.com/kamailio/kamailio/commit/a752fde2fd2eb3615d16eb8940364ceea2f7d79c.diff > Patch: > https://github.com/kamailio/kamailio/commit/a752fde2fd2eb3615d16eb8940364ceea2f7d79c.patch > > --- > > diff --git a/misc/external/wolfssl/wolfssl b/misc/external/wolfssl/wolfssl > index 37884f864d6..66596ad9e1d 16 > --- a/misc/external/wolfssl/wolfssl > +++ b/misc/external/wolfssl/wolfssl > @@ -1 +1 @@ > -Subproject commit 37884f864d6fd9b04f44677cb04da15d0c9d6526 > +Subproject commit 66596ad9e1d7efa8479656872cf09c9c1870a02e > > ___ > Kamailio (SER) - Development Mailing List > To unsubscribe send an email to sr-dev-le...@lists.kamailio.org -- Daniel-Constantin Mierla (@ asipto.com) twitter.com/miconda -- linkedin.com/in/miconda Kamailio Consultancy, Training and Development Services -- asipto.com Kamailio Advanced Training, February 20-22, 2024 -- asipto.com Kamailio World Conference, April 18-19, 2024, Berlin -- kamailioworld.com ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: auto build failure
Hello Victor, thank you, yes seems to build now. Cheers, Henning > -Original Message- > From: Victor Seva via sr-dev > Sent: Dienstag, 16. Januar 2024 09:37 > To: sr-dev@lists.kamailio.org > Cc: linuxman...@torreviejawireless.org > Subject: [sr-dev] Re: auto build failure > > Hello, > > On 16/1/24 8:38, "Henning Westerholt via sr-dev" d...@lists.kamailio.org> wrote: > > Hello, > > > > the kamailio auto build is failing, I noticed after my last commit. But it > > seems > to be related to some docker issue: > > > > […] > > refreshed the images and commited a possible fix for registry login. Now it > seems to work fine. > > Cheers > > ___ > Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr- > dev-le...@lists.kamailio.org ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:5.7:d411c6ea: dialog: don't send the BYE if dialog is in deleted state (#3714)
Module: kamailio Branch: 5.7 Commit: d411c6ea4358e6d9dd367349e877ed5f5bf4bb2f URL: https://github.com/kamailio/kamailio/commit/d411c6ea4358e6d9dd367349e877ed5f5bf4bb2f Author: Federico Cabiddu Committer: Federico Cabiddu Date: 2024-01-16T09:51:14+01:00 dialog: don't send the BYE if dialog is in deleted state (#3714) (cherry picked from commit 695f155f3a127f0bbe220a6b44a0fc3887e1e4be) --- Modified: src/modules/dialog/dlg_req_within.c --- Diff: https://github.com/kamailio/kamailio/commit/d411c6ea4358e6d9dd367349e877ed5f5bf4bb2f.diff Patch: https://github.com/kamailio/kamailio/commit/d411c6ea4358e6d9dd367349e877ed5f5bf4bb2f.patch --- diff --git a/src/modules/dialog/dlg_req_within.c b/src/modules/dialog/dlg_req_within.c index aab22da3c64..fb5f2e51e32 100644 --- a/src/modules/dialog/dlg_req_within.c +++ b/src/modules/dialog/dlg_req_within.c @@ -383,6 +383,14 @@ static inline int send_bye(struct dlg_cell *cell, int dir, str *hdrs) dlg_iuid_t *iuid = NULL; str lhdrs; + /* dialog is already in deleted state, nothing to do */ + if(cell->state == DLG_STATE_DELETED) { + LM_WARN("dlg [%u:%u] with callid %.*s already in deleted state, BYE " + "not sent.\n", + cell->h_entry, cell->h_id, cell->callid.len, cell->callid.s); + return 0; + } + /* Send Cancel or final response for non-confirmed dialogs */ if(cell->state != DLG_STATE_CONFIRMED_NA && cell->state != DLG_STATE_CONFIRMED) { ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] dialog: don't send the BYE if dialog is in deleted state (PR #3714)
Merged #3714 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3714#event-11495736901 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:695f155f: dialog: don't send the BYE if dialog is in deleted state (#3714)
Module: kamailio Branch: master Commit: 695f155f3a127f0bbe220a6b44a0fc3887e1e4be URL: https://github.com/kamailio/kamailio/commit/695f155f3a127f0bbe220a6b44a0fc3887e1e4be Author: Federico Cabiddu Committer: GitHub Date: 2024-01-16T09:42:27+01:00 dialog: don't send the BYE if dialog is in deleted state (#3714) --- Modified: src/modules/dialog/dlg_req_within.c --- Diff: https://github.com/kamailio/kamailio/commit/695f155f3a127f0bbe220a6b44a0fc3887e1e4be.diff Patch: https://github.com/kamailio/kamailio/commit/695f155f3a127f0bbe220a6b44a0fc3887e1e4be.patch --- diff --git a/src/modules/dialog/dlg_req_within.c b/src/modules/dialog/dlg_req_within.c index aab22da3c64..fb5f2e51e32 100644 --- a/src/modules/dialog/dlg_req_within.c +++ b/src/modules/dialog/dlg_req_within.c @@ -383,6 +383,14 @@ static inline int send_bye(struct dlg_cell *cell, int dir, str *hdrs) dlg_iuid_t *iuid = NULL; str lhdrs; + /* dialog is already in deleted state, nothing to do */ + if(cell->state == DLG_STATE_DELETED) { + LM_WARN("dlg [%u:%u] with callid %.*s already in deleted state, BYE " + "not sent.\n", + cell->h_entry, cell->h_id, cell->callid.len, cell->callid.s); + return 0; + } + /* Send Cancel or final response for non-confirmed dialogs */ if(cell->state != DLG_STATE_CONFIRMED_NA && cell->state != DLG_STATE_CONFIRMED) { ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:5.7:b6796b11: tls_wolfssl: mask outer make DESTDIR=XX if building internal submodule
Module: kamailio Branch: 5.7 Commit: b6796b110adbe4dec7ac1acb1d7d70bdc58bf1c2 URL: https://github.com/kamailio/kamailio/commit/b6796b110adbe4dec7ac1acb1d7d70bdc58bf1c2 Author: S-P Chan Committer: S-P Chan Date: 2024-01-16T16:37:47+08:00 tls_wolfssl: mask outer make DESTDIR=XX if building internal submodule --- Modified: src/modules/tls_wolfssl/Makefile --- Diff: https://github.com/kamailio/kamailio/commit/b6796b110adbe4dec7ac1acb1d7d70bdc58bf1c2.diff Patch: https://github.com/kamailio/kamailio/commit/b6796b110adbe4dec7ac1acb1d7d70bdc58bf1c2.patch --- diff --git a/src/modules/tls_wolfssl/Makefile b/src/modules/tls_wolfssl/Makefile index 730076023a9..5ef95d697b6 100644 --- a/src/modules/tls_wolfssl/Makefile +++ b/src/modules/tls_wolfssl/Makefile @@ -30,7 +30,7 @@ $(WOLFSSL_PREFIX)/include/wolfssl/options.h $(WOLFSSL_PREFIX)/lib/libwolfssl.a: --prefix=$(CURDIR)/$(WOLFSSL_PREFIX) \ --exec-prefix=$(CURDIR)/$(WOLFSSL_PREFIX); \ fi; - @$(MAKE) -C $(WOLFSSL_SRC) prefix=$(CURDIR)/$(WOLFSSL_PREFIX) exec-prefix=$(CURDIR)/$(WOLFSSL_PREFIX) install + @$(MAKE) -C $(WOLFSSL_SRC) DESTDIR= prefix=$(CURDIR)/$(WOLFSSL_PREFIX) exec-prefix=$(CURDIR)/$(WOLFSSL_PREFIX) install $(NAME): $(WOLFSSL_PREFIX)/lib/libwolfssl.a ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: auto build failure
Hello, On 16/1/24 8:38, "Henning Westerholt via sr-dev" wrote: > Hello, > > the kamailio auto build is failing, I noticed after my last commit. But it > seems to be related to some docker issue: > > […] refreshed the images and commited a possible fix for registry login. Now it seems to work fine. Cheers ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:7e5843e2: tls_wolfssl: mask outer make DESTDIR=XX if building internal submodule
Module: kamailio Branch: master Commit: 7e5843e28dc4e331f434381defeb4cef43c5298f URL: https://github.com/kamailio/kamailio/commit/7e5843e28dc4e331f434381defeb4cef43c5298f Author: S-P Chan Committer: S-P Chan Date: 2024-01-16T16:36:57+08:00 tls_wolfssl: mask outer make DESTDIR=XX if building internal submodule --- Modified: src/modules/tls_wolfssl/Makefile --- Diff: https://github.com/kamailio/kamailio/commit/7e5843e28dc4e331f434381defeb4cef43c5298f.diff Patch: https://github.com/kamailio/kamailio/commit/7e5843e28dc4e331f434381defeb4cef43c5298f.patch --- diff --git a/src/modules/tls_wolfssl/Makefile b/src/modules/tls_wolfssl/Makefile index 1a6254ea7b2..dda5ad4779e 100644 --- a/src/modules/tls_wolfssl/Makefile +++ b/src/modules/tls_wolfssl/Makefile @@ -37,7 +37,7 @@ $(WOLFSSL_PREFIX)/include/wolfssl/options.h $(WOLFSSL_PREFIX)/lib/libwolfssl.a: --prefix=$(CURDIR)/$(WOLFSSL_PREFIX) \ --exec-prefix=$(CURDIR)/$(WOLFSSL_PREFIX); \ fi; - @$(MAKE) -C $(WOLFSSL_SRC) prefix=$(CURDIR)/$(WOLFSSL_PREFIX) exec-prefix=$(CURDIR)/$(WOLFSSL_PREFIX) install + @$(MAKE) -C $(WOLFSSL_SRC) DESTDIR= prefix=$(CURDIR)/$(WOLFSSL_PREFIX) exec-prefix=$(CURDIR)/$(WOLFSSL_PREFIX) install $(NAME): $(WOLFSSL_PREFIX)/lib/libwolfssl.a ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:4df93942: github: add default registry credentials [skip ci]
Module: kamailio Branch: master Commit: 4df939428555f8c4fde67f7b8638809aca56c9f2 URL: https://github.com/kamailio/kamailio/commit/4df939428555f8c4fde67f7b8638809aca56c9f2 Author: Victor Seva Committer: Victor Seva Date: 2024-01-16T09:34:38+01:00 github: add default registry credentials [skip ci] > https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idcontainercredentials --- Modified: .github/workflows/main.yml Modified: .github/workflows/pull_request.yml --- Diff: https://github.com/kamailio/kamailio/commit/4df939428555f8c4fde67f7b8638809aca56c9f2.diff Patch: https://github.com/kamailio/kamailio/commit/4df939428555f8c4fde67f7b8638809aca56c9f2.patch --- diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 8f1d028cda8..86b05df1822 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -13,6 +13,9 @@ jobs: contents: read # to fetch code (actions/checkout) container: image: ghcr.io/kamailio/pkg-kamailio-docker:${{ github.ref_name }}-${{ matrix.distribution }} + credentials: +username: ${{ github.actor }} +password: ${{ secrets.GITHUB_TOKEN }} volumes: - ${{ github.workspace }}:/code env: diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index a2fc539ddfc..cda04d04389 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -22,6 +22,9 @@ jobs: contents: read # to fetch code (actions/checkout) container: image: ghcr.io/kamailio/pkg-kamailio-docker:master-${{ matrix.distribution }} + credentials: +username: ${{ github.actor }} +password: ${{ secrets.GITHUB_TOKEN }} volumes: - ${{ github.workspace }}:/code env: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:5.7:d5ebc271: tls_wolfssl: update to v5.6.6-stable
Module: kamailio Branch: 5.7 Commit: d5ebc2716992c2480c60411511ce043bead7 URL: https://github.com/kamailio/kamailio/commit/d5ebc2716992c2480c60411511ce043bead7 Author: S-P Chan Committer: S-P Chan Date: 2024-01-16T16:13:55+08:00 tls_wolfssl: update to v5.6.6-stable --- Modified: misc/external/wolfssl/wolfssl --- Diff: https://github.com/kamailio/kamailio/commit/d5ebc2716992c2480c60411511ce043bead7.diff Patch: https://github.com/kamailio/kamailio/commit/d5ebc2716992c2480c60411511ce043bead7.patch --- diff --git a/misc/external/wolfssl/wolfssl b/misc/external/wolfssl/wolfssl index 3b3c175af0e..66596ad9e1d 16 --- a/misc/external/wolfssl/wolfssl +++ b/misc/external/wolfssl/wolfssl @@ -1 +1 @@ -Subproject commit 3b3c175af0e993ffaae251871421e206cc41963f +Subproject commit 66596ad9e1d7efa8479656872cf09c9c1870a02e ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:a752fde2: tls_wolfssl: update to v5.6.6-stable
Module: kamailio Branch: master Commit: a752fde2fd2eb3615d16eb8940364ceea2f7d79c URL: https://github.com/kamailio/kamailio/commit/a752fde2fd2eb3615d16eb8940364ceea2f7d79c Author: S-P Chan Committer: S-P Chan Date: 2024-01-16T16:06:45+08:00 tls_wolfssl: update to v5.6.6-stable --- Modified: misc/external/wolfssl/wolfssl --- Diff: https://github.com/kamailio/kamailio/commit/a752fde2fd2eb3615d16eb8940364ceea2f7d79c.diff Patch: https://github.com/kamailio/kamailio/commit/a752fde2fd2eb3615d16eb8940364ceea2f7d79c.patch --- diff --git a/misc/external/wolfssl/wolfssl b/misc/external/wolfssl/wolfssl index 37884f864d6..66596ad9e1d 16 --- a/misc/external/wolfssl/wolfssl +++ b/misc/external/wolfssl/wolfssl @@ -1 +1 @@ -Subproject commit 37884f864d6fd9b04f44677cb04da15d0c9d6526 +Subproject commit 66596ad9e1d7efa8479656872cf09c9c1870a02e ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] dialog: don't send the BYE if dialog is in deleted state (PR #3714)
Thanks, fine for me to merge it. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3714#issuecomment-1893236937 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org