[sr-dev] Re: [kamailio/kamailio] Dialog DMQ sync: Timer needs fixing, firing on wrong node! (Issue #3656)

2024-01-22 Thread github-actions[bot] via sr-dev 
This issue is stale because it has been open 6 weeks with no activity. Remove 
stale label or comment or this will be closed in 2 weeks.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3656#issuecomment-1905194869
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] Silence “make: --libs: No such file or directory” warnings (PR #3475)

2024-01-22 Thread github-actions[bot] via sr-dev 
Closed #3475.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3475#event-11564226634
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] cfgt: doesn't support tm_suspend() tm_continue() (#684)

2024-01-22 Thread github-actions[bot] via sr-dev 
Closed #684 as not planned.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/684#event-11564226452
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] github: [skip ci]: bump tj-actions/changed-files from 41 to 42 (PR #3724)

2024-01-22 Thread Victor Seva via sr-dev 
Merged #3724 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3724#event-11563362666
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:100d96bf: github: [skip ci]: bump tj-actions/changed-files from 41 to 42

2024-01-22 Thread Victor Seva via sr-dev 
Module: kamailio
Branch: master
Commit: 100d96bf3819082ac38f8a4fae1f3c64c8d0c5e1
URL: 
https://github.com/kamailio/kamailio/commit/100d96bf3819082ac38f8a4fae1f3c64c8d0c5e1

Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Committer: Victor Seva 
Date: 2024-01-23T01:06:07+01:00

github: [skip ci]: bump tj-actions/changed-files from 41 to 42

Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) 
from 41 to 42.
- [Release notes](https://github.com/tj-actions/changed-files/releases)
- [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md)
- [Commits](https://github.com/tj-actions/changed-files/compare/v41...v42)

---
updated-dependencies:
- dependency-name: tj-actions/changed-files
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] 

---

Modified: .github/workflows/devcontainer.yaml

---

Diff:  
https://github.com/kamailio/kamailio/commit/100d96bf3819082ac38f8a4fae1f3c64c8d0c5e1.diff
Patch: 
https://github.com/kamailio/kamailio/commit/100d96bf3819082ac38f8a4fae1f3c64c8d0c5e1.patch

---

diff --git a/.github/workflows/devcontainer.yaml 
b/.github/workflows/devcontainer.yaml
index 1c2a584ed84..2da1e56c742 100644
--- a/.github/workflows/devcontainer.yaml
+++ b/.github/workflows/devcontainer.yaml
@@ -33,14 +33,14 @@ jobs:
   - name: Get changed files
 if: ${{ ! inputs.force }}
 id: changed-files
-uses: tj-actions/changed-files@v41
+uses: tj-actions/changed-files@v42
 with:
   since_last_remote_commit: true
 
   - name: changes in relevant files
 if: ${{ ! inputs.force }}
 id: changed-files-builder
-uses: tj-actions/changed-files@v41
+uses: tj-actions/changed-files@v42
 with:
   files: |
 .devcontainer/**

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] TLS related crash in Kamailio 5.7.2 (double free) with libssl 3.x Ubuntu 22.04 (Issue #3635)

2024-01-22 Thread space88man via sr-dev 
Fixes back-ported to 5.7 and available with 5.7.4 release.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3635#issuecomment-1905022812
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] [kamailio/kamailio] github: [skip ci]: bump tj-actions/changed-files from 41 to 42 (PR #3724)

2024-01-22 Thread dependabot[bot] via sr-dev 
Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) 
from 41 to 42.
details
summaryRelease notes/summary
pemSourced from a 
href=https://github.com/tj-actions/changed-files/releasestj-actions/changed-filess
 releases/a./em/p
blockquote
h2v42/h2
h1Changes in v42.0.0/h1
h2 BREAKING CHANGE /h2
ul
liInput file patterns that end with a code//code would 
now match all sub-files within the directory without requiring you to specify 
the globstar pattern./li
/ul
h3/h3
pre lang=yamlcode...
  - name: Get changed files
id: changed-files
uses: tj-actions/changed-files@v42
with:
  files: dir/  # Would also be the same as dir/** 
/code/pre
h2Whats Changed/h2
ul
liUpgraded to v41.1.2 by a 
href=https://github.com/tj-actions-botcode@​tj-actions-bot/code/a;
 in a 
href=https://redirect.github.com/tj-actions/changed-files/pull/1869tj-actions/changed-files#1869/a/li;
lichore(deps): update dependency prettier to v3.2.4 by a 
href=https://github.com/renovatecode@​renovate/code/a;
 in a 
href=https://redirect.github.com/tj-actions/changed-files/pull/1871tj-actions/changed-files#1871/a/li;
lifix: update input warning by a 
href=https://github.com/jackton1code@​jackton1/code/a;
 in a 
href=https://redirect.github.com/tj-actions/changed-files/pull/1870tj-actions/changed-files#1870/a/li;
lirename: unsupported REST API inputs constant name by a 
href=https://github.com/jackton1code@​jackton1/code/a;
 in a 
href=https://redirect.github.com/tj-actions/changed-files/pull/1872tj-actions/changed-files#1872/a/li;
lifeat: add support for include/exclude all nested files when a 
directory is specified and ends with a slash by a 
href=https://github.com/jackton1code@​jackton1/code/a;
 in a 
href=https://redirect.github.com/tj-actions/changed-files/pull/1873tj-actions/changed-files#1873/a/li;
/ul
pstrongFull Changelog/strong: a 
href=https://github.com/tj-actions/changed-files/compare/v41...v42.0.0https://github.com/tj-actions/changed-files/compare/v41...v42.0.0/a/p;
hr /
h2v42.0.0/h2
h2 BREAKING CHANGE /h2
ul
liInput file patterns that end with a code//code would 
now match all sub-files within the directory without requiring you to specify 
the globstar pattern./li
/ul
h3/h3
pre lang=yamlcode...
  - name: Get changed files
id: changed-files
uses: tj-actions/changed-files@v42
with:
  files: dir/  # Would also be the same as dir/** 
/code/pre
h2Whats Changed/h2
ul
liUpgraded to v41.1.2 by a 
href=https://github.com/tj-actions-botcode@​tj-actions-bot/code/a;
 in a 
href=https://redirect.github.com/tj-actions/changed-files/pull/1869tj-actions/changed-files#1869/a/li;
lichore(deps): update dependency prettier to v3.2.4 by a 
href=https://github.com/renovatecode@​renovate/code/a;
 in a 
href=https://redirect.github.com/tj-actions/changed-files/pull/1871tj-actions/changed-files#1871/a/li;
lifix: update input warning by a 
href=https://github.com/jackton1code@​jackton1/code/a;
 in a 
href=https://redirect.github.com/tj-actions/changed-files/pull/1870tj-actions/changed-files#1870/a/li;
lirename: unsupported REST API inputs constant name by a 
href=https://github.com/jackton1code@​jackton1/code/a;
 in a 
href=https://redirect.github.com/tj-actions/changed-files/pull/1872tj-actions/changed-files#1872/a/li;
lifeat: add support for include/exclude all nested files when a 
directory is specified and ends with a slash by a 
href=https://github.com/jackton1code@​jackton1/code/a;
 in a 
href=https://redirect.github.com/tj-actions/changed-files/pull/1873tj-actions/changed-files#1873/a/li;
/ul
!-- raw HTML omitted --
/blockquote
p... (truncated)/p
/details
details
summaryChangelog/summary
pemSourced from a 
href=https://github.com/tj-actions/changed-files/blob/main/HISTORY.mdtj-actions/changed-filess
 changelog/a./em/p
blockquote
h1Changelog/h1
h1a 
href=https://github.com/tj-actions/changed-files/compare/v41.1.2...v42.0.042.0.0/a;
 - (2024-01-18)/h1
h2!-- raw HTML omitted -- Features/h2
ul
liAdd support for include/exclude all nested files when a directory is 
specified and ends with a slash (a 
href=https://redirect.github.com/tj-actions/changed-files/issues/1873#1873/a;)
 (a 
href=https://github.com/tj-actions/changed-files/commit/ae82ed4ae04587b665efad2f206578aa6f0e8539ae82ed4/a;)
  - (Tonye Jack)/li
/ul
h2!-- raw HTML omitted -- Bug Fixes/h2
ul
liUpdate input warning (a 
href=https://redirect.github.com/tj-actions/changed-files/issues/1870#1870/a;)
 (a 
href=https://github.com/tj-actions/changed-files/commit/6c9dcea4432fd0eb2f3e07c9149eab2807ce44b26c9dcea/a;)
  - (Tonye Jack)/li
/ul
h2!-- raw HTML omitted -- Rename/h2
ul
liUnsupported REST API inputs constant name (a 
href=https://redirect.github.com/tj-actions/changed-files/issues/1872#1872/a;)
 (a 
href=https://github.com/tj-actions/changed-files/commit/cbd59070e8276b539ecdfa0f2316db7b1599ea0fcbd5907/a;)
  - (Tonye Jack)/li
/ul
h2!-- raw HTML omitted --⚙️ Miscellaneous Tasks/h2
ul

[sr-dev] [kamailio/kamailio] xhttp: fix execution of async functions (PR #3723)

2024-01-22 Thread Vadim Saranov via sr-dev 
!-- Kamailio Pull Request Template --

 Pre-Submission Checklist
!-- Go over all points below, and after creating the PR, tick all the 
checkboxes that apply --
!-- All points should be verified, otherwise, read the CONTRIBUTING 
guidelines from above--
!-- If youre unsure about any of these, dont hesitate to ask on 
sr-dev mailing list --
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, 
...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook 
files
in `doc/` subfolder, the README file is autogenerated)

 Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

 Checklist:
!-- Go over all points below, and after creating the PR, tick the 
checkboxes that apply --
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [x] Related to issue #3720

 Description
Fixing R-RURI and adding necessary headers when creating fake_msg in 
xhttp_mod.c for successful message validation and the ability to perform 
various kamailio functions from event_route[xhttp:request].
You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/3723

-- Commit Summary --

  * xhttp: fix execution of async functions

-- File Changes --

M src/modules/xhttp/xhttp_mod.c (39)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/3723.patch
https://github.com/kamailio/kamailio/pull/3723.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3723
You are receiving this because you are subscribed to this thread.

Message ID: kamailio/kamailio/pull/3...@github.com
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:15aafe49: presence: prefix short global variables

2024-01-22 Thread Daniel-Constantin Mierla via sr-dev 
Module: kamailio
Branch: master
Commit: 15aafe49a6a022809f278f596812c97dc5404982
URL: 
https://github.com/kamailio/kamailio/commit/15aafe49a6a022809f278f596812c97dc5404982

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2024-01-22T13:25:04+01:00

presence: prefix short global variables

---

Modified: src/modules/presence/notify.c
Modified: src/modules/presence/presence.c
Modified: src/modules/presence/presence.h
Modified: src/modules/presence/presentity.c
Modified: src/modules/presence/subscribe.c
Modified: src/modules/presence/utils_func.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/15aafe49a6a022809f278f596812c97dc5404982.diff
Patch: 
https://github.com/kamailio/kamailio/commit/15aafe49a6a022809f278f596812c97dc5404982.patch

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:c3b47e0c: core: parser - flag to mark request when a local final reply is sent

2024-01-22 Thread Daniel-Constantin Mierla via sr-dev 
Module: kamailio
Branch: master
Commit: c3b47e0c5cf4ed405b02aa2d0d4cb31073bab0aa
URL: 
https://github.com/kamailio/kamailio/commit/c3b47e0c5cf4ed405b02aa2d0d4cb31073bab0aa

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2024-01-22T13:50:08+01:00

core: parser - flag to mark request when a local final reply is sent

---

Modified: src/core/parser/msg_parser.h

---

Diff:  
https://github.com/kamailio/kamailio/commit/c3b47e0c5cf4ed405b02aa2d0d4cb31073bab0aa.diff
Patch: 
https://github.com/kamailio/kamailio/commit/c3b47e0c5cf4ed405b02aa2d0d4cb31073bab0aa.patch

---

diff --git a/src/core/parser/msg_parser.h b/src/core/parser/msg_parser.h
index 67650523451..303c8c04248 100644
--- a/src/core/parser/msg_parser.h
+++ b/src/core/parser/msg_parser.h
@@ -133,6 +133,8 @@ typedef enum request_method
 /* WARNING: Value (1 << 31) is reserved for use in kamailio
  * nat_traversal module (flag FL_DO_KEEPALIVE)! */
 
+#define FL_FINAL_REPLY (1ULL << 32) /* final reply sent */
+
 #define FL_MTU_FB_MASK (FL_MTU_TCP_FB | FL_MTU_TLS_FB | FL_MTU_SCTP_FB)
 
 

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:7da07508: presence: removed unused external variable

2024-01-22 Thread Daniel-Constantin Mierla via sr-dev 
Module: kamailio
Branch: master
Commit: 7da07508bc74a6a0c87e1dc7993d0061b65e2faa
URL: 
https://github.com/kamailio/kamailio/commit/7da07508bc74a6a0c87e1dc7993d0061b65e2faa

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2024-01-22T13:18:15+01:00

presence: removed unused external variable

---

Modified: src/modules/presence/publish.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/7da07508bc74a6a0c87e1dc7993d0061b65e2faa.diff
Patch: 
https://github.com/kamailio/kamailio/commit/7da07508bc74a6a0c87e1dc7993d0061b65e2faa.patch

---

diff --git a/src/modules/presence/publish.c b/src/modules/presence/publish.c
index 2399ff43e10..fa39498d986 100644
--- a/src/modules/presence/publish.c
+++ b/src/modules/presence/publish.c
@@ -46,8 +46,6 @@
 #include "publish.h"
 #include "presentity.h"
 
-extern gen_lock_set_t *set;
-
 static str pu_400a_rpl = str_init("Bad request");
 static str pu_400b_rpl = str_init("Invalid request");
 static str pu_500_rpl = str_init("Server Internal Error");
@@ -713,4 +711,4 @@ int update_hard_presentity(
}
 
return ret;
-}
\ No newline at end of file
+}

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:1a2477ba: sl: mark request with final reply flag

2024-01-22 Thread Daniel-Constantin Mierla via sr-dev 
Module: kamailio
Branch: master
Commit: 1a2477ba348928e6bdff15be765cb907e32cffc4
URL: 
https://github.com/kamailio/kamailio/commit/1a2477ba348928e6bdff15be765cb907e32cffc4

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2024-01-22T14:02:47+01:00

sl: mark request with final reply flag

- send error function checks flag and returns if set to avoid sending
  more than one final reply in case of failures

---

Modified: src/modules/sl/sl.c
Modified: src/modules/sl/sl_funcs.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/1a2477ba348928e6bdff15be765cb907e32cffc4.diff
Patch: 
https://github.com/kamailio/kamailio/commit/1a2477ba348928e6bdff15be765cb907e32cffc4.patch

---

diff --git a/src/modules/sl/sl.c b/src/modules/sl/sl.c
index 2a8f49fe78c..83eb8bac0d3 100644
--- a/src/modules/sl/sl.c
+++ b/src/modules/sl/sl.c
@@ -335,6 +335,12 @@ static int w_send_reply(struct sip_msg *msg, char *p1, 
char *p2)
 static int ki_send_reply_error(sip_msg_t *msg)
 {
int ret;
+
+   if(msg->msg_flags & FL_FINAL_REPLY) {
+   LM_INFO("message marked with final-reply flag\n");
+   return -2;
+   }
+
if(sl_bind_tm != 0 && tmb.t_reply_error != NULL) {
ret = tmb.t_reply_error(msg);
if(ret > 0) {
diff --git a/src/modules/sl/sl_funcs.c b/src/modules/sl/sl_funcs.c
index 253686a4a77..29ef6835e22 100644
--- a/src/modules/sl/sl_funcs.c
+++ b/src/modules/sl/sl_funcs.c
@@ -337,6 +337,10 @@ int sl_reply_helper(struct sip_msg *msg, int code, char 
*reason, str *tag)
goto error;
}
 
+   if(code >= 200) {
+   msg->msg_flags |= FL_FINAL_REPLY;
+   }
+
update_sl_stats(code);
return 1;
 
@@ -408,6 +412,11 @@ int sl_reply_error(struct sip_msg *msg)
return -2;
}
 
+   if(msg->msg_flags & FL_FINAL_REPLY) {
+   LM_INFO("message marked with final-reply flag\n");
+   return -2;
+   }
+
ret = err2reason_phrase(
prev_ser_error, _error, err_buf, sizeof(err_buf), 
"SL");
if(ret > 0) {

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:569b5364: tm: mark request with final reply flag

2024-01-22 Thread Daniel-Constantin Mierla via sr-dev 
Module: kamailio
Branch: master
Commit: 569b536404afd855742a42320d7c858a8bb4952b
URL: 
https://github.com/kamailio/kamailio/commit/569b536404afd855742a42320d7c858a8bb4952b

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2024-01-22T14:11:29+01:00

tm: mark request with final reply flag

- send error function checks flag and returns if set to avoid sending
  more than one final reply in case of failure

---

Modified: src/modules/tm/t_reply.c
Modified: src/modules/tm/tm.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/569b536404afd855742a42320d7c858a8bb4952b.diff
Patch: 
https://github.com/kamailio/kamailio/commit/569b536404afd855742a42320d7c858a8bb4952b.patch

---

diff --git a/src/modules/tm/t_reply.c b/src/modules/tm/t_reply.c
index f52ecc7d3ad..e012dc29c28 100644
--- a/src/modules/tm/t_reply.c
+++ b/src/modules/tm/t_reply.c
@@ -640,6 +640,11 @@ static int _reply_light(struct cell *trans, char *buf, 
unsigned int len,
 * (timer_allow_del()) (there's no chance of having the wait 
handler
 *  executed while we still need t) --andrei */
put_on_wait(trans);
+
+   /* mark the request with final reply flag */
+   if(trans->uas.request != NULL) {
+   trans->uas.request->msg_flags |= FL_FINAL_REPLY;
+   }
}
pkg_free(buf);
LM_DBG("finished\n");
diff --git a/src/modules/tm/tm.c b/src/modules/tm/tm.c
index 0be958a0848..0147bf44579 100644
--- a/src/modules/tm/tm.c
+++ b/src/modules/tm/tm.c
@@ -1608,6 +1608,11 @@ int ki_t_reply_error(sip_msg_t *msg)
int sip_err;
int ret;
 
+   if(msg->msg_flags & FL_FINAL_REPLY) {
+   LM_INFO("message marked with final-reply flag\n");
+   return -2;
+   }
+
ret = err2reason_phrase(
prev_ser_error, _err, err_buffer, 
sizeof(err_buffer), "TM");
if(ret > 0) {

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] uac_req_send crash Kamailio (Issue #3522)

2024-01-22 Thread Sergii via sr-dev 
I'm trying to do following registration to asterisk pool:

ds_select("BACKENDS","0");
while(ds_set_dst()) {
xlog("L_DBG",">>> BACKEND du=$du\n");
$uac_req(ruri)="sip:" + $(du{uri.host});
$uac_req(furi)="sip:" + $avp(username) + "@" + $(du{uri.host});
$uac_req(turi)=$uac_req(furi);
uac_req_send();
ds_next_dst();
}


But it looks like "REGISTER" is not leaving my Kamailio server. 
Can anyone help me out with this?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3522#issuecomment-1903873720
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] Debian package build fails for Kamailio 5.7.4 (Issue #3722)

2024-01-22 Thread Alexander Bakker via sr-dev 
@linuxmaniac Right, but in ``pkg/kamailio/deb/bookworm/rules``:

```
export LIBDIR ?= lib/$(DEB_HOST_MULTIARCH)
```

Happens after:

```
export LIBSSL_STATIC_SRCPATH=/usr/$(LIBDIR)
```

So when ``LIBSSL_STATIC_SRCPATH`` is set, ``LIBDIR`` contains a value from 
someplace else.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3722#issuecomment-1903738978
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] Debian package build fails for Kamailio 5.7.4 (Issue #3722)

2024-01-22 Thread Victor Seva via sr-dev 
Closed #3722 as completed.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3722#event-11554684420
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] Debian package build fails for Kamailio 5.7.4 (Issue #3722)

2024-01-22 Thread Victor Seva via sr-dev 
simple test Makefile:
```
#!/usr/bin/make -f

# Uncomment this to turn on verbose mode.
#export DH_VERBOSE=1

include /usr/share/dpkg/architecture.mk

# Name of libdir in the path for libraries (e.g., the multiarch triplet).
export LIBDIR ?= lib/$(DEB_HOST_MULTIARCH)

all:
@echo LIBDIR=$(LIBDIR)
```

```shell
make
echo LIBDIR=lib/x86_64-linux-gnu
LIBDIR=lib/x86_64-linux-gnu
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3722#issuecomment-1903682814
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] Debian package build fails for Kamailio 5.7.4 (Issue #3722)

2024-01-22 Thread Victor Seva via sr-dev 
>From 
>https://kamailio.sipwise.com/view/kam5.7/job/kamailio57-binaries/architecture=amd64,distribution=bookworm/5/consoleText
```
gcc -fPIC -DPIC -funroll-loops -Wcast-align -m64 -minline-all-stringops 
-falign-loops -ftree-vectorize -fno-strict-overflow -mtune=generic -pthread 
-DKSR_PTHREAD_MUTEX_SHARED -Wall -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 
-ffile-prefix-map=/build/kamailio-5.7.4+bpo12=. -fstack-protector-strong 
-Wformat -Werror=format-security -DVERSION_NODATE   -DNAME='"kamailio"' 
-DVERSION='"5.7.4"' -DARCH='"x86_64"' -DOS='linux_' -DOS_QUOTED='"linux"' 
-DCOMPILER='"gcc 12.2.0"' -D__CPU_x86_64 -D__OS_linux -DVERSIONVAL=5007004 
-DCFG_DIR='"/etc/kamailio/"' -DSHARE_DIR='"/usr/share/kamailio/"' 
-DRUN_DIR='"/var/run/kamailio/"' -DPKG_MALLOC -DSHM_MMAP -DDNS_IP_HACK 
-DUSE_MCAST -DUSE_TCP -DDISABLE_NAGLE -DHAVE_RESOLV_RES -DUSE_DNS_CACHE 
-DUSE_DNS_FAILOVER -DUSE_DST_BLOCKLIST -DUSE_NAPTR -DWITH_XAVP -DMEM_JOIN_FREE 
-DF_MALLOC -DQ_MALLOC -DTLSF_MALLOC -DDBG_SR_MEMORY -DUSE_TLS -DTLS_HOOKS 
-DUSE_CORE_STATS -DSTATISTICS -DMALLOC_STATS -DUSE_SCTP -DFAST_LOCK 
-DADAPTIVE_WAIT -DADAPTIVE_WAIT_LOOPS=1024 -DCC_GCC_LIKE_ASM 
-DHAVE_GETHOSTBYNAME2 -DHAVE_UNION_SEMUN -DHAVE_SCHED_YIELD -DHAVE_MSG_NOSIGNAL 
-DHAVE_MSGHDR_MSG_CONTROL -DHAVE_ALLOCA_H -DHAVE_TIMEGM 
-DHAVE_SCHED_SETSCHEDULER -DHAVE_IP_MREQN -DUSE_RAW_SOCKS -DHAVE_EPOLL 
-DHAVE_SIGIO_RT -DSIGINFO64_WORKAROUND -DUSE_FUTEX -DHAVE_SELECT  
-DKSR_LIBSSL_STATIC -I/usr/lib/x86_64-linux-gnu/include -DMOD_NAME='"tlsa"' -c 
tls_bio.c -o tls_bio.o -MMD -MP
```

so it's using the proper path :
```
-DKSR_LIBSSL_STATIC -I/usr/lib/x86_64-linux-gnu/include -DMOD_NAME='"tlsa"'
```


-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3722#issuecomment-1903571256
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] [kamailio/kamailio] Debian package build fails for Kamailio 5.7.4 (Issue #3722)

2024-01-22 Thread Alexander Bakker via sr-dev 
### Description

The Debian package build fails for Kamailio 5.7.4 because it can't find static 
libssl. This happens because ``LIBSSL_STATIC_SRCPATH`` is set to the wrong 
location in the rules file.

### Troubleshooting

 Reproduction

1. Run ``ln -s pkg/kamailio/deb/bookworm debian``
2. Run ``make deb``

 Output

```
gcc -shared -g -m64 -Wl,-O2 -Wl,-E  -Wl,-z,relro -pthread -rdynamic "-ldl" 
-Wl,-Bsymbolic-functions tls_bio.o tls_cfg.o tls_config.o tls_ct_wrq.o 
tls_domain.o tls_dump_vf.o tls_init.o tls_locking.o tls_map.o tls_rand.o 
tls_rpc.o tls_select.o tls_server.o tls_util.o tls_verify.o tlsa_mod.o  -lm 
/usr/lib64/libssl.a /usr/lib64/libcrypto.a   -o tlsa.so
/usr/bin/ld: cannot find /usr/lib64/libssl.a: No such file or directory
/usr/bin/ld: cannot find /usr/lib64/libcrypto.a: No such file or directory
collect2: error: ld returned 1 exit status
make[5]: *** [../../Makefile.rules:191: tlsa.so] Error 1
```

### Possible Solutions

An extremely hacky workaround is to patch the rules file to point 
``LIBSSL_STATIC_SRCPATH`` to the right location:

```
sed -i -e "/LIBSSL_STATIC_SRCPATH/a export\\ 
LIBSSL_STATIC_SRCPATH=\\/usr\\/lib\\/$(uname -m)-linux-gnu" 
pkg/kamailio/deb/bookworm/rules
```

### Additional Information

  * **Kamailio Version** - output of `kamailio -v`

```
version: kamailio 5.7.4 (x86_64/linux) 
flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, 
USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, 
F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, 
USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, 
TLS_PTHREAD_MUTEX_SHARED
ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, 
BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: unknown 
compiled with gcc 12.2.0
```

* **Operating System**:

```
Distributor ID: Debian
Description:Debian GNU/Linux 12 (bookworm)
Release:12
Codename:   bookworm
```

```
Linux 6.5.0-14-generic #14-Ubuntu SMP PREEMPT_DYNAMIC Tue Nov 14 14:59:49 UTC 
2023 x86_64 GNU/Linux
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3722
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:e8ee31f6: lib/cds: reviewed and removed old comments

2024-01-22 Thread Daniel-Constantin Mierla via sr-dev 
Module: kamailio
Branch: master
Commit: e8ee31f6bce32050f8caaa8d053ddaea8d99cc1d
URL: 
https://github.com/kamailio/kamailio/commit/e8ee31f6bce32050f8caaa8d053ddaea8d99cc1d

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2024-01-20T12:16:13+01:00

lib/cds: reviewed and removed old comments

---

Modified: src/lib/cds/dbid.c
Modified: src/lib/cds/simple_profile.c
Modified: src/lib/cds/sstr.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/e8ee31f6bce32050f8caaa8d053ddaea8d99cc1d.diff
Patch: 
https://github.com/kamailio/kamailio/commit/e8ee31f6bce32050f8caaa8d053ddaea8d99cc1d.patch

---

diff --git a/src/lib/cds/dbid.c b/src/lib/cds/dbid.c
index 5eb2ab20edc..fc4a47deb6d 100644
--- a/src/lib/cds/dbid.c
+++ b/src/lib/cds/dbid.c
@@ -9,7 +9,6 @@
 void generate_dbid_ptr(dbid_t dst, void *data_ptr)
 {
/* TODO: add cluster distinctive member */
-   /* FIXME: replace sprintf by something more effective */
snprintf(dst, MAX_DBID_LEN, "%px%xx%x", data_ptr, (int)time(NULL), 
rand());
 }
 
@@ -26,7 +25,6 @@ void generate_dbid(dbid_t dst)
}
 
/* TODO: add cluster distinctive member */
-   /* FIXME: replace sprintf by something more effective */
snprintf(dst, MAX_DBID_LEN, "%xy%xy%xy%x", my_pid, cntr++, 
(int)time(NULL),
rand());
 }
diff --git a/src/lib/cds/simple_profile.c b/src/lib/cds/simple_profile.c
index f166ec8b0db..f20211776a0 100644
--- a/src/lib/cds/simple_profile.c
+++ b/src/lib/cds/simple_profile.c
@@ -4,9 +4,6 @@
 #include 
 #include 
 
-/* FIXME: only for testing */
-/*#include "dprint.h"*/
-
 #define trace_signal SIGTRAP
 
 typedef void (*_sig_t)(int);
diff --git a/src/lib/cds/sstr.c b/src/lib/cds/sstr.c
index 5b065fdcbe5..a342fbb26dc 100644
--- a/src/lib/cds/sstr.c
+++ b/src/lib/cds/sstr.c
@@ -263,7 +263,6 @@ char *str_strchr(const str_t *s, char c)
 char *str_str(const str_t *s, const str_t *search_for)
 {
int i, j;
-   /* FIXME: reimplement using better algorithm */
 
if(is_str_empty(search_for))
return s->s;

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:67f71d1b: lib/xcap: reviewed and removed old comments and disabled code

2024-01-22 Thread Daniel-Constantin Mierla via sr-dev 
Module: kamailio
Branch: master
Commit: 67f71d1b7c44a7d3ef1ba2917272e2ba36608cd7
URL: 
https://github.com/kamailio/kamailio/commit/67f71d1b7c44a7d3ef1ba2917272e2ba36608cd7

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2024-01-20T12:37:12+01:00

lib/xcap: reviewed and removed old comments and disabled code

---

Modified: src/lib/xcap/common_policy.c
Modified: src/lib/xcap/parse_common_rules.c
Modified: src/lib/xcap/resource_list.c
Modified: src/lib/xcap/xcap_client.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/67f71d1b7c44a7d3ef1ba2917272e2ba36608cd7.diff
Patch: 
https://github.com/kamailio/kamailio/commit/67f71d1b7c44a7d3ef1ba2917272e2ba36608cd7.patch

---

diff --git a/src/lib/xcap/common_policy.c b/src/lib/xcap/common_policy.c
index a7d33d95d5d..0f887aa7ce7 100644
--- a/src/lib/xcap/common_policy.c
+++ b/src/lib/xcap/common_policy.c
@@ -175,7 +175,7 @@ int is_rule_for_uri(cp_rule_t *rule, const str_t *uri)
if(!rule)
return 0;
if(!rule->conditions)
-   return 1; /* FIXME: ??? */
+   return 1;
id = rule->conditions->identity;
if(!id)
return 0;
diff --git a/src/lib/xcap/parse_common_rules.c 
b/src/lib/xcap/parse_common_rules.c
index 0e46ace7161..ca3f4599c06 100644
--- a/src/lib/xcap/parse_common_rules.c
+++ b/src/lib/xcap/parse_common_rules.c
@@ -211,13 +211,11 @@ static int read_conditions(xmlNode *cn, cp_conditions_t 
**dst)
while(n) {
if(n->type == XML_ELEMENT_NODE) {
if(cmp_node(n, "validity", common_policy_ns) >= 0) {
-   /* FIXME: free existing validity */
res = read_validity(n, &(*dst)->validity);
if(res != 0)
break;
} else {
if(cmp_node(n, "identity", common_policy_ns) >= 
0) {
-   /* FIXME: free existing identity */
res = read_identity(n, 
&(*dst)->identity);
if(res != 0)
break;
diff --git a/src/lib/xcap/resource_list.c b/src/lib/xcap/resource_list.c
index cb7d111057f..928c133df51 100644
--- a/src/lib/xcap/resource_list.c
+++ b/src/lib/xcap/resource_list.c
@@ -169,9 +169,9 @@ void free_traversed_list(traversed_list_t *list)
 
 /* --- helper functions (doing flat list) --- */
 
+/* absolute uri from ref (RFC 3986, section 5.2) */
 static char *relative2absolute_uri(const str_t *xcap_root, const char 
*relative)
 {
-   /* FIXME: do absolute uri from ref (RFC 3986, section 5.2) */
int len;
int root_len = 0;
int rel_len = 0;
diff --git a/src/lib/xcap/xcap_client.c b/src/lib/xcap/xcap_client.c
index c633f3c7f5f..2fe6e41d1d6 100644
--- a/src/lib/xcap/xcap_client.c
+++ b/src/lib/xcap/xcap_client.c
@@ -284,13 +284,8 @@ int xcap_query(
/* follow redirects (needed for apache mod_speling - case 
insesitive names) */
curl_easy_setopt(handle, CURLOPT_FOLLOWLOCATION, 1);
 
-   /*  curl_easy_setopt(handle, CURLOPT_TCP_NODELAY, 1);
-   curl_easy_setopt(handle, CURLOPT_CONNECTTIMEOUT, 10);*/
-
/* Accept headers */
-
res = curl_easy_perform(handle);
-   /* curl_easy_cleanup(handle); */ /* FIXME: experimental */
} else
ERROR_LOG("can't initialize curl handle\n");
if(res == 0) {

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:0a11489d: lib/srdb2: review and adapt old comments

2024-01-22 Thread Daniel-Constantin Mierla via sr-dev 
Module: kamailio
Branch: master
Commit: 0a11489d4b699a62596b2c4626171e8d92e966fd
URL: 
https://github.com/kamailio/kamailio/commit/0a11489d4b699a62596b2c4626171e8d92e966fd

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2024-01-21T10:20:39+01:00

lib/srdb2: review and adapt old comments

---

Modified: src/lib/srdb2/db_cmd.c
Modified: src/lib/srdb2/db_gen.h

---

Diff:  
https://github.com/kamailio/kamailio/commit/0a11489d4b699a62596b2c4626171e8d92e966fd.diff
Patch: 
https://github.com/kamailio/kamailio/commit/0a11489d4b699a62596b2c4626171e8d92e966fd.patch

---

diff --git a/src/lib/srdb2/db_cmd.c b/src/lib/srdb2/db_cmd.c
index 2782f4dc7c5..9ba1d22ee66 100644
--- a/src/lib/srdb2/db_cmd.c
+++ b/src/lib/srdb2/db_cmd.c
@@ -58,7 +58,7 @@ db_cmd_t *db_cmd(enum db_cmd_type type, db_ctx_t *ctx, char 
*table,
 
newp->type = type;
 
-   /** FIXME: it is not clear now that this is necessary
+   /** NOTE: it is not clear now that this is necessary
 * when we have match and value separate arrays */
if(result) {
newp->result = db_fld_copy(result);
@@ -78,7 +78,7 @@ db_cmd_t *db_cmd(enum db_cmd_type type, db_ctx_t *ctx, char 
*table,
goto err;
}
 
-   /* FIXME: This should be redesigned so that we do not need to connect
+   /* NOTE: This should be redesigned so that we do not need to connect
 * connections in context before commands are created, this takes 
splitting
 * the command initialization sequence in two steps, one would be 
creating
 * all the data structures and the second would be checking 
corresponding
@@ -242,7 +242,6 @@ int db_exec(db_res_t **res, db_cmd_t *cmd)
return -1;
}
 
-   /* FIXME */
db_payload_idx = 0;
ret = cmd->exec[0](r, cmd);
if(ret < 0) {
diff --git a/src/lib/srdb2/db_gen.h b/src/lib/srdb2/db_gen.h
index eca24c76046..f8dd483b87a 100644
--- a/src/lib/srdb2/db_gen.h
+++ b/src/lib/srdb2/db_gen.h
@@ -95,7 +95,7 @@ extern "C"
  */
 
 /*
- * FIXME: We should find some other way of doing this than just copying
+ * NOTE: We should find some other way of doing this than just copying
  * and pasting the code from STAILQ_FOREACH
  */
 #define DBLIST_FOREACH(var, head)\
@@ -111,7 +111,7 @@ extern "C"
  */
 
 /*
- * FIXME: We should find some other way of doing this than just copying
+ * NOTE: We should find some other way of doing this than just copying
  * and pasting the code from STAILQ_FOREACH_SAFE
  */
 #define DBLIST_FOREACH_SAFE(var, head, tvar)  \

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:05076041: lib: presence - remove old commented code and adjust comments

2024-01-22 Thread Daniel-Constantin Mierla via sr-dev 
Module: kamailio
Branch: master
Commit: 050760411bac006c1e6351f179fab7ea6333b3e5
URL: 
https://github.com/kamailio/kamailio/commit/050760411bac006c1e6351f179fab7ea6333b3e5

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2024-01-22T09:29:31+01:00

lib: presence - remove old commented code and adjust comments

---

Modified: src/lib/presence/notifier_domain.c
Modified: src/lib/presence/pidf.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/050760411bac006c1e6351f179fab7ea6333b3e5.diff
Patch: 
https://github.com/kamailio/kamailio/commit/050760411bac006c1e6351f179fab7ea6333b3e5.patch

---

diff --git a/src/lib/presence/notifier_domain.c 
b/src/lib/presence/notifier_domain.c
index 56773d13c1c..8f03828c119 100644
--- a/src/lib/presence/notifier_domain.c
+++ b/src/lib/presence/notifier_domain.c
@@ -223,33 +223,6 @@ static void free_subscription(qsa_subscription_t *s)
cds_free(s);
 }
 
-/*static void add_server_subscription(notifier_t *n, qsa_subscription_t *s)
-{
-   server_subscription_t server_s;
-
-   server_s.notifier_data = NULL;
-   if (n->subscribe(n, >record_id, s, _s.notifier_data) == 0) {
-   server_s.notifier = n;
-   vector_add(>server_subscriptions, _s);
-   }
-   else ERROR_LOG("subscription not accepted by notifier %p\n", n);
-}
-
-static void remove_notifier_from_subscription(qsa_subscription_t *s, 
notifier_t *n)
-{
-   int cnt,i;
-
-   cnt = vector_size(>server_subscriptions);
-   for (i = 0; i < cnt; i++) {
-   ss = vector_get_ptr(>server_subscriptions, i);
-   if (!ss) continue;
-   / * FIXME: call n->unsubscribe ???
-* NO this is called from unregister which is initiated
-* by the notifier (may be synchronized there!) * /
-   if (ss->notifier == n) ss->notifier = NULL; / * "zombie" * /
-   }
-}
-*/
 
 /*  Domain initialization/destruction functions  */
 
diff --git a/src/lib/presence/pidf.c b/src/lib/presence/pidf.c
index d875ce974c4..3f00314a5fa 100644
--- a/src/lib/presence/pidf.c
+++ b/src/lib/presence/pidf.c
@@ -170,9 +170,9 @@ static void doc_add_presentity(
 
DEBUG_LOG("doc_add_presentity()\n");
if(use_cpim_pidf_ns)
-   dstr_append_zt(
-   buf, "properties, "id"));
@@ -433,7 +433,7 @@ static int read_tuple(xmlNode *tuple, presence_tuple_info_t 
**dst,
} else if(cmp_node(n, "status", ns) >= 0) {
/* skip, already processed */
} else if(cmp_node(n, "timestamp", ns) >= 0) {
-   /* FIXME: process */
+   /* TODO: process */
} else { /* PIDF extensions - only from non-PIDF 
namespace? */
res = read_extension(n, , doc);
if((res == 0) && ex)

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org