[sr-dev] Re: [kamailio/kamailio] usrloc: check on db delete the return value of memchr (PR #3815)

2024-04-17 Thread Victor Seva via sr-dev
@dunst0 please use clang-format and force push the updated commit

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3815#issuecomment-2061056490
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] [kamailio/kamailio] usrloc: check on db delete the return value of memchr (PR #3815)

2024-04-17 Thread Rick Barenthin via sr-dev
!-- Kamailio Pull Request Template --

!--
IMPORTANT:
  - for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
  - pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
  - backports to stable branches must be done with git cherry-pick -x 
...
  - code is contributed under BSD for core and main components (tm, sl, auth, 
tls)
  - code is contributed GPLv2 or a compatible license for the other components
  - GPL code is contributed with OpenSSL licensing exception
--

 Pre-Submission Checklist
!-- Go over all points below, and after creating the PR, tick all the 
checkboxes that apply --
!-- All points should be verified, otherwise, read the CONTRIBUTING 
guidelines from above--
!-- If youre unsure about any of these, dont hesitate to ask on 
sr-dev mailing list --
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, 
...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook 
files
in `doc/` subfolder, the README file is autogenerated)

 Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

 Checklist:
!-- Go over all points below, and after creating the PR, tick the 
checkboxes that apply --
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue # (replace  with an open issue number)

 Description
!-- Describe your changes in detail --
When inserting into the database the AOR is split at the @ sign and if there is 
no @ sign in the AOR only the domain part is filled and the user part is left 
empty.

But for deleting this is not done and the query failed to be executed and the 
AOR is not deleted. This PR add this behaviour of only comparing against the 
domain part if the AOR doesnt contain a @ sign.
You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/3815

-- Commit Summary --

  * usrloc: check on db delete the return value of memchr

-- File Changes --

M src/modules/usrloc/urecord.c (14)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/3815.patch
https://github.com/kamailio/kamailio/pull/3815.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3815
You are receiving this because you are subscribed to this thread.

Message ID: kamailio/kamailio/pull/3...@github.com
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org