[sr-dev] Re: [kamailio/kamailio] K crash v5.5.6 with dlg_profile (Issue #3878)

[Henning Westerholt via sr-dev]

Thanks for the report. There was one particular bug fixed some time ago in the 
dialog module related to some concurrency issues for the dialog data 
structures. Could you please update to a supported version (e.g. one of the 
latest 5.7.x or 5.8.x) and see if the problem is fixed there?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3878#issuecomment-2173658935
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] Warnings emitted when calling functions from dialplan module (Issue #3851)

[Henning Westerholt via sr-dev]

Reopened #3851.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3851#event-13186435520
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] Hello, I would like to confirm if our SMS module supports sending long SMS messages ？ (Issue #3822)

[Henning Westerholt via sr-dev]

I don't use this particular module right now. If there are no parameters or 
documentation that suggests functionality for this use case support, a code 
extension is probably necessary. For this a PR can be created on our tracker if 
people want this functionality.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3822#issuecomment-2172753178
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] topos: add enable_register_publish (PR #3766)

[Henning Westerholt via sr-dev]

@toharish do you still like to get this merged? Not sure what the last result 
from your testing discussion was.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3766#issuecomment-2172750125
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] Kamailio ims_charging module Ro Interface User-Equipment-Info-Type AVP (Issue #3807)

[Henning Westerholt via sr-dev]

Thanks for rasing this. If somebody else like to change and/or improve the 
ims_charging module, just create a PR with referring to this discussion.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3807#issuecomment-2172746520
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] topos: add enable_register_publish (PR #3766)

[Henning Westerholt via sr-dev]

Reopened #3766.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3766#event-13182335512
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] siptrace: handle trace_to_database param at runtime (PR #3877)

[Henning Westerholt via sr-dev]

Thanks for the PR. I did not reviewed the code yet, but noticed that the format 
check is failing. Could you please fix the format by executing clang-format on 
the file(s) and do a force-push?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3877#issuecomment-2169152926
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] tls: enable statistics (PR #3852)

[Henning Westerholt via sr-dev]

> If I understand this correctly, I have to adjust the formatting, right?

If you are referring to the failed build format checks, yes this caused from an 
error in the formatting. You could execute clang-format for the changed files 
and force-push again.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3852#issuecomment-2162443040
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:24afb14c: carrierroute: use proper define for db_url

[Henning Westerholt via sr-dev]

Module: kamailio
Branch: master
Commit: 24afb14cfaba28c4e5a7dfe9f352b02a551eed5c
URL: 
https://github.com/kamailio/kamailio/commit/24afb14cfaba28c4e5a7dfe9f352b02a551eed5c

Author: Henning Westerholt 
Committer: Henning Westerholt 
Date: 2024-06-12T07:59:20Z

carrierroute: use proper define for db_url

---

Modified: src/modules/carrierroute/doc/carrierroute_db.xml

---

Diff:  
https://github.com/kamailio/kamailio/commit/24afb14cfaba28c4e5a7dfe9f352b02a551eed5c.diff
Patch: 
https://github.com/kamailio/kamailio/commit/24afb14cfaba28c4e5a7dfe9f352b02a551eed5c.patch

---

diff --git a/src/modules/carrierroute/doc/carrierroute_db.xml 
b/src/modules/carrierroute/doc/carrierroute_db.xml
index 87017a3d259..0e9d7b3fded 100644
--- a/src/modules/carrierroute/doc/carrierroute_db.xml
+++ b/src/modules/carrierroute/doc/carrierroute_db.xml
@@ -29,7 +29,7 @@ ALL CHANGES DONE HERE WILL BE LOST IF THE FILE IS REGENERATED
   Set db_url parameter
   
 ...
-modparam("carrierroute", "db_url", 
"dbdriver://username:password@dbhost/dbname")
+modparam("carrierroute", "db_url", "")
 ...
 
 

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] ims_icscf: add missing documents for database params (PR #3874)

[Henning Westerholt via sr-dev]

@henningw commented on this pull request.

Thanks for the PR, I have added two comments related to the usage of database 
URLs.

> @@ -71,7 +71,7 @@ stat_var *uar_replies_response_time = NULL;
 stat_var *lir_replies_response_time = NULL;
 
 //module parameters
-char *ims_icscf_db_url = "mysql://icscf:heslo@localhost/hssdata"; /**< DB URL 
*/
+char *ims_icscf_db_url = "mysql://kamailio:kamailiorw@localhost/kamailio"; 
/**< DB URL */

Consider using the correct define for it: DEFAULT_RODB_URL


> +  
+  If the db_url string is empty, the default database URL
+  will be used.
+  
+
+  
+
+Default value is .
+
+  
+
+  
+Set db_url parameter
+
+...
+modparam("ims_icscf", "db_url", "mysql://username:password@localhost/kamailio")

You could use also here the definition "

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3874#pullrequestreview-2112231440
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] pua_dialoginfo fails to publish the caller when not using avps (Issue #3838)

[Henning Westerholt via sr-dev]

PR got merged and will be also backported in one of the next minor releases, 
closed.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3838#issuecomment-2155843210
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] pua_dialoginfo fails to publish the caller when not using avps (Issue #3838)

[Henning Westerholt via sr-dev]

Closed #3838 as completed.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3838#event-13087537111
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] pua_dialoginfo: Fix ruri length (PR #3871)

[Henning Westerholt via sr-dev]

Merged #3871 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3871#event-13087534828
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:2c7c2d21: pua_dialoginfo: Fix ruri length

[Henning Westerholt via sr-dev]

Module: kamailio
Branch: master
Commit: 2c7c2d215ec9277fa706053579a38f058f15ae85
URL: 
https://github.com/kamailio/kamailio/commit/2c7c2d215ec9277fa706053579a38f058f15ae85

Author: Xenofon Karamanos <22965395+xkara...@users.noreply.github.com>
Committer: Henning Westerholt 
Date: 2024-06-08T08:52:02+02:00

pua_dialoginfo: Fix ruri length

---

Modified: src/modules/pua_dialoginfo/pua_dialoginfo.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/2c7c2d215ec9277fa706053579a38f058f15ae85.diff
Patch: 
https://github.com/kamailio/kamailio/commit/2c7c2d215ec9277fa706053579a38f058f15ae85.patch

---

diff --git a/src/modules/pua_dialoginfo/pua_dialoginfo.c 
b/src/modules/pua_dialoginfo/pua_dialoginfo.c
index 22a2fb11da7..c8a8a6f31a3 100644
--- a/src/modules/pua_dialoginfo/pua_dialoginfo.c
+++ b/src/modules/pua_dialoginfo/pua_dialoginfo.c
@@ -838,6 +838,7 @@ struct dlginfo_cell *get_dialog_data(struct dlg_cell *dlg, 
int type,
}
memset(dlginfo->pubruris_caller, 0, sizeof(struct str_list));
dlginfo->pubruris_caller->s.s = 
shm_str2char_dup(>from_uri);
+   dlginfo->pubruris_caller->s.len = dlginfo->from_uri.len;
if(!dlginfo->pubruris_caller->s.s) {
free_dlginfo_cell(dlginfo);
return NULL;

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] pua_dialoginfo: Fix ruri length (PR #3871)

[Henning Westerholt via sr-dev]

Thank you, merged

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3871#issuecomment-2155842977
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] pdb: make 'timeout' runtime configurable (PR #3850)

[Henning Westerholt via sr-dev]

Merged #3850 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3850#event-13056652042
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] pdb: make 'timeout' runtime configurable (PR #3850)

[Henning Westerholt via sr-dev]

Thanks for updating the PR, merged.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3850#issuecomment-2150827595
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:f57be803: pdb: make 'timeout' runtime configurable

[Henning Westerholt via sr-dev]

Module: kamailio
Branch: master
Commit: f57be8030834cdeb0bb509d0d25afc89f3cca6e8
URL: 
https://github.com/kamailio/kamailio/commit/f57be8030834cdeb0bb509d0d25afc89f3cca6e8

Author: Stefan-Cristian Mititelu 
Committer: Henning Westerholt 
Date: 2024-06-05T21:43:02+02:00

pdb: make 'timeout' runtime configurable

Also modify logs related to timeout from NOTICE to ERR and add
a bit more info to them.

---

Added: src/modules/pdb/config.c
Added: src/modules/pdb/config.h
Modified: src/modules/pdb/pdb.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/f57be8030834cdeb0bb509d0d25afc89f3cca6e8.diff
Patch: 
https://github.com/kamailio/kamailio/commit/f57be8030834cdeb0bb509d0d25afc89f3cca6e8.patch

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:fc07aad0: pdbt: Allow to return carrier id 0

[Henning Westerholt via sr-dev]

Module: kamailio
Branch: master
Commit: fc07aad0beaae9e133ca3252b088afd9eece0c53
URL: 
https://github.com/kamailio/kamailio/commit/fc07aad0beaae9e133ca3252b088afd9eece0c53

Author: Stefan-Cristian Mititelu 
Committer: Henning Westerholt 
Date: 2024-06-05T21:43:02+02:00

pdbt: Allow to return carrier id 0

---

Modified: utils/pdbt/pdbt.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/fc07aad0beaae9e133ca3252b088afd9eece0c53.diff
Patch: 
https://github.com/kamailio/kamailio/commit/fc07aad0beaae9e133ca3252b088afd9eece0c53.patch

---

diff --git a/utils/pdbt/pdbt.c b/utils/pdbt/pdbt.c
index be670eeb7f8..d9fa0bca45d 100644
--- a/utils/pdbt/pdbt.c
+++ b/utils/pdbt/pdbt.c
@@ -628,15 +628,14 @@ int query_server(char *number, char *comment, void *data) 
{
 
carrierid = query_udp(number, sdata->timeout, &(sdata->pfds), 
&(sdata->dstaddr), sdata->dstaddrlen);
 
-   if (carrierid<=0) {
+   if(carrierid < 0) {
LINFO("%s: not_found: comment='%s', result=%d\n", number, 
comment, carrierid);
if (carrierid < 0) {
result = carrierid;
} else {
result = PDB_NOT_IN_PDB;
}
-   }
-   else {
+   } else {
LINFO("%s:%ld:%s\n", number, (long int)carrierid, 
carrierid2name(carrierid));
result = PDB_OK;
}

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: core dump on AWS with ~4000 TCP sockets

[Henning Westerholt via sr-dev]

Hello David,

please share the usual details, e.g.:


  *   Kamailio version
  *   Operating system version
  *   OpenSSL version

Furthermore please try to enable core dumping and have a look to the backtrace.

Cheers,

Henning Westerholt

--
Henning Westerholt – https://skalatan.de/blog/
Kamailio services – https://gilawa.com

From: David Villasmil via sr-dev 
Sent: Donnerstag, 30. Mai 2024 22:47
To: Kamailio (SER) - Development Mailing List ; 
Kamailio (SER) - Users Mailing List 
Cc: David Villasmil 
Subject: [sr-dev] core dump on AWS with ~4000 TCP sockets

Hello all,
I'm seeing core dumps (can't find them!) on AWS with lots of TCP sockets open 
(not related to load), kamailio dies randomly with:

May 30 14:31:03 sip-proxy /usr/sbin/kamailio[743739]: CRITICAL:  
[core/pass_fd.c:277]: receive_fd(): EOF on 142 May 30 14:31:03 sip-proxy 
/usr/sbin/kamailio[743542]: ALERT:  [main.c:788]: handle_sigs(): child 
process 743672 exited by a signal 11 May 30 14:31:03 sip-proxy 
/usr/sbin/kamailio[743542]: ALERT:  [main.c:791]: handle_sigs(): core was 
generated May 30 14:32:03 sip-proxy /usr/sbin/kamailio[743542]: CRITICAL: 
 [main.c:698]: sig_alarm_abort(): shutdown timeout triggered, dying...

before this happens, there's a ton of

May 26 00:32:01 sip-proxy /usr/sbin/kamailio[74966]: ERROR:  
[core/tcp_main.c:4591]: tcpconn_main_timeout(): connect 
172.56.51.197:34846 failed (timeout)
May 26 00:32:01 sip-proxy /usr/sbin/kamailio[74966]: ERROR:  
[core/tcp_main.c:4591]: tcpconn_main_timeout(): connect 
98.196.165.187:38593 failed (timeout)
May 26 00:32:01 sip-proxy /usr/sbin/kamailio[74966]: ERROR:  
[core/tcp_main.c:4591]: tcpconn_main_timeout(): connect 
10.241.49.185:49372 failed (timeout)
May 26 00:32:01 sip-proxy /usr/sbin/kamailio[74966]: ERROR:  
[core/tcp_main.c:4591]: tcpconn_main_timeout(): connect 
97.101.162.40:45248 failed (timeout)
May 26 00:32:01 sip-proxy /usr/sbin/kamailio[74966]: ERROR:  
[core/tcp_main.c:4591]: tcpconn_main_timeout(): connect 
172.59.213.36:57074 failed (timeout)
May 26 00:32:01 sip-proxy /usr/sbin/kamailio[74966]: ERROR:  
[core/tcp_main.c:4591]: tcpconn_main_timeout(): connect 
207.195.63.14:2521 failed (timeout)
May 26 00:32:01 sip-proxy /usr/sbin/kamailio[74966]: ERROR:  
[core/tcp_main.c:4591]: tcpconn_main_timeout(): connect 
10.241.49.185:22155 failed (timeout)
May 26 00:32:01 sip-proxy /usr/sbin/kamailio[74966]: ERROR:  
[core/tcp_main.c:4591]: tcpconn_main_timeout(): connect 
10.241.49.185:10339 failed (timeout)

Regards,

David Villasmil
email: david.villasmil.w...@gmail.com
phone: +34669448337
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] Warnings emitted when calling functions from dialplan module (Issue #3851)

[Henning Westerholt via sr-dev]

> I was able to "get around" that warning by changing the memory manager.
> 
> Not sure if this is the correct solution/workaround, but having the constant 
> warnings in the logs seems wrong.
> 
> I added `-x fm -X fm` to the kamailio run command.
> 
> Any downside to this change?

Well, the issue is still there, the other memory manager just did not log a 
warning message for it. I personally would not recommend to switch to a much 
less used memory manager which might cause unknown issues for your workload 
just for getting rid of a few warnings. As said already, the issue needs to be 
analyzed in the dialplan module and fixed there. If you are annoyed from the 
warnings, just increase the log level to ERROR level for now.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3851#issuecomment-2121070212
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] Warnings emitted when calling functions from dialplan module (Issue #3851)

[Henning Westerholt via sr-dev]

It is a warning, which should not be reduced or silenced. The memory manager 
emits this warning because its not used correctly, e.g. in the example above a 
free(0) was called. It should be investigated in the module. Its only warning 
level, so it might be not a serious issue.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3851#issuecomment-2119106312
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] usrloc: delete location_attrs in db_only mode on delete_urecord (PR #3827)

[Henning Westerholt via sr-dev]

Thank you, merged

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3827#issuecomment-2115226477
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] usrloc: delete location_attrs in db_only mode on delete_urecord (PR #3827)

[Henning Westerholt via sr-dev]

Merged #3827 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3827#event-12833708801
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:6b8f6d3b: usrloc: delete location_attrs in db_only mode on delete_urecord

[Henning Westerholt via sr-dev]

Module: kamailio
Branch: master
Commit: 6b8f6d3b5d563d91234b8d4b7e155b7e74b9d313
URL: 
https://github.com/kamailio/kamailio/commit/6b8f6d3b5d563d91234b8d4b7e155b7e74b9d313

Author: Rick Barenthin 
Committer: Henning Westerholt 
Date: 2024-05-16T15:18:54+02:00

usrloc: delete location_attrs in db_only mode on delete_urecord

When calling delete_urecord in DB_ONLY mode the location_attrs are not deleted.
This fix makes sure to delete location_attrs when calling db_delete_urecord is 
called.

---

Modified: src/modules/usrloc/ucontact.c
Modified: src/modules/usrloc/urecord.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/6b8f6d3b5d563d91234b8d4b7e155b7e74b9d313.diff
Patch: 
https://github.com/kamailio/kamailio/commit/6b8f6d3b5d563d91234b8d4b7e155b7e74b9d313.patch

---

diff --git a/src/modules/usrloc/ucontact.c b/src/modules/usrloc/ucontact.c
index f95fe987d75..8a8c1ea7895 100644
--- a/src/modules/usrloc/ucontact.c
+++ b/src/modules/usrloc/ucontact.c
@@ -1784,9 +1784,11 @@ int uldb_delete_attrs(str *_dname, str *_user, str 
*_domain, str *_ruid)
str tname;
db_key_t keys[3];
db_val_t vals[3];
+   int n = 0;
 
-   if(ul_db_ops_ruid == 1)
+   if(ul_db_ops_ruid == 1 && _ruid) {
return uldb_delete_attrs_ruid(_dname, _ruid);
+   }
 
LM_DBG("trying to delete location attributes\n");
 
@@ -1805,22 +1807,26 @@ int uldb_delete_attrs(str *_dname, str *_user, str 
*_domain, str *_ruid)
tname.s = tname_buf;
tname.len = _dname->len + 6;
 
-   keys[0] = _user_col;
-   keys[1] = _ruid_col;
-   keys[2] = _domain_col;
-
-   vals[0].type = DB1_STR;
-   vals[0].nul = 0;
-   vals[0].val.str_val = *_user;
+   keys[n] = _user_col;
+   vals[n].type = DB1_STR;
+   vals[n].nul = 0;
+   vals[n].val.str_val = *_user;
+   n++;
 
-   vals[1].type = DB1_STR;
-   vals[1].nul = 0;
-   vals[1].val.str_val = *_ruid;
+   if(_ruid) {
+   keys[n] = _ruid_col;
+   vals[n].type = DB1_STR;
+   vals[n].nul = 0;
+   vals[n].val.str_val = *_ruid;
+   n++;
+   }
 
if(ul_use_domain) {
-   vals[2].type = DB1_STR;
-   vals[2].nul = 0;
-   vals[2].val.str_val = *_domain;
+   keys[n] = _domain_col;
+   vals[n].type = DB1_STR;
+   vals[n].nul = 0;
+   vals[n].val.str_val = *_domain;
+   n++;
}
 
if(ul_dbf.use_table(ul_dbh, ) < 0) {
@@ -1828,7 +1834,7 @@ int uldb_delete_attrs(str *_dname, str *_user, str 
*_domain, str *_ruid)
return -1;
}
 
-   if(ul_dbf.delete(ul_dbh, keys, 0, vals, (ul_use_domain) ? (3) : (2)) < 
0) {
+   if(ul_dbf.delete(ul_dbh, keys, 0, vals, n) < 0) {
LM_ERR("deleting from database failed\n");
return -1;
}
diff --git a/src/modules/usrloc/urecord.c b/src/modules/usrloc/urecord.c
index 3c394a24a10..d47167c0f4b 100644
--- a/src/modules/usrloc/urecord.c
+++ b/src/modules/usrloc/urecord.c
@@ -502,6 +502,10 @@ int db_delete_urecord(urecord_t *_r)
vals[1].val.str_val.s = dom + 1;
vals[1].val.str_val.len = _r->aor.s + _r->aor.len - dom 
- 1;
}
+   uldb_delete_attrs(
+   _r->domain, [0].val.str_val, 
[1].val.str_val, NULL);
+   } else {
+   uldb_delete_attrs(_r->domain, [0].val.str_val, NULL, NULL);
}
 
if(ul_dbf.use_table(ul_dbh, _r->domain) < 0) {

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] [FEATURE] mid-call self-redirect call to new nexthop (Issue #3773)

[Henning Westerholt via sr-dev]

Maybe you can try to start a discussion about that on the users lists, to see 
if there is some interest about it.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3773#issuecomment-2115211397
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] extented haproxy protocol support (PR #3731)

[Henning Westerholt via sr-dev]

Reopened #3731.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3731#event-12833617033
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] extented haproxy protocol support (PR #3731)

[Henning Westerholt via sr-dev]

@sergey-safarov do you like to continue to work on this? I think there have 
been already several discussions about the PR.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3731#issuecomment-2115214324
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] Wrong Route header order in called party re-INVITE when using topos (Issue #3778)

[Henning Westerholt via sr-dev]

Reopened #3778.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3778#event-12833629926
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] bad BYE message from endpoint when using topoh in kamailio 5.5.1 (Issue #3853)

[Henning Westerholt via sr-dev]

Hello, thanks for the report. The Kamailio version you used is unfortunately 
already end of life. Please update to a supported version, e.g. 5.7.5 or 5.8.1 
and see if the error is still there. If you can't update right now to this 
versions, I would recommend to at least update to the latest release of this 
branch, 5.5.7.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3853#issuecomment-2113020195
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: TLS.reload and memory usage of SSL_CTX structs

[Henning Westerholt via sr-dev]

Hello Xenofon,

thanks for the additional information regarding the load_crl(..) function. 
Regarding the question about making it configurable, I think the idea was to 
have a new configuration parameter to disable the SSL context duplication per 
process, to make it easier testable and provide a way to deactivate if its 
makes problems. It could be then maybe made the default later on, if its works 
stable. It will be certainly some code duplication, but you can probably 
comment better how easy or difficult it could be implemented.

Cheers,

Henning

--
Henning Westerholt – https://skalatan.de/blog/
Kamailio services – https://gilawa.com

From: Xenofon Karamanos via sr-dev 
Sent: Dienstag, 14. Mai 2024 15:54
To: Kamailio (SER) - Development Mailing List ; 
mico...@gmail.com
Cc: Xenofon Karamanos 
Subject: [sr-dev] Re: TLS.reload and memory usage of SSL_CTX structs

Hello Daniel,

Thanks for the feedback!

Maybe i should have explained better regarding the leak. Indeed, i couldn't 
clearly identify the leak itself but there is an indication that the leak is 
happening in the SSL_CTX_load_verify_locations() function.

When i comment out that part of the load_crl() function there is no more 
exhaustion of memory, so it's probably something SSL related.

Multiple issues suggest this also, look at:
https://groups.google.com/g/envoy-dev/c/JnWnH6HcsDU
https://github.com/pyca/pyopenssl/issues/1120
https://mta.openssl.org/pipermail/openssl-users/2015-April/001255.html
https://www.mail-archive.com/openssl-users@openssl.org/msg66240.html
https://www.mail-archive.com/openssl-users@openssl.org/msg57199.html
https://groups.google.com/g/mailing.openssl.users/c/R7bzJx167V4/m/lAGAPcDVmSMJ
https://github.com/twisted/twisted/issues/12125
https://stackoverflow.com/questions/29845527/how-to-properly-uninitialize-openssl

But i can't say for sure because the exact same function is called for CA list 
(maybe exhaustion here is much slower).

I don't know the internal of SSL but when i enable the memory debugs, i see a 
lot of mallocs and reallocs in that call, and no free() for the respective 
memories when reloading each new tls.reload. Freeing() happens only when 
kamailio is terminated.

The idea of reusing instead of recreating came from this 
https://stackoverflow.com/questions/67868098/how-to-duplicate-a-ssl-ctx-object-in-a-tls-application.

>>  (e.g., by libssl internally on handling traffic)

SSL_CTX should not be chagned once you have initialized an SSL connection 
according to this https://github.com/openssl/openssl/discussions/24203. maybe 
it was never needed but then again i am not deeply familiar with how kamailio 
uses these ctx.

Make configurable what? whether to initialize it once and reuse it vs 
initialize per process?

Thanks,
Xenofon

From: Daniel-Constantin Mierla 
Sent: Tuesday, May 14, 2024 15:05
To: Kamailio (SER) - Development Mailing List 
Cc: Xenofon Karamanos 
Subject: Re: [sr-dev] TLS.reload and memory usage of SSL_CTX structs


Hello,



thanks for digging in it!



As I understand, this is somehow first about reducing the size of used memory, 
not clearly identifying the leak itself.



The duplication done per process was to avoid races if local changes has to be 
performed (e.g., by libssl internally on handling traffic), but maybe with the 
libssl3.x and new threading approach is no longer needed, if ever was necessary.



What I would suggest is to make it configurable for now, so in case behaviour 
becomes unstable on high load, one can switch between modes.



Cheers,
Daniel


On 14.05.24 10:36, Xenofon Karamanos via sr-dev wrote:
Hello all,

I am currently looking into issue 
https://github.com/kamailio/kamailio/issues/3823 regarding the tls.reload and 
the constant increase in memory usage when it's called.

I tried to look something up related to CRL and related functions for what 
causing it but nothing to obvious. The only culprit i could find was this 
function call in  SSL_verify_load_locations in 
load_crl().
 But the same exact function is also called in load_ca_list() with no such 
behaviour.

Next thing i notice, is that on the first rpc call of tls.reload, there is a 
"significant" memory allocation.
What i mean by this is that when a fresh kamailio (5.8) is started up (with -m 
7, for low shared memory availability to try and replicate the issue and 
children=2) and then check free shared memory usage using `kamcmd core.shmmem` 
is around 2196096 (bytes i am assuming) for my system.

On the first call of tls.reload, it drops to 539248. That's a heavy drop so i 
started digging why on so much allocation is caused. When loading a tls 
configuration, 
ksr_fix_domain
 allocates a new 

[sr-dev] Re: [kamailio/kamailio] p_usrloc: use a global p_usrloc_columns variable in db_load* functions (PR #3845)

[Henning Westerholt via sr-dev]

I think it would be also a good addition for the usrloc module. It certainly 
makes the code better understandable (some integer IDs vs. easy names).

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3845#issuecomment-2112911458
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] pdb: make 'timeout' runtime configurable (PR #3850)

[Henning Westerholt via sr-dev]

@henningw commented on this pull request.

Thanks for the PR. The run-time cfg option looks straight-forward, good 
addition. You've also change the log level of a bunch of NOTICEs messages 
related to the timeout to ERROR and log additional information, was this done 
intentionally? Because its not mentioned in the commit message.

You've also change the pdbt tool behaviour in another location, this should 
probably be a dedicated commit with an own commit message, with the proper 
prefix.



-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3850#pullrequestreview-2058029377
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] p_usrloc: use a global all_columns variable in db_load* functions (PR #3845)

[Henning Westerholt via sr-dev]

Looks good to me. It similar code is used in usrloc udomain.c, the same 
refactoring could be of course also done there.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3845#issuecomment-2104180664
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: Proposing 6.0.x for next stable release series

[Henning Westerholt via sr-dev]

Hello Daniel,

the "6.0" sounds good to me, its indeed a major change for the main network 
protocol in the server.
It was discussed also some time ago at the developer meeting(s) that this would 
be probably a good reason for a larger version increment.

Nice extension to the core, thank you.

Henning

> -Original Message-
> From: Daniel-Constantin Mierla via sr-dev 
> Sent: Mittwoch, 8. Mai 2024 14:03
> To: Kamailio (SER) - Devel Mailing List 
> Cc: Daniel-Constantin Mierla 
> Subject: [sr-dev] Proposing 6.0.x for next stable release series
> 
> Hello,
> 
> I am proposing to switch the development version to target 6.0.x as next
> major series. I have pushed a new mode for receiving UDP traffic via a multi-
> threaded process, useful when having to deal with a rather large set of UDP
> sockets. While it is built reusing some existing components (async workers
> group and sworker design), it changes substantially how the core can deal with
> the sip traffic. Similar approach might be added for TCP (TLS), but right now
> this transport is already using a single pool of works for all sockets, so it
> doesn't faces the same issues as with UDP for large number of sockets.
> 
> The old way of handling UDP traffic is not removed, it is still the default, 
> the
> new one needs testing, of course.
> 
> Furthermore, the socket global parameter (which is an alternative to
> listen) can now take a port range to the bind field, simplifying the config 
> when
> Kamailio has to listen on large number on consecutive ports.
> 
> Cheers,
> Daniel
> 
> --
> Daniel-Constantin Mierla (@ asipto.com)
> twitter.com/miconda -- linkedin.com/in/miconda Kamailio Consultancy,
> Training and Development Services -- asipto.com
> 
> ___
> Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-
> dev-le...@lists.kamailio.org
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] Memory usage increases everytime tls.reload is executed (Issue #3823)

[Henning Westerholt via sr-dev]

If it happens only with adding a CRL, it looks indeed like an issue in this 
code path. In the end using CRL is probably quite rare. 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3823#issuecomment-2099911525
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] Possible Mem leak in Core (Issue #3841)

[Henning Westerholt via sr-dev]

@paresh-panda If there is a leak in smsops module, please create a new issue 
with debug information for that, as mentioned, thank you.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3841#issuecomment-2099902705
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:5.7:289ab7dd: sipcapture: fix default DB URL docs

[Henning Westerholt via sr-dev]

Module: kamailio
Branch: 5.7
Commit: 289ab7ddceaaf923edfe15b11361f0acb16c0dde
URL: 
https://github.com/kamailio/kamailio/commit/289ab7ddceaaf923edfe15b11361f0acb16c0dde

Author: Henning Westerholt 
Committer: Henning Westerholt 
Date: 2024-05-07T19:02:35Z

sipcapture: fix default DB URL docs

(cherry picked from commit aeeeb0c2f46c2575639dd725bef78fac64219a07)
(cherry picked from commit 29ef69b8807023e082d7c9880c63bee11d4f3b30)

---

Modified: src/modules/sipcapture/doc/sipcapture_admin.xml

---

Diff:  
https://github.com/kamailio/kamailio/commit/289ab7ddceaaf923edfe15b11361f0acb16c0dde.diff
Patch: 
https://github.com/kamailio/kamailio/commit/289ab7ddceaaf923edfe15b11361f0acb16c0dde.patch

---

diff --git a/src/modules/sipcapture/doc/sipcapture_admin.xml 
b/src/modules/sipcapture/doc/sipcapture_admin.xml
index 6a428133866..258e30fe237 100644
--- a/src/modules/sipcapture/doc/sipcapture_admin.xml
+++ b/src/modules/sipcapture/doc/sipcapture_admin.xml
@@ -89,14 +89,14 @@



-   Default value is DEFAULT_DB_URL.
+   Default value is .



Set db_url parameter

 ...
-modparam("sipcapture", "db_url", "mysql://user:passwd@host/dbname")
+modparam("sipcapture", "db_url", "")
 ...
 


___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:5.8:29ef69b8: sipcapture: fix default DB URL docs

[Henning Westerholt via sr-dev]

Module: kamailio
Branch: 5.8
Commit: 29ef69b8807023e082d7c9880c63bee11d4f3b30
URL: 
https://github.com/kamailio/kamailio/commit/29ef69b8807023e082d7c9880c63bee11d4f3b30

Author: Henning Westerholt 
Committer: Henning Westerholt 
Date: 2024-05-07T19:02:16Z

sipcapture: fix default DB URL docs

(cherry picked from commit aeeeb0c2f46c2575639dd725bef78fac64219a07)

---

Modified: src/modules/sipcapture/doc/sipcapture_admin.xml

---

Diff:  
https://github.com/kamailio/kamailio/commit/29ef69b8807023e082d7c9880c63bee11d4f3b30.diff
Patch: 
https://github.com/kamailio/kamailio/commit/29ef69b8807023e082d7c9880c63bee11d4f3b30.patch

---

diff --git a/src/modules/sipcapture/doc/sipcapture_admin.xml 
b/src/modules/sipcapture/doc/sipcapture_admin.xml
index 6a428133866..258e30fe237 100644
--- a/src/modules/sipcapture/doc/sipcapture_admin.xml
+++ b/src/modules/sipcapture/doc/sipcapture_admin.xml
@@ -89,14 +89,14 @@



-   Default value is DEFAULT_DB_URL.
+   Default value is .



Set db_url parameter

 ...
-modparam("sipcapture", "db_url", "mysql://user:passwd@host/dbname")
+modparam("sipcapture", "db_url", "")
 ...
 


___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:aeeeb0c2: sipcapture: fix default DB URL docs

[Henning Westerholt via sr-dev]

Module: kamailio
Branch: master
Commit: aeeeb0c2f46c2575639dd725bef78fac64219a07
URL: 
https://github.com/kamailio/kamailio/commit/aeeeb0c2f46c2575639dd725bef78fac64219a07

Author: Henning Westerholt 
Committer: Henning Westerholt 
Date: 2024-05-07T16:14:46Z

sipcapture: fix default DB URL docs

---

Modified: src/modules/sipcapture/doc/sipcapture_admin.xml

---

Diff:  
https://github.com/kamailio/kamailio/commit/aeeeb0c2f46c2575639dd725bef78fac64219a07.diff
Patch: 
https://github.com/kamailio/kamailio/commit/aeeeb0c2f46c2575639dd725bef78fac64219a07.patch

---

diff --git a/src/modules/sipcapture/doc/sipcapture_admin.xml 
b/src/modules/sipcapture/doc/sipcapture_admin.xml
index 6a428133866..258e30fe237 100644
--- a/src/modules/sipcapture/doc/sipcapture_admin.xml
+++ b/src/modules/sipcapture/doc/sipcapture_admin.xml
@@ -89,14 +89,14 @@



-   Default value is DEFAULT_DB_URL.
+   Default value is .



Set db_url parameter

 ...
-modparam("sipcapture", "db_url", "mysql://user:passwd@host/dbname")
+modparam("sipcapture", "db_url", "")
 ...
 


___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] sipcapture: docs - fix default value for parameter (PR #3836)

[Henning Westerholt via sr-dev]

Thank you, merged.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3836#issuecomment-2085527583
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] sipcapture: docs - fix default value for parameter (PR #3836)

[Henning Westerholt via sr-dev]

Merged #3836 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3836#event-12659199112
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:265c9482: sipcapture: docs - fix default value for parameter

[Henning Westerholt via sr-dev]

Module: kamailio
Branch: master
Commit: 265c948286f2df5136179c95fbb1d7f1255e4c71
URL: 
https://github.com/kamailio/kamailio/commit/265c948286f2df5136179c95fbb1d7f1255e4c71

Author: Jannik <40364587+volkl...@users.noreply.github.com>
Committer: Henning Westerholt 
Date: 2024-04-30T16:38:40+02:00

sipcapture: docs - fix default value for parameter

---

Modified: src/modules/sipcapture/doc/sipcapture_admin.xml

---

Diff:  
https://github.com/kamailio/kamailio/commit/265c948286f2df5136179c95fbb1d7f1255e4c71.diff
Patch: 
https://github.com/kamailio/kamailio/commit/265c948286f2df5136179c95fbb1d7f1255e4c71.patch

---

diff --git a/src/modules/sipcapture/doc/sipcapture_admin.xml 
b/src/modules/sipcapture/doc/sipcapture_admin.xml
index 8bca159432f..6a428133866 100644
--- a/src/modules/sipcapture/doc/sipcapture_admin.xml
+++ b/src/modules/sipcapture/doc/sipcapture_admin.xml
@@ -89,7 +89,7 @@



-   Default value is "".
+   Default value is DEFAULT_DB_URL.




___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] Mem leak in smsops which leads to the udp receiver process leak memory continuously (Issue #3833)

[Henning Westerholt via sr-dev]

Hello, thanks for the feedback. Your description sounds indeed like a memory 
leak. The code logic got changed, so its freeing the rp_data when its allocated 
now. Its a bit longer function, so it should be properly analyzed that its 
freed in all error conditions (which does not look like that right now).

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3833#issuecomment-2085047132
You are receiving this because you commented.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] Mem leak in smsops which leads to the udp receiver process leak memory continuously (Issue #3833)

[Henning Westerholt via sr-dev]

Hello,

it looks like that you are observing a memory leak. You can look into it e.g. 
with memory debugging and try to debug it:
https://www.kamailio.org/wiki/tutorials/troubleshooting/memory

Generally, I would suggest decreasing the PGK memory, 256 MB is way too much, 
e.g, to 16-32 MB and increase the shared memory e.g. to 1GB.
If there is a large memory leak, the memory will be used anyway so it makes no 
sense to increase it too much.

Cheers,

Henning

--
Henning Westerholt – https://skalatan.de/blog/
Kamailio services – https://gilawa.com

From: paresh-panda via sr-dev 
Sent: Montag, 29. April 2024 14:06
To: Kamailio Devel List 
Cc: Subscribed ; paresh-panda 

Subject: [sr-dev] [kamailio/kamailio] Mem leak in smsops which leads to the udp 
receiver process leak memory continuously (Issue #3833)


Hi,
I am using Kamailio 5.8.1 ( ubuntu 22.04 Jammy 64 Bit),. Below are the 
observations.

I am running a load of 500 3GPP IMS SMS which kamailio decodes and sends to 
another application over Rabbit MQ (Kazoo Module).
-m 512 -M 256 , using 512 MB Shared memory and 256MB Package Memory.

When the load for 20 mins the available Memory drops from 80% to 25%

And I see below error logs

Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 
1 MESSAGE 739708-3401@192.168.136.152} [core/mem/q_malloc.c:324]: 
qm_find_free(): qm_find_free(0x7ff912e21010, 192); Free fragment not found!
Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 
1 MESSAGE 739708-3401@192.168.136.152} [core/mem/q_malloc.c:463]: qm_malloc(): 
qm_malloc(0x7ff912e21010, 192) called from smsops: smsops_impl.c: 
decode_3gpp_sms(813), module: smsops; Free fragment not found!
Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 
1 MESSAGE 739708-3401@192.168.136.152} smsops [smsops_impl.c:815]: 
decode_3gpp_sms(): Error allocating 192 bytes!
Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 
1 MESSAGE 739708-3401@192.168.136.152} smsops [smsops_impl.c:1320]: 
pv_get_sms(): Error getting/decoding RP-Data from request!
Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 
1 MESSAGE 739708-3401@192.168.136.152} [core/mem/q_malloc.c:324]: 
qm_find_free(): qm_find_free(0x7ff912e21010, 192); Free fragment not found!
Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 
1 MESSAGE 739708-3401@192.168.136.152} [core/mem/q_malloc.c:463]: qm_malloc(): 
qm_malloc(0x7ff912e21010, 192) called from smsops: smsops_impl.c: 
decode_3gpp_sms(813), module: smsops; Free fragment not found!
Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 
1 MESSAGE 739708-3401@192.168.136.152} smsops [smsops_impl.c:815]: 
decode_3gpp_sms(): Error allocating 192 bytes!
Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 
1 MESSAGE 739708-3401@192.168.136.152} smsops [smsops_impl.c:1320]: 
pv_get_sms(): Error getting/decoding RP-Data from request!
Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 
1 MESSAGE 739708-3401@192.168.136.152} [core/pvapi.c:1136]: pv_parse_format(): 
could not allocate private memory from pkg pool
Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 
1 MESSAGE 739708-3401@192.168.136.152} [core/sr_module.c:1318]: fix_param(): 
bad PVE format: "PRD-IR92/11 term-Motorola/XT2205-1-T2STS33.105-51-11-1-2-2 
device-type/smart-phone"
Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 
1 MESSAGE 739708-3401@192.168.136.152} [core/mod_fix.c:601]: fixup_spve_null(): 
Cannot convert function parameter 1 to spve
Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 
1 MESSAGE 739708-3401@192.168.136.152} [core/action.c:1178]: do_action(): 
runtime fixup failed for jansson_set param 3
Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 
1 MESSAGE 739708-3401@192.168.136.152} [core/action.c:1566]: do_action(): run 
action error at: /etc/kamailio/kamailio.cfg:539
Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 
1 MESSAGE 739708-3401@192.168.136.152} [core/sr_module.c:1208]: fix_param(): 
could not allocate private memory from pkg pool
Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 
1 MESSAGE 739708-3401@192.168.136.152} [core/mod_fix.c:601]: fixup_spve_null(): 
Cannot convert function parameter 1 to spve
Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 
1 MESSAGE 739708-3401@192.168.136.152} [core/action.c:1178]: do_action(): 
runtime fixup failed for jansson_set param 3
Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 /usr/sbin/kamailio[5520]: ERROR: {1 
1 MESSAGE 739708-3401@192.168.136.152} [core/action.c:1566]: do_action(): run 
action error at: /etc/kamailio/kamailio.cfg:540
Apr 29 13:28:53 stgn-haud-vm-ub-kamailio01 

[sr-dev] git:master:20a75004: ims_registrar_scscf: fix uninitialized arguments in save()

[Henning Westerholt via sr-dev]

Module: kamailio
Branch: master
Commit: 20a75004d53a06da0f22b11804a4d83496ad8919
URL: 
https://github.com/kamailio/kamailio/commit/20a75004d53a06da0f22b11804a4d83496ad8919

Author: Alexander Couzens 
Committer: Henning Westerholt 
Date: 2024-04-29T19:27:15+02:00

ims_registrar_scscf: fix uninitialized arguments in save()

The script "save" command can be used with different arguments:
2, 3 and 4.
But internally for all save() calls the exact same function is use, w_save().
When calling save("PRE_REG_SAR_REPLY","location"); as given by the examples,
kamailio will call w_save().
Because the command code will cast the function pointer, the w_save() function
is called with 2 uninitialized arguments *mode, *c_flags.
mode is unused, seems a legacy argument. c_flags is referenced resulting in a 
crash
if not null.

Use separate wrapper functions to handle different argument number.

Fixes: a627c9a04a74 ("ims_registrar_scscf: Extend save() with optional flag")

---

Modified: src/modules/ims_registrar_scscf/ims_registrar_scscf_mod.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/20a75004d53a06da0f22b11804a4d83496ad8919.diff
Patch: 
https://github.com/kamailio/kamailio/commit/20a75004d53a06da0f22b11804a4d83496ad8919.patch

---

diff --git a/src/modules/ims_registrar_scscf/ims_registrar_scscf_mod.c 
b/src/modules/ims_registrar_scscf/ims_registrar_scscf_mod.c
index 07403a2b1e6..d17b5e38823 100644
--- a/src/modules/ims_registrar_scscf/ims_registrar_scscf_mod.c
+++ b/src/modules/ims_registrar_scscf/ims_registrar_scscf_mod.c
@@ -131,7 +131,9 @@ struct _pv_req_data _pv_treq;
 static int mod_init(void);
 static int child_init(int);
 static void mod_destroy(void);
-static int w_save(
+static int w_save2(struct sip_msg *_m, char *_route, char *_d);
+static int w_save3(struct sip_msg *_m, char *_route, char *_d, char *mode);
+static int w_save4(
struct sip_msg *_m, char *_route, char *_d, char *mode, char 
*_cflags);
 static int w_assign_server_unreg(
struct sip_msg *_m, char *_route, char *_d, char *_direction);
@@ -231,11 +233,11 @@ static pv_export_t mod_pvs[] = {
  * Exported functions
  */
 static cmd_export_t cmds[] = {
-   {"save", (cmd_function)w_save, 2, assign_save_fixup3_async, 0,
+   {"save", (cmd_function)w_save2, 2, assign_save_fixup3_async, 0,
REQUEST_ROUTE | ONREPLY_ROUTE},
-   {"save", (cmd_function)w_save, 3, assign_save_fixup3_async, 0,
+   {"save", (cmd_function)w_save3, 3, assign_save_fixup3_async, 0,
REQUEST_ROUTE | ONREPLY_ROUTE},
-   {"save", (cmd_function)w_save, 4, save_fixup3, free_uint_fixup,
+   {"save", (cmd_function)w_save4, 4, save_fixup3, free_uint_fixup,
REQUEST_ROUTE | ONREPLY_ROUTE},
{"lookup", (cmd_function)w_lookup, 1, domain_fixup, 0,
REQUEST_ROUTE | FAILURE_ROUTE},
@@ -677,9 +679,21 @@ AAAMessage *callback_cdp_request(AAAMessage *request, void 
*param)
 /*! \brief
  * Wrapper to save(location)
  */
-static int w_save(
+static int w_save2(struct sip_msg *_m, char *_route, char *_d)
+{
+   return save(_m, _d, _route, 0);
+}
+
+static int w_save3(struct sip_msg *_m, char *_route, char *_d, char *_mode)
+{
+   /* mode is unsed. Docs says legacy parameter? Maybe to be compatible 
with registrar/save? */
+   return save(_m, _d, _route, 0);
+}
+
+static int w_save4(
struct sip_msg *_m, char *_route, char *_d, char *mode, char 
*_cflags)
 {
+   /* mode is unsed. Docs says legacy parameter? Maybe to be compatible 
with registrar/save? */
if(_cflags) {
return save(_m, _d, _route, ((int)(*_cflags)));
}

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] ims_registrar_scscf: fix uninitialized access of memory, minor refactors (PR #3787)

[Henning Westerholt via sr-dev]

Merged #3787 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3787#event-12646570767
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:82a6d7ea: ims_registrar_scscf: refactor save_fixup4

[Henning Westerholt via sr-dev]

Module: kamailio
Branch: master
Commit: 82a6d7ea6edbaca60879a38c5e74e40920e89342
URL: 
https://github.com/kamailio/kamailio/commit/82a6d7ea6edbaca60879a38c5e74e40920e89342

Author: Alexander Couzens 
Committer: Henning Westerholt 
Date: 2024-04-29T19:27:15+02:00

ims_registrar_scscf: refactor save_fixup4

Rename function to match argument number.
Use assign_save_fixup3_async instead of the code copy

---

Modified: src/modules/ims_registrar_scscf/ims_registrar_scscf_mod.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/82a6d7ea6edbaca60879a38c5e74e40920e89342.diff
Patch: 
https://github.com/kamailio/kamailio/commit/82a6d7ea6edbaca60879a38c5e74e40920e89342.patch

---

diff --git a/src/modules/ims_registrar_scscf/ims_registrar_scscf_mod.c 
b/src/modules/ims_registrar_scscf/ims_registrar_scscf_mod.c
index d17b5e38823..854ed2d484f 100644
--- a/src/modules/ims_registrar_scscf/ims_registrar_scscf_mod.c
+++ b/src/modules/ims_registrar_scscf/ims_registrar_scscf_mod.c
@@ -145,7 +145,7 @@ static int w_lookup_path_to_contact(struct sip_msg *_m, 
char *contact_uri);
 static int domain_fixup(void **param, int param_no);
 static int assign_save_fixup3_async(void **param, int param_no);
 static int free_uint_fixup(void **param, int param_no);
-static int save_fixup3(void **param, int param_no);
+static int save_fixup4(void **param, int param_no);
 static int unreg_fixup(void **param, int param_no);
 static int fetchc_fixup(void **param, int param_no);
 /*! \brief Functions */
@@ -237,7 +237,7 @@ static cmd_export_t cmds[] = {
REQUEST_ROUTE | ONREPLY_ROUTE},
{"save", (cmd_function)w_save3, 3, assign_save_fixup3_async, 0,
REQUEST_ROUTE | ONREPLY_ROUTE},
-   {"save", (cmd_function)w_save4, 4, save_fixup3, free_uint_fixup,
+   {"save", (cmd_function)w_save4, 4, save_fixup4, free_uint_fixup,
REQUEST_ROUTE | ONREPLY_ROUTE},
{"lookup", (cmd_function)w_lookup, 1, domain_fixup, 0,
REQUEST_ROUTE | FAILURE_ROUTE},
@@ -821,27 +821,10 @@ static int free_uint_fixup(void **param, int param_no)
return 0;
 }
 
-static int save_fixup3(void **param, int param_no)
+static int save_fixup4(void **param, int param_no)
 {
-   if(strlen((char *)*param) <= 0) {
-   LM_ERR("empty parameter %d not allowed\n", param_no);
-   return -1;
-   }
-
-   if(param_no == 1) { //route name - static or dynamic string (config 
vars)
-   if(fixup_spve_null(param, param_no) < 0)
-   return -1;
-   return 0;
-   } else if(param_no == 2) {
-   udomain_t *d;
-
-   if(ul.register_udomain((char *)*param, ) < 0) {
-   LM_ERR("Error doing fixup on save");
-   return -1;
-   }
-   *param = (void *)d;
-   } else if(param_no == 3) {
-   return 0;
+   if(param_no < 4) {
+   return assign_save_fixup3_async(param, param_no);
} else if(param_no == 4) {
return unit_fixup(param, param_no);
}

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:6f908f05: ims_registrar_scscf: fix typo in function name uint_fixup

[Henning Westerholt via sr-dev]

Module: kamailio
Branch: master
Commit: 6f908f05d4691abcb1b3a745048d3cc2a9996676
URL: 
https://github.com/kamailio/kamailio/commit/6f908f05d4691abcb1b3a745048d3cc2a9996676

Author: Alexander Couzens 
Committer: Henning Westerholt 
Date: 2024-04-29T19:27:15+02:00

ims_registrar_scscf: fix typo in function name uint_fixup

---

Modified: src/modules/ims_registrar_scscf/ims_registrar_scscf_mod.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/6f908f05d4691abcb1b3a745048d3cc2a9996676.diff
Patch: 
https://github.com/kamailio/kamailio/commit/6f908f05d4691abcb1b3a745048d3cc2a9996676.patch

---

diff --git a/src/modules/ims_registrar_scscf/ims_registrar_scscf_mod.c 
b/src/modules/ims_registrar_scscf/ims_registrar_scscf_mod.c
index 854ed2d484f..80535d77b5a 100644
--- a/src/modules/ims_registrar_scscf/ims_registrar_scscf_mod.c
+++ b/src/modules/ims_registrar_scscf/ims_registrar_scscf_mod.c
@@ -786,7 +786,7 @@ static int assign_save_fixup3_async(void **param, int 
param_no)
return 0;
 }
 
-static int unit_fixup(void **param, int param_no)
+static int uint_fixup(void **param, int param_no)
 {
str s;
unsigned int *num;
@@ -826,7 +826,7 @@ static int save_fixup4(void **param, int param_no)
if(param_no < 4) {
return assign_save_fixup3_async(param, param_no);
} else if(param_no == 4) {
-   return unit_fixup(param, param_no);
+   return uint_fixup(param, param_no);
}
 
return 0;

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:c3e6c1ed: ims_registrar_scscf: free_uint_fixup: fix memleak/freeing the wrong parameter

[Henning Westerholt via sr-dev]

Module: kamailio
Branch: master
Commit: c3e6c1edc7531406208efe2965243e6e81506127
URL: 
https://github.com/kamailio/kamailio/commit/c3e6c1edc7531406208efe2965243e6e81506127

Author: Alexander Couzens 
Committer: Henning Westerholt 
Date: 2024-04-29T19:27:15+02:00

ims_registrar_scscf: free_uint_fixup: fix memleak/freeing the wrong parameter

The free_uint_fixup() freed the wrong parameter in the past.

---

Modified: src/modules/ims_registrar_scscf/ims_registrar_scscf_mod.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/c3e6c1edc7531406208efe2965243e6e81506127.diff
Patch: 
https://github.com/kamailio/kamailio/commit/c3e6c1edc7531406208efe2965243e6e81506127.patch

---

diff --git a/src/modules/ims_registrar_scscf/ims_registrar_scscf_mod.c 
b/src/modules/ims_registrar_scscf/ims_registrar_scscf_mod.c
index 80535d77b5a..714ae571518 100644
--- a/src/modules/ims_registrar_scscf/ims_registrar_scscf_mod.c
+++ b/src/modules/ims_registrar_scscf/ims_registrar_scscf_mod.c
@@ -814,7 +814,7 @@ static int uint_fixup(void **param, int param_no)
 
 static int free_uint_fixup(void **param, int param_no)
 {
-   if(*param && param_no == 2) {
+   if(*param && param_no == 4) {
pkg_free(*param);
*param = 0;
}

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] ims_registrar_scscf: fix uninitialized access of memory, minor refactors (PR #3787)

[Henning Westerholt via sr-dev]

Thanks again, merged

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3787#issuecomment-2083271557
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] ims_registrar_scscf: fix uninitialized access of memory, minor refactors (PR #3787)

[Henning Westerholt via sr-dev]

Thanks for the PR, it will be merged in the next days if there are no more 
comments. Regarding further cleanups, it probably should also be investigated 
if we can replace the uint_fixup with some standard fixup from the core.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3787#issuecomment-2082269187
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] The tm.cancel function does not generate a “tm:local-request” event. (Issue #3831)

[Henning Westerholt via sr-dev]

Thanks for the report, it was probably not implemented yet for CANCEL generated 
from tm over a RPC command.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3831#issuecomment-2079157964
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] uac: add reload_delta parameter (PR #3829)

[Henning Westerholt via sr-dev]

Thanks for the PR. Could you please fix the format by running clang-format on 
the files and do a force-push to update the individual commit(s)? This check is 
right now failing.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3829#issuecomment-2078719839
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] multiple subsytems: unsigned integer conversion fixes (PR #3828)

[Henning Westerholt via sr-dev]

Thanks for the PR. Could you please fix the format by running clang-format on 
the files and do a force-push to update the individual commits? This check is 
right now failing.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3828#issuecomment-2078684597
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:9f284503: uid_auth_db: spelling fix in documentation

[Henning Westerholt via sr-dev]

Module: kamailio
Branch: master
Commit: 9f28450312749dfbc021a8cbc23472c8a39d3fef
URL: 
https://github.com/kamailio/kamailio/commit/9f28450312749dfbc021a8cbc23472c8a39d3fef

Author: Henning Westerholt 
Committer: Henning Westerholt 
Date: 2024-04-26T05:54:27Z

uid_auth_db: spelling fix in documentation

---

Modified: src/modules/uid_auth_db/auth_db.xml

---

Diff:  
https://github.com/kamailio/kamailio/commit/9f28450312749dfbc021a8cbc23472c8a39d3fef.diff
Patch: 
https://github.com/kamailio/kamailio/commit/9f28450312749dfbc021a8cbc23472c8a39d3fef.patch

---

diff --git a/src/modules/uid_auth_db/auth_db.xml 
b/src/modules/uid_auth_db/auth_db.xml
index 25849663c54..99e5eb7c594 100644
--- a/src/modules/uid_auth_db/auth_db.xml
+++ b/src/modules/uid_auth_db/auth_db.xml
@@ -66,7 +66,7 @@
 the textops module.
   
   
-The reason for the failure can be determined from the interger
+The reason for the failure can be determined from the integer
 return value stored in the $? attribute.
 A value of -3 indicates that it was impossible
 to retrieve credentials from the request. A 400 (Bad Request)

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:db176a49: core: spelling fix in comment and log message

[Henning Westerholt via sr-dev]

Module: kamailio
Branch: master
Commit: db176a4918c0b500f5f051cad16fd8d442450ab7
URL: 
https://github.com/kamailio/kamailio/commit/db176a4918c0b500f5f051cad16fd8d442450ab7

Author: Henning Westerholt 
Committer: Henning Westerholt 
Date: 2024-04-26T05:53:30Z

core: spelling fix in comment and log message

---

Modified: src/core/switch.c
Modified: src/core/ut.h

---

Diff:  
https://github.com/kamailio/kamailio/commit/db176a4918c0b500f5f051cad16fd8d442450ab7.diff
Patch: 
https://github.com/kamailio/kamailio/commit/db176a4918c0b500f5f051cad16fd8d442450ab7.patch

---

diff --git a/src/core/switch.c b/src/core/switch.c
index 79cee21c501..e12b7e5f6d1 100644
--- a/src/core/switch.c
+++ b/src/core/switch.c
@@ -203,7 +203,7 @@ int fix_switch(struct action *t)
return E_BUG;
}
if(rval_expr_eval_long(0, 0, >label.match_int, 
c->ct_rve) < 0) {
-   LM_ERR("case expression (%d,%d) has 
non-interger type\n",
+   LM_ERR("case expression (%d,%d) has non-integer 
type\n",
c->ct_rve->fpos.s_line, 
c->ct_rve->fpos.s_col);
return E_BUG;
}
diff --git a/src/core/ut.h b/src/core/ut.h
index ff8d964e559..1efd7abd242 100644
--- a/src/core/ut.h
+++ b/src/core/ut.h
@@ -315,7 +315,7 @@ static inline char *int2strbuf(unsigned long l, char *r, 
int r_size, int *len)
 }
 
 extern char ut_buf_int2str[INT2STR_MAX_LEN];
-/** interger(long) to string conversion.
+/** integer(long) to string conversion.
  * This version uses a static buffer (shared with sint2str()).
  * WARNING: other function calls might overwrite the static buffer, so
  * either always save the result immediately or use int2strbuf(...).

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] ERROR cfgtrace:dbg_cfg_trace() (Issue #3821)

[Henning Westerholt via sr-dev]

Closed #3821 as completed.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3821#event-12593979051
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] ERROR cfgtrace:dbg_cfg_trace() (Issue #3821)

[Henning Westerholt via sr-dev]

Hello, the cfgtrace ERROR output is just the normal operation of this module. 
It gives information about the cfg. 
Please address generic question about kamailio usage to our sr-users mailing 
list, the tracker is for reporting bugs and other issues with the code.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3821#issuecomment-2075224333
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] tcpops module event_route[tcp:closed] route block $conid is null (Issue #3767)

[Henning Westerholt via sr-dev]

Reopened #3767.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3767#event-12571408485
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] usrloc: check on db delete the return value of memchr (PR #3815)

[Henning Westerholt via sr-dev]

Merged #3815 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3815#event-12546672427
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:49276a1f: usrloc: check on db delete the return value of memchr

[Henning Westerholt via sr-dev]

Module: kamailio
Branch: master
Commit: 49276a1f43b1a3bf4a8d681888df964000360c79
URL: 
https://github.com/kamailio/kamailio/commit/49276a1f43b1a3bf4a8d681888df964000360c79

Author: Rick Barenthin 
Committer: Henning Westerholt 
Date: 2024-04-20T06:35:51+02:00

usrloc: check on db delete the return value of memchr

When inserting into the database the AOR is split at the @ sign and
if there is no @ sign in the AOR only the domain part is filled and the
user part is left empty.

But for deleting this is not done and the query failed to be executed
and the AOR is not deleted. This PR add this behaviour of only comparing 
against the
domain part if the AOR doesn't contain a @ sign.

---

Modified: src/modules/usrloc/urecord.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/49276a1f43b1a3bf4a8d681888df964000360c79.diff
Patch: 
https://github.com/kamailio/kamailio/commit/49276a1f43b1a3bf4a8d681888df964000360c79.patch

---

diff --git a/src/modules/usrloc/urecord.c b/src/modules/usrloc/urecord.c
index e027affc8aa..3c394a24a10 100644
--- a/src/modules/usrloc/urecord.c
+++ b/src/modules/usrloc/urecord.c
@@ -491,13 +491,17 @@ int db_delete_urecord(urecord_t *_r)
vals[0].val.str_val.len = _r->aor.len;
 
if(ul_use_domain) {
-   dom = memchr(_r->aor.s, '@', _r->aor.len);
-   vals[0].val.str_val.len = dom - _r->aor.s;
-
vals[1].type = DB1_STR;
vals[1].nul = 0;
-   vals[1].val.str_val.s = dom + 1;
-   vals[1].val.str_val.len = _r->aor.s + _r->aor.len - dom - 1;
+   dom = memchr(_r->aor.s, '@', _r->aor.len);
+   if(dom == 0) {
+   vals[0].val.str_val.len = 0;
+   vals[1].val.str_val = _r->aor;
+   } else {
+   vals[0].val.str_val.len = dom - _r->aor.s;
+   vals[1].val.str_val.s = dom + 1;
+   vals[1].val.str_val.len = _r->aor.s + _r->aor.len - dom 
- 1;
+   }
}
 
if(ul_dbf.use_table(ul_dbh, _r->domain) < 0) {

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] Misleading source IP of 1.0.0.127 in event routes (Issue #3817)

[Henning Westerholt via sr-dev]

Thanks for the report. Yes, it should be probably changed to e.g. 127.0.0.1 or 
another address from this range.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3817#issuecomment-2066582128
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] usrloc: check on db delete the return value of memchr (PR #3815)

[Henning Westerholt via sr-dev]

Thanks for fixing the format. If there are no more comments, it will be merged 
in the next days.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3815#issuecomment-2066575520
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] Core parameters user_agent_header fail to take effect (Issue #3816)

[Henning Westerholt via sr-dev]

For replies generated from Kamailio you need to set the server_header 
parameter. The user_agent_header is for Kamailio generated requests. For 
questions like this please contact our sr-users lists, as this bug tracker is 
for bugs and issues in the code.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3816#issuecomment-2066288250
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] Core parameters user_agent_header fail to take effect (Issue #3816)

[Henning Westerholt via sr-dev]

Closed #3816 as completed.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3816#event-12536494983
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] core/tcp_main: Match protocol when lookup tcp/tls connections (PR #3810)

[Henning Westerholt via sr-dev]

@frideo Thank you for the tests!

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3810#issuecomment-2059106348
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] core/tcp_main: Match protocol when lookup tcp/tls connections (PR #3810)

[Henning Westerholt via sr-dev]

Merged #3810 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3810#event-12488998774
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:0a28a93c: tcp_main: Update comment docs

[Henning Westerholt via sr-dev]

Module: kamailio
Branch: master
Commit: 0a28a93c6e060081267dc686e342d45ef03358e7
URL: 
https://github.com/kamailio/kamailio/commit/0a28a93c6e060081267dc686e342d45ef03358e7

Author: Xenofon Karamanos <22965395+xkara...@users.noreply.github.com>
Committer: Henning Westerholt 
Date: 2024-04-16T14:42:20+02:00

tcp_main: Update comment docs

---

Modified: src/core/tcp_main.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/0a28a93c6e060081267dc686e342d45ef03358e7.diff
Patch: 
https://github.com/kamailio/kamailio/commit/0a28a93c6e060081267dc686e342d45ef03358e7.patch

---

diff --git a/src/core/tcp_main.c b/src/core/tcp_main.c
index 0ea1b541ea6..e3323736cc0 100644
--- a/src/core/tcp_main.c
+++ b/src/core/tcp_main.c
@@ -1697,8 +1697,8 @@ void tcpconn_rm(struct tcp_connection *c)
 
 /* finds a connection, if id=0 uses the ip addr, port, local_ip and local port
  *  (host byte order) and tries to find the connection that matches all of
- *   them. Wild cards can be used for local_ip and local_port (a 0 filled
- *   ip address and/or a 0 local port).
+ *   them. Wild cards can be used for local_ip, local_port and proto (a 0 
filled
+ *   ip address and/or a 0 local port and/or PROTO_NONE).
  * WARNING: unprotected (locks) use tcpconn_get unless you really
  * know what you are doing */
 struct tcp_connection *_tcpconn_find(int id, struct ip_addr *ip, int port,
@@ -1754,7 +1754,7 @@ struct tcp_connection *_tcpconn_find(int id, struct 
ip_addr *ip, int port,
 
 
 /**
- * find if a tcp connection exits by id or remote+local address/port
+ * find if a tcp connection exits by id or remote+local address/port and 
protocol
  * - return: 1 if found; 0 if not found
  */
 int tcpconn_exists(int conn_id, ip_addr_t *peer_ip, int peer_port,
@@ -1774,6 +1774,7 @@ int tcpconn_exists(int conn_id, ip_addr_t *peer_ip, int 
peer_port,
 /* TCP connection find with locks and timeout
  * - local_addr contains the desired local ip:port. If null any local address
  * will be used. IN*ADDR_ANY or 0 port are wild cards.
+ * - proto is the protocol to match (PROTO_NONE for any)
  * - try_local_port makes the search use it first, instead of port from 
local_addr
  * If found, the connection's reference counter will be incremented, you might
  * want to decrement it after use.

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:175d755c: tcp_main: Match wss protocol

[Henning Westerholt via sr-dev]

Module: kamailio
Branch: master
Commit: 175d755c40bc50b78b2cf4f18ad22429289af90d
URL: 
https://github.com/kamailio/kamailio/commit/175d755c40bc50b78b2cf4f18ad22429289af90d

Author: Xenofon Karamanos <22965395+xkara...@users.noreply.github.com>
Committer: Henning Westerholt 
Date: 2024-04-16T14:42:20+02:00

tcp_main: Match wss protocol

---

Modified: src/core/tcp_main.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/175d755c40bc50b78b2cf4f18ad22429289af90d.diff
Patch: 
https://github.com/kamailio/kamailio/commit/175d755c40bc50b78b2cf4f18ad22429289af90d.patch

---

diff --git a/src/core/tcp_main.c b/src/core/tcp_main.c
index e3323736cc0..b71e7ad37f2 100644
--- a/src/core/tcp_main.c
+++ b/src/core/tcp_main.c
@@ -5435,7 +5435,7 @@ int wss_send(dest_info_t *dst, const char *buf, unsigned 
len)
if(tcp_connection_match == TCPCONN_MATCH_STRICT) {
con = tcpconn_lookup(dst->id, , port, from,
(dst->send_sock) ? 
dst->send_sock->port_no : 0, 0,
-   PROTO_NONE);
+   dst->proto);
} else {
con = tcpconn_get(dst->id, , port, from, 0);
}

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] tcp/docs: Added tcp_accept_iplimit config sample (PR #3792)

[Henning Westerholt via sr-dev]

commit 30a0fe2ea4b1b5

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3792#issuecomment-2059000217
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:4a40b16d: tcp_main: Add protocol argument for searching tcp/tls connections

[Henning Westerholt via sr-dev]

Module: kamailio
Branch: master
Commit: 4a40b16d4f9bef9bc75d3272c83878e6348aa0b8
URL: 
https://github.com/kamailio/kamailio/commit/4a40b16d4f9bef9bc75d3272c83878e6348aa0b8

Author: Xenofon Karamanos <22965395+xkara...@users.noreply.github.com>
Committer: Henning Westerholt 
Date: 2024-04-16T14:42:20+02:00

tcp_main: Add protocol argument for searching tcp/tls connections

---

Modified: src/core/forward.h
Modified: src/core/tcp_conn.h
Modified: src/core/tcp_main.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/4a40b16d4f9bef9bc75d3272c83878e6348aa0b8.diff
Patch: 
https://github.com/kamailio/kamailio/commit/4a40b16d4f9bef9bc75d3272c83878e6348aa0b8.patch

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:6779efd4: tcp_main: Add proto argument to tcpconn_exists function

[Henning Westerholt via sr-dev]

Module: kamailio
Branch: master
Commit: 6779efd430178adff0ae438d178e38c003e4e05c
URL: 
https://github.com/kamailio/kamailio/commit/6779efd430178adff0ae438d178e38c003e4e05c

Author: Xenofon Karamanos <22965395+xkara...@users.noreply.github.com>
Committer: Henning Westerholt 
Date: 2024-04-16T14:42:20+02:00

tcp_main: Add proto argument to tcpconn_exists function

---

Modified: src/core/tcp_main.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/6779efd430178adff0ae438d178e38c003e4e05c.diff
Patch: 
https://github.com/kamailio/kamailio/commit/6779efd430178adff0ae438d178e38c003e4e05c.patch

---

diff --git a/src/core/tcp_main.c b/src/core/tcp_main.c
index 73e2ef6163d..0ea1b541ea6 100644
--- a/src/core/tcp_main.c
+++ b/src/core/tcp_main.c
@@ -1758,13 +1758,12 @@ struct tcp_connection *_tcpconn_find(int id, struct 
ip_addr *ip, int port,
  * - return: 1 if found; 0 if not found
  */
 int tcpconn_exists(int conn_id, ip_addr_t *peer_ip, int peer_port,
-   ip_addr_t *local_ip, int local_port)
+   ip_addr_t *local_ip, int local_port, sip_protos_t proto)
 {
tcp_connection_t *c;
 
TCPCONN_LOCK;
-   c = _tcpconn_find(
-   conn_id, peer_ip, peer_port, local_ip, local_port, 
PROTO_NONE);
+   c = _tcpconn_find(conn_id, peer_ip, peer_port, local_ip, local_port, 
proto);
TCPCONN_UNLOCK;
if(c) {
return 1;
@@ -4497,7 +4496,8 @@ static inline int handle_new_connect(struct socket_info 
*si)
if(likely(tcpconn)) {
if(tcp_accept_unique) {
if(tcpconn_exists(0, >rcv.dst_ip, 
tcpconn->rcv.dst_port,
-  >rcv.src_ip, 
tcpconn->rcv.src_port)) {
+  >rcv.src_ip, 
tcpconn->rcv.src_port,
+  si->proto)) {
LM_ERR("duplicated connection by local and 
remote addresses\n");
_tcpconn_free(tcpconn);
tcp_safe_close(new_sock);

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:d81e5113: core/forward: Match protocol when forwarding

[Henning Westerholt via sr-dev]

Module: kamailio
Branch: master
Commit: d81e5113884b933251499630d112ec5b1150b8a4
URL: 
https://github.com/kamailio/kamailio/commit/d81e5113884b933251499630d112ec5b1150b8a4

Author: Xenofon Karamanos <22965395+xkara...@users.noreply.github.com>
Committer: Henning Westerholt 
Date: 2024-04-16T14:42:20+02:00

core/forward: Match protocol when forwarding

---

Modified: src/core/forward.h

---

Diff:  
https://github.com/kamailio/kamailio/commit/d81e5113884b933251499630d112ec5b1150b8a4.diff
Patch: 
https://github.com/kamailio/kamailio/commit/d81e5113884b933251499630d112ec5b1150b8a4.patch

---

diff --git a/src/core/forward.h b/src/core/forward.h
index 46bd3a36171..7b51e1a5559 100644
--- a/src/core/forward.h
+++ b/src/core/forward.h
@@ -189,7 +189,7 @@ static inline int msg_send_buffer(
if(tcp_connection_match == TCPCONN_MATCH_STRICT) {
con = tcpconn_lookup(dst->id, , port, from,
(dst->send_sock) ? 
dst->send_sock->port_no : 0, 0,
-   PROTO_NONE);
+   dst->proto);
} else {
con = tcpconn_get(dst->id, , port, from, 0);
}

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] tcp/docs: Added tcp_accept_iplimit config sample (PR #3792)

[Henning Westerholt via sr-dev]

Closed #3792.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3792#event-12488983805
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] tcp/docs: Added tcp_accept_iplimit config sample (PR #3792)

[Henning Westerholt via sr-dev]

Thanks, it was merged manually due to a wrong commit message.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3792#issuecomment-2058999395
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:30a0fe2e: etc/kamailio.cfg: added tcp_accept_iplimit config sample

[Henning Westerholt via sr-dev]

Module: kamailio
Branch: master
Commit: 30a0fe2ea4b1b59bb8e552f9abd3a65e1c7226ec
URL: 
https://github.com/kamailio/kamailio/commit/30a0fe2ea4b1b59bb8e552f9abd3a65e1c7226ec

Author: Arnis Voitkans 
Committer: Henning Westerholt 
Date: 2024-04-16T12:40:09Z

etc/kamailio.cfg: added tcp_accept_iplimit config sample

---

Modified: etc/kamailio.cfg

---

Diff:  
https://github.com/kamailio/kamailio/commit/30a0fe2ea4b1b59bb8e552f9abd3a65e1c7226ec.diff
Patch: 
https://github.com/kamailio/kamailio/commit/30a0fe2ea4b1b59bb8e552f9abd3a65e1c7226ec.patch

---

diff --git a/etc/kamailio.cfg b/etc/kamailio.cfg
index 3f9a5fe793f..cd2ecd0109f 100755
--- a/etc/kamailio.cfg
+++ b/etc/kamailio.cfg
@@ -211,6 +211,9 @@ tcp_connection_lifetime=3605
 /* upper limit for TCP connections (it includes the TLS connections) */
 tcp_max_connections=2048
 
+/* upper limit for TCP connections for one ip address - default 1024 */
+#tcp_accept_iplimit=1024
+
 #!ifdef WITH_JSONRPC
 tcp_accept_no_cl=yes
 #!endif

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:b4753ae4: rtpengine: fix pkg mem leak in send_rtpp_command()

[Henning Westerholt via sr-dev]

Module: kamailio
Branch: master
Commit: b4753ae4216b0c960ac094f4be8232fb4d0147b0
URL: 
https://github.com/kamailio/kamailio/commit/b4753ae4216b0c960ac094f4be8232fb4d0147b0

Author: vijay kumar 
Committer: Henning Westerholt 
Date: 2024-04-16T14:38:27+02:00

rtpengine: fix pkg mem leak in send_rtpp_command()
- freed request.s after sending request to websocket

---

Modified: src/modules/rtpengine/rtpengine.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/b4753ae4216b0c960ac094f4be8232fb4d0147b0.diff
Patch: 
https://github.com/kamailio/kamailio/commit/b4753ae4216b0c960ac094f4be8232fb4d0147b0.patch

---

diff --git a/src/modules/rtpengine/rtpengine.c 
b/src/modules/rtpengine/rtpengine.c
index c51b4742081..6d62b92900d 100644
--- a/src/modules/rtpengine/rtpengine.c
+++ b/src/modules/rtpengine/rtpengine.c
@@ -3672,6 +3672,7 @@ static char *send_rtpp_command(
 
len = _rtpe_lwscb.request(>rn_url, (str *)_proto, 
,
, rtpengine_tout_ms * 1000);
+   pkg_free(request.s);
 
if(len < 0) {
LM_ERR("failed to do websocket request\n");

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] rtpengine: fix pkg mem leak in send_rtpp_command() (PR #3813)

[Henning Westerholt via sr-dev]

Merged #3813 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3813#event-12488936001
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] rtpengine: fix pkg mem leak in send_rtpp_command() (PR #3813)

[Henning Westerholt via sr-dev]

> Hi @henningw , memory is getting allocated in line 3660 , which was not 
> getting freed. request.s = pkg_malloc(len + 1);

Sure. :-) I checked in the lwsc module (which is actually called from the 
rtpengine module in this function part) to no have a double free. If nobody 
else comment, I will merge it tomorrow.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3813#issuecomment-2057182250
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] rtpengine: fix pkg mem leak in send_rtpp_command() (PR #3813)

[Henning Westerholt via sr-dev]

Looks good to me. The lwsc module seems to malloc its own memory for the sdata, 
so it should be freed in rtpengine module code.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3813#issuecomment-2056319994
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] PKG Memory Leak with RTPEngine Module with WebSocket (Issue #3777)

[Henning Westerholt via sr-dev]

@vijaykumar-exotel Thanks for the confirmation, do you could also paste the 
updated log messages here?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3777#issuecomment-2049373279
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] tcp/docs: Added tcp_accept_iplimit config sample (PR #3792)

[Henning Westerholt via sr-dev]

Looks good to me, its also just a comment in the end. Lets wait a bit more for 
feedback and then merge it.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3792#issuecomment-2049370698
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] Less predictive algorithm for carrierroute hashing (Issue #3786)

[Henning Westerholt via sr-dev]

The hashing algorithm could be changed, sure. There are some internal hashing 
algorithms available (e.g. MD5) in the Kamailio core, there is of course also 
the possibility to use OpenSSL, but we might not want to introduce this 
depencency for that module.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3786#issuecomment-2049313684
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] Segfault in pua_dialoginfo.c when starting up with a dialog in the database (Issue #3743)

[Henning Westerholt via sr-dev]

Thanks for providing the additional information. Does it crash only with the DB 
entry listed from above? If not, maybe you can provide the DB dump somewhere 
for download (sensitive data removed of course)?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3743#issuecomment-2049304633
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] pike: fix documentation for reqs_density_per_unit (PR #3806)

[Henning Westerholt via sr-dev]

Thanks for the PR. If I remember correctly the module does some kind of IP 
prefix aggregation, and therefore the condition was correct. But maybe that 
changed over the years?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3806#issuecomment-2039605428
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] ipops: Add PTR query support (PR #3802)

[Henning Westerholt via sr-dev]

@henningw commented on this pull request.



> @@ -883,6 +883,57 @@ if(dns_query("test.com", "xyz"))
 
 
 
+
+  
+ptr_query(ip, pvid)
+  
+
+  
+ Store the hostname that correspond to ip
+ in a config variable $ptrquery(pvid=>hostname).

The term "config variable" is also already used in the module, but I agree its 
probably more clear to spell it explictly.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3802#discussion_r1549082716
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] ipops: Add PTR query support (PR #3802)

[Henning Westerholt via sr-dev]

@henningw commented on this pull request.



> +   Store the hostname that correspond to ip
+ in a config variable $ptrquery(pvid=>hostname).
+  
+
+  Parameters:
+
+  
+
+  
+ ip - string or pseudo-variable 
containing the ip.
+ The resulting IP addresses from DNS query are 
compared with ipaddr.
+  
+
+
+  
+pvid - container id for script variable.

Actually the module uses already the term "container" in 3 places. So its 
probably fine in this regards.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3802#discussion_r1549081138
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] Kamailio 5.7 TLS fail to compile (Issue #3796)

[Henning Westerholt via sr-dev]

Thanks for the report. There are also some issues like this in file_out. 
@xkaraman could you please have a look?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3796#issuecomment-2023085521
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] xhttp_prom: export pkg mem statistics (PR #3793)

[Henning Westerholt via sr-dev]

Thanks for the PR. Two comments:
- the code format checker seems to fail, could you please check with 
clang-format and update if necessary?
- you introduced a new parameter "xhttp_prom_pkgmem_stats_enabled", what about 
just checking during startup if the kex module is available, if yes enable the 
statistics, if not log a INFO message about it. In the end there is already a 
parameter to specify the statistics to show: "xhttp_prom_stats", we probably 
should re-use it.

You are probably aware of this, but after changes just force-push to this PR is 
ok, no need to create a new one.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3793#issuecomment-2018763361
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] TLS crash in Kamailio 5.6.3 (5.7.4) on Debian 12 (Issue #3791)

[Henning Westerholt via sr-dev]

Thanks for the report. This is could be a known issue with OpenSSL 3.0 e.g. on 
bookworm. Please try with Kamailio 5.8.0, or even better, the soon to be 
released 5.8.1. If it still crashes, its probably something that still needs to 
be fixed in the tls module.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3791#issuecomment-2010488832
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] Dispatcher: added two new flags to mode parameter of ds_is_from_list function for more strictly matching (PR #3699)

[Henning Westerholt via sr-dev]

Yes, you probably need to create a new PR for that, against git master. For 5.8 
branch it will be cherry-picked.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3699#issuecomment-1988117447
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] Docs: TLS module known limitations need clarifications (Issue #3717)

[Henning Westerholt via sr-dev]

@barryib Have a look to the referenced PR, it should address your concerns, 
feedback welcome of course.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3717#issuecomment-1980182608
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] Discrepancies in migration of commits from herlesupreeth/kamailio to upstream (Issue #3772)

[Henning Westerholt via sr-dev]

Thanks for the great analysis guys. It looks that its now fine, maybe it can be 
closed then. If I misunderstood it, just create a PR with the necessary change.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3772#issuecomment-1978226657
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] tm: memory leak in case dropping messages in local-request event route (PR #3403)

[Henning Westerholt via sr-dev]

Reopened #3403.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3403#event-12008685798
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: Roadmap to next major Kamailio release series v5.8.x

[Henning Westerholt via sr-dev]

Hello Richard,

thank you, really helpful. Regarding the cdp module, we could provide some 
access to a test setup. A colleague will contact you about that.

Cheers,

Henning


--
Henning Westerholt – https://skalatan.de/blog/
Kamailio services – https://gilawa.com

From: Richard Chan via sr-dev 
Sent: Mittwoch, 28. Februar 2024 01:17
To: mico...@gmail.com; Kamailio (SER) - Development Mailing List 

Cc: Kamailio (SER) - Users Mailing List ; 
busin...@lists.kamailio.org; Richard Chan 
Subject: [sr-dev] Re: Roadmap to next major Kamailio release series v5.8.x

Hi Daniel

===
For the upgrading notes, some ideas —

"tls.so: fixing GH#3635 new global config tls_threads_mode = 0 | 1
0: is the default and is the existing Kamailio behaviour
1: run some initialization functions(libcurl, database) in a thread to avoid 
creating thread-locals in thread#1 before fork

On platforms with OpenSSL 3 "tls_threads_mode = 1" is needed to avoid shared 
memory contention, especially if other modules (eg. db_mysql, 
http_async_client, dispatcher with SIPS URIs) that might use TLS are loaded.

On platforms with OpenSSL 1.1.1 — shared memory contention is much harder to 
trigger — but this setting is recommended when other modules that use TLS are 
loaded"

===
Deployment note (for the wiki?)
Here is an SRE/deployment note — not sure of a good place to put this (maybe 
the wiki)

"To validate the config for OpenSSL 3/1.1.1 memory contention potential run the 
main kamailio process
under gdb (don't follow child forks: "set follow-fork-mode parent" — the 
default setting anyway)

# ** EITHER **
# deb-based: install dbgsym for libssl3 / libssl1.1
# RPM-based: install debuginfo for openssl, openssl-libs
# ** OR **
# configure gdb to use debuginfod for debug symbols

# STEP 1
# stop at main(), this step is required because the next breakpoint requires 
knowledge
# of thread#1
gdb> break main
gdb> run

# STEP 2
# this breakpoint detects if OpenSSL 3 initializes the thread-local 
err_thread_local
# in process#0.thread#1 — this causes shared memory contention
gdb> breakpoint CRYPTO_THREAD_set_local thread 1 if 
$_caller_is("ossl_err_get_state_int", 32)
gdb> commands
backtrace 32
continue
end

##For OpenSSL 1.1.1
gdb> breakpoint CRYPTO_THREAD_set_local thread 1 if 
$_caller_is("ERR_get_state", 32)
gdb> commands
backtrace 32
continue
end

# continue execution of Kamailio
gdb> continue

If this breakpoint is triggered then the configuration has potential for shared 
memory contention.
Do file an issue at GH with your configuration and the gdb output.
"

Dev note: I have completed an "audit" of all in-tree modules that load libssl — 
libcurl, libmariadb, libcrypto, libpq etc. The only one not touched is DIAMETER 
cdp.so with TLS. If anyone uses this and can provide me with temporary access 
that would be great.


Regards
Richard

On Tue, 27 Feb 2024 at 23:55, Daniel-Constantin Mierla via sr-dev 
mailto:sr-dev@lists.kamailio.org>> wrote:
Hello,

I propose to aim to get out 5.8.0 next week on Wednesday or Thursday
(March 6 or 7, 2024). I haven't seen much activity around issues in the
new features/modules. If time allows to build the pages for what-is-new
and how-to-upgrade (which I think it should be rather minimal), then I
think it should be no other major task. Overall it will be almost two
weeks since the 5.8 branch was created.

Cheers,
Daniel

On 23.02.24 12:11, Daniel-Constantin Mierla wrote:
> Hello,
>
> quick note that later today I will create the branch 5.8, notification
> emails will be sent once done.
>
> Cheers,
> Daniel
>
> On 16.02.24 08:01, Daniel-Constantin Mierla wrote:
>> Hello,
>>
>> hopefully the devel version is now more stabilized after the freezing,
>> the new components being adjusted enough not to need many more changes.
>> Therefore I consider to branch 5.8 out of devel version next week on
>> Friday, February 23, 2024, sometime around noon UTC.
>>
>> After that the master branch becomes open for new features, and branch
>> 5.8 has to be hammered further to build the 5.8.x series.
>>
>> Cheers,
>> Daniel
>>
>> On 10.01.24 10:11, Daniel-Constantin Mierla wrote:
>>> Hello,
>>>
>>> discussed a bit during the online Kamailio devel meeting, it is time to
>>> set the milestones towards the next major Kamailio release series v5.8.x.
>>>
>>> If no other suggestions that suit more developers, I would propose to
>>> freeze by end of this month or early February, then test for about 4
>>> weeks as usual and release by end of February or during March.
>>>
>>> If anyone wants to add new features/modules, they have to be published
>>> till freezing date, either pushed in the git repository or proposed as
>>> pull request.
>>>
>>> Cheers,
>>> Daniel
>> --
>> Daniel-Constantin Mierla (@ asipto.com)
>> twitter.com/miconda -- 
>> linkedin.com/in/miconda
>> Kamailio Consultancy, 

[sr-dev] Re: [kamailio/kamailio] Dispatcher: added two new flags to mode parameter of ds_is_from_list function for more strictly matching (PR #3699)

[Henning Westerholt via sr-dev]

@Den4t @miconda Any more questions or things that needs to be discussed? 
Otherwise its probably a good idea to merge it in the next days before the 
window for 5.8.0 closes completely.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3699#issuecomment-1957162295
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] performance regression related to new TCP connection tracking feature with a high number of connections (Issue #3759)

[Henning Westerholt via sr-dev]

Thank  you for the commit, will have it tested soon. Regarding the performance 
regression question, one one system where we observed it there are about 35.000 
current TCP connections and a new connection rate about 85 connections per 
second.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3759#issuecomment-1956207031
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] rpm kamailio git master version

[Henning Westerholt via sr-dev]

Hello,

just a question about the https://rpm.kamailio.org/ repository, especially 
regarding git master builds. It seems that the git master build there was 
updated last autumn. It would be great if it could be updated, now as we want 
to test for the coming release.

Thank you,

Henning Westerholt


--
Henning Westerholt - https://skalatan.de/blog/
Kamailio services - https://gilawa.com


___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] performance regression related to new TCP connection tracking feature with a high number of connections (Issue #3759)

[Henning Westerholt via sr-dev]

SVG version of flamegraph: 
https://github.com/kamailio/kamailio/assets/6481937/02aa91c9-fa72-4e7e-9bcd-732cdca454cb


-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3759#issuecomment-1953174460
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org