Re: [sr-dev] [kamailio/kamailio] Adding Support for Azure Database for MySQL Service (#1992)

2019-06-27 Thread Daniel-Constantin Mierla
Closed #1992.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1992#event-2443309822___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] Adding Support for Azure Database for MySQL Service (#1992)

2019-06-27 Thread Daniel-Constantin Mierla
Looking more at the patch, it didn't seem to work properly, eating the `@` in 
case there was no other one. Therefore I pushed a slightly reworked version, 
test with master branch and fill an issue if doesn't work. Thanks!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1992#issuecomment-506231498___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] Adding Support for Azure Database for MySQL Service (#1992)

2019-06-27 Thread Daniel-Constantin Mierla
Thanks! I will squash and merge it adjusting a bit the commit message, the 
patch being to the lib.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1992#issuecomment-506208529___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


[sr-dev] [kamailio/kamailio] Adding Support for Azure Database for MySQL Service (#1992)

2019-06-24 Thread Mack Hendricks




 Pre-Submission Checklist



- [X ] Commit message has the format required by CONTRIBUTING guide
- [ X] Commits are split per component (core, individual modules, libs, utils, 
...)
- [ X] Each component has a single commit (if not, squash them into one commit)
- [ X] No commits to README files for modules (changes must be done to docbook 
files
in `doc/` subfolder, the README file is autogenerated)

 Type Of Change
- [X] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

 Checklist:

- [X ] PR should be backported to stable branches
- [ X] Tested changes locally
- [ ] Related to issue # (replace  with an open issue number)

 Description

The Azure Database for MySQL Service requires that usernames have the format of
username@databasename.  In the current implementation, the @ denotes that the 
next set of characters contains the database hostname, port (optionally) and 
database name.  This patch
modifies the parse_db_url() to look for multiple @ signs.  If multiple exists, 
then the first @ sign will be used as part of the username.
You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/1992

-- Commit Summary --

  * db_mysql: added support for Azure Database for MySQL
  * db_mysql: added support for Azure Database for MySQL

-- File Changes --

M src/lib/srdb1/db_id.c (16)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/1992.patch
https://github.com/kamailio/kamailio/pull/1992.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1992
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev