Re: [sr-dev] [kamailio/kamailio] Smsops 7bit support special chars (#2756)

2021-06-07 Thread Daniel-Constantin Mierla
Merged #2756 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2756#event-4851944864___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] Smsops 7bit support special chars (#2756)

2021-06-07 Thread Daniel-Constantin Mierla
@riccardv - if you want to do improvements to this part, just do a PR. This one 
will be merged.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2756#issuecomment-855915738___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] Smsops 7bit support special chars (#2756)

2021-06-04 Thread riccardv
Hi @alexyosifov ,

a little comment regarding the fill bits, it's just for information.
There is a more easy way to perform decoding and encoding of 7bit concatenated 
sms.

Let me explain

3GPP has added the fill bits for retro compatibility with old devices that 
doesn't support the concatenated sms and then the UDH header. 
With this assumption the decoding of entire PDU may be done with the effect of 
first N ASCII characters (due to udh header) are not valid but the rest is ok. 
So it's possible to decode the entire user-data pdu as a normal non udh pdu 
discarding the first N decoded ASCII string.
N is equal to the septet of udh header + 1

In encoding the concept is the same, just add N preamble (3GPP recommends N 
'\n') characters to the ASCII string, encode as 7bit and overwrite the initial 
octets with the UDH header.

Hope my comment was useful
Regards



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2756#issuecomment-855064337___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] Smsops 7bit support special chars (#2756)

2021-06-03 Thread Daniel-Constantin Mierla
If no comments from other devs, it can be merged soon.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2756#issuecomment-853641476___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


[sr-dev] [kamailio/kamailio] Smsops 7bit support special chars (#2756)

2021-06-02 Thread alexyosifov




 Pre-Submission Checklist



- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, 
...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook 
files
in `doc/` subfolder, the README file is autogenerated)

 Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

 Checklist:

- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue # (replace  with an open issue number)

 Description


You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/2756

-- Commit Summary --

  * Add README.md
  * Merge branch 'master' of github.com:alexyosifov/kamailio
  * Merge remote-tracking branch 'remote_yosifov/master'
  * Merge branch 'master' of github.com:alexyosifov/kamailio
  * smsops: support for 7bit special chars

-- File Changes --

M src/modules/smsops/smsops_impl.c (256)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/2756.patch
https://github.com/kamailio/kamailio/pull/2756.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2756
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev