Re: [sr-dev] [kamailio/kamailio] pkg/kamailio/centos/7: Packaged sipcapture module (#1106)
Closed #1106. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1106#event-1329540763___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] pkg/kamailio/centos/7: Packaged sipcapture module (#1106)
Merged it manually with the commit referenced above. It has the config file relocated to `misc/examples/pkg/` and the install is done by `make install-cfg-pkg` (which was added in `src/Makefile` and included in spec build process). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1106#issuecomment-342461961___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] pkg/kamailio/centos/7: Packaged sipcapture module (#1106)
Purpose of this patch simplify homer/sipcapture installation. OBS changes not related to this PR. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1106#issuecomment-342446722___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] pkg/kamailio/centos/7: Packaged sipcapture module (#1106)
@sergey-safarov - is this patch still actual after your OBS packaging work? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1106#issuecomment-342429766___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] pkg/kamailio/centos/7: Packaged sipcapture module (#1106)
Daniel, let me know if required to move config file to subfolder. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1106#issuecomment-333859364___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] pkg/kamailio/centos/7: Packaged sipcapture module (#1106)
@miconda when your ready to accept PR, i will bump all commits to one. Is required to install config file to folder like "/usr/share/kamailio/example" too? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1106#issuecomment-311936676___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] pkg/kamailio/centos/7: Packaged sipcapture module (#1106)
@miconda requested changes done -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1106#issuecomment-305822217___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] pkg/kamailio/centos/7: Packaged sipcapture module (#1106)
There are companies that already installed kamailio and then need to just do upgrade. I don't see a reason to split sipcapture in its own package, it depends on kamailio core and other modules. It adds to maintenance overhead without any benefit, including a whole bunch of conflicts rules for upgrades. In many distros, when adding a new package requires a complete review process for license, etc... might not be the case here, but it is better to be coherent with packaging across distros. I am fine to add the packages that deploys the config for sipcapture daemon, but the module is better in the main package, like so far. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1106#issuecomment-305788082___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] pkg/kamailio/centos/7: Packaged sipcapture module (#1106)
@miconda PR is updated. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1106#issuecomment-301575963___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] pkg/kamailio/centos/7: Packaged sipcapture module (#1106)
Purpose of this PR - simplify sipcapture installation and configuration of sipcapture daemon. At present time to configure sipcapture required to create systemd unit file and install config file. After this PR, sipcapture daemon will be installed using "yum install" -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1106#issuecomment-298622391___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] pkg/kamailio/centos/7: Packaged sipcapture module (#1106)
What this is actually doing? I see it removes the sipcapture module from the old packages and then creates a new packages as well as refers a sipcapture specific configuration file. Can you describe the purpose and what is expected to happen with the new package, how is it supposed to be used? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1106#issuecomment-298618190___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
