[sr-dev] Re: [kamailio/kamailio] Added new auth module function auth_algorithm (PR #3849)
You can push --force the new commit with the format fixed squashing previous commits -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3849#issuecomment-2110860065 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] Added new auth module function auth_algorithm (PR #3849)
As I said, I haven't looked much into it, not sure what was the reason ... I installed `pre-commit` along with `clang-format` and before each commit the formatting is checked automatically, simplifying my coding process as I can do it without caring of formatting and it gets fixed at commit time. I sent an email about it a while ago: - https://kamailio.org/mailman3/hyperkitty/list/sr-us...@lists.kamailio.org/message/7PSVLEKOMSCDMUYN4VZLIO4ZBRBJXMF6/ -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3849#issuecomment-2110854386 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] Added new auth module function auth_algorithm (PR #3849)
After the first commit. there was format issues that I tried to fix manually and pushed another commit. After that, format check was re-run automatically and one more format issue remained. I fixed also that, push a new commit, and again format check was re-run automatically. Now the format check passed, but still the web page showed that format check failed. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3849#issuecomment-2110830547 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] Added new auth module function auth_algorithm (PR #3849)
I haven't checked closely, at the first look it seems some spacing issues in one of the commits out of three. Did you run clang-format? I installed the git hooks as suggested by Victor Seva and any clang-format issues are reported and fixed before I can do a commit. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3849#issuecomment-2110786081 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] Added new auth module function auth_algorithm (PR #3849)
How about the failing format check? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3849#issuecomment-2110621100 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] Added new auth module function auth_algorithm (PR #3849)
> If you want to test README generation locally, then you are missing some > dockbook-relate packages, likely `docbook-xsl`. README generation worked after I installed Debian package `docbook-xsl`. For some reason make command as described here [https://www.kamailio.org/wikidocs/devel/module-docbook-readme/]() was not able to load it from source repo. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3849#issuecomment-2110617698 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] Added new auth module function auth_algorithm (PR #3849)
Closed #3849. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3849#event-12804750240 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] Added new auth module function auth_algorithm (PR #3849)
Merged manually! -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3849#issuecomment-2110591764 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] Added new auth module function auth_algorithm (PR #3849)
If you want to test README generation locally, then you are missing some dockbook-relate packages, likely `docbook-xsl`. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3849#issuecomment-2110568295 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] Added new auth module function auth_algorithm (PR #3849)
Daniel-Constantin Mierla writes: > One can generate readme locally only for checking it if it is correct, > but then reverted before committing. That is exactly what I tried to do according to instructions, but generation failed. Also, there is something wrong with the format check. It shows red even when the Details shows OK: 6992d1784aa3e1f96aa3a406f25675178605108d... PASSED 3bcedc47e381d22521aeb544b0d27180786d7039... PASSED -- Juha -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3849#issuecomment-2110471230 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] Added new auth module function auth_algorithm (PR #3849)
The README must not be regenerated locally and part of the commit, it is going to be generated on server and pushed to git repository by a cron job. One can generate readme locally only for checking it if it is correct, but then reverted before committing. Of course, if one pushed a regenerated commit is not critical, but by using the server side generation, the READMEs look coherent. I am going to merge the PR manually for make it consistent with the commit message guidelines. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3849#issuecomment-2110213125 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] Added new auth module function auth_algorithm (PR #3849)
@juha-h pushed 1 commit. 6992d1784aa3e1f96aa3a406f25675178605108d More format changes -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3849/files/4ccadb7ed3a762ec1d2781e783f760f6de4b588e..6992d1784aa3e1f96aa3a406f25675178605108d You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] Added new auth module function auth_algorithm (PR #3849)
@juha-h pushed 1 commit. 4ccadb7ed3a762ec1d2781e783f760f6de4b588e Format changes -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3849/files/4a1aa23d6b1d8bb90f267b64a33b25beb2b0977c..4ccadb7ed3a762ec1d2781e783f760f6de4b588e You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
