[sr-dev] Re: [kamailio/kamailio] ims_registrar_pcscf: changes for ul db_mode DB_ONLY (PR #3317)

2023-03-20 Thread Henning Westerholt 
Merged #3317 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3317#event-8792424533
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] ims_registrar_pcscf: changes for ul db_mode DB_ONLY (PR #3317)

2023-03-15 Thread Henning Westerholt 
@petermarianF no, I will review it one more time during until the end of the 
week and then apply it its ok.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3317#issuecomment-1469857719
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] ims_registrar_pcscf: changes for ul db_mode DB_ONLY (PR #3317)

2023-03-15 Thread petermarianF 
Hi,
is there something else required for closing this pull request ?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3317#issuecomment-1469824549
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] ims_registrar_pcscf: changes for ul db_mode DB_ONLY (PR #3317)

2023-02-13 Thread petermarianF 
@petermarianF commented on this pull request.



> @@ -142,15 +143,15 @@ inline void pcscf_act_time()
  * Exported functions
  */
 static cmd_export_t cmds[] = {
-   {"pcscf_save",  (cmd_function)w_save,   
1,  save_fixup2,0,ONREPLY_ROUTE },
+   {"pcscf_save",  (cmd_function)w_save,   
1,  save_fixup2,0,ONREPLY_ROUTE },

Added some documentation for save_pending function 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3317#discussion_r1104782200
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] ims_registrar_pcscf: changes for ul db_mode DB_ONLY (PR #3317)

2023-02-13 Thread petermarianF 
@petermarianF commented on this pull request.



> @@ -142,15 +143,15 @@ inline void pcscf_act_time()
  * Exported functions
  */
 static cmd_export_t cmds[] = {
-   {"pcscf_save",  (cmd_function)w_save,   
1,  save_fixup2,0,ONREPLY_ROUTE },
+   {"pcscf_save",  (cmd_function)w_save,   
1,  save_fixup2,0,ONREPLY_ROUTE },

Removed these formatting changes

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3317#discussion_r1104780033
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] ims_registrar_pcscf: changes for ul db_mode DB_ONLY (PR #3317)

2023-02-13 Thread petermarianF 
@petermarianF commented on this pull request.



> @@ -261,6 +262,8 @@ static int mod_init(void) {
if (bind_usrloc() < 0) {
return -1;
}
+   if (ul.db_mode == DB_ONLY)
+ul.register_ulcb_method(NULL, PCSCF_CONTACT_UPDATE, 
callback_pcscf_contact_cb, NULL);

Added return value check and abort on error

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3317#discussion_r1104778068
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] ims_registrar_pcscf: changes for ul db_mode DB_ONLY (PR #3317)

2023-02-13 Thread petermarianF 
@petermarianF commented on this pull request.



> @@ -467,6 +484,20 @@ int save(struct sip_msg* _m, udomain_t* _d, int _cflags) 
> {
goto error;
}
 
+// skip subscribe, if all contacts have "expires=0" parameter
+   contact_t *ctct;

Moved the new definitions to the beginning of the function and did some 
formatting 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3317#discussion_r1104776779
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] ims_registrar_pcscf: changes for ul db_mode DB_ONLY (PR #3317)

2023-02-13 Thread petermarianF 
@petermarianF pushed 1 commit.

5d1b946495680142c1c154400716cf975b59  ims_registrar_pcscf:  changes for ul 
db_mode DB_ONLY

-- 
View it on GitHub:
https://github.com/kamailio/kamailio/pull/3317/files/6d7d2faf534b8475db1c2c515c7580b7dec08cb9..5d1b946495680142c1c154400716cf975b59
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] ims_registrar_pcscf: changes for ul db_mode DB_ONLY (PR #3317)

2023-02-13 Thread petermarianF 
Hi Henning,

sorry for the long delay, I was busy with some urgent fixes on other areas. Yes 
I already prepared the code changes and hope to do the docu additions also very 
soon (probably this evenening)

KR,
Peter

Von: Henning Westerholt ***@***.***>
Gesendet: Montag, 13. Februar 2023 09:31
An: kamailio/kamailio ***@***.***>
Cc: Friedrich Peter ***@***.***>; Mention ***@***.***>
Betreff: Re: [kamailio/kamailio] ims_registrar_pcscf: changes for ul db_mode 
DB_ONLY (PR #3317)


@petermarianF
 Any update from your side regarding the comments?

-
Reply to this email directly, view it on 
GitHub,
 or 
unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>


-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3317#issuecomment-1427728988
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] ims_registrar_pcscf: changes for ul db_mode DB_ONLY (PR #3317)

2023-02-13 Thread Henning Westerholt 
@petermarianF Any update from your side regarding the comments?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3317#issuecomment-1427537554
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] ims_registrar_pcscf: changes for ul db_mode DB_ONLY (PR #3317)

2023-01-02 Thread Henning Westerholt 
@henningw commented on this pull request.

Thanks for the PR. This is a smaller patch, so I just added a few comments, 
mostly related to formatting. Before merging the module documentation should be 
extended as well with the new function, its return code and description from 
the PR.

> @@ -142,15 +143,15 @@ inline void pcscf_act_time()
  * Exported functions
  */
 static cmd_export_t cmds[] = {
-   {"pcscf_save",  (cmd_function)w_save,   
1,  save_fixup2,0,ONREPLY_ROUTE },
+   {"pcscf_save",  (cmd_function)w_save,   
1,  save_fixup2,0,ONREPLY_ROUTE },

Please align the formatting to the existing code, there seems to be some 
whitespaces/tabs here and also two more places below.

> @@ -261,6 +262,8 @@ static int mod_init(void) {
if (bind_usrloc() < 0) {
return -1;
}
+   if (ul.db_mode == DB_ONLY)
+ul.register_ulcb_method(NULL, PCSCF_CONTACT_UPDATE, 
callback_pcscf_contact_cb, NULL);

This can fail according to ims_usrloc_pcscf/ul_callback.c. So the return value 
should be checked and aborted on error, in a similar ways as the other cases 
above.

> @@ -467,6 +484,20 @@ int save(struct sip_msg* _m, udomain_t* _d, int _cflags) 
> {
goto error;
}
 
+// skip subscribe, if all contacts have "expires=0" parameter
+   contact_t *ctct;

Move the contact and also expir parameter definition to the beginning of the 
function. Not sure why the cast to unsigned int * is needed here? The if 
(expir) condition also need to be aligned from the formatting.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3317#pullrequestreview-1233911028
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org