[sr-dev] Re: [kamailio/kamailio] rtpengine: fix pkg mem leak in send_rtpp_command() (PR #3813)

2024-04-16 Thread Henning Westerholt via sr-dev
Merged #3813 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3813#event-12488936001
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] Re: [kamailio/kamailio] rtpengine: fix pkg mem leak in send_rtpp_command() (PR #3813)

2024-04-15 Thread vijaykumar-exotel via sr-dev
Sure. Thanks @henningw 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3813#issuecomment-2057506104
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] Re: [kamailio/kamailio] rtpengine: fix pkg mem leak in send_rtpp_command() (PR #3813)

2024-04-15 Thread Henning Westerholt via sr-dev
> Hi @henningw , memory is getting allocated in line 3660 , which was not 
> getting freed. request.s = pkg_malloc(len + 1);

Sure. :-) I checked in the lwsc module (which is actually called from the 
rtpengine module in this function part) to no have a double free. If nobody 
else comment, I will merge it tomorrow.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3813#issuecomment-2057182250
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] Re: [kamailio/kamailio] rtpengine: fix pkg mem leak in send_rtpp_command() (PR #3813)

2024-04-15 Thread vijaykumar-exotel via sr-dev
Hi @henningw , 
memory is getting allocated in line 3660 ,  which was not getting freed.
request.s = pkg_malloc(len + 1);


-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3813#issuecomment-2056502355
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] Re: [kamailio/kamailio] rtpengine: fix pkg mem leak in send_rtpp_command() (PR #3813)

2024-04-15 Thread Henning Westerholt via sr-dev
Looks good to me. The lwsc module seems to malloc its own memory for the sdata, 
so it should be freed in rtpengine module code.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3813#issuecomment-2056319994
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org