Re: [sr-dev] [kamailio/kamailio] carrierroute: warning for the same carrier/domain having routes with only 0 probability (#1232)

2017-09-12 Thread Daniel-Constantin Mierla 
@hdikme - the comment of @lbalaceanu was on the code of the patch and github 
hides it, you need to press `Show outdated` in the right side of @lbalaceanu's 
comment above here.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1232#issuecomment-328859577___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] carrierroute: warning for the same carrier/domain having routes with only 0 probability (#1232)

2017-09-12 Thread hdikme 
Closed #1232.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1232#event-1245286133___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] carrierroute: warning for the same carrier/domain having routes with only 0 probability (#1232)

2017-09-12 Thread hdikme 
Following the commit based on your comment, your comment "Please change 
query_done to false here and adapt the code accordingly. The name of the 
variable should reflect the value it holds." disappeared but i have done the 
requested changes.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1232#issuecomment-328848085___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] carrierroute: warning for the same carrier/domain having routes with only 0 probability (#1232)

2017-09-12 Thread hdikme 
@hdikme pushed 2 commits.

4aaa0af  carrierroute: warning for the same carrier/domain having routes with 
only 0 probability
c275210  Merge branch 'master' of https://github.com/hdikme/kamailio


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/kamailio/kamailio/pull/1232/files/0d2a7161454ef36ca3a23083eca1b4245c133e57..c275210836476cd4f94059b26ddf625e89a3d856
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] carrierroute: warning for the same carrier/domain having routes with only 0 probability (#1232)

2017-09-12 Thread Lucian Balaceanu 
lbalaceanu commented on this pull request.



> @@ -352,6 +353,7 @@ int load_route_data_db(struct route_data_t * rd) {
}
}
int n = 0;
+   boolean query_done = true;

Please change query_done to false here and adapt the code accordingly. The name 
of the variable should reflect the value it holds.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1232#pullrequestreview-62101949___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev