Re: [sr-dev] [kamailio/kamailio] ims_ipsec_pcscf: closing mnl_socket in some exceptional situations (#2114)
Merged, will also backport to stable branches. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2114#issuecomment-551172743___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] ims_ipsec_pcscf: closing mnl_socket in some exceptional situations (#2114)
Merged #2114 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2114#event-2780132406___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] ims_ipsec_pcscf: closing mnl_socket in some exceptional situations (#2114)
@miconda - I know. :-) But as @alexyosifov was working on the code right now, I wanted to ask him about his opinion. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2114#issuecomment-551172300___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] ims_ipsec_pcscf: closing mnl_socket in some exceptional situations (#2114)
> @henningw, @alexyosifov - looking at the patch, the pull request here is not > adding any `return 0`, they existed. The patch is adding a couple of > `close_mnl_socket(sock)`. > > If the existing `return 0` in error cases are wrong, then they need to be > fixed of course. But it is not a strict relation with this PR. Hi, I'll fix the problem with the error codes in the next ipsec pull request from my side. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2114#issuecomment-551146675___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] ims_ipsec_pcscf: closing mnl_socket in some exceptional situations (#2114)
@henningw, @alexyosifov - looking at the patch, the pull request here is not adding any `return 0`, they existed. The patch is adding a couple of `close_mnl_socket(sock)`. If the existing `return 0` in error cases are wrong, then they need to be fixed of course. But it is not a strict relation with this PR. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2114#issuecomment-551141814___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] ims_ipsec_pcscf: closing mnl_socket in some exceptional situations (#2114)
I looked into the existing code of the function create_ipsec_tunnel(..) Are you sure that the "return 0" in the error cases is correct? Should it not be -1, as in the one case in the bottom of the function? If yes - then it makes probably sense to combine them all into one "goto error" case. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2114#issuecomment-548443605___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
