[sr-dev] git:master:6960cb80: sipcapture: updated README to document exported variables

2017-02-15 Thread David Villasmil
Module: kamailio
Branch: master
Commit: 6960cb80e0d3fe8103306e65258d62a9ab6620c7
URL: 
https://github.com/kamailio/kamailio/commit/6960cb80e0d3fe8103306e65258d62a9ab6620c7

Author: David Villasmil <david.villasmil.w...@gmail.com>
Committer: David Villasmil <david.villasmil.w...@gmail.com>
Date: 2017-02-15T17:43:00Z

sipcapture: updated README to document exported variables

- Added an "Exported pseudo-variabled" to the README file to document
  $hep(src_ip) and $hep(dst_ip)

---

Modified: src/modules/sipcapture/README

---

Diff:  
https://github.com/kamailio/kamailio/commit/6960cb80e0d3fe8103306e65258d62a9ab6620c7.diff
Patch: 
https://github.com/kamailio/kamailio/commit/6960cb80e0d3fe8103306e65258d62a9ab6620c7.patch

---

diff --git a/src/modules/sipcapture/README b/src/modules/sipcapture/README
index 016d198..cd92cd5 100644
--- a/src/modules/sipcapture/README
+++ b/src/modules/sipcapture/README
@@ -55,12 +55,17 @@ Alexandr Dubovikov
   4.1. sip_capture([table])
   4.2. report_capture([table],[data])
 
-5. RPC Commands
+5. Exported pseudo-variables
 
-  5.1. sipcapture.status param
+  5.1. $hep(src_ip)
+  5.2. $hep(dst_ip)
 
-6. Database setup
-7. Limitations
+6. RPC Commands
+
+  6.1. sipcapture.status param
+
+7. Database setup
+8. Limitations
 
List of Examples
 
@@ -125,12 +130,16 @@ Chapter 1. Admin Guide
 4.1. sip_capture([table])
 4.2. report_capture([table],[data])
 
-   5. RPC Commands
+   5. Exported pseudo-variables
+5.1. $hep(src_ip)
+5.2. $hep(dst_ip)
+
+   6. RPC Commands
 
-5.1. sipcapture.status param
+6.1. sipcapture.status param
 
-   6. Database setup
-   7. Limitations
+   7. Database setup
+   8. Limitations
 
 1. Overview
 
@@ -505,11 +514,26 @@ report_capture("report_data");
 report_capture("report_data", "{\"MOS\":4.1,\"PACKET_LOST\":100"});
 ...
 
-5. RPC Commands
+5. Exported pseudo-variables
+
+   5.1. $hep(src_ip)
+   5.2. $hep(dst_ip)
+
+   Exported pseudo-variables are listed in the next sections.
+
+5.1. $hep(src_ip)
+
+   Returns the current HEP's message original source IP address.
+
+5.2. $hep(dst_ip)
+
+   Returns the current HEP's message original destination IP address.
+
+6. RPC Commands
 
-   5.1. sipcapture.status param
+   6.1. sipcapture.status param
 
-5.1.  sipcapture.status param
+6.1.  sipcapture.status param
 
Name: sipcapture.status
 
@@ -527,7 +551,7 @@ kamcmd sipcapture.status off
 kamcmd sipcapture.status check
 ...
 
-6. Database setup
+7. Database setup
 
Before running Kamailio with the sipcapture module, you have to setup
the database tables where the module will store the data. For that, if
@@ -537,7 +561,7 @@ kamcmd sipcapture.status check
find the complete database documentation on the project webpage,
http://www.kamailio.org/docs/db-tables/kamailio-db-devel.html.
 
-7. Limitations
+8. Limitations
 
  * 1. Only one capturing mode on RAW socket is supported: IPIP or
monitoring/mirroring port. Don't activate both at the same time.


___
sr-dev mailing list
sr-dev@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev


[sr-dev] git:master:16cea04b: sipcapture: Fixed missing 'break' after case-switch.

2017-02-15 Thread David Villasmil
Module: kamailio
Branch: master
Commit: 16cea04b08c648bd32b036e35bdb10f4bfdafdff
URL: 
https://github.com/kamailio/kamailio/commit/16cea04b08c648bd32b036e35bdb10f4bfdafdff

Author: David Villasmil <david.villasmil.w...@gmail.com>
Committer: David Villasmil <david.villasmil.w...@gmail.com>
Date: 2017-02-15T20:32:50Z

sipcapture: Fixed missing 'break' after case-switch.

- Added 'break' missing from a case/switch

---

Modified: src/modules/sipcapture/sipcapture.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/16cea04b08c648bd32b036e35bdb10f4bfdafdff.diff
Patch: 
https://github.com/kamailio/kamailio/commit/16cea04b08c648bd32b036e35bdb10f4bfdafdff.patch

---

diff --git a/src/modules/sipcapture/sipcapture.c 
b/src/modules/sipcapture/sipcapture.c
index 5d5227c..c398c72 100644
--- a/src/modules/sipcapture/sipcapture.c
+++ b/src/modules/sipcapture/sipcapture.c
@@ -2772,10 +2772,11 @@ static int pv_parse_hep_name (pv_spec_p sp, str *in)
break;
case 6:
{
-   if(!strncmp(in->s, "src_ip", 6)) 
sp->pvp.pvn.u.isname.name.n = 2;
-   else if(!strncmp(in->s, "dst_ip", 6)) 
sp->pvp.pvn.u.isname.name.n = 3;
+   if(!strncmp(in->s, "src_ip", 6)) 
sp->pvp.pvn.u.isname.name.n = 2; 
+   else if(!strncmp(in->s, "dst_ip", 6)) 
sp->pvp.pvn.u.isname.name.n = 3; 
else goto error;
}
+   break;
case 7:
{
if(!strncmp(in->s, "version", 7)) 
sp->pvp.pvn.u.isname.name.n = 0;


___
sr-dev mailing list
sr-dev@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev


[sr-dev] git:master:4f960122: sipcapture: added $hep(dst_ip) variable

2017-02-15 Thread David Villasmil
Module: kamailio
Branch: master
Commit: 4f960122142c845862ad140e85827a1c530bc22e
URL: 
https://github.com/kamailio/kamailio/commit/4f960122142c845862ad140e85827a1c530bc22e

Author: David Villasmil <david.villasmil.w...@gmail.com>
Committer: David Villasmil <david.villasmil.w...@gmail.com>
Date: 2017-02-15T16:42:03Z

sipcapture: added $hep(dst_ip) variable

- expose hep(dst_ip) to get hep's message destination IP

---

Modified: src/modules/sipcapture/sipcapture.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/4f960122142c845862ad140e85827a1c530bc22e.diff
Patch: 
https://github.com/kamailio/kamailio/commit/4f960122142c845862ad140e85827a1c530bc22e.patch

---

diff --git a/src/modules/sipcapture/sipcapture.c 
b/src/modules/sipcapture/sipcapture.c
index efc53d1..5d5227c 100644
--- a/src/modules/sipcapture/sipcapture.c
+++ b/src/modules/sipcapture/sipcapture.c
@@ -2773,6 +2773,7 @@ static int pv_parse_hep_name (pv_spec_p sp, str *in)
case 6:
{
if(!strncmp(in->s, "src_ip", 6)) 
sp->pvp.pvn.u.isname.name.n = 2;
+   else if(!strncmp(in->s, "dst_ip", 6)) 
sp->pvp.pvn.u.isname.name.n = 3;
else goto error;
}
case 7:
@@ -2813,6 +2814,10 @@ static int pv_get_hep(struct sip_msg *msg, pv_param_t 
*param, pv_value_t *res)
sizeof(sc_buf_ip)-1);
sc_buf_ip[sc_buf_ip_len]=0;
return pv_get_strlval(msg, param, res, 
sc_buf_ip, sc_buf_ip_len);
+   case 3:
+   sc_buf_ip_len=ip_addr2sbuf(>rcv.dst_ip, sc_buf_ip, 
sizeof(sc_buf_ip)-1);
+   sc_buf_ip[sc_buf_ip_len]=0;
+   return pv_get_strlval(msg, param, res, sc_buf_ip, 
sc_buf_ip_len);
default:
return  hepv3_get_chunk(msg, msg->buf, msg->len, 
param->pvn.u.isname.name.n, param, res);
}


___
sr-dev mailing list
sr-dev@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev


[sr-dev] [kamailio/kamailio] sipcapture: Added exported pseudo-variable $hep(dst_ip) and updated README (#995)

2017-02-15 Thread David Villasmil
Added a new exported pseudo-variable to expose HEP's message's original source 
ip address.
Added an "Exported pseudo-variabled" to the README file to document 
$hep(src_ip) and $hep(dst_ip).
You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/995

-- Commit Summary --

  * sipcapture: added $hep(dst_ip) variable
  * sipcapture: updated README to document exported variables
  * sipcapture: Fixed missing 'break' after case-switch.

-- File Changes --

M src/modules/sipcapture/README (50)
M src/modules/sipcapture/sipcapture.c (8)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/995.patch
https://github.com/kamailio/kamailio/pull/995.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/995
___
sr-dev mailing list
sr-dev@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] sipcapture: Added exported pseudo-variable $hep(dst_ip) and updated README (#994)

2017-02-15 Thread David Villasmil
Closed #994.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/994#event-963637659___
sr-dev mailing list
sr-dev@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev


[sr-dev] [kamailio/kamailio] sipcapture: Added exported pseudo-variable $hep(dst_ip) and updated README (#994)

2017-02-15 Thread David Villasmil
Added a new exported pseudo-variable to expose HEP's message's original source 
ip address.
Added an "Exported pseudo-variabled" to the README file to document 
$hep(src_ip) and $hep(dst_ip).
You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/994

-- Commit Summary --

  * sipcapture: added $hep(dst_ip) variable
  * sipcapture: updated README to document exported variables

-- File Changes --

M src/modules/sipcapture/README (50)
M src/modules/sipcapture/sipcapture.c (5)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/994.patch
https://github.com/kamailio/kamailio/pull/994.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/994
___
sr-dev mailing list
sr-dev@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev


[sr-dev] git:master:67419f91: sipcapture: Fixed missing 'break' in pv_parse_hep_name switch

2017-02-13 Thread David Villasmil
Module: kamailio
Branch: master
Commit: 67419f91a4b6f2ad5d2590434b64087cf812b794
URL: 
https://github.com/kamailio/kamailio/commit/67419f91a4b6f2ad5d2590434b64087cf812b794

Author: David Villasmil <david.villasmil.w...@gmail.com>
Committer: David Villasmil <david.villasmil.w...@gmail.com>
Date: 2017-02-13T13:03:37Z

sipcapture: Fixed missing 'break' in pv_parse_hep_name switch

- Added missing 'break;' in sipcapture.c's pv_parse_hep_name function's switch
   statement.

---

Modified: src/modules/sipcapture/sipcapture.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/67419f91a4b6f2ad5d2590434b64087cf812b794.diff
Patch: 
https://github.com/kamailio/kamailio/commit/67419f91a4b6f2ad5d2590434b64087cf812b794.patch

---

diff --git a/src/modules/sipcapture/sipcapture.c 
b/src/modules/sipcapture/sipcapture.c
index efc53d1..a5cf1f9 100644
--- a/src/modules/sipcapture/sipcapture.c
+++ b/src/modules/sipcapture/sipcapture.c
@@ -2775,6 +2775,7 @@ static int pv_parse_hep_name (pv_spec_p sp, str *in)
if(!strncmp(in->s, "src_ip", 6)) 
sp->pvp.pvn.u.isname.name.n = 2;
else goto error;
}
+   break;
case 7:
{
if(!strncmp(in->s, "version", 7)) 
sp->pvp.pvn.u.isname.name.n = 0;


___
sr-dev mailing list
sr-dev@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev


[sr-dev] [kamailio/kamailio] sipcapture: Fixed missing 'break' in pv_parse_hep_name switch (#986)

2017-02-13 Thread David Villasmil
- Added missing 'break;' in sipcapture.c's pv_parse_hep_name function's switch
   statement.
You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/986

-- Commit Summary --

  * sipcapture: Fixed missing 'break' in pv_parse_hep_name switch

-- File Changes --

M src/modules/sipcapture/sipcapture.c (1)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/986.patch
https://github.com/kamailio/kamailio/pull/986.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/986
___
sr-dev mailing list
sr-dev@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] sipcapture: Fixed missing 'break' in pv_parse_hep_name switch (#985)

2017-02-13 Thread David Villasmil
Closed #985.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/985#event-959553499___
sr-dev mailing list
sr-dev@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev


[sr-dev] [kamailio/kamailio] sipcapture: Fixed missing 'break' in pv_parse_hep_name switch (#985)

2017-02-13 Thread David Villasmil
- Added missing 'break;' in sipcapture.c's pv_parse_hep_name function's switch
  statement.
You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/985

-- Commit Summary --

  * sipcapture: Fixed missing 'break' in pv_parse_hep_name switch

-- File Changes --

M src/modules/sipcapture/sipcapture.c (59)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/985.patch
https://github.com/kamailio/kamailio/pull/985.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/985
___
sr-dev mailing list
sr-dev@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] sipcapture: expose pv $hep(src_ip) (#879)

2016-12-08 Thread David Villasmil
Yes, sorry about those beautifications... vim (spf13 mod) did it 
automatically.. i'll be more careful in the future.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/879#issuecomment-265845215___
sr-dev mailing list
sr-dev@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] sipcapture: expose pv $hep(src_ip) (#879)

2016-12-06 Thread David Villasmil
Changed "char buf_ip" as static

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/879#issuecomment-265088845___
sr-dev mailing list
sr-dev@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] sipcapture: expose pv $hep(src_ip) (#879)

2016-12-06 Thread David Villasmil
@davidcsi pushed 1 commit.

fb6328e  sipcapture: Set char buf_ip as static


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/kamailio/kamailio/pull/879/files/b8680815fc46c6612de9d41339f5c537d252dbc6..fb6328edcdb9edd06d474e8cd3c10ecf9817e3a8
___
sr-dev mailing list
sr-dev@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] sipcapture: expose pv $hep(src_ip) (#879)

2016-12-02 Thread David Villasmil
@adubovikov I hope this is better. If you find I'm not adhering in any way to 
guidelines, please point them out as it's my first time contributing.

Many thanks!
David

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/879#issuecomment-264459253___
sr-dev mailing list
sr-dev@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev


[sr-dev] [kamailio/kamailio] sipcapture: expose pv $hep(src_ip) (#879)

2016-12-02 Thread David Villasmil
- modified pv_parse_hep_name() and pv_get_hep() to expose
  the HEP's packet source ip address on replies. The associated
  pv $hep(src_ip), i.e.:

  onreply_route {
...
xlog("[onreply_route] Source IP: $hep(src_ip)\n");
...

  }
You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/879

-- Commit Summary --

  * sipcapture: expose pv $hep(src_ip)

-- File Changes --

M modules/sipcapture/sipcapture.c (15)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/879.patch
https://github.com/kamailio/kamailio/pull/879.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/879
___
sr-dev mailing list
sr-dev@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] sipcapture: expose pv $hep(src_ip) (#877)

2016-12-02 Thread David Villasmil
Closed #877.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/877#event-879881875___
sr-dev mailing list
sr-dev@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] Sipcapture: When inserting a reply, this module would insert the SIP … (#876)

2016-12-02 Thread David Villasmil
I've been looking into Homer's source code, and you are correct. It's easier 
doing it on the resultCtrl.js.
In any case, this has been a good exercise for me in terms of working with 
Kamailio's source code, as I'm just a beginner.

Thanks!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/876#issuecomment-264429830___
sr-dev mailing list
sr-dev@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] Sipcapture: When inserting a reply, this module would insert the SIP … (#876)

2016-12-02 Thread David Villasmil
Closed #876.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/876#event-879833214___
sr-dev mailing list
sr-dev@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev


[sr-dev] [kamailio/kamailio] sipcapture: expose pv $hep(src_ip) (#877)

2016-12-01 Thread David Villasmil
- when using with Homer, on onreply_route it is not possible to
  get the source ip address sending the reply. This patch exposes
  pv $hep(src_ip), i.e.:

  onreply_route {
...
xlog("[onreply_route] Source IP: $hep(src_ip)\n");
...
  }
You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/877

-- Commit Summary --

  * sipcapture: expose pv $hep(src_ip)

-- File Changes --

M modules/sipcapture/sipcapture.c (83)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/877.patch
https://github.com/kamailio/kamailio/pull/877.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/877
___
sr-dev mailing list
sr-dev@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] Sipcapture: When inserting a reply, this module would insert the SIP … (#876)

2016-12-01 Thread David Villasmil
The way it works now, on a reply the SIP Status is inserted into the "method" 
field, this isn't very nice as, if you're working with the table, you'd need to 
actually look into the cseq and break it into Sequence and Method to be able to 
do anything useful. Then you'd need to check if the "method" field is an actual 
method or a status code. The patch makes it much more readable:

```
+-+--+++---+--+
| date| micro_ts | method | status | reply_reason   
   | ruri |
+-+--+++---+--+
| 2016-12-01 02:18:31 | 1480558711188146 | INVITE ||
   | sip:12345@1.2.3.4|
| 2016-12-01 02:18:31 | 1480558711188584 | INVITE | 100| Trying 
   |  |
| 2016-12-01 02:18:31 | 1480558711189884 | INVITE | 407| Proxy 
Authentication Required |  |
| 2016-12-01 02:18:31 | 1480558711391719 | ACK||
   | sip:12345@1.2.3.4|
| 2016-12-01 02:18:31 | 1480558711391871 | INVITE ||
   | sip:12345@1.2.3.4|
| 2016-12-01 02:18:31 | 1480558711392194 | INVITE | 100| Trying 
   |  |
| 2016-12-01 02:18:31 | 1480558711411499 | INVITE | 403| Forbidden  
   |  |
| 2016-12-01 02:18:31 | 1480558711796623 | ACK||
   | sip:12345@1.2.3.4|

```
Which is easier to read than the current way:

```
+-+--++---+--+
| date| micro_ts | method | reply_reason
  | ruri |
+-+--++---+--+
| 2016-12-01 02:18:31 | 1480558711188146 | INVITE | 
  | sip:12345@1.2.3.4|
| 2016-12-01 02:18:31 | 1480558711188584 | 100| Trying  
  |  |
| 2016-12-01 02:18:31 | 1480558711189884 | 407| Proxy Authentication 
Required |  |
| 2016-12-01 02:18:31 | 1480558711391719 | ACK| 
  | sip:12345@1.2.3.4|
| 2016-12-01 02:18:31 | 1480558711391871 | INVITE | 
  | sip:12345@1.2.3.4|
| 2016-12-01 02:18:31 | 1480558711392194 | 100| Trying  
  |  |
| 2016-12-01 02:18:31 | 1480558711411499 | 403| Forbidden   
  |  |
| 2016-12-01 02:18:31 | 1480558711796623 | ACK| 
  | sip:12345@1.2.3.4|

```

Also, I'm doing a PR to homer as well to take into account this change, which 
will show in the "sip search" as a "Status" column.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/876#issuecomment-264192515___
sr-dev mailing list
sr-dev@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev


[sr-dev] [kamailio/kamailio] Sipcapture: When inserting a reply, this module would insert the SIP … (#876)

2016-12-01 Thread David Villasmil
…Status as the reply method. I've patched sipcapture.c and sipcapture.h to 
insert the actual SIP Status into a 'status' field on replies, and the Method 
extracted from the CSEQ into the 'method' field. This means when using this 
version of the module, you're tables must include a 'status' varchar(5) NULL 
field.
You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/876

-- Commit Summary --

  * Sipcapture: When inserting a reply, this module would insert the SIP Status 
as the reply method. I've patched sipcapture.c and sipcapture.h to insert the 
actual SIP Status into a 'status' field on replies, and the Method extracted 
from the CSEQ into the 'method' field. This means when using this version of 
the module, you're tables must include a 'status' varchar(5) NULL field.

-- File Changes --

M modules/sipcapture/sipcapture.c (83)
M modules/sipcapture/sipcapture.h (1)
M modules/sipcapture/sql/create_sipcapture_postgress.sql (3)
M modules/sipcapture/sql/schema_data.sql (3)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/876.patch
https://github.com/kamailio/kamailio/pull/876.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/876
___
sr-dev mailing list
sr-dev@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev


[sr-dev] sipcapture sip-status and method

2016-11-30 Thread David Villasmil
Hello all,

The way sipcapture now works, for requests it inserts the actual method
name into the "method" field. But for replies, it inserts the SIP Status
(i.e. 200, 407) into the "method" field.

It would be better to extract the actual method name from the CSEQ header
and insert it into the "method" field, as well as adding a "status" field
to the tables and inserting there the actual SIP Status.

I've made a patch for sipcapture.c and sipcapture.h which do just that.
I will also be submitting a PR to homer for this, as db tables need to be
modified to accept the status field.

How do i do the pull request?

I don't seem to be allowed to do commits to a branch i created locally

Regards,


Regards,

David Villasmil
email: david.villasmil.w...@gmail.com
<https://mail.google.com/mail/?view=cm=1=1=david.villasmil.w...@gmail.com>
phone: +34669448337
___
sr-dev mailing list
sr-dev@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev