Re: [sr-dev] [kamailio/kamailio] sipcapture: expose pv $hep(src_ip) (#879)
Closed #879. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/879#event-888072343___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] sipcapture: expose pv $hep(src_ip) (#879)
I reworked the patch to use buffered print of ip address in order to avoid the str copy. Test and if any issue is found, open a bug report. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/879#issuecomment-265968665___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] sipcapture: expose pv $hep(src_ip) (#879)
Yes, sorry about those beautifications... vim (spf13 mod) did it automatically.. i'll be more careful in the future. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/879#issuecomment-265845215___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] sipcapture: expose pv $hep(src_ip) (#879)
I am ok for this. Of course ideally will be add more "aliases" but it's ok for start! :-) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/879#issuecomment-265383852___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] sipcapture: expose pv $hep(src_ip) (#879)
@adubovikov - is this pull ok to merge? If yes, then let me do it manually this time, because I am going to work on restructuring of the source code tree and don't want to mess it. @davidcsi - for the future pull requests, do not do reformatting (indentation changes, renaming, etc.) in a pull request with new features, because it is hard to review the additions to the code. We value a lot the pull requests for beautification, they are very welcome, but do them as separate patches. In this specific case, your addition seems not to have coherent indentation, but you tried to do for other parts of existing code. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/879#issuecomment-265383287___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] sipcapture: expose pv $hep(src_ip) (#879)
Changed "char buf_ip" as static -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/879#issuecomment-265088845___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] sipcapture: expose pv $hep(src_ip) (#879)
@davidcsi pushed 1 commit. fb6328e sipcapture: Set char buf_ip as static -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/kamailio/kamailio/pull/879/files/b8680815fc46c6612de9d41339f5c537d252dbc6..fb6328edcdb9edd06d474e8cd3c10ecf9817e3a8 ___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] sipcapture: expose pv $hep(src_ip) (#879)
@adubovikov I hope this is better. If you find I'm not adhering in any way to guidelines, please point them out as it's my first time contributing. Many thanks! David -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/879#issuecomment-264459253___ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
