Re: [SR-Users] [sr-dev] topoh, angle brackets and Contact URI params interpretation

2011-02-03 Thread Andrew Pogrebennyk

On 03.02.2011 10:26, Andrew Pogrebennyk wrote:

I think the topoh module should force the angle brackets.
BTW it seems that parameter needs to be urlencoded, see rule
'other-param' in RFC 3261 section 25.1:


From what I understand the valid form is:
Contact:
sip:192.168.0.107;line=sr-N6IAzB3AWxyfz.stM.quOBFZMJZfWxj7W.y-MljAWBy*
or
Contact:
sip:192.168.0.107;line=sr-N6IAzB3AWxyfz.stM.quOBFZMJZfWxj7W.y-MljAWBy*

so it should be enclosed by angle brackets or double quote, otherwise 
most implementations would treat ;line as header parameter and the 
parsing would fail since @ is not allowed as header parameter value if 
it's not enclosed by double quotes.


--
Sincerely,
Andrew Pogrebennyk

___
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
sr-users@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users


Re: [SR-Users] [sr-dev] topoh, angle brackets and Contact URI params interpretation

2011-02-03 Thread Daniel-Constantin Mierla

Hello,

On 2/3/11 1:36 PM, Andrew Pogrebennyk wrote:

On 03.02.2011 10:26, Andrew Pogrebennyk wrote:

I think the topoh module should force the angle brackets.
BTW it seems that parameter needs to be urlencoded, see rule
'other-param' in RFC 3261 section 25.1:


From what I understand the valid form is:
Contact:
sip:192.168.0.107;line=sr-N6IAzB3AWxyfz.stM.quOBFZMJZfWxj7W.y-MljAWBy*
or
Contact:
sip:192.168.0.107;line=sr-N6IAzB3AWxyfz.stM.quOBFZMJZfWxj7W.y-MljAWBy*

so it should be enclosed by angle brackets or double quote, otherwise 
most implementations would treat ;line as header parameter and the 
parsing would fail since @ is not allowed as header parameter value 
if it's not enclosed by double quotes.

I will check the sources and fix if the contact address is not between .

However, I do not undeerstand where you got the @, is none there or am 
I missing something?


Thanks,
Daniel

--
Daniel-Constantin Mierla
http://www.asipto.com


___
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
sr-users@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users


Re: [SR-Users] [sr-dev] topoh, angle brackets and Contact URI params interpretation

2011-02-03 Thread Andrew Pogrebennyk

On 03.02.2011 18:12, Daniel-Constantin Mierla wrote:



I will check the sources and fix if the contact address is not between .

However, I do not undeerstand where you got the @, is none there or am
I missing something?


Daniel,
Sorry, I meant the * sign. Thanks for looking into it.

--
Sincerely,
Andrew Pogrebennyk

___
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
sr-users@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users