date:20151029

Re: [SSSD] [PATCH] DEBUG: Don't error on chown of nonexistent file

2015-10-29 Thread Stephen Gallagher

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 10/28/2015 04:48 PM, Lukas Slebodnik wrote:
> On (28/10/15 09:03), Stephen Gallagher wrote:
>> On 10/27/2015 05:33 PM, Lukas Slebodnik wrote:
>>> On (27/10/15 09:48), Stephen Gallagher wrote:
 We get an error message if we start up SSSD and the debug
 log does not yet exist.
>>> 
 From 53592734f73c50029fa573b9bc070437304ea489 Mon Sep 17
 00:00:00 2001 From: Stephen Gallagher 
 Date: Tue, 27 Oct 2015 09:39:01 -0400 Subject: [PATCH] DEBUG:
 Don't error on chown of nonexistent file
 
 We get an error message if we start up SSSD and the debug
 log does not yet exist. --- src/util/debug.c | 9 ++--- 1
 file changed, 6 insertions(+), 3 deletions(-)
 
 diff --git a/src/util/debug.c b/src/util/debug.c index 
 a8eea32740155ec3daf6be71ef9a8af6592f74a9..729d9f99d35c7208950a9a1af1f
>>
 
df3942b23a147
 100644 --- a/src/util/debug.c +++ b/src/util/debug.c @@
 -331,13 +331,16 @@ int chown_debug_file(const char
 *filename,
 
 ret = chown(logpath, uid, gid); free(logpath); if (ret != 0)
 { ret = errno; -DEBUG(SSSDBG_FATAL_FAILURE,
 "chown failed for [%s]: [%d]\n", -  log_file,
 ret); - return ret; +if (ret != ENOENT) { +
 /* Don't write an error message for a nonexistent file */ + 
 DEBUG(SSSDBG_FATAL_FAILURE, "chown failed for [%s]: [%d]\n",
 + log_file, ret); +return ret; +
 }
>>> Patch make sense, But I cannot see an error message even with
>>> empty directory /var/log/sssd. Do you have an idea why?
>>> 
>> 
>> Start the sssd in interactive mode instead of sending to files
>> and it will become clear :)
>> 
> I'm sorry but it is not clear :-)
> 
> [root@host ~]# rm -f /var/log/sssd/* /var/lib/sss/{db,mc}/* 
> [root@host ~]# sssd -i -d 3 (Wed Oct 28 21:43:57 2015)
> [sssd[be[redhat.com]]] [sysdb_idmap_get_mappings] (0x0080): Could
> not locate ID mappings: [No such file or directory] (Wed Oct 28
> 21:43:57 2015) [sssd[be[redhat.com]]] [be_process_init] (0x0080): 
> No SUDO module provided for [redhat.com] !! (Wed Oct 28 21:43:57
> 2015) [sssd[be[redhat.com]]] [be_process_init] (0x0020): No selinux
> module provided for [redhat.com] !! (Wed Oct 28 21:43:57 2015)
> [sssd[be[redhat.com]]] [be_process_init] (0x0020): No host info
> module provided for [redhat.com] !! (Wed Oct 28 21:43:57 2015)
> [sssd[be[redhat.com]]] [be_process_init] (0x0020): Subdomains are
> not supported for [redhat.com] !! (Wed Oct 28 21:44:27 2015)
> [sssd[be[redhat.com]]] [be_run_online_cb] (0x0080): Going online.
> Running callbacks.
> 
> I think it was fixed in ticket or did I miss something? 
> https://fedorahosted.org/sssd/ticket/2493
> 

It's entirely possible; I was comparing against the latest Fedora
release and I missed that patch going in. Feel free to drop this.

-BEGIN PGP SIGNATURE-
Version: GnuPG v2

iEYEARECAAYFAlYyGc0ACgkQeiVVYja6o6ObkACePb/EfAA/heF7+VLMALdq05Mt
pE8An1+QkoT8oNfR2OQdacTlb5kwFLl6
=xcV8
-END PGP SIGNATURE-
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] sss_override: add -find and -show

2015-10-29 Thread Pavel Březina


On 10/26/2015 01:57 PM, Pavel Reichl wrote:

Thanks, patch set works for me now.

I have just a few last nitpicks.

user-find takes extra parameter but ignores it, I believe this is not
user friendly as IMO user will consider it to be a domain name.

Please consider expanding man page description for --domain option in
commands user-find and group-find.


+static int override_group_show(struct sss_cmdline *cmdline,
+   struct sss_tool_ctx *tool_ctx,
+   void *pvt)
+{
+TALLOC_CTX *tmp_ctx;
+struct override_group input = {NULL};
+const char *dn;
+char *anchor;
+const char *filter;
+int ret;


Please add empty line here.


+tmp_ctx = talloc_new(NULL);
+if (tmp_ctx == NULL) {
+DEBUG(SSSDBG_CRIT_FAILURE, "talloc_new() failed.\n");
+return EXIT_FAILURE;
+}
+
+ret = parse_cmdline_group_show(cmdline, tool_ctx, );
+   if (ret != EOK) {


Indentation.


+DEBUG(SSSDBG_CRIT_FAILURE, "Unable to parse command line.\n");
+goto done;
+}
+
+ret = get_group_domain_msg(tool_ctx, );
+if (ret != EOK) {
+DEBUG(SSSDBG_CRIT_FAILURE, "Unable to get object domain\n");
+goto done;
+}
+
+ret = get_object_dn(tmp_ctx, input.domain, SYSDB_MEMBER_GROUP,
+   input.orig_name, NULL, );

Indentation.

+if (ret != EOK) {
+DEBUG(SSSDBG_CRIT_FAILURE, "Unable to get object dn\n");
+goto done;
+}


Here you go.

>From 838870f8fa6a91193a6dc291d9ad7168d3395853 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pavel=20B=C5=99ezina?= 
Date: Tue, 20 Oct 2015 12:22:23 +0200
Subject: [PATCH 1/9] sss_tools: always show common and help options

popt don't handle merging NULL option table, thus common and help
options were not displayed when command doesn't have any options.
---
 src/tools/common/sss_tools.c | 15 ++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/src/tools/common/sss_tools.c b/src/tools/common/sss_tools.c
index c0b52bb86941d3245569e13ff8b830d861ba..abb9dbace3c622df84350cfc0b7a6f42c1a5e469 100644
--- a/src/tools/common/sss_tools.c
+++ b/src/tools/common/sss_tools.c
@@ -262,6 +262,19 @@ int sss_tool_route(int argc, const char **argv,
 return sss_tool_usage(argv[0], commands);
 }
 
+static struct poptOption *nonnull_popt_table(struct poptOption *options)
+{
+static struct poptOption empty[] = {
+POPT_TABLEEND
+};
+
+if (options == NULL) {
+return empty;
+}
+
+return options;
+}
+
 int sss_tool_popt_ex(struct sss_cmdline *cmdline,
  struct poptOption *options,
  enum sss_tool_opt require_option,
@@ -272,7 +285,7 @@ int sss_tool_popt_ex(struct sss_cmdline *cmdline,
  const char **_fopt)
 {
 struct poptOption opts_table[] = {
-{NULL, '\0', POPT_ARG_INCLUDE_TABLE, options, \
+{NULL, '\0', POPT_ARG_INCLUDE_TABLE, nonnull_popt_table(options), \
  0, _("Command options:"), NULL },
 {NULL, '\0', POPT_ARG_INCLUDE_TABLE, sss_tool_common_opts_table(), \
  0, _("Common options:"), NULL },
-- 
1.9.3

>From 5ca16aea919c8f71c48495ed7c40ad49edb48138 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pavel=20B=C5=99ezina?= 
Date: Tue, 20 Oct 2015 11:18:31 +0200
Subject: [PATCH 2/9] sss_override: fix exporting multiple domains

There was a mistake in the code which resulted in exporting one
domain several times if multiple domain were configured.
---
 src/tools/sss_override.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/tools/sss_override.c b/src/tools/sss_override.c
index 041c2a10617c98bac584b9058fe0050286f71249..d0bf38729519e785aeff8e06e6e7b4e8710e0946 100644
--- a/src/tools/sss_override.c
+++ b/src/tools/sss_override.c
@@ -1249,7 +1249,7 @@ static int override_user_export(struct sss_cmdline *cmdline,
 
 dom = tool_ctx->domains;
 do {
-objs = list_user_overrides(tool_ctx, tool_ctx->domains);
+objs = list_user_overrides(tool_ctx, dom);
 if (objs == NULL) {
 DEBUG(SSSDBG_CRIT_FAILURE, "Unable to get override objects\n");
 exit = EXIT_FAILURE;
@@ -1454,7 +1454,7 @@ static int override_group_export(struct sss_cmdline *cmdline,
 
 dom = tool_ctx->domains;
 do {
-objs = list_group_overrides(tool_ctx, tool_ctx->domains);
+objs = list_group_overrides(tool_ctx, dom);
 if (objs == NULL) {
 DEBUG(SSSDBG_CRIT_FAILURE, "Unable to get override objects\n");
 exit = EXIT_FAILURE;
-- 
1.9.3

>From 8d90adae72d43d3d2359592a93ed4c8c050ff1ef Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pavel=20B=C5=99ezina?= 
Date: Fri, 23 Oct 2015 13:30:08 +0200
Subject: [PATCH 3/9] sss_override: add user-find

Resolves:
https://fedorahosted.org/sssd/ticket/2736
---
 src/man/sss_override.8.xml |  13 +++
 src/tools/sss_override.c   | 194

[SSSD] [PATCH] PAM: successful authentication sets explicitly PAM_SUCCESSS

2015-10-29 Thread Pavel Reichl


Hello,

while I worked on tests for PAM responder Sumit proposed to use attached patch. 
QA have already kindly run their tests (successfully).

I'll do the review myself (But all opinions are welcomed for sure).

Thanks
>From 55e487ac403f39e8b65e9373b06059399e74b792 Mon Sep 17 00:00:00 2001
From: Sumit Bose 
Date: Mon, 19 Oct 2015 13:10:51 -0400
Subject: [PATCH] PAM: successful authentication sets explicitly PAM_SUCCESSS

Set PAM_SYSTEM_ERR as default pam_status to ensure that we always must
set PAM_SUCCESSS explicitly for a successful authentication and will
really return an error in all other cases.
---
 src/providers/dp_pam_data_util.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/src/providers/dp_pam_data_util.c b/src/providers/dp_pam_data_util.c
index 10e91f5f7286db5e76ad98b6c7519f2482d006db..f471c7d02f5c86d1b1a45dd152c048de0e0bbb44 100644
--- a/src/providers/dp_pam_data_util.c
+++ b/src/providers/dp_pam_data_util.c
@@ -22,6 +22,8 @@
 along with this program.  If not, see .
 */
 
+#include 
+
 #include "providers/data_provider.h"
 #include "util/sss_cli_cmd.h"
 
@@ -48,6 +50,8 @@ struct pam_data *create_pam_data(TALLOC_CTX *mem_ctx)
 goto failed;
 }
 
+pd->pam_status = PAM_SYSTEM_ERR;
+
 pd->authtok = sss_authtok_new(pd);
 if (pd->authtok == NULL) {
 DEBUG(SSSDBG_CRIT_FAILURE, "talloc_zero failed.\n");
-- 
2.4.3

___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] sss_override: add -find and -show

2015-10-29 Thread Pavel Reichl


Here you go.



Thanks, my manual testing passed. Code LGTM. CI passed: 
http://sssd-ci.duckdns.org/logs/job/31/47/summary.html

ACK
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] sss_override: Add restart requirements to man page

2015-10-29 Thread Pavel Březina


On 10/29/2015 03:44 PM, Pavel Reichl wrote:



The patch is different iw we compare to the initial version.
I think Dad deserves a credit so the author should be Dan.
Will you prepare new patch or shoudl we change it before pushing.

LS


Patch with changed authorship attached.


Ack.

___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] sss_override: Add restart requirements to man page

2015-10-29 Thread Pavel Reichl




The patch is different iw we compare to the initial version.
I think Dad deserves a credit so the author should be Dan.
Will you prepare new patch or shoudl we change it before pushing.

LS


Patch with changed authorship attached.
>From 3fc31691499fbee896d78e9f970cb4300d2fb2af Mon Sep 17 00:00:00 2001
From: Dan Lavu 
Date: Wed, 21 Oct 2015 12:28:37 +0200
Subject: [PATCH 1/2] sss_override: Add restart requirements to man page

---
 src/man/sss_override.8.xml | 11 +--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/src/man/sss_override.8.xml b/src/man/sss_override.8.xml
index 24c38936984946b3284d1523a7321a7e7f3d7982..5be4295183a78a9e6625b6689cb1003ce1c01541 100644
--- a/src/man/sss_override.8.xml
+++ b/src/man/sss_override.8.xml
@@ -34,8 +34,15 @@
 and groups. This change takes effect only on local machine.
 
 
-Overrides data are stored in SSSD cache. If the cache is deleted
-all local overrides are lost.
+Overrides data are stored in the SSSD cache. If the cache is deleted,
+all local overrides are lost. Please note that after the first
+override is created using any of the following
+user-add, group-add,
+user-import or
+group-import command. SSSD needs to be
+restarted to take effect.
+sss_override prints message when a restart is
+required.
 
 
 
-- 
2.4.3

>From 420adb29a8ab765516c6ef63c397fdff78391c9f Mon Sep 17 00:00:00 2001
From: Pavel Reichl 
Date: Thu, 22 Oct 2015 13:25:45 +0200
Subject: [PATCH 2/2] sss_override: Removed overrides might be in memcache

---
 src/man/sss_override.8.xml | 10 --
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/src/man/sss_override.8.xml b/src/man/sss_override.8.xml
index 5be4295183a78a9e6625b6689cb1003ce1c01541..6d6d28477c1304072484bc9def5461fe6332e8ed 100644
--- a/src/man/sss_override.8.xml
+++ b/src/man/sss_override.8.xml
@@ -80,7 +80,10 @@
 
 
 
-Remove user overrides.
+Remove user overrides. However be aware that overridden
+attributes might be returned from memory cache. Please
+see SSSD option memcache_timeout
+for more details.
 
 
 
@@ -150,7 +153,10 @@
 
 
 
-Remove group overrides.
+Remove group overrides. However be aware that overridden
+attributes might be returned from memory cache. Please
+see SSSD option memcache_timeout
+for more details.
 
 
 
-- 
2.4.3

___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] PAM: successful authentication sets explicitly PAM_SUCCESSS

2015-10-29 Thread Lukas Slebodnik

On (29/10/15 15:32), Pavel Reichl wrote:
>Hello,
>
>while I worked on tests for PAM responder Sumit proposed to use attached 
>patch. QA have already kindly run their tests (successfully).
>
>I'll do the review myself (But all opinions are welcomed for sure).
>
>Thanks

>From 55e487ac403f39e8b65e9373b06059399e74b792 Mon Sep 17 00:00:00 2001
>From: Sumit Bose 
>Date: Mon, 19 Oct 2015 13:10:51 -0400
>Subject: [PATCH] PAM: successful authentication sets explicitly PAM_SUCCESSS
>
>Set PAM_SYSTEM_ERR as default pam_status to ensure that we always must
>set PAM_SUCCESSS explicitly for a successful authentication and will
>really return an error in all other cases.
>---
> src/providers/dp_pam_data_util.c | 4 
> 1 file changed, 4 insertions(+)
>
>diff --git a/src/providers/dp_pam_data_util.c 
>b/src/providers/dp_pam_data_util.c
>index 
>10e91f5f7286db5e76ad98b6c7519f2482d006db..f471c7d02f5c86d1b1a45dd152c048de0e0bbb44
> 100644
>--- a/src/providers/dp_pam_data_util.c
>+++ b/src/providers/dp_pam_data_util.c
>@@ -22,6 +22,8 @@
> along with this program.  If not, see .
> */
> 
>+#include 
>+
We try to avoid including non-standar pam header files.
Prefix "_" is Linux PAM specific.

sh$ git grep pam_types | wc -l
0

sh$ git grep pam_modules .
src/external/pam.m4:AC_CHECK_HEADERS([security/pam_appl.h 
security/pam_modules.h],
src/providers/ad/ad_access.c:#include 
src/providers/ad/ad_gpo.c:#include 
src/providers/ad/ad_gpo_child.c:#include 
src/providers/data_provider_be.c:#include 
src/providers/ipa/ipa_access.c:#include 
src/providers/ipa/ipa_auth.c:#include 
src/providers/ipa/ipa_selinux.c:#include 
src/providers/krb5/krb5_auth.c:#include 
src/providers/krb5/krb5_child.c:#include 
src/providers/krb5/krb5_delayed_online_authentication.c:#include 

src/providers/krb5/krb5_renew_tgt.c:#include 
src/providers/krb5/krb5_wait_queue.c:#include 
src/providers/ldap/ldap_access.c:#include 
src/providers/ldap/ldap_auth.c:#include 
src/providers/ldap/sdap_access.c:#include 
src/providers/proxy/proxy.h:#include 
src/providers/proxy/proxy_child.c:#include 
src/providers/simple/simple_access.c:#include 
src/responder/pam/pam_LOCAL_domain.c:#include 
src/responder/pam/pamsrv_dp.c:#include 
src/sss_client/common.c:#include 
src/sss_client/pam_message.c:#include 
src/sss_client/pam_sss.c:#include 
src/tests/cmocka/test_krb5_wait_queue.c:#include 
src/tests/cmocka/test_pam_srv.c:#include 

LS
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH v2] intg: Add more LDAP tests

2015-10-29 Thread Michal Židek


On 10/27/2015 04:10 PM, Nikolai Kondrashov wrote:

Hi Michal,

Thanks a lot for the detailed review and testing!
Please see my comments below.

On 10/23/2015 02:54 PM, Michal Židek wrote:

Hi!

There is one new pep8 error in the code:
../src/tests/intg/ldap_test.py:819:37: E126 continuation line
over-indented for hanging indent


Sure, will fix it.


For the memcache workaroud please do this change in the
code:
diff --git a/src/tests/intg/ldap_test.py b/src/tests/intg/ldap_test.py
index 8263d88..eb466ab 100644
--- a/src/tests/intg/ldap_test.py
+++ b/src/tests/intg/ldap_test.py
@@ -194,8 +194,10 @@ def cleanup_sssd_process():
  subprocess.call(["sss_cache", "-E"])
  for path in os.listdir(config.DB_PATH):
  os.unlink(config.DB_PATH + "/" + path)
-for path in os.listdir(config.MCACHE_PATH):
-os.unlink(config.MCACHE_PATH + "/" + path)
+# FIXME: Uncomment this when ticket #2726 is solved
+# https://fedorahosted.org/sssd/ticket/2726
+# for path in os.listdir(config.MCACHE_PATH):
+#os.unlink(config.MCACHE_PATH + "/" + path)




+def format_interactive_conf(ldap_conn, schema):
+"""Format an SSSD configuration with all caches refreshing in 4
seconds"""
+return \
+format_basic_conf(ldap_conn, schema, enum=True) + \
+unindent("""
+[nss]
+memcache_timeout= 4


It is better to set memcache timeout to zero outside tests
that are not dedicated to memcache. This will also probably
solve the membership tests failure that you saw when using the
workaround for the memcache tests failure.


Hmm, perhaps. However, could you please explain why the membership tests
fail?

I noticed that they also fail if I simply don't run the group
addition/removal
tests before them, in addition to enabling the workaround. Also, they
work if
I put "run_shell" before each "assert" and immediately exit the spawned
shells
even without doing anything in them.


I really do not know why the run_shell helped. Maybe it
forced pytest to initialize new client memory cache context.
I tried to do some tests with run_shell, but they did not
work for me.

Anyway, the failures were connected to memory cache
and memory cache currently is not reliable in these
test, so I did not investigated further, why they
failed.




+enum_cache_timeout  = 4
+entry_negative_timeout  = 4


I would set negative cache timeout to zero as well,
see comments below.


Replying below.


+def test_add_remove_user(ldap_conn, blank_rfc2307):
+"""Test user addition and removal are reflected by SSSD"""
+e = ldap_ent.user(ldap_conn.ds_inst.base_dn, "user", 1001, 2000)
+time.sleep(2)


What is the purpose of this timeout? It does not seem to be
necessary. You use it in all the other tests as well, so
I guess it had some meaning (but I tried to remove them and
tests passed for me without problems).


This puts test actions and tests in the middle of the 4 second cache
timeouts,
so they are more reliable and time drift doesn't affect them that much.

E.g.:

 0 - sssd start
 1 -
 2 - add user, check it's not yet present
 3 -
 4 - cache expiry/purging
 5 -
 6 - check user added
 7 -
 8 - cache expiry/purging

etc.

IIRC, I got 400+ perfect runs before the first failure occurred with this -
better than other schemes.


Hmmm...maybe this was because SSSD was not initialized (fully
started) when the test was run. In which case it is problem
of the fixture that starts SSSD and should be solved inside
the fixture (the sleep() should be added there).




+# Add the user
+ent.assert_passwd(ent.contains_only())
+ldap_conn.add_s(*e)
+ent.assert_passwd(ent.contains_only())


I would avoid testing the negative cache outside tests
that are dedicated to negative cache. We had this same
pattern in our C code tests and it timed out when CI
was under heavy load. We can add dedicated tests
for negative cache in CI later with big enough timeout
to pass even under heavy load CI.

So please, remove the negative cache testing from everywhere
in these tests.


I'm OK with minimizing the tests and not exercising some caching
mechanisms. I understand it will make tests more reliable.

However, my intention was to test the full end-user functionality, what
actually matters to users. Users don't really care about caches, they just
want everything work fast and reliably. They just want their LDAP changes
propagated. For that matter I only touch cache timeouts to make tests
run in
reasonable time. I don't disable them, because users will probably have
them
enabled as well.

We can test all the cache mechanisms separately, but we will still have to
test them working together. Can we do that? Can we have these particular
tests
do that? Or is it too hard/impossible?

If we can do that, how would you like to see them?

If not, I'll just disable memory cache and remove negative cache testing

Re: [SSSD] [PATCH] BUILD: Fix cleanup without NLS

2015-10-29 Thread Michal Židek


On 10/26/2015 03:57 PM, Lukas Slebodnik wrote:

0001-BUILD-Fix-cleanup-without-NLS.patch



Ack.

CI link:
http://sssd-ci.duckdns.org/logs/job/31/48/summary.html

Michal
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] Monitor: Show service pings at debug level 8

2015-10-29 Thread Lukas Slebodnik

On (27/10/15 15:41), Petr Cech wrote:
>On 10/27/2015 02:58 PM, Stephen Gallagher wrote:
>>SSSDBG_CONF_SETTINGS is reserved for configuration information. These
>>pings are generally just noise (when they fail, this is logged at
>>SSDBG_FATAL_FAILURE). We should only log these at SSSDBG_TRACE_INTERNAL.
>
>Hi Stephen,
>
>CI tests are right:
>http://sssd-ci.duckdns.org/logs/job/31/44/summary.html
>
>=> ACK
>
+DEBUG(SSSDBG_TRACE_INTERNAL,"Pinging %s\n", svc->name);
 ^
I hope you don't mind that I fixed missing space
before pushing.

master:
* 284c22c191963f11e5c07ba6d14dcd8dc7e494fe

It reduce "a noise" in log files and it's trvivila change therefore:
sssd-1-13:
* 6f6622cfe0fdfa5a3522566cd83217e6d628e924

LS
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

[SSSD] [PATCH] BUILD: Fix doc directory for sss_simpleifp

2015-10-29 Thread Lukas Slebodnik

ehlo,

make all docs && make install DESTDIR=`pwd`/_instdir
will not install doxygen generated files for sss_simpleifp
because directory was wrong.

Simple patch is attached.

LS
>From 889a60baa12f40efb9c98e97cf81c2c978825ab5 Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik 
Date: Tue, 2 Jun 2015 16:44:26 +0200
Subject: [PATCH 2/2] BUILD: Fix doc directory for sss_simpleifp

make all docs && make install DESTDIR=`pwd`/_instdir
will not install doxygen generated files for sss_simpleifp
because directory was wrong
---
 Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile.am b/Makefile.am
index 
e7920e0710253c8360a168c68fa5503d08841451..281b33d645242ce332f6bfa4a4ba130fe3298b89
 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -675,7 +675,7 @@ SSSD_DOCS = \
 nss_idmap_doc
 
 if BUILD_IFP
-SSSD_DOCS += libsss_simpleifp_doc
+SSSD_DOCS += sss_simpleifp_doc
 endif
 
 CLIENT_LIBS = $(LTLIBINTL)
-- 
2.5.0

___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

[SSSD] [PATCH] BUILD: Remove sudo doxygen file

2015-10-29 Thread Lukas Slebodnik

ehlo,

There aren't any documented files in directory src/sss_client/sudo/

LS
>From 709e71d86269082e89209dc01e08dd5a3d10d348 Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik 
Date: Tue, 2 Jun 2015 16:48:58 +0200
Subject: [PATCH 1/2] BUILD: Remove sudo doxygen file

There aren't any documented files in directory src/sss_client/sudo/
---
 Makefile.am  |4 -
 configure.ac |1 -
 src/sss_client/sudo/sss_sudo.doxy.in | 1883 --
 3 files changed, 1888 deletions(-)
 delete mode 100644 src/sss_client/sudo/sss_sudo.doxy.in

diff --git a/Makefile.am b/Makefile.am
index 
15d99ce0551f95e213693cd28d7de09353002b50..e7920e0710253c8360a168c68fa5503d08841451
 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -674,10 +674,6 @@ SSSD_DOCS = \
 idmap_doc \
 nss_idmap_doc
 
-if BUILD_SUDO
-SSSD_DOCS += libsss_sudo_doc
-endif
-
 if BUILD_IFP
 SSSD_DOCS += libsss_simpleifp_doc
 endif
diff --git a/configure.ac b/configure.ac
index 
e699e30dcc234f638ef6f458c63c3af05e7058f1..51c0b0da8a7cfb692eabf38a71e42fbb0e40b4b0
 100644
--- a/configure.ac
+++ b/configure.ac
@@ -411,7 +411,6 @@ AC_CONFIG_FILES([Makefile contrib/sssd.spec 
src/examples/rwtab src/doxy.config
  src/tests/intg/Makefile
  src/providers/ipa/ipa_hbac.pc src/providers/ipa/ipa_hbac.doxy
  src/lib/idmap/sss_idmap.pc src/lib/idmap/sss_idmap.doxy
- src/sss_client/sudo/sss_sudo.doxy
  src/sss_client/idmap/sss_nss_idmap.pc
  src/sss_client/idmap/sss_nss_idmap.doxy
  src/sss_client/libwbclient/wbclient_sssd.pc
diff --git a/src/sss_client/sudo/sss_sudo.doxy.in 
b/src/sss_client/sudo/sss_sudo.doxy.in
deleted file mode 100644
index 
63dccf6347994c94f888a74332ede6a297e02bba..
--- a/src/sss_client/sudo/sss_sudo.doxy.in
+++ /dev/null
@@ -1,1883 +0,0 @@
-# Doxyfile 1.8.3
-
-# This file describes the settings to be used by the documentation system
-# doxygen (www.doxygen.org) for a project.
-#
-# All text after a hash (#) is considered a comment and will be ignored.
-# The format is:
-#   TAG = value [value, ...]
-# For lists items can also be appended using:
-#   TAG += value [value, ...]
-# Values that contain spaces should be placed between quotes (" ").
-
-#---
-# Project related configuration options
-#---
-
-# This tag specifies the encoding used for all characters in the config file
-# that follow. The default is UTF-8 which is also the encoding used for all
-# text before the first occurrence of this tag. Doxygen uses libiconv (or the
-# iconv built into libc) for the transcoding. See
-# http://www.gnu.org/software/libiconv for the list of possible encodings.
-
-DOXYFILE_ENCODING  = UTF-8
-
-# The PROJECT_NAME tag is a single word (or sequence of words) that should
-# identify the project. Note that if you do not use Doxywizard you need
-# to put quotes around the project name if it contains spaces.
-
-PROJECT_NAME   = libsss_sudo
-
-# The PROJECT_NUMBER tag can be used to enter a project or revision number.
-# This could be handy for archiving the generated documentation or
-# if some version control system is used.
-
-PROJECT_NUMBER = @PACKAGE_VERSION@
-
-# Using the PROJECT_BRIEF tag one can provide an optional one line description
-# for a project that appears at the top of each page and should give viewer
-# a quick idea about the purpose of the project. Keep the description short.
-
-PROJECT_BRIEF  =
-
-# With the PROJECT_LOGO tag one can specify an logo or icon that is
-# included in the documentation. The maximum height of the logo should not
-# exceed 55 pixels and the maximum width should not exceed 200 pixels.
-# Doxygen will copy the logo to the output directory.
-
-PROJECT_LOGO   =
-
-# The OUTPUT_DIRECTORY tag is used to specify the (relative or absolute)
-# base path where the generated documentation will be put.
-# If a relative path is entered, it will be relative to the location
-# where doxygen was started. If left blank the current directory will be used.
-
-OUTPUT_DIRECTORY   = libsss_sudo_doc
-
-# If the CREATE_SUBDIRS tag is set to YES, then doxygen will create
-# 4096 sub-directories (in 2 levels) under the output directory of each output
-# format and will distribute the generated files over these directories.
-# Enabling this option can be useful when feeding doxygen a huge amount of
-# source files, where putting all generated files in the same directory would
-# otherwise cause performance problems for the file system.
-
-CREATE_SUBDIRS = NO
-
-# The OUTPUT_LANGUAGE tag is used to specify the language in which all
-# documentation generated by doxygen is written. Doxygen will use this
-#

Re: [SSSD] [PATCH] DEBUG: Don't error on chown of nonexistent file

Re: [SSSD] [PATCH] sss_override: add -find and -show

[SSSD] [PATCH] PAM: successful authentication sets explicitly PAM_SUCCESSS

Re: [SSSD] [PATCH] sss_override: add -find and -show

Re: [SSSD] [PATCH] sss_override: Add restart requirements to man page

Re: [SSSD] [PATCH] sss_override: Add restart requirements to man page

Re: [SSSD] [PATCH] PAM: successful authentication sets explicitly PAM_SUCCESSS

Re: [SSSD] [PATCH v2] intg: Add more LDAP tests

Re: [SSSD] [PATCH] BUILD: Fix cleanup without NLS

Re: [SSSD] [PATCH] Monitor: Show service pings at debug level 8

[SSSD] [PATCH] BUILD: Fix doc directory for sss_simpleifp

[SSSD] [PATCH] BUILD: Remove sudo doxygen file

12 matches

Site Navigation

Mail list logo

Footer information