[SSSD] [sssd PR#231][comment] changing all talloc_get_type() with talloc_get_type_abort()
URL: https://github.com/SSSD/sssd/pull/231
Title: #231: changing all talloc_get_type() with talloc_get_type_abort()
simo5 commented:
"""
So I can't really comment inline because there are too many lines in the patch
but I grepped throught the code:
I see:
+ void sss_talloc_abort(const char reason){
Well .. that should be a const char * to start with as you want to pass a
pointer to string not a single character
Also the style is incorrect as the opening brace should be on the next line.
The content of the function also is not what the issue describes.
the issue describes the option to either abort() or print a debug error based
on configuration (or perhaps build flags). Instead this code unconditionally
prints a debug error (this may be ok actually) and then unconditionally calls
abort().
Finally this patchset is going to be big as it touches thousands of file in a
mostly mecahnical way.
To improve reviewability it wuld be nice to split this PR in 2/3 patches:
1. Introduce the new sss_talloc_abort() function in the first patch with a good
commit message that explains what this will bring us.
2. a separate patch that enables it everywhere
3. a separate patch that changes the invocations ofa talloc_get_type() to
talloc_get_type_abort()
HTH.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/231#issuecomment-292973967
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#231][comment] changing all talloc_get_type() with talloc_get_type_abort()
URL: https://github.com/SSSD/sssd/pull/231 Title: #231: changing all talloc_get_type() with talloc_get_type_abort() simo5 commented: """ Please also do not commit as root, but use a proper user/email setting, and if you can add the signed-off-by header. """ See the full comment at https://github.com/SSSD/sssd/pull/231#issuecomment-292971151 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] Re: Design document - SSSD KCM server
On Wed, 2017-04-05 at 21:02 +0200, Jakub Hrozek wrote: > On Tue, Nov 22, 2016 at 08:51:10AM +0100, Jakub Hrozek wrote: > > Hi, > > > > I was working on a KCM server for SSSD for some time already in parallel > > with the files provider and had some discussions with Simo as well. Of > > course my intent wasn't to implement a feature secretly without a design > > review, but to have a prototype to base a proper design on :) > > > > However it makes sense to have a peer-reviewed design page now, also > > because of Fedora's move towards Kerberos and KDC proxy, which leads to > > questions on the Fedora lists about ccache renewals and so on -- so I > > think it makes sense to pitch the design to Fedora at least already.. > > > > Here is the design page: > > https://fedorahosted.org/sssd/wiki/DesignDocs/KCM > > and here is the code of the KCM responder so far: > > https://github.com/jhrozek/sssd/tree/kcm > > Hi, > > I moved the design doc to pagure: > https://docs.pagure.org/SSSD.sssd/design_pages/kcm.html > > It's been cleaned up and reconciled with the implementation. It looks really nice with the docs formatting/font/style :-) .. and the content LGTM too. Simo. -- Simo Sorce Sr. Principal Software Engineer Red Hat, Inc ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#196][closed] SSSD-1.15 - config-check: Message when sssd.conf is missing
URL: https://github.com/SSSD/sssd/pull/196 Author: mzidek-rh Title: #196: SSSD-1.15 - config-check: Message when sssd.conf is missing Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/196/head:pr196 git checkout pr196 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#196][comment] SSSD-1.15 - config-check: Message when sssd.conf is missing
URL: https://github.com/SSSD/sssd/pull/196 Title: #196: SSSD-1.15 - config-check: Message when sssd.conf is missing lslebodn commented: """ master: * 955574eeb3a3b937abc3df150e979b75c889 sssd-1-14: * b35d7aa90b18ba544ba11fcabeb9662e38fb91fa """ See the full comment at https://github.com/SSSD/sssd/pull/196#issuecomment-292969976 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#196][+Pushed] SSSD-1.15 - config-check: Message when sssd.conf is missing
URL: https://github.com/SSSD/sssd/pull/196 Title: #196: SSSD-1.15 - config-check: Message when sssd.conf is missing Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#231][+Changes requested] changing all talloc_get_type() with talloc_get_type_abort()
URL: https://github.com/SSSD/sssd/pull/231 Title: #231: changing all talloc_get_type() with talloc_get_type_abort() Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#231][comment] changing all talloc_get_type() with talloc_get_type_abort()
URL: https://github.com/SSSD/sssd/pull/231 Title: #231: changing all talloc_get_type() with talloc_get_type_abort() fidencio commented: """ @amitkumar50: So, I didn't go through your patches but I've noticed that you added a bunch of files that are not part of our tree (and shouldn't be). I'm assuming here you did something like `git add -A -f` and this is not the way to go :-) So, please, add just the files changed that are part of our git (x86_64 and rpmbuilds directories and everything under those are not) and a re-submit the patches. Thanks a lot for the contribution and I'm looking forward to seeing a new version of the patch! """ See the full comment at https://github.com/SSSD/sssd/pull/231#issuecomment-292967495 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#231][comment] changing all talloc_get_type() with talloc_get_type_abort()
URL: https://github.com/SSSD/sssd/pull/231 Title: #231: changing all talloc_get_type() with talloc_get_type_abort() lslebodn commented: """ @amitkumar50 could you rebase patches on top of git master? """ See the full comment at https://github.com/SSSD/sssd/pull/231#issuecomment-292961182 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#200][comment] Improve PAM test client
URL: https://github.com/SSSD/sssd/pull/200 Title: #200: Improve PAM test client lslebodn commented: """ master: * dbeae483464e42238a84c6a5b8c3c4f5312ae643 * 4a9160e2b3b9c531e2b4a7884f49bfbb4a07a992 * 9be97c9cc69e5e6e568d7e21f61a46c3ae2dc387 * 40ff10d73063949ca699670ca212e96b809d5fcd * 435b3678de25d22eb8a6e892109d26c32f0760a4 * 7be6624d9eda369e9a4d70c8ee4939b369b3 """ See the full comment at https://github.com/SSSD/sssd/pull/200#issuecomment-292952641 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#200][closed] Improve PAM test client
URL: https://github.com/SSSD/sssd/pull/200 Author: sumit-bose Title: #200: Improve PAM test client Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/200/head:pr200 git checkout pr200 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#200][+Pushed] Improve PAM test client
URL: https://github.com/SSSD/sssd/pull/200 Title: #200: Improve PAM test client Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#231][comment] changing all talloc_get_type() with talloc_get_type_abort()
URL: https://github.com/SSSD/sssd/pull/231 Title: #231: changing all talloc_get_type() with talloc_get_type_abort() centos-ci commented: """ Can one of the admins verify this patch? """ See the full comment at https://github.com/SSSD/sssd/pull/231#issuecomment-292950202 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#231][comment] changing all talloc_get_type() with talloc_get_type_abort()
URL: https://github.com/SSSD/sssd/pull/231 Title: #231: changing all talloc_get_type() with talloc_get_type_abort() centos-ci commented: """ Can one of the admins verify this patch? """ See the full comment at https://github.com/SSSD/sssd/pull/231#issuecomment-292950199 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#227][closed] CONFDB: Fix handling of enable_files_domain
URL: https://github.com/SSSD/sssd/pull/227 Author: lslebodn Title: #227: CONFDB: Fix handling of enable_files_domain Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/227/head:pr227 git checkout pr227 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#227][+Pushed] CONFDB: Fix handling of enable_files_domain
URL: https://github.com/SSSD/sssd/pull/227 Title: #227: CONFDB: Fix handling of enable_files_domain Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#227][comment] CONFDB: Fix handling of enable_files_domain
URL: https://github.com/SSSD/sssd/pull/227 Title: #227: CONFDB: Fix handling of enable_files_domain lslebodn commented: """ master: * 3509bb03ecef49264820c9e287e8b2c7e0a8a508 """ See the full comment at https://github.com/SSSD/sssd/pull/227#issuecomment-292938580 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#200][comment] Improve PAM test client
URL: https://github.com/SSSD/sssd/pull/200 Title: #200: Improve PAM test client pbrezina commented: """ Ack. """ See the full comment at https://github.com/SSSD/sssd/pull/200#issuecomment-292923387 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
