[SSSD] [sssd PR#601][-Changes requested] sbus: integrate sssd with sbus2
URL: https://github.com/SSSD/sssd/pull/601 Title: #601: sbus: integrate sssd with sbus2 Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/NF25QXODHRV7FSDYLDMTJD4O57FQ4KMJ/
[SSSD] [sssd PR#631][+Pushed] nss: remove unused label
URL: https://github.com/SSSD/sssd/pull/631 Title: #631: nss: remove unused label Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/QYFZDMX4SJGYBC5FJR3XIPFECZEDR4AI/
[SSSD] [sssd PR#631][closed] nss: remove unused label
URL: https://github.com/SSSD/sssd/pull/631 Author: fidencio Title: #631: nss: remove unused label Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/631/head:pr631 git checkout pr631 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/TN6DYCTAKG2T4I5NFY6CDNDMU4T6FKEQ/
[SSSD] [sssd PR#631][comment] nss: remove unused label
URL: https://github.com/SSSD/sssd/pull/631 Title: #631: nss: remove unused label fidencio commented: """ master: e8b417e """ See the full comment at https://github.com/SSSD/sssd/pull/631#issuecomment-412120488 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/I76MPRW362XEL3RT7B4C4KSBTWDK3QWR/
[SSSD] [sssd PR#631][-Accepted] nss: remove unused label
URL: https://github.com/SSSD/sssd/pull/631 Title: #631: nss: remove unused label Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/RMVMJVUYCXIWYMTM2UM7XWJQ5R7SRDBD/
[SSSD] [sssd PR#634][comment] P11: Don't return int failure from a bool function
URL: https://github.com/SSSD/sssd/pull/634 Title: #634: P11: Don't return int failure from a bool function fidencio commented: """ master: 7225bab """ See the full comment at https://github.com/SSSD/sssd/pull/634#issuecomment-412120291 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/4I3Y7HLD2LIP7G7TMVEPVLULR5EHPAOW/
[SSSD] [sssd PR#634][+Pushed] P11: Don't return int failure from a bool function
URL: https://github.com/SSSD/sssd/pull/634 Title: #634: P11: Don't return int failure from a bool function Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/RQ5XKLOUVS3L4YSMEQJR6W42ORX6FXSE/
[SSSD] [sssd PR#634][-Accepted] P11: Don't return int failure from a bool function
URL: https://github.com/SSSD/sssd/pull/634 Title: #634: P11: Don't return int failure from a bool function Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/ZG5X6Z6CDTVZIJBIIXXIDCNAJLWHZNDB/
[SSSD] [sssd PR#632][-Accepted] tests: fix sss_nss_idmap-tests
URL: https://github.com/SSSD/sssd/pull/632 Title: #632: tests: fix sss_nss_idmap-tests Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/CHUPRBGZMFWBBLHZLGRR7DQGD6KKCUT3/
[SSSD] [sssd PR#634][closed] P11: Don't return int failure from a bool function
URL: https://github.com/SSSD/sssd/pull/634 Author: jhrozek Title: #634: P11: Don't return int failure from a bool function Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/634/head:pr634 git checkout pr634 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/AZ7BH7US3TRTP4MHKALZTREDSP7USMJU/
[SSSD] [sssd PR#632][closed] tests: fix sss_nss_idmap-tests
URL: https://github.com/SSSD/sssd/pull/632 Author: sumit-bose Title: #632: tests: fix sss_nss_idmap-tests Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/632/head:pr632 git checkout pr632 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/MO2QXQ4Q6CZAVVZBL4IMQSHVE2TFCNQY/
[SSSD] [sssd PR#632][comment] tests: fix sss_nss_idmap-tests
URL: https://github.com/SSSD/sssd/pull/632 Title: #632: tests: fix sss_nss_idmap-tests fidencio commented: """ master: da9e34e """ See the full comment at https://github.com/SSSD/sssd/pull/632#issuecomment-412119927 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/D6YVMDFDTOFPRGTKE7RL77XG7M6MO66T/
[SSSD] [sssd PR#632][+Pushed] tests: fix sss_nss_idmap-tests
URL: https://github.com/SSSD/sssd/pull/632 Title: #632: tests: fix sss_nss_idmap-tests Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/EWY3JDRPLOSLYWLYCEFXPGTHZUJODZNP/
[SSSD] [sssd PR#630][comment] KCM/SECRETS: Use a library to access the secrets storage instead of the secrets responder, deprecate secrets responder
URL: https://github.com/SSSD/sssd/pull/630
Title: #630: KCM/SECRETS: Use a library to access the secrets storage instead
of the secrets responder, deprecate secrets responder
fidencio commented:
"""
@jhrozek, I found out a few more issues related to the last patch of the latest
series, please, take a look at the following patch that could be squashed into
yours:
```
diff --git a/Makefile.am b/Makefile.am
index 23e094a37..0f36148e8 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -4663,8 +4663,6 @@ if HAVE_SYSTEMD_UNIT
src/sysv/systemd/sssd-pam.socket \
src/sysv/systemd/sssd-pam-priv.socket \
src/sysv/systemd/sssd-pam.service \
-src/sysv/systemd/sssd-secrets.socket \
-src/sysv/systemd/sssd-secrets.service \
$(NULL)
if BUILD_AUTOFS
systemdunit_DATA += \
@@ -4683,6 +4681,12 @@ if BUILD_PAC_RESPONDER
src/sysv/systemd/sssd-pac.service \
$(NULL)
endif
+if BUILD_SECRETS
+systemdunit_DATA += \
+src/sysv/systemd/sssd-secrets.socket \
+src/sysv/systemd/sssd-secrets.service \
+$(NULL)
+endif
if BUILD_SSH
systemdunit_DATA += \
src/sysv/systemd/sssd-ssh.socket \
@@ -4820,6 +4824,7 @@ src/sysv/systemd/sssd-pam.service:
src/sysv/systemd/sssd-pam.service.in Makefile
@$(MKDIR_P) src/sysv/systemd/
$(replace_script)
+if BUILD_SECRETS
src/sysv/systemd/sssd-secrets.socket: src/sysv/systemd/sssd-secrets.socket.in
Makefile
@$(MKDIR_P) src/sysv/systemd/
$(replace_script)
@@ -4827,6 +4832,7 @@ src/sysv/systemd/sssd-secrets.socket:
src/sysv/systemd/sssd-secrets.socket.in Ma
src/sysv/systemd/sssd-secrets.service:
src/sysv/systemd/sssd-secrets.service.in Makefile
@$(MKDIR_P) src/sysv/systemd/
$(replace_script)
+endif
if BUILD_AUTOFS
src/sysv/systemd/sssd-autofs.socket: src/sysv/systemd/sssd-autofs.socket.in
Makefile
@@ -4875,9 +4881,25 @@ src/sysv/systemd/sssd-sudo.service:
src/sysv/systemd/sssd-sudo.service.in Makefi
endif
if BUILD_KCM
+if BUILD_SECRETS
+kcm_socket_requires = Requires=sssd-secrets.socket
+else
+kcm_socket_requires =
+endif
+
+kcm_edit_cmd = $(edit_cmd) \
+-e 's|@kcm_socket_requires[@]|$(kcm_socket_requires)|g'
+
+kcm_replace_script = \
+@rm -f $@ $@.tmp; \
+srcdir=''; \
+test -f ./$@.in || srcdir=$(srcdir)/; \
+$(kcm_edit_cmd) $${srcdir}$@.in >$@.tmp; \
+mv $@.tmp $@
+
src/sysv/systemd/sssd-kcm.socket: src/sysv/systemd/sssd-kcm.socket.in Makefile
@$(MKDIR_P) src/sysv/systemd/
- $(replace_script)
+ $(kcm_replace_script)
src/sysv/systemd/sssd-kcm.service: src/sysv/systemd/sssd-kcm.service.in
Makefile
@$(MKDIR_P) src/sysv/systemd/
diff --git a/contrib/sssd.spec.in b/contrib/sssd.spec.in
index a9874a10e..706254deb 100644
--- a/contrib/sssd.spec.in
+++ b/contrib/sssd.spec.in
@@ -1351,10 +1351,10 @@ done
%{_datadir}/sssd-kcm/kcm_default_ccache
%{_unitdir}/sssd-kcm.socket
%{_unitdir}/sssd-kcm.service
-%{_unitdir}/sssd-secrets.socket
-%{_unitdir}/sssd-secrets.service
%{_mandir}/man8/sssd-kcm.8*
%if (0%{?with_secrets} == 1)
+%{_unitdir}/sssd-secrets.socket
+%{_unitdir}/sssd-secrets.service
%{_mandir}/man5/sssd-secrets.5*
%endif
%endif
@@ -1372,7 +1372,6 @@ getent passwd sssd >/dev/null || useradd -r -g sssd -d /
-s /sbin/nologin -c "Us
%systemd_post sssd-pac.socket
%systemd_post sssd-pam.socket
%systemd_post sssd-pam-priv.socket
-%systemd_post sssd-secrets.socket
%systemd_post sssd-ssh.socket
%systemd_post sssd-sudo.socket
@@ -1383,7 +1382,6 @@ getent passwd sssd >/dev/null || useradd -r -g sssd -d /
-s /sbin/nologin -c "Us
%systemd_preun sssd-pac.socket
%systemd_preun sssd-pam.socket
%systemd_preun sssd-pam-priv.socket
-%systemd_preun sssd-secrets.socket
%systemd_preun sssd-ssh.socket
%systemd_preun sssd-sudo.socket
@@ -1398,8 +1396,6 @@ getent passwd sssd >/dev/null || useradd -r -g sssd -d /
-s /sbin/nologin -c "Us
%systemd_postun_with_restart sssd-pam.socket
%systemd_postun_with_restart sssd-pam-priv.socket
%systemd_postun_with_restart sssd-pam.service
-%systemd_postun_with_restart sssd-secrets.socket
-%systemd_postun_with_restart sssd-secrets.service
%systemd_postun_with_restart sssd-ssh.socket
%systemd_postun_with_restart sssd-ssh.service
%systemd_postun_with_restart sssd-sudo.socket
@@ -1426,6 +1422,18 @@ getent passwd sssd >/dev/null || useradd -r -g sssd -d /
-s /sbin/nologin -c "Us
%systemd_postun_with_restart sssd-kcm.service
%endif
+%if (0%{?with_secrets} == 1)
+%post secrets
+%systemd_postun_with_restart sssd-secrets.socket
+
+%preun secrets
+%systemd_preun_with_restart sssd-secrets.socket
+
+%postun secrets
+%systemd_postun_with_restart sssd-secrets.socket
+%systemd_postun_with_restart sssd-secrets.service
+%endif
+
%else
# sysv
%post common
diff --git a/src/sysv/systemd/sssd-kcm.socket.in
b/src/sysv/systemd/sssd-kcm.socket.in
index 8b742847d..e8a5f0aca 100644
--- a/src/sysv/systemd/sssd-kcm.socket.in
+++
[SSSD] [sssd PR#631][+Accepted] nss: remove unused label
URL: https://github.com/SSSD/sssd/pull/631 Title: #631: nss: remove unused label Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/WYTBS6I4KTRN3O3RLL3XFLTMQ2TPTOOO/
[SSSD] [sssd PR#631][comment] nss: remove unused label
URL: https://github.com/SSSD/sssd/pull/631 Title: #631: nss: remove unused label sumit-bose commented: """ Ok, CI passed with an unrealated issue. ACK. """ See the full comment at https://github.com/SSSD/sssd/pull/631#issuecomment-412110512 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/YWI6V25LUEMJO2JSKKUISAEJT4T4AQ3D/
[SSSD] [sssd PR#634][+Accepted] P11: Don't return int failure from a bool function
URL: https://github.com/SSSD/sssd/pull/634 Title: #634: P11: Don't return int failure from a bool function Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/OXSVLC2JPYSFBHHUPQAEXNGTKMPIM6L2/
[SSSD] [sssd PR#634][comment] P11: Don't return int failure from a bool function
URL: https://github.com/SSSD/sssd/pull/634 Title: #634: P11: Don't return int failure from a bool function sumit-bose commented: """ ACK from me as well. """ See the full comment at https://github.com/SSSD/sssd/pull/634#issuecomment-412103322 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/QPBOC76XSXAYQRHFQTUE5TQ4AGETXY2Y/
[SSSD] [sssd PR#634][comment] P11: Don't return int failure from a bool function
URL: https://github.com/SSSD/sssd/pull/634 Title: #634: P11: Don't return int failure from a bool function pbrezina commented: """ Obvious ack. """ See the full comment at https://github.com/SSSD/sssd/pull/634#issuecomment-412081632 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/3YG76OIRZPIVOLLLOSJPP2SNLCZJVTAP/
[SSSD] [sssd PR#634][opened] P11: Don't return int failure from a bool function
URL: https://github.com/SSSD/sssd/pull/634
Author: jhrozek
Title: #634: P11: Don't return int failure from a bool function
Action: opened
PR body:
"""
The functions return bool as per their prototype, but returning EINVAL on
failure meant that EINVAL (typically 22) was converted to 'true', so a
certificate that was not processable was considered valid.
Luckily this code only converts certificates into SSH public keys, so there
are no security implications.
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/634/head:pr634
git checkout pr634
From c1b32d91aabaa93168661505749fcafca2c4 Mon Sep 17 00:00:00 2001
From: Jakub Hrozek
Date: Wed, 1 Aug 2018 10:26:28 +0200
Subject: [PATCH] P11: Don't return int failure from a bool function
The functions return bool as per their prototype, but returning EINVAL
on failure meant that EINVAL (typically 22) was converted to 'true', so
a certificate that was not processable was considered valid.
Luckily this code only converts certificates into SSH public keys, so
there are no security implications.
---
src/p11_child/p11_child_nss.c | 2 +-
src/p11_child/p11_child_openssl.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/p11_child/p11_child_nss.c b/src/p11_child/p11_child_nss.c
index 717c7a4cf..d6a0b804a 100644
--- a/src/p11_child/p11_child_nss.c
+++ b/src/p11_child/p11_child_nss.c
@@ -220,7 +220,7 @@ bool do_verification_b64(struct p11_ctx *p11_ctx, const char *cert_b64)
ret = b64_to_cert(p11_ctx, cert_b64, );
if (ret != EOK) {
DEBUG(SSSDBG_OP_FAILURE, "Failed to convert certificate.\n");
-return EINVAL;
+return false;
}
res = do_verification(p11_ctx, cert);
diff --git a/src/p11_child/p11_child_openssl.c b/src/p11_child/p11_child_openssl.c
index 953cd3cc8..be5872626 100644
--- a/src/p11_child/p11_child_openssl.c
+++ b/src/p11_child/p11_child_openssl.c
@@ -209,7 +209,7 @@ bool do_verification_b64(struct p11_ctx *p11_ctx, const char *cert_b64)
ret = b64_to_cert(cert_b64, );
if (ret != EOK) {
DEBUG(SSSDBG_OP_FAILURE, "Failed to convert certificate.\n");
-return EINVAL;
+return false;
}
res = do_verification(p11_ctx, cert);
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/2WAAGMJCS6T4MDZD6ED3WUBMNMRTFIMP/
[SSSD] [sssd PR#601][comment] sbus: integrate sssd with sbus2
URL: https://github.com/SSSD/sssd/pull/601
Title: #601: sbus: integrate sssd with sbus2
pbrezina commented:
"""
Right. The problem was when reading the keytab as you wrote in the mail. I did
not notice it because my test keytab is readable by all.
I moved `become_user` after the point where data provider is fully initialized
so the initialization is done as root as it was before.
```diff
+diff --git a/src/providers/data_provider_be.c
b/src/providers/data_provider_be.c
index 095966b25..670ddb477 100644
--- a/src/providers/data_provider_be.c
+++ b/src/providers/data_provider_be.c
@@ -582,6 +582,23 @@ static void dp_initialized(struct tevent_req *req)
goto done;
}
+ret = chown_debug_file(NULL, be_ctx->uid, be_ctx->gid);
+if (ret != EOK) {
+DEBUG(SSSDBG_MINOR_FAILURE,
+ "Cannot chown the debug files, debugging might not work!\n");
+}
+
+ret = become_user(be_ctx->uid, be_ctx->gid);
+if (ret != EOK) {
+DEBUG(SSSDBG_FUNC_DATA,
+ "Cannot become user [%"SPRIuid"][%"SPRIgid"].\n",
+ be_ctx->uid, be_ctx->gid);
+goto done;
+}
+
+DEBUG(SSSDBG_TRACE_FUNC, "Backend provider (%s) started!\n",
+ be_ctx->domain->name);
+
ret = EOK;
done:
@@ -678,21 +695,6 @@ int main(int argc, const char *argv[])
return 3;
}
-ret = chown_debug_file(NULL, uid, gid);
-if (ret != EOK) {
-DEBUG(SSSDBG_MINOR_FAILURE,
- "Cannot chown the debug files, debugging might not work!\n");
-}
-
-ret = become_user(uid, gid);
-if (ret != EOK) {
-DEBUG(SSSDBG_FUNC_DATA,
- "Cannot become user [%"SPRIuid"][%"SPRIgid"].\n", uid, gid);
-return ret;
-}
-
-DEBUG(SSSDBG_TRACE_FUNC, "Backend provider (%s) started!\n", be_domain);
-
/* loop on main */
server_loop(main_ctx);
```
"""
See the full comment at
https://github.com/SSSD/sssd/pull/601#issuecomment-412063892
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/DLAN5Y5OJ7BFMIQZIO5SAZ6VK7UEWFA6/
[SSSD][sssd PR#633][comment] nss_protocol_fill_initgr: fix label ‘done’ defined but not used
URL: https://github.com/SSSD/sssd/pull/633 Title: #633: nss_protocol_fill_initgr: fix label ‘done’ defined but not used pbrezina commented: """ Right. """ See the full comment at https://github.com/SSSD/sssd/pull/633#issuecomment-412061435 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/N7TET3TQRYC37OQ4WQKVO2AAOUHVIP5O/
[SSSD][sssd PR#633][closed] nss_protocol_fill_initgr: fix label ‘done’ defined but not used
URL: https://github.com/SSSD/sssd/pull/633 Author: pbrezina Title: #633: nss_protocol_fill_initgr: fix label ‘done’ defined but not used Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/633/head:pr633 git checkout pr633 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/SB3BHH4M3NZZQLYV5FJPF3A2JONTOIPD/
[SSSD][sssd PR#633][comment] nss_protocol_fill_initgr: fix label ‘done’ defined but not used
URL: https://github.com/SSSD/sssd/pull/633 Title: #633: nss_protocol_fill_initgr: fix label ‘done’ defined but not used sumit-bose commented: """ @pbrezina, there is already https://github.com/SSSD/sssd/pull/631 by @fidencio. """ See the full comment at https://github.com/SSSD/sssd/pull/633#issuecomment-412057200 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/57KEZ2I43VCEWFH4WJCT64A2UQH6YMYF/
[SSSD][sssd PR#633][opened] nss_protocol_fill_initgr: fix label ‘done’ defined but not used
URL: https://github.com/SSSD/sssd/pull/633
Author: pbrezina
Title: #633: nss_protocol_fill_initgr: fix label ‘done’ defined but not used
Action: opened
PR body:
"""
CC src/responder/nss/nss_protocol_netgr.o
/home/pbrezina/workspace/sssd/src/responder/nss/nss_protocol_grent.c: In
function ‘nss_protocol_fill_initgr’:
/home/pbrezina/workspace/sssd/src/responder/nss/nss_protocol_grent.c:409:1:
error: label ‘done’ defined but not used [-Werror=unused-label]
done:
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/633/head:pr633
git checkout pr633
From 17a09b45ff292e943654d5c29a2cd6753d73bca3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pavel=20B=C5=99ezina?=
Date: Fri, 10 Aug 2018 13:08:50 +0200
Subject: [PATCH] =?UTF-8?q?nss=5Fprotocol=5Ffill=5Finitgr:=20fix=20label?=
=?UTF-8?q?=20=E2=80=98done=E2=80=99=20defined=20but=20not=20used?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
/home/pbrezina/workspace/sssd/src/responder/nss/nss_protocol_grent.c: In function ‘nss_protocol_fill_initgr’:
/home/pbrezina/workspace/sssd/src/responder/nss/nss_protocol_grent.c:409:1: error: label ‘done’ defined but not used [-Werror=unused-label]
done:
^~~~
---
src/responder/nss/nss_protocol_grent.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/responder/nss/nss_protocol_grent.c b/src/responder/nss/nss_protocol_grent.c
index a697e86ef..1b03d660b 100644
--- a/src/responder/nss/nss_protocol_grent.c
+++ b/src/responder/nss/nss_protocol_grent.c
@@ -406,7 +406,6 @@ nss_protocol_fill_initgr(struct nss_ctx *nss_ctx,
}
}
-done:
if (ret != EOK) {
sss_packet_set_size(packet, 0);
return ret;
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/VONCL2CTP2NTZU4AB3SQKAGJW5XKKARG/
[SSSD] [sssd PR#601][+Changes requested] sbus: integrate sssd with sbus2
URL: https://github.com/SSSD/sssd/pull/601 Title: #601: sbus: integrate sssd with sbus2 Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/M7VZNDZA4Y2AZRMEHSPM7I5BVJ27JMQE/
[SSSD] [sssd PR#601][comment] sbus: integrate sssd with sbus2
URL: https://github.com/SSSD/sssd/pull/601 Title: #601: sbus: integrate sssd with sbus2 jhrozek commented: """ Another issue revelaed by tests is that starting with `user=sssd` does not work at the moment.. """ See the full comment at https://github.com/SSSD/sssd/pull/601#issuecomment-412037717 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/D6OPCVKMUDMVI4TEUNDF4KD4G4IYEOI3/
[SSSD] [sssd PR#630][-Changes requested] KCM/SECRETS: Use a library to access the secrets storage instead of the secrets responder, deprecate secrets responder
URL: https://github.com/SSSD/sssd/pull/630 Title: #630: KCM/SECRETS: Use a library to access the secrets storage instead of the secrets responder, deprecate secrets responder Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/7U5OV2GWEBAN3GLGKYCEWHQAWDJMRORT/
[SSSD] [sssd PR#630][comment] KCM/SECRETS: Use a library to access the secrets storage instead of the secrets responder, deprecate secrets responder
URL: https://github.com/SSSD/sssd/pull/630 Title: #630: KCM/SECRETS: Use a library to access the secrets storage instead of the secrets responder, deprecate secrets responder jhrozek commented: """ Thank you for the review, I hope all comments were addressed (modulo those where I asked what would you prefer to have done). """ See the full comment at https://github.com/SSSD/sssd/pull/630#issuecomment-412021137 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/DUMX4AVPJD2BVY42KAG7DMGW3IJRPPWV/
[SSSD] [sssd PR#620][comment] Add pam_cert_pam_services option
URL: https://github.com/SSSD/sssd/pull/620 Title: #620: Add pam_cert_pam_services option sumit-bose commented: """ @fidencio, yes, I'm currently reviewing @lslebodn patch. """ See the full comment at https://github.com/SSSD/sssd/pull/620#issuecomment-411987368 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/LAHB2BCTGYMBLAVYIEU6LH6TRMH3TYXF/
[SSSD] [sssd PR#631][comment] nss: remove unused label
URL: https://github.com/SSSD/sssd/pull/631 Title: #631: nss: remove unused label sumit-bose commented: """ Thanks, I've started a CI run. """ See the full comment at https://github.com/SSSD/sssd/pull/631#issuecomment-411987087 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/3OF63SC5LCHMCZL2ZGAA5QRF24RFPEHZ/
[SSSD] [sssd PR#632][comment] tests: fix sss_nss_idmap-tests
URL: https://github.com/SSSD/sssd/pull/632 Title: #632: tests: fix sss_nss_idmap-tests sumit-bose commented: """ @panlinux, thank you for the feedback. @fidencio, please wait a bit before commiting the patch, I'm evaluating a change atm. """ See the full comment at https://github.com/SSSD/sssd/pull/632#issuecomment-411986264 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/LLRI6XUAUZVEFVEBQXE67TDOPGE2LZEE/
