[SSSD] [sssd PR#5766][comment] Sources cleanup - part 3.

2021-10-06 Thread alexey-tikhonov
  URL: https://github.com/SSSD/sssd/pull/5766
Title: #5766: Sources cleanup - part 3.

alexey-tikhonov commented:
"""
> `test_kcm_renewals` is broken.

This PR built without last patch fails this test the same way. Built without 2 
last patches - `test_kcm.py::test_kcm_renewals PASSED`.

So looks like changes in `TESTS: avoid cross-test tainting of os.environ` is 
the reason.
Perhaps kcm-renewal test relied on this "cross-test tainting of os.environ", 
but this is just a guess yet.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/5766#issuecomment-937066525
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5712][comment] Health and Support Analyzer - Add request log parsing utility

2021-10-06 Thread justin-stephenson
  URL: https://github.com/SSSD/sssd/pull/5712
Title: #5712: Health and Support Analyzer - Add request log parsing utility

justin-stephenson commented:
"""
Latest push includes change to declare Reader as an abstract base class with 
required methods, source Files and Journald classes are subclassing Reader.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/5712#issuecomment-936600494
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5712][comment] Health and Support Analyzer - Add request log parsing utility

2021-10-06 Thread justin-stephenson
  URL: https://github.com/SSSD/sssd/pull/5712
Title: #5712: Health and Support Analyzer - Add request log parsing utility

justin-stephenson commented:
"""
Latest push includes change to declare Reader as an abstract base class with 
required methods, Files() and Journald() readers are subclassing Reader.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/5712#issuecomment-936600494
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5712][synchronized] Health and Support Analyzer - Add request log parsing utility

2021-10-06 Thread justin-stephenson
   URL: https://github.com/SSSD/sssd/pull/5712
Author: justin-stephenson
 Title: #5712: Health and Support Analyzer - Add request log parsing utility
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5712/head:pr5712
git checkout pr5712
From 225f91087af3d0abb8d0c91811a8c1e305874a66 Mon Sep 17 00:00:00 2001
From: Justin Stephenson 
Date: Wed, 4 Aug 2021 14:57:55 +
Subject: [PATCH 1/4] DP: Log offline warning for REQ_TRACE tracking

This allows the sssctl analyze parsing tool to report if the
backend was offline when the request came in to the data
provider.
---
 src/providers/data_provider/dp_request.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/src/providers/data_provider/dp_request.c b/src/providers/data_provider/dp_request.c
index 077b361f3c..3cbd55c1ec 100644
--- a/src/providers/data_provider/dp_request.c
+++ b/src/providers/data_provider/dp_request.c
@@ -133,6 +133,10 @@ static errno_t dp_attach_req(struct dp_req *dp_req,
 SSS_REQ_TRACE_CID_DP_REQ(SSSDBG_TRACE_FUNC, dp_req->name,
  "New request. [%s CID #%u] Flags [%#.4x].",
  sender_name, cli_id, dp_flags);
+if (be_is_offline(provider->be_ctx)) {
+DEBUG(SSSDBG_TRACE_FUNC, "[CID #%u] Backend is offline! " \
+ "Using cached data if available\n", cli_id);
+}
 } else {
 SSS_REQ_TRACE_CID_DP_REQ(SSSDBG_TRACE_FUNC, dp_req->name,
  "New request. Flags [%#.4x].",

From f67152712f30fef7abca494520ca32cacac03b55 Mon Sep 17 00:00:00 2001
From: Justin Stephenson 
Date: Fri, 1 Oct 2021 15:13:57 +
Subject: [PATCH 2/4] Responder: Log client uid that started a request

---
 src/responder/common/responder_common.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/responder/common/responder_common.c b/src/responder/common/responder_common.c
index 3207e26e6f..7e145aa9b2 100644
--- a/src/responder/common/responder_common.c
+++ b/src/responder/common/responder_common.c
@@ -640,9 +640,9 @@ static void accept_fd_handler(struct tevent_context *ev,
 
 rctx->client_id_num++;
 DEBUG(SSSDBG_TRACE_FUNC,
-  "Client [CID #%u][cmd %s][%p][%d] connected%s!\n",
-  rctx->client_id_num, cctx->cmd_line, cctx, cctx->cfd,
-  accept_ctx->is_private ? " to privileged pipe" : "");
+  "Client [CID #%u][cmd %s][uid %u][%p][%d] connected%s!\n",
+  rctx->client_id_num, cctx->cmd_line, cli_creds_get_uid(cctx->creds),
+  cctx, cctx->cfd, accept_ctx->is_private ? " to privileged pipe" : "");
 
 return;
 }

From 858d1ed9cacbb815ba23b24d4236257061681751 Mon Sep 17 00:00:00 2001
From: Justin Stephenson 
Date: Fri, 11 Jun 2021 11:04:59 -0400
Subject: [PATCH 3/4] TOOLS: Add sss_analyze utility

Add log parsing tool which can be used to track requests across
responder and backend logs.
---
 Makefile.am|   2 +-
 configure.ac   |   3 +
 contrib/sssd.spec.in   |   5 +
 src/conf_macros.m4 |  14 ++
 src/tools/analyzer/Makefile.am |  16 ++
 src/tools/analyzer/modules/__init__.py |   0
 src/tools/analyzer/modules/request.py  | 277 +
 src/tools/analyzer/source_files.py |  76 +++
 src/tools/analyzer/source_journald.py  |  47 +
 src/tools/analyzer/source_reader.py|  27 +++
 src/tools/analyzer/sss_analyze.py.in   |  24 +++
 11 files changed, 490 insertions(+), 1 deletion(-)
 create mode 100644 src/tools/analyzer/Makefile.am
 create mode 100644 src/tools/analyzer/modules/__init__.py
 create mode 100644 src/tools/analyzer/modules/request.py
 create mode 100644 src/tools/analyzer/source_files.py
 create mode 100644 src/tools/analyzer/source_journald.py
 create mode 100644 src/tools/analyzer/source_reader.py
 create mode 100755 src/tools/analyzer/sss_analyze.py.in

diff --git a/Makefile.am b/Makefile.am
index 6d84b082ec..c7c429965d 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -22,7 +22,7 @@ SUBDIRS += src/man
 endif
 
 SUBDIRS += . src/tests/cwrap src/tests/intg src/tests/test_CA \
- src/tests/test_ECC_CA
+ src/tests/test_ECC_CA src/tools/analyzer
 
 # Some old versions of automake don't define builddir
 builddir ?= .
diff --git a/configure.ac b/configure.ac
index c5c3a903b0..2b1f5fc828 100644
--- a/configure.ac
+++ b/configure.ac
@@ -152,6 +152,7 @@ WITH_WINBIND_PLUGIN_PATH
 WITH_SELINUX
 WITH_NSCD
 WITH_IPA_GETKEYTAB
+WITH_PYTHON_BIN
 WITH_SEMANAGE
 WITH_AD_GPO_DEFAULT
 WITH_GPO_CACHE_PATH
@@ -531,6 +532,8 @@ AC_CONFIG_FILES([Makefile contrib/sssd.spec src/examples/rwtab src/doxy.config
  src/lib/sifp/sss_simpleifp.doxy
  src/config/setup.py
  src/systemtap/sssd.stp
+ src/tools/analyzer/Makefile
+ 

[SSSD] [sssd PR#5817][closed] Tests: pam_sss_gss.so doesn't work with large kerberos tickets #5815

2021-10-06 Thread shridhargadekar
   URL: https://github.com/SSSD/sssd/pull/5817
Author: shridhargadekar
 Title: #5817: Tests: pam_sss_gss.so doesn't work with large kerberos tickets 
#5815
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5817/head:pr5817
git checkout pr5817
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5803][-Changes requested] CONF: removed unused 'sbus_timeout' option

2021-10-06 Thread ikerexxe
  URL: https://github.com/SSSD/sssd/pull/5803
Title: #5803: CONF: removed unused 'sbus_timeout' option

Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5803][+Accepted] CONF: removed unused 'sbus_timeout' option

2021-10-06 Thread ikerexxe
  URL: https://github.com/SSSD/sssd/pull/5803
Title: #5803: CONF: removed unused 'sbus_timeout' option

Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5803][comment] CONF: removed unused 'sbus_timeout' option

2021-10-06 Thread ikerexxe
  URL: https://github.com/SSSD/sssd/pull/5803
Title: #5803: CONF: removed unused 'sbus_timeout' option

ikerexxe commented:
"""
> But the options was NOT available. I mean, putting this option in sssd.conf 
> did NOT have any effect. This is merely removal of code that did nothing, so 
> I don't think it's worth a ticket and especially a RN.

In that case, everything looks good to me. Thanks for the patch!


"""

See the full comment at 
https://github.com/SSSD/sssd/pull/5803#issuecomment-936312056
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5712][comment] Health and Support Analyzer - Add request log parsing utility

2021-10-06 Thread justin-stephenson
  URL: https://github.com/SSSD/sssd/pull/5712
Title: #5712: Health and Support Analyzer - Add request log parsing utility

justin-stephenson commented:
"""
> Can't run:
> 
> ```
> [pbrezina /dev/shm/sssd]$ sudo sssctl analyze
> Traceback (most recent call last):
>   File "/usr/lib/python3.9/site-packages/sssd/sss_analyze.py", line 7, in 
> 
> from modules import request
>   File "/usr/lib/python3.9/site-packages/sssd/modules/request.py", line 78
> Return source lines which match any number of patterns
>^
> SyntaxError: invalid syntax
> Command '/usr/lib/python3.9/site-packages/sssd/sss_analyze.py' failed with [1]
> ```

Fixed now, sorry.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/5712#issuecomment-936299262
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5712][synchronized] Health and Support Analyzer - Add request log parsing utility

2021-10-06 Thread justin-stephenson
   URL: https://github.com/SSSD/sssd/pull/5712
Author: justin-stephenson
 Title: #5712: Health and Support Analyzer - Add request log parsing utility
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5712/head:pr5712
git checkout pr5712
From 225f91087af3d0abb8d0c91811a8c1e305874a66 Mon Sep 17 00:00:00 2001
From: Justin Stephenson 
Date: Wed, 4 Aug 2021 14:57:55 +
Subject: [PATCH 1/4] DP: Log offline warning for REQ_TRACE tracking

This allows the sssctl analyze parsing tool to report if the
backend was offline when the request came in to the data
provider.
---
 src/providers/data_provider/dp_request.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/src/providers/data_provider/dp_request.c b/src/providers/data_provider/dp_request.c
index 077b361f3c..3cbd55c1ec 100644
--- a/src/providers/data_provider/dp_request.c
+++ b/src/providers/data_provider/dp_request.c
@@ -133,6 +133,10 @@ static errno_t dp_attach_req(struct dp_req *dp_req,
 SSS_REQ_TRACE_CID_DP_REQ(SSSDBG_TRACE_FUNC, dp_req->name,
  "New request. [%s CID #%u] Flags [%#.4x].",
  sender_name, cli_id, dp_flags);
+if (be_is_offline(provider->be_ctx)) {
+DEBUG(SSSDBG_TRACE_FUNC, "[CID #%u] Backend is offline! " \
+ "Using cached data if available\n", cli_id);
+}
 } else {
 SSS_REQ_TRACE_CID_DP_REQ(SSSDBG_TRACE_FUNC, dp_req->name,
  "New request. Flags [%#.4x].",

From f67152712f30fef7abca494520ca32cacac03b55 Mon Sep 17 00:00:00 2001
From: Justin Stephenson 
Date: Fri, 1 Oct 2021 15:13:57 +
Subject: [PATCH 2/4] Responder: Log client uid that started a request

---
 src/responder/common/responder_common.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/responder/common/responder_common.c b/src/responder/common/responder_common.c
index 3207e26e6f..7e145aa9b2 100644
--- a/src/responder/common/responder_common.c
+++ b/src/responder/common/responder_common.c
@@ -640,9 +640,9 @@ static void accept_fd_handler(struct tevent_context *ev,
 
 rctx->client_id_num++;
 DEBUG(SSSDBG_TRACE_FUNC,
-  "Client [CID #%u][cmd %s][%p][%d] connected%s!\n",
-  rctx->client_id_num, cctx->cmd_line, cctx, cctx->cfd,
-  accept_ctx->is_private ? " to privileged pipe" : "");
+  "Client [CID #%u][cmd %s][uid %u][%p][%d] connected%s!\n",
+  rctx->client_id_num, cctx->cmd_line, cli_creds_get_uid(cctx->creds),
+  cctx, cctx->cfd, accept_ctx->is_private ? " to privileged pipe" : "");
 
 return;
 }

From b24921db7588ebe5372a3f5419845ea869aeb034 Mon Sep 17 00:00:00 2001
From: Justin Stephenson 
Date: Fri, 11 Jun 2021 11:04:59 -0400
Subject: [PATCH 3/4] TOOLS: Add sss_analyze utility

Add log parsing tool which can be used to track requests across
responder and backend logs.
---
 Makefile.am|   2 +-
 configure.ac   |   3 +
 contrib/sssd.spec.in   |   5 +
 src/conf_macros.m4 |  14 ++
 src/tools/analyzer/Makefile.am |  15 ++
 src/tools/analyzer/modules/__init__.py |   0
 src/tools/analyzer/modules/request.py  | 278 +
 src/tools/analyzer/source_files.py |  79 +++
 src/tools/analyzer/source_journald.py  |  51 +
 src/tools/analyzer/sss_analyze.py.in   |  24 +++
 10 files changed, 470 insertions(+), 1 deletion(-)
 create mode 100644 src/tools/analyzer/Makefile.am
 create mode 100644 src/tools/analyzer/modules/__init__.py
 create mode 100644 src/tools/analyzer/modules/request.py
 create mode 100644 src/tools/analyzer/source_files.py
 create mode 100644 src/tools/analyzer/source_journald.py
 create mode 100755 src/tools/analyzer/sss_analyze.py.in

diff --git a/Makefile.am b/Makefile.am
index 6d84b082ec..c7c429965d 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -22,7 +22,7 @@ SUBDIRS += src/man
 endif
 
 SUBDIRS += . src/tests/cwrap src/tests/intg src/tests/test_CA \
- src/tests/test_ECC_CA
+ src/tests/test_ECC_CA src/tools/analyzer
 
 # Some old versions of automake don't define builddir
 builddir ?= .
diff --git a/configure.ac b/configure.ac
index c5c3a903b0..2b1f5fc828 100644
--- a/configure.ac
+++ b/configure.ac
@@ -152,6 +152,7 @@ WITH_WINBIND_PLUGIN_PATH
 WITH_SELINUX
 WITH_NSCD
 WITH_IPA_GETKEYTAB
+WITH_PYTHON_BIN
 WITH_SEMANAGE
 WITH_AD_GPO_DEFAULT
 WITH_GPO_CACHE_PATH
@@ -531,6 +532,8 @@ AC_CONFIG_FILES([Makefile contrib/sssd.spec src/examples/rwtab src/doxy.config
  src/lib/sifp/sss_simpleifp.doxy
  src/config/setup.py
  src/systemtap/sssd.stp
+ src/tools/analyzer/Makefile
+ src/tools/analyzer/sss_analyze.py
  src/config/SSSDConfig/__init__.py])
 AC_CONFIG_FILES([sbus_generate.sh], [chmod +x 

[SSSD] [sssd PR#5816][+Accepted] debug: fix unused variable warnings

2021-10-06 Thread alexey-tikhonov
  URL: https://github.com/SSSD/sssd/pull/5816
Title: #5816: debug: fix unused variable warnings

Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5816][comment] debug: fix unused variable warnings

2021-10-06 Thread alexey-tikhonov
  URL: https://github.com/SSSD/sssd/pull/5816
Title: #5816: debug: fix unused variable warnings

alexey-tikhonov commented:
"""
Thank you, ACK.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/5816#issuecomment-936282402
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5803][comment] CONF: removed unused 'sbus_timeout' option

2021-10-06 Thread alexey-tikhonov
  URL: https://github.com/SSSD/sssd/pull/5803
Title: #5803: CONF: removed unused 'sbus_timeout' option

alexey-tikhonov commented:
"""
> The changes look good to me but I think that you should link an upstream 
> ticket both in the commit message and in the PR description.
> 
> Moreover, I wonder if we should notify in the next release that the option is 
> no longer available.

But the options was NOT available. I mean, putting this option in sssd.conf did 
NOT have any effect.
This is merely removal of code that did nothing, so I don't think it's worth a 
ticket and especially a RN.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/5803#issuecomment-936275819
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5784][-Changes requested] proxy: allow removing group members

2021-10-06 Thread ikerexxe
  URL: https://github.com/SSSD/sssd/pull/5784
Title: #5784: proxy: allow removing group members

Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5784][+Waiting for review] proxy: allow removing group members

2021-10-06 Thread ikerexxe
  URL: https://github.com/SSSD/sssd/pull/5784
Title: #5784: proxy: allow removing group members

Label: +Waiting for review
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5784][comment] proxy: allow removing group members

2021-10-06 Thread ikerexxe
  URL: https://github.com/SSSD/sssd/pull/5784
Title: #5784: proxy: allow removing group members

ikerexxe commented:
"""
> Wouldn't it make sense to instead lookup GID of SYSDB_MEMBEROF DN and compare 
> GIDs (numerical values)?

Yes, so I've updated the PR accordingly. Nowadays, a list of GIDs is composed 
from the cache and this is compared with the actual GIDs list. This should 
optimize the execution flow compared with the previous proposed patch.

"""

See the full comment at 
https://github.com/SSSD/sssd/pull/5784#issuecomment-936256484
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5784][synchronized] proxy: allow removing group members

2021-10-06 Thread ikerexxe
   URL: https://github.com/SSSD/sssd/pull/5784
Author: ikerexxe
 Title: #5784: proxy: allow removing group members
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5784/head:pr5784
git checkout pr5784
From 9f2cf6abddc352ca894e63c6ebe66687d3dd6abb Mon Sep 17 00:00:00 2001
From: Iker Pedrosa 
Date: Tue, 14 Sep 2021 12:35:09 +0200
Subject: [PATCH] proxy: allow removing group members

The proxy provider doesn't allow to remove group members once they have
been added. This patch allows to do it by looping the member list from
the cache and comparing it with the actual membership list. If a member
is missing then it's removed from the cache.

Resolves: https://github.com/SSSD/sssd/issues/5783

Signed-off-by: Iker Pedrosa 
---
 src/providers/proxy/proxy_id.c | 166 -
 1 file changed, 164 insertions(+), 2 deletions(-)

diff --git a/src/providers/proxy/proxy_id.c b/src/providers/proxy/proxy_id.c
index 25daea585d..f7cfe5cf65 100644
--- a/src/providers/proxy/proxy_id.c
+++ b/src/providers/proxy/proxy_id.c
@@ -915,7 +915,9 @@ handle_getgr_result(enum nss_status status, struct group *grp,
 
 case NSS_STATUS_NOTFOUND:
 DEBUG(SSSDBG_MINOR_FAILURE, "Group not found.\n");
-*delete_group = true;
+if (delete_group) {
+*delete_group = true;
+}
 break;
 
 case NSS_STATUS_SUCCESS:
@@ -927,7 +929,9 @@ handle_getgr_result(enum nss_status status, struct group *grp,
 if (OUT_OF_ID_RANGE(grp->gr_gid, dom->id_min, dom->id_max)) {
 DEBUG(SSSDBG_MINOR_FAILURE,
   "Group filtered out! (id out of range)\n");
-*delete_group = true;
+if (delete_group) {
+*delete_group = true;
+}
 break;
 }
 break;
@@ -1488,6 +1492,153 @@ static int get_initgr(TALLOC_CTX *mem_ctx,
 return ret;
 }
 
+static int remove_group_members(struct proxy_id_ctx *ctx,
+struct sss_domain_info *dom,
+const struct passwd *pwd,
+long int num_gids,
+const gid_t *gids,
+long int num_cached_gids,
+const gid_t *cached_gids)
+{
+TALLOC_CTX *tmp_ctx = NULL;
+int i = 0, j = 0;
+int ret = EOK;
+size_t buflen = 0;
+char *buffer = NULL;
+char *groupname = NULL;
+const char *username = NULL;
+enum nss_status status;
+struct group *grp = NULL;
+bool group_found = false;
+
+tmp_ctx = talloc_new(NULL);
+if (!tmp_ctx) {
+ret = ENOMEM;
+DEBUG(SSSDBG_CRIT_FAILURE, "talloc_new() failed\n");
+goto done;
+}
+
+username = sss_create_internal_fqname(tmp_ctx, pwd->pw_name, dom->name);
+if (username == NULL) {
+DEBUG(SSSDBG_OP_FAILURE, "Failed to create fqdn '%s'\n", pwd->pw_name);
+ret = ENOMEM;
+goto done;
+}
+
+grp = talloc(tmp_ctx, struct group);
+if (!grp) {
+ret = ENOMEM;
+DEBUG(SSSDBG_CRIT_FAILURE, "talloc() failed\n");
+goto done;
+}
+
+for (i = 0; i < num_cached_gids; i++) {
+group_found = false;
+// group 0 is the primary group so it can be skipped
+for (j = 1; j < num_gids; j++) {
+if (cached_gids[i] == gids[j]) {
+group_found = true;
+break;
+}
+}
+
+if (!group_found) {
+do {
+/* always zero out the grp structure */
+memset(grp, 0, sizeof(struct group));
+buffer = grow_group_buffer(tmp_ctx, , );
+if (!buffer) {
+ret = ENOMEM;
+break;
+}
+
+status = ctx->ops.getgrgid_r(cached_gids[i], grp, buffer, buflen, );
+
+ret = handle_getgr_result(status, grp, dom, NULL);
+} while (ret == EAGAIN);
+
+if (ret != EOK) {
+DEBUG(SSSDBG_OP_FAILURE,
+  "getgrgid failed [%d]: %s\n", ret, strerror(ret));
+continue;
+}
+
+groupname = sss_create_internal_fqname(tmp_ctx, grp->gr_name, dom->name);
+if (groupname == NULL) {
+DEBUG(SSSDBG_OP_FAILURE, "Failed to create fqdn '%s'\n",
+  grp->gr_name);
+ret = ENOMEM;
+continue;
+}
+
+ret = sysdb_remove_group_member(dom, groupname,
+username,
+SYSDB_MEMBER_USER, false);
+
+if (ret != EOK) {
+DEBUG(SSSDBG_CRIT_FAILURE,
+  "Could not remove member [%s] from group [%s]\n",
+  username, groupname);
+continue;
+}

[SSSD] [sssd PR#5803][+Changes requested] CONF: removed unused 'sbus_timeout' option

2021-10-06 Thread ikerexxe
  URL: https://github.com/SSSD/sssd/pull/5803
Title: #5803: CONF: removed unused 'sbus_timeout' option

Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5803][-Waiting for review] CONF: removed unused 'sbus_timeout' option

2021-10-06 Thread ikerexxe
  URL: https://github.com/SSSD/sssd/pull/5803
Title: #5803: CONF: removed unused 'sbus_timeout' option

Label: -Waiting for review
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5803][comment] CONF: removed unused 'sbus_timeout' option

2021-10-06 Thread ikerexxe
  URL: https://github.com/SSSD/sssd/pull/5803
Title: #5803: CONF: removed unused 'sbus_timeout' option

ikerexxe commented:
"""
The changes look good to me but I think that you should link an upstream ticket 
both in the commit message and in the PR description.

Moreover, I wonder if we should notify in the next release that the option is 
no longer available.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/5803#issuecomment-936240331
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5712][comment] Health and Support Analyzer - Add request log parsing utility

2021-10-06 Thread pbrezina
  URL: https://github.com/SSSD/sssd/pull/5712
Title: #5712: Health and Support Analyzer - Add request log parsing utility

pbrezina commented:
"""
Can't run:

```
[pbrezina /dev/shm/sssd]$ sudo sssctl analyze
Traceback (most recent call last):
  File "/usr/lib/python3.9/site-packages/sssd/sss_analyze.py", line 7, in 

from modules import request
  File "/usr/lib/python3.9/site-packages/sssd/modules/request.py", line 78
Return source lines which match any number of patterns
   ^
SyntaxError: invalid syntax
Command '/usr/lib/python3.9/site-packages/sssd/sss_analyze.py' failed with [1]

```
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/5712#issuecomment-936227327
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5817][+Tests] Tests: pam_sss_gss.so doesn't work with large kerberos tickets #5815

2021-10-06 Thread shridhargadekar
  URL: https://github.com/SSSD/sssd/pull/5817
Title: #5817: Tests: pam_sss_gss.so doesn't work with large kerberos tickets 
#5815

Label: +Tests
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5817][opened] Tests: pam_sss_gss.so doesn't work with large kerberos tickets #5815

2021-10-06 Thread shridhargadekar
   URL: https://github.com/SSSD/sssd/pull/5817
Author: shridhargadekar
 Title: #5817: Tests: pam_sss_gss.so doesn't work with large kerberos tickets 
#5815
Action: opened

PR body:
"""
Verifies: #5568
Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1948657
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5817/head:pr5817
git checkout pr5817
From 119794f2ef5492dcaa82c3ecd004416c0ee26b04 Mon Sep 17 00:00:00 2001
From: Shridhar Gadekar 
Date: Wed, 6 Oct 2021 18:49:05 +0530
Subject: [PATCH] Tests: pam_sss_gss.so doesn't work with large kerberos
 tickets #5815

Verifies: #5568
Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1948657
---
 src/tests/multihost/ipa/test_adtrust.py | 76 +
 1 file changed, 76 insertions(+)

diff --git a/src/tests/multihost/ipa/test_adtrust.py b/src/tests/multihost/ipa/test_adtrust.py
index b3dae24700..d5f039b0f6 100644
--- a/src/tests/multihost/ipa/test_adtrust.py
+++ b/src/tests/multihost/ipa/test_adtrust.py
@@ -292,3 +292,79 @@ def test_nss_get_by_name_with_private_group(self, multihost):
 assert cmd_adm.returncode == 0, 'Something wrong with setup!'
 assert cmd_usr.returncode == 0, \
 f"pysss_nss_idmap.getsidbyname for {username} failed"
+
+def test_sudo_kerberos_ticket(self, multihost, create_aduser_group):
+"""
+:title: Verify pam_sss_gss.so can handle large kerberos ticket
+for sudo
+:id: 456ea53b-6702-4b8e-beb1-eee841b85fed
+:bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1948657
+:steps:
+ 1. Add sudo rule in IPA-server for AD-users
+ 2. Modify /etc/krb5.conf.d/kcm_default_ccache to specify location
+of storing a TGT
+ 3. Enable pam_sss_gss.so for auth in /etc/pam.d/{sudo,sudo-i} files
+ 4. Add a sudo rule for AD-user
+ 5. Log in on ipa-client as AD-user
+ 6. Run kinit and fetch tgt
+ 7. Run sudo command
+ 8. Remove sudo cache
+ 9. Run sudo command again
+ :expectedresults:
+ 1. Should succeed
+ 2. Should succeed
+ 3. Should succeed
+ 4. Should succeed
+ 5. Should succeed
+ 6. Should succeed
+ 7. Should not ask password, and should succeed
+ 8. Should succeed
+ 9. Should not ask password, and should succeed
+"""
+(aduser, adgroup) = create_aduser_group
+client = sssdTools(multihost.client[0], multihost.ad[0])
+ipaserver = sssdTools(multihost.master[0])
+cmd = 'dnf install -y sssd sssd-kcm'
+multihost.client[0].run_command(cmd, raiseonerr=False)
+domain_name = ipaserver.get_domain_section_name()
+domain_section = 'domain/{}'.format(domain_name)
+params = {'pam_gssapi_services': 'sudo, sudo-i'}
+client.sssd_conf(domain_section, params)
+krbkcm = '/etc/krb5.conf.d/kcm_default_ccache'
+bk_krbkcm = '/tmp/kcm_default_ccache'
+src = 'KCM:'
+dest = 'FILE:/tmp/krb5cc_%{uid}'
+multihost.client[0].run_command(f'cp {krbkcm} {bk_krbkcm}')
+cmd = "echo -e  '[libdefaults]\n' \
+  'default_ccache_name  = FILE:/tmp/krb5cc_%{uid}:'"
+multihost.client[0].run_command(cmd, raiseonerr=False)
+multihost.client[0].service_sssd('restart')
+pam_sss_gss = "auth   sufficient   pam_sss_gss.so debug"
+for pam_file in "/etc/pam.d/sudo-i", "/etc/pam.d/sudo":
+cmd = f'sed -i "1 i\{pam_sss_gss}" {pam_file}'
+multihost.client[0].run_command(cmd, raiseonerr=False)
+cmd = f'echo "{aduser} ALL=(ALL) ALL" >> /etc/sudoers'
+multihost.client[0].run_command(cmd, raiseonerr=False)
+try:
+ssh = SSHClient(multihost.client[0].sys_hostname,
+username=aduser, password='Secret123')
+
+except paramiko.ssh_exception.AuthenticationException:
+pytest.fail(f'{aduser} failed to login')
+else:
+(_, _, exit_status) = ssh.execute_cmd(f'kinit {aduser}',
+  stdin='Secret123')
+assert exit_status == 0
+(stdout, _, exit_status) = ssh.execute_cmd('sudo id')
+assert 'uid=0(root)' in stdout.readlines()
+(stdout, _, exit_status) = ssh.execute_cmd('sudo -k')
+(stdout, _, exit_status) = ssh.execute_cmd('sudo -l')
+assert '(ALL) ALL' in stdout.readlines()
+client.sssd_conf(domain_section, params, action='delete')
+for pam_file in "/etc/pam.d/sudo-i", "/etc/pam.d/sudo":
+cmd = f'sed -i "1d" {pam_file}'
+multihost.client[0].run_command(cmd, raiseonerr=False)
+cmd = f'sed -i "$ d" /etc/sudoers'
+multihost.client[0].run_command(cmd, raiseonerr=False)
+cmd = f'mv {bk_krbkcm} {krbkcm}'
+

[SSSD] [sssd PR#5815][closed] Tests: pam_sss_gss.so doesn't work with large kerberos tickets

2021-10-06 Thread shridhargadekar
   URL: https://github.com/SSSD/sssd/pull/5815
Author: shridhargadekar
 Title: #5815: Tests: pam_sss_gss.so doesn't work with large kerberos tickets
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5815/head:pr5815
git checkout pr5815
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5816][opened] debug: fix unused variable warnings

2021-10-06 Thread pbrezina
   URL: https://github.com/SSSD/sssd/pull/5816
Author: pbrezina
 Title: #5816: debug: fix unused variable warnings
Action: opened

PR body:
"""
```
/home/pbrezina/workspace/sssd/src/util/debug.c: In function ‘sss_vdebug_fn’:
/home/pbrezina/workspace/sssd/src/util/debug.c:274:11: error: unused variable 
‘result_fmt’ [-Werror=unused-variable]
  274 | char *result_fmt;
  |   ^~
/home/pbrezina/workspace/sssd/src/util/debug.c:273:11: error: unused variable 
‘chain_id_fmt_dyn’ [-Werror=unused-variable]
  273 | char *chain_id_fmt_dyn = NULL;
  |   ^~~~
/home/pbrezina/workspace/sssd/src/util/debug.c:272:10: error: unused variable 
‘chain_id_fmt_fixed’ [-Werror=unused-variable]
  272 | char chain_id_fmt_fixed[256];

```

Introduced in: 3d8dd1282ffb7d0188e36d0109340ce622745717
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5816/head:pr5816
git checkout pr5816
From 2a6ff85c70de902807ed821f9eb32ae50160db19 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pavel=20B=C5=99ezina?= 
Date: Wed, 6 Oct 2021 15:16:12 +0200
Subject: [PATCH] debug: fix unused variable warnings
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

```
/home/pbrezina/workspace/sssd/src/util/debug.c: In function ‘sss_vdebug_fn’:
/home/pbrezina/workspace/sssd/src/util/debug.c:274:11: error: unused variable ‘result_fmt’ [-Werror=unused-variable]
  274 | char *result_fmt;
  |   ^~
/home/pbrezina/workspace/sssd/src/util/debug.c:273:11: error: unused variable ‘chain_id_fmt_dyn’ [-Werror=unused-variable]
  273 | char *chain_id_fmt_dyn = NULL;
  |   ^~~~
/home/pbrezina/workspace/sssd/src/util/debug.c:272:10: error: unused variable ‘chain_id_fmt_fixed’ [-Werror=unused-variable]
  272 | char chain_id_fmt_fixed[256];

```

Introduced in: 3d8dd1282ffb7d0188e36d0109340ce622745717
---
 src/util/debug.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/util/debug.c b/src/util/debug.c
index 989589a707..51fb42d3cf 100644
--- a/src/util/debug.c
+++ b/src/util/debug.c
@@ -269,9 +269,6 @@ void sss_vdebug_fn(const char *file,
const char *format,
va_list ap)
 {
-char chain_id_fmt_fixed[256];
-char *chain_id_fmt_dyn = NULL;
-char *result_fmt;
 static time_t last_time;
 static char last_time_str[128];
 struct timeval tv;
@@ -279,6 +276,9 @@ void sss_vdebug_fn(const char *file,
 time_t t;
 
 #ifdef WITH_JOURNALD
+char chain_id_fmt_fixed[256];
+char *chain_id_fmt_dyn = NULL;
+char *result_fmt;
 errno_t ret;
 va_list ap_fallback;
 
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5815][opened] Tests: pam_sss_gss.so doesn't work with large kerberos tickets

2021-10-06 Thread shridhargadekar
   URL: https://github.com/SSSD/sssd/pull/5815
Author: shridhargadekar
 Title: #5815: Tests: pam_sss_gss.so doesn't work with large kerberos tickets
Action: opened

PR body:
"""
Verifies: #5568
Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1948657
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5815/head:pr5815
git checkout pr5815
From 51cd0a66a207603d70e5d754d4c1e80a62894bb3 Mon Sep 17 00:00:00 2001
From: Shridhar Gadekar 
Date: Wed, 6 Oct 2021 18:42:03 +0530
Subject: [PATCH] Tests: pam_sss_gss.so doesn't work with large kerberos
 tickets

Verifies: #5568
Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1948657
---
 src/tests/multihost/ipa/test_adtrust.py | 78 +
 1 file changed, 78 insertions(+)

diff --git a/src/tests/multihost/ipa/test_adtrust.py b/src/tests/multihost/ipa/test_adtrust.py
index 061199b466..2ca5e0fae4 100644
--- a/src/tests/multihost/ipa/test_adtrust.py
+++ b/src/tests/multihost/ipa/test_adtrust.py
@@ -104,3 +104,81 @@ def test_honour_idoverride(self, multihost, create_aduser_group):
 multihost.master[0].run_command(delete_id_view)
 ipa_client.clear_sssd_cache()
 assert count == 0
+
+
+def test_sudo_kerberos_ticket(self, multihost, create_aduser_group):
+"""
+:title: Verify pam_sss_gss.so can handle large kerberos ticket
+for sudo
+:id: 456ea53b-6702-4b8e-beb1-eee841b85fed
+:bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1948657
+:steps:
+ 1. Add sudo rule in IPA-server for AD-users
+ 2. Modify /etc/krb5.conf.d/kcm_default_ccache to specify location
+of storing a TGT
+ 3. Enable pam_sss_gss.so for auth in /etc/pam.d/{sudo,sudo-i} files
+ 4. Add a sudo rule for AD-user
+ 5. Log in on ipa-client as AD-user
+ 6. Run kinit and fetch tgt
+ 7. Run sudo command
+ 8. Remove sudo cache
+ 9. Run sudo command again
+ :expectedresults:
+ 1. Should succeed
+ 2. Should succeed
+ 3. Should succeed
+ 4. Should succeed
+ 5. Should succeed
+ 6. Should succeed
+ 7. Should not ask password, and should succeed
+ 8. Should succeed
+ 9. Should not ask password, and should succeed
+
+"""
+(aduser, adgroup) = create_aduser_group
+client = sssdTools(multihost.client[0], multihost.ad[0])
+ipaserver = sssdTools(multihost.master[0])
+cmd = 'dnf install -y sssd sssd-kcm'
+multihost.client[0].run_command(cmd, raiseonerr=False)
+domain_name = ipaserver.get_domain_section_name()
+domain_section = 'domain/{}'.format(domain_name)
+params = {'pam_gssapi_services': 'sudo, sudo-i'}
+client.sssd_conf(domain_section, params)
+krbkcm = '/etc/krb5.conf.d/kcm_default_ccache'
+bk_krbkcm = '/tmp/kcm_default_ccache'
+src = 'KCM:'
+dest = 'FILE:/tmp/krb5cc_%{uid}'
+multihost.client[0].run_command(f'cp {krbkcm} {bk_krbkcm}')
+cmd = "echo -e  '[libdefaults]\n' \
+  'default_ccache_name  = FILE:/tmp/krb5cc_%{uid}:'"
+multihost.client[0].run_command(cmd, raiseonerr=False)
+multihost.client[0].service_sssd('restart')
+pam_sss_gss = "auth   sufficient   pam_sss_gss.so debug"
+for pam_file in "/etc/pam.d/sudo-i", "/etc/pam.d/sudo":
+cmd = f'sed -i "1 i\{pam_sss_gss}" {pam_file}'
+multihost.client[0].run_command(cmd, raiseonerr=False)
+cmd = f'echo "{aduser} ALL=(ALL) ALL" >> /etc/sudoers'
+multihost.client[0].run_command(cmd, raiseonerr=False)
+try:
+ssh = SSHClient(multihost.client[0].sys_hostname,
+username=aduser, password='Secret123')
+
+except paramiko.ssh_exception.AuthenticationException:
+pytest.fail(f'{aduser} failed to login')
+else:
+(_, _, exit_status) = ssh.execute_cmd(f'kinit {aduser}',
+  stdin='Secret123')
+assert exit_status == 0
+(stdout, _, exit_status) = ssh.execute_cmd('sudo id')
+assert 'uid=0(root)' in stdout.readlines()
+(stdout, _, exit_status) = ssh.execute_cmd('sudo -k')
+(stdout, _, exit_status) = ssh.execute_cmd('sudo -l')
+assert '(ALL) ALL' in stdout.readlines()
+client.sssd_conf(domain_section, params, action='delete')
+for pam_file in "/etc/pam.d/sudo-i", "/etc/pam.d/sudo":
+cmd = f'sed -i "1d" {pam_file}'
+multihost.client[0].run_command(cmd, raiseonerr=False)
+cmd = f'sed -i "$ d" /etc/sudoers'
+multihost.client[0].run_command(cmd, raiseonerr=False)
+cmd = f'mv {bk_krbkcm} {krbkcm}'
+multihost.client[0].run_command(cmd, raiseonerr=False)

[SSSD][sssd PR#5814][synchronized] Tests: sss_override does not take precedence over override_homedir di…

2021-10-06 Thread aborah-sudo
   URL: https://github.com/SSSD/sssd/pull/5814
Author: aborah-sudo
 Title: #5814: Tests: sss_override does not take precedence over 
override_homedir di…
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5814/head:pr5814
git checkout pr5814
From bf9845e06655215aac011506e57db11bdd8a2c56 Mon Sep 17 00:00:00 2001
From: Anuj Borah 
Date: Wed, 6 Oct 2021 17:59:51 +0530
Subject: [PATCH] Tests: sss_override does not take precedence over
 override_homedir directive

bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1919942
---
 .../alltests/test_ldap_extra_attrs.py | 26 +++
 1 file changed, 26 insertions(+)

diff --git a/src/tests/multihost/alltests/test_ldap_extra_attrs.py b/src/tests/multihost/alltests/test_ldap_extra_attrs.py
index a493fb558b..793eacd43f 100644
--- a/src/tests/multihost/alltests/test_ldap_extra_attrs.py
+++ b/src/tests/multihost/alltests/test_ldap_extra_attrs.py
@@ -193,3 +193,29 @@ def test_0006_bz1667252(self, multihost):
 cmd = multihost.client[0].run_command(sssctl_cmd)
 ret = multihost.client[0].service_sssd('status')
 assert ret == 0
+
+@pytest.mark.tier1
+def test_0007_bz1919942(self, multihost,
+backupsssdconf):
+"""
+:title: ifp: sss_override does not take
+ precedence over override_homedir directive
+:id: d2e98c70-26a0-11ec-bcf5-845cf3eff344
+:bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1919942
+"""
+tools = sssdTools(multihost.client[0])
+domain_name = tools.get_domain_section_name()
+client = sssdTools(multihost.client[0])
+domain_params = {'override_homedir': '/home/%u1'}
+client.sssd_conf(f'domain/{domain_name}', domain_params)
+multihost.client[0].service_sssd('restart')
+before = multihost.client[0].run_command("getent passwd "
+ "foo5@example1")
+assert before.returncode == 0
+multihost.client[0].run_command("sss_override "
+"user-add foo5@example1 -h "
+"/home/foo56")
+multihost.client[0].service_sssd('restart')
+after = multihost.client[0].run_command("getent passwd "
+"foo5@example1")
+assert "User:/home/foo56" in after.stdout_text
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD][sssd PR#5814][synchronized] Tests: sss_override does not take precedence over override_homedir di…

2021-10-06 Thread aborah-sudo
   URL: https://github.com/SSSD/sssd/pull/5814
Author: aborah-sudo
 Title: #5814: Tests: sss_override does not take precedence over 
override_homedir di…
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5814/head:pr5814
git checkout pr5814
From e9332914166567d2340c8eae8f3516f1ebc3e00c Mon Sep 17 00:00:00 2001
From: Anuj Borah 
Date: Wed, 6 Oct 2021 17:59:51 +0530
Subject: [PATCH] Tests: sss_override does not take precedence over
 override_homedir directive

bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1919942
---
 .../alltests/test_ldap_extra_attrs.py | 26 +++
 1 file changed, 26 insertions(+)

diff --git a/src/tests/multihost/alltests/test_ldap_extra_attrs.py b/src/tests/multihost/alltests/test_ldap_extra_attrs.py
index a493fb558b..adda62bf70 100644
--- a/src/tests/multihost/alltests/test_ldap_extra_attrs.py
+++ b/src/tests/multihost/alltests/test_ldap_extra_attrs.py
@@ -193,3 +193,29 @@ def test_0006_bz1667252(self, multihost):
 cmd = multihost.client[0].run_command(sssctl_cmd)
 ret = multihost.client[0].service_sssd('status')
 assert ret == 0
+
+@pytest.mark.tier1
+def test_0007_bz1416150(self, multihost,
+backupsssdconf):
+"""
+:title: ifp: sss_override does not take
+ precedence over override_homedir directive
+:id: d2e98c70-26a0-11ec-bcf5-845cf3eff344
+:bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1919942
+"""
+tools = sssdTools(multihost.client[0])
+domain_name = tools.get_domain_section_name()
+client = sssdTools(multihost.client[0])
+domain_params = {'override_homedir': '/home/%u1'}
+client.sssd_conf(f'domain/{domain_name}', domain_params)
+multihost.client[0].service_sssd('restart')
+before = multihost.client[0].run_command("getent passwd "
+ "foo5@example1")
+assert before.returncode == 0
+multihost.client[0].run_command("sss_override "
+"user-add foo5@example1 -h "
+"/home/foo56")
+multihost.client[0].service_sssd('restart')
+after = multihost.client[0].run_command("getent passwd "
+"foo5@example1")
+assert "User:/home/foo56" in after.stdout_text
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD][sssd PR#5814][+Tests] Tests: sss_override does not take precedence over override_homedir di…

2021-10-06 Thread aborah-sudo
  URL: https://github.com/SSSD/sssd/pull/5814
Title: #5814: Tests: sss_override does not take precedence over 
override_homedir di…

Label: +Tests
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD][sssd PR#5814][opened] Tests: sss_override does not take precedence over override_homedir di…

2021-10-06 Thread aborah-sudo
   URL: https://github.com/SSSD/sssd/pull/5814
Author: aborah-sudo
 Title: #5814: Tests: sss_override does not take precedence over 
override_homedir di…
Action: opened

PR body:
"""
…rective

bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1919942
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5814/head:pr5814
git checkout pr5814
From b0e4e4c220f3352289fb471f1a942740721f20e2 Mon Sep 17 00:00:00 2001
From: Anuj Borah 
Date: Wed, 6 Oct 2021 17:59:51 +0530
Subject: [PATCH] Tests: sss_override does not take precedence over
 override_homedir directive

bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1919942
---
 .../alltests/test_ldap_extra_attrs.py | 26 +++
 1 file changed, 26 insertions(+)

diff --git a/src/tests/multihost/alltests/test_ldap_extra_attrs.py b/src/tests/multihost/alltests/test_ldap_extra_attrs.py
index a493fb558b..30499df879 100644
--- a/src/tests/multihost/alltests/test_ldap_extra_attrs.py
+++ b/src/tests/multihost/alltests/test_ldap_extra_attrs.py
@@ -193,3 +193,29 @@ def test_0006_bz1667252(self, multihost):
 cmd = multihost.client[0].run_command(sssctl_cmd)
 ret = multihost.client[0].service_sssd('status')
 assert ret == 0
+
+@pytest.mark.tier1
+def test_0001_bz1416150(self, multihost,
+backupsssdconf):
+"""
+:title: ifp: sss_override does not take
+ precedence over override_homedir directive
+:id: d2e98c70-26a0-11ec-bcf5-845cf3eff344
+:bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1919942
+"""
+tools = sssdTools(multihost.client[0])
+domain_name = tools.get_domain_section_name()
+client = sssdTools(multihost.client[0])
+domain_params = {'override_homedir': '/home/%u1'}
+client.sssd_conf(f'domain/{domain_name}', domain_params)
+multihost.client[0].service_sssd('restart')
+before = multihost.client[0].run_command("getent passwd "
+ "foo5@example1")
+assert before.returncode == 0
+multihost.client[0].run_command("sss_override "
+"user-add foo5@example1 -h "
+"/home/foo56")
+multihost.client[0].service_sssd('restart')
+after = multihost.client[0].run_command("getent passwd "
+"foo5@example1")
+assert "User:/home/foo56" in after.stdout_text
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5813][+Tests] Tests: files provider automation

2021-10-06 Thread shridhargadekar
  URL: https://github.com/SSSD/sssd/pull/5813
Title: #5813: Tests: files provider automation

Label: +Tests
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5813][synchronized] Tests: files provider automation

2021-10-06 Thread shridhargadekar
   URL: https://github.com/SSSD/sssd/pull/5813
Author: shridhargadekar
 Title: #5813: Tests: files provider automation
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5813/head:pr5813
git checkout pr5813
From ce347a00257e2f670d97a24e7904be612dad69ac Mon Sep 17 00:00:00 2001
From: Shridhar Gadekar 
Date: Wed, 6 Oct 2021 17:52:07 +0530
Subject: [PATCH] Tests: files provider automation

verifies: #4295
---
 src/tests/multihost/alltests/conftest.py   |  44 +++
 src/tests/multihost/alltests/test_files.py | 379 +
 2 files changed, 423 insertions(+)
 create mode 100644 src/tests/multihost/alltests/test_files.py

diff --git a/src/tests/multihost/alltests/conftest.py b/src/tests/multihost/alltests/conftest.py
index 3996459632..be29bb49be 100644
--- a/src/tests/multihost/alltests/conftest.py
+++ b/src/tests/multihost/alltests/conftest.py
@@ -371,6 +371,28 @@ def remove_keys():
 request.addfinalizer(remove_keys)
 
 
+@pytest.fixture(scope="function")
+def local_useradd(session_multihost, request):
+tool = sssdTools(session_multihost.client[0])
+users = ['test1', 'user1']
+groups = ['localgrp', 'l_grp1', 'l_grp2', 'l_grp3']
+for user in users:
+cmd = f'useradd {user}'
+session_multihost.client[0].run_command(cmd)
+for grp in groups:
+cmd = f'groupadd {grp}'
+session_multihost.client[0].run_command(cmd)
+
+def remove_local_users():
+for user in users:
+cmd = f'userdel -rf {user}'
+session_multihost.client[0].run_command(cmd)
+for grp in groups:
+cmd = f'groupdel {grp}'
+session_multihost.client[0].run_command(cmd)
+request.addfinalizer(remove_local_users)
+
+
 @pytest.fixture(scope='function')
 def enable_multiple_responders(session_multihost, request):
 """ Enable multiple responders to sssd services """
@@ -798,6 +820,28 @@ def removesssd():
 request.addfinalizer(removesssd)
 
 
+@pytest.fixture(scope='class')
+def setup_sssd_files(session_multihost, request):
+""" Configure sssd.conf """
+tools = sssdTools(session_multihost.client[0])
+sssd_params = {'domains': 'files'}
+tools.sssd_conf('sssd', sssd_params)
+domain_section = 'domain/%s' % 'files'
+domain_params = { 'id_provider': 'files',
+ 'debug_level': '9'}
+tools.sssd_conf(domain_section, domain_params)
+start_sssd = 'systemctl start sssd'
+session_multihost.client[0].run_command(start_sssd)
+
+def removesssd():
+""" Remove sssd configuration """
+stop_sssd = 'systemctl stop sssd'
+session_multihost.client[0].run_command(stop_sssd)
+removeconf = 'rm -f %s' % (SSSD_DEFAULT_CONF)
+session_multihost.client[0].run_command(removeconf)
+request.addfinalizer(removesssd)
+
+
 @pytest.fixture(scope="class")
 def multihost(session_multihost, request):
 """ Multihost fixture to be used by tests
diff --git a/src/tests/multihost/alltests/test_files.py b/src/tests/multihost/alltests/test_files.py
new file mode 100644
index 00..20ece93805
--- /dev/null
+++ b/src/tests/multihost/alltests/test_files.py
@@ -0,0 +1,379 @@
+from __future__ import print_function
+import pdb
+import re
+import subprocess
+import time
+from sssd.testlib.common.utils import sssdTools
+
+
+def getent_sss(multihost, obj, db):
+gtnt = f'getent {db} -s sss {obj}'
+cmd = multihost.client[0].run_command(gtnt, raiseonerr=False)
+return cmd.returncode, cmd.stdout_text
+
+
+def run_cmd(multihost, arg):
+cmd = multihost.client[0].run_command(arg, raiseonerr=False)
+return cmd.returncode, cmd.stdout_text
+
+
+@pytest.mark.usefixtures("setup_sssd_files")
+@pytest.mark.filesprovider
+@pytest.mark.tier1_2
+class TestFilesProvider(object):
+" This is a test case class for files-provider"
+def test_001_local_usr_caching(self, multihost, local_useradd):
+"""
+:Title: local user caching with files-provider
+:id: fa12373b-8285-4fca-afe1-5e544fd58674
+:customerscenario: false
+:steps:
+1. Create an unprivileged user
+2. User details are returned from sss_cache
+:expectedresults:
+1. Should succeed
+2. Should succeed
+"""
+multihost.client[0].service_sssd('start')
+exit_status, ot = getent_sss(multihost, 'test1', "passwd")
+assert exit_status == 0
+
+def test_002_root_usr_caching(self, multihost, backupsssdconf):
+"""
+:Title: root user caching with files-provider
+:id: 0fea4269-de00-4e34-95c5-ab106957769d
+:customerscenario: false
+:steps:
+1. SSSD should not cache root user
+:expectedresults:
+1. Should succeed
+"""
+multihost.client[0].service_sssd('start')
+exit_status, _ = getent_sss(multihost, 'root', "passwd")
+

[SSSD] [sssd PR#5813][opened] Tests: files provider automation

2021-10-06 Thread shridhargadekar
   URL: https://github.com/SSSD/sssd/pull/5813
Author: shridhargadekar
 Title: #5813: Tests: files provider automation
Action: opened

PR body:
"""
verifies: #4295
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5813/head:pr5813
git checkout pr5813
From ed4a94db16b8ceb573784da4ea54411899dfb3be Mon Sep 17 00:00:00 2001
From: Shridhar Gadekar 
Date: Wed, 6 Oct 2021 17:52:07 +0530
Subject: [PATCH] Tests: files provider automation

verifies: #4295
---
 src/tests/multihost/alltests/conftest.py   |  44 +++
 src/tests/multihost/alltests/test_files.py | 382 +
 2 files changed, 426 insertions(+)
 create mode 100644 src/tests/multihost/alltests/test_files.py

diff --git a/src/tests/multihost/alltests/conftest.py b/src/tests/multihost/alltests/conftest.py
index 3996459632..be29bb49be 100644
--- a/src/tests/multihost/alltests/conftest.py
+++ b/src/tests/multihost/alltests/conftest.py
@@ -371,6 +371,28 @@ def remove_keys():
 request.addfinalizer(remove_keys)
 
 
+@pytest.fixture(scope="function")
+def local_useradd(session_multihost, request):
+tool = sssdTools(session_multihost.client[0])
+users = ['test1', 'user1']
+groups = ['localgrp', 'l_grp1', 'l_grp2', 'l_grp3']
+for user in users:
+cmd = f'useradd {user}'
+session_multihost.client[0].run_command(cmd)
+for grp in groups:
+cmd = f'groupadd {grp}'
+session_multihost.client[0].run_command(cmd)
+
+def remove_local_users():
+for user in users:
+cmd = f'userdel -rf {user}'
+session_multihost.client[0].run_command(cmd)
+for grp in groups:
+cmd = f'groupdel {grp}'
+session_multihost.client[0].run_command(cmd)
+request.addfinalizer(remove_local_users)
+
+
 @pytest.fixture(scope='function')
 def enable_multiple_responders(session_multihost, request):
 """ Enable multiple responders to sssd services """
@@ -798,6 +820,28 @@ def removesssd():
 request.addfinalizer(removesssd)
 
 
+@pytest.fixture(scope='class')
+def setup_sssd_files(session_multihost, request):
+""" Configure sssd.conf """
+tools = sssdTools(session_multihost.client[0])
+sssd_params = {'domains': 'files'}
+tools.sssd_conf('sssd', sssd_params)
+domain_section = 'domain/%s' % 'files'
+domain_params = { 'id_provider': 'files',
+ 'debug_level': '9'}
+tools.sssd_conf(domain_section, domain_params)
+start_sssd = 'systemctl start sssd'
+session_multihost.client[0].run_command(start_sssd)
+
+def removesssd():
+""" Remove sssd configuration """
+stop_sssd = 'systemctl stop sssd'
+session_multihost.client[0].run_command(stop_sssd)
+removeconf = 'rm -f %s' % (SSSD_DEFAULT_CONF)
+session_multihost.client[0].run_command(removeconf)
+request.addfinalizer(removesssd)
+
+
 @pytest.fixture(scope="class")
 def multihost(session_multihost, request):
 """ Multihost fixture to be used by tests
diff --git a/src/tests/multihost/alltests/test_files.py b/src/tests/multihost/alltests/test_files.py
new file mode 100644
index 00..65b9decf48
--- /dev/null
+++ b/src/tests/multihost/alltests/test_files.py
@@ -0,0 +1,382 @@
+from __future__ import print_function
+import pdb
+import re
+import subprocess
+import time
+from sssd.testlib.common.utils import sssdTools
+
+
+def getent_sss(multihost, obj, db):
+gtnt = f'getent {db} -s sss {obj}'
+cmd = multihost.client[0].run_command(gtnt, raiseonerr=False)
+return cmd.returncode, cmd.stdout_text
+
+
+def run_cmd(multihost, arg):
+cmd = multihost.client[0].run_command(arg, raiseonerr=False)
+return cmd.returncode, cmd.stdout_text
+
+
+@pytest.mark.usefixtures("setup_sssd_files")
+@pytest.mark.filesprovider
+@pytest.mark.tier1
+class TestFilesProvider(object):
+" This is a test case class for files-provider"
+def test_001_local_usr_caching(self, multihost, local_useradd):
+"""
+:Title: local user caching with files-provider
+:id: fa12373b-8285-4fca-afe1-5e544fd58674
+:customerscenario: false
+:steps:
+1. Create an unprivileged user
+2. User details are returned from sss_cache
+:expectedresults:
+1. Should succeed
+2. Should succeed
+"""
+multihost.client[0].service_sssd('start')
+exit_status, ot = getent_sss(multihost, 'test1', "passwd")
+assert exit_status == 0
+
+def test_002_root_usr_caching(self, multihost, backupsssdconf):
+"""
+:Title: root user caching with files-provider
+:id: 0fea4269-de00-4e34-95c5-ab106957769d
+:customerscenario: false
+:steps:
+1. SSSD should not cache root user
+:expectedresults:
+1. Should succeed
+"""
+multihost.client[0].service_sssd('start')
+exit_status, _ = getent_sss(multihost, 

[SSSD] [sssd PR#5812][+Tests] Tests: Modify ported AD tests marker to tier1_2 and fix a restore error

2021-10-06 Thread sgoveas
  URL: https://github.com/SSSD/sssd/pull/5812
Title: #5812: Tests: Modify ported AD tests marker to tier1_2 and fix a restore 
error

Label: +Tests
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5812][+Waiting for review] Tests: Modify ported AD tests marker to tier1_2 and fix a restore error

2021-10-06 Thread sgoveas
  URL: https://github.com/SSSD/sssd/pull/5812
Title: #5812: Tests: Modify ported AD tests marker to tier1_2 and fix a restore 
error

Label: +Waiting for review
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5766][comment] Sources cleanup - part 3.

2021-10-06 Thread alexey-tikhonov
  URL: https://github.com/SSSD/sssd/pull/5766
Title: #5766: Sources cleanup - part 3.

alexey-tikhonov commented:
"""
`test_kcm_renewals` is broken.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/5766#issuecomment-935981231
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5766][-Waiting for review] Sources cleanup - part 3.

2021-10-06 Thread alexey-tikhonov
  URL: https://github.com/SSSD/sssd/pull/5766
Title: #5766: Sources cleanup - part 3.

Label: -Waiting for review
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5766][+Changes requested] Sources cleanup - part 3.

2021-10-06 Thread alexey-tikhonov
  URL: https://github.com/SSSD/sssd/pull/5766
Title: #5766: Sources cleanup - part 3.

Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5801][closed] util/inotify: fixed bug in inotify event processing - 1.16 backport

2021-10-06 Thread pbrezina
   URL: https://github.com/SSSD/sssd/pull/5801
Author: alexey-tikhonov
 Title: #5801: util/inotify: fixed bug in inotify event processing - 1.16 
backport
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5801/head:pr5801
git checkout pr5801
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5801][-Ready to push] util/inotify: fixed bug in inotify event processing - 1.16 backport

2021-10-06 Thread pbrezina
  URL: https://github.com/SSSD/sssd/pull/5801
Title: #5801: util/inotify: fixed bug in inotify event processing - 1.16 
backport

Label: -Ready to push
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5801][comment] util/inotify: fixed bug in inotify event processing - 1.16 backport

2021-10-06 Thread pbrezina
  URL: https://github.com/SSSD/sssd/pull/5801
Title: #5801: util/inotify: fixed bug in inotify event processing - 1.16 
backport

pbrezina commented:
"""
Pushed PR: https://github.com/SSSD/sssd/pull/5801

* `sssd-1-16`
* 758b99590a8e1f69b4487fad9cf343525797e05f - util/inotify: fixed bug in 
inotify event processing

"""

See the full comment at 
https://github.com/SSSD/sssd/pull/5801#issuecomment-935978892
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5801][+Ready to push] util/inotify: fixed bug in inotify event processing - 1.16 backport

2021-10-06 Thread pbrezina
  URL: https://github.com/SSSD/sssd/pull/5801
Title: #5801: util/inotify: fixed bug in inotify event processing - 1.16 
backport

Label: +Ready to push
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5801][+Accepted] util/inotify: fixed bug in inotify event processing - 1.16 backport

2021-10-06 Thread thalman
  URL: https://github.com/SSSD/sssd/pull/5801
Title: #5801: util/inotify: fixed bug in inotify event processing - 1.16 
backport

Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5801][-Waiting for review] util/inotify: fixed bug in inotify event processing - 1.16 backport

2021-10-06 Thread thalman
  URL: https://github.com/SSSD/sssd/pull/5801
Title: #5801: util/inotify: fixed bug in inotify event processing - 1.16 
backport

Label: -Waiting for review
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5801][comment] util/inotify: fixed bug in inotify event processing - 1.16 backport

2021-10-06 Thread thalman
  URL: https://github.com/SSSD/sssd/pull/5801
Title: #5801: util/inotify: fixed bug in inotify event processing - 1.16 
backport

thalman commented:
"""
Thank you for the patch, LGTM, ACK
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/5801#issuecomment-935825772
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5809][closed] PR CI Test - Do not merge

2021-10-06 Thread pbrezina
   URL: https://github.com/SSSD/sssd/pull/5809
Author: justin-stephenson
 Title: #5809: PR CI Test - Do not merge
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5809/head:pr5809
git checkout pr5809
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5809][comment] PR CI Test - Do not merge

2021-10-06 Thread pbrezina
  URL: https://github.com/SSSD/sssd/pull/5809
Title: #5809: PR CI Test - Do not merge

pbrezina commented:
"""
Works now. Closing.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/5809#issuecomment-935801507
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5722][closed] NSS client: avoid using NETDB_INTERNAL if daemon is not available

2021-10-06 Thread pbrezina
   URL: https://github.com/SSSD/sssd/pull/5722
Author: grawity
 Title: #5722: NSS client: avoid using NETDB_INTERNAL if daemon is not available
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5722/head:pr5722
git checkout pr5722
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5722][-Ready to push] NSS client: avoid using NETDB_INTERNAL if daemon is not available

2021-10-06 Thread pbrezina
  URL: https://github.com/SSSD/sssd/pull/5722
Title: #5722: NSS client: avoid using NETDB_INTERNAL if daemon is not available

Label: -Ready to push
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5722][-Accepted] NSS client: avoid using NETDB_INTERNAL if daemon is not available

2021-10-06 Thread pbrezina
  URL: https://github.com/SSSD/sssd/pull/5722
Title: #5722: NSS client: avoid using NETDB_INTERNAL if daemon is not available

Label: -Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5722][+Pushed] NSS client: avoid using NETDB_INTERNAL if daemon is not available

2021-10-06 Thread pbrezina
  URL: https://github.com/SSSD/sssd/pull/5722
Title: #5722: NSS client: avoid using NETDB_INTERNAL if daemon is not available

Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5722][comment] NSS client: avoid using NETDB_INTERNAL if daemon is not available

2021-10-06 Thread pbrezina
  URL: https://github.com/SSSD/sssd/pull/5722
Title: #5722: NSS client: avoid using NETDB_INTERNAL if daemon is not available

pbrezina commented:
"""
Pushed PR: https://github.com/SSSD/sssd/pull/5722

* `master`
* 1a1e914b95c6415533f318f32da58a04015fa912 - NSS client: avoid using 
NETDB_INTERNAL if daemon is not available

"""

See the full comment at 
https://github.com/SSSD/sssd/pull/5722#issuecomment-935800928
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5795][-Accepted] debug: Add chain ID support for journald logger

2021-10-06 Thread pbrezina
  URL: https://github.com/SSSD/sssd/pull/5795
Title: #5795: debug: Add chain ID support for journald logger

Label: -Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5795][closed] debug: Add chain ID support for journald logger

2021-10-06 Thread pbrezina
   URL: https://github.com/SSSD/sssd/pull/5795
Author: justin-stephenson
 Title: #5795: debug: Add chain ID support for journald logger
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5795/head:pr5795
git checkout pr5795
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5795][-Ready to push] debug: Add chain ID support for journald logger

2021-10-06 Thread pbrezina
  URL: https://github.com/SSSD/sssd/pull/5795
Title: #5795: debug: Add chain ID support for journald logger

Label: -Ready to push
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5795][comment] debug: Add chain ID support for journald logger

2021-10-06 Thread pbrezina
  URL: https://github.com/SSSD/sssd/pull/5795
Title: #5795: debug: Add chain ID support for journald logger

pbrezina commented:
"""
Pushed PR: https://github.com/SSSD/sssd/pull/5795

* `master`
* 3d8dd1282ffb7d0188e36d0109340ce622745717 - debug: Add chain ID support 
for journald logger

"""

See the full comment at 
https://github.com/SSSD/sssd/pull/5795#issuecomment-935800539
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5804][closed] Tests: Fix Failure of sssctl_local test

2021-10-06 Thread pbrezina
   URL: https://github.com/SSSD/sssd/pull/5804
Author: aborah-sudo
 Title: #5804: Tests: Fix Failure of sssctl_local test
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5804/head:pr5804
git checkout pr5804
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5804][-Ready to push] Tests: Fix Failure of sssctl_local test

2021-10-06 Thread pbrezina
  URL: https://github.com/SSSD/sssd/pull/5804
Title: #5804: Tests: Fix Failure of sssctl_local test

Label: -Ready to push
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5804][-Accepted] Tests: Fix Failure of sssctl_local test

2021-10-06 Thread pbrezina
  URL: https://github.com/SSSD/sssd/pull/5804
Title: #5804: Tests: Fix Failure of sssctl_local test

Label: -Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5804][comment] Tests: Fix Failure of sssctl_local test

2021-10-06 Thread pbrezina
  URL: https://github.com/SSSD/sssd/pull/5804
Title: #5804: Tests: Fix Failure of sssctl_local test

pbrezina commented:
"""
Pushed PR: https://github.com/SSSD/sssd/pull/5804

* `master`
* 51eaed9d0627465ee90142dd092816abb84db3e9 - Tests: Fix Failure of 
sssctl_local test

"""

See the full comment at 
https://github.com/SSSD/sssd/pull/5804#issuecomment-935800225
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5804][+Pushed] Tests: Fix Failure of sssctl_local test

2021-10-06 Thread pbrezina
  URL: https://github.com/SSSD/sssd/pull/5804
Title: #5804: Tests: Fix Failure of sssctl_local test

Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5806][closed] Tests: files provider testcases

2021-10-06 Thread shridhargadekar
   URL: https://github.com/SSSD/sssd/pull/5806
Author: shridhargadekar
 Title: #5806: Tests: files provider testcases
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5806/head:pr5806
git checkout pr5806
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5806][comment] Tests: files provider testcases

2021-10-06 Thread shridhargadekar
  URL: https://github.com/SSSD/sssd/pull/5806
Title: #5806: Tests: files provider testcases

shridhargadekar commented:
"""
Code will be rearranged in the alltests instead of a separate dir.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/5806#issuecomment-935790326
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5722][+Ready to push] NSS client: avoid using NETDB_INTERNAL if daemon is not available

2021-10-06 Thread sssd-bot
  URL: https://github.com/SSSD/sssd/pull/5722
Title: #5722: NSS client: avoid using NETDB_INTERNAL if daemon is not available

Label: +Ready to push
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5795][+Ready to push] debug: Add chain ID support for journald logger

2021-10-06 Thread sssd-bot
  URL: https://github.com/SSSD/sssd/pull/5795
Title: #5795: debug: Add chain ID support for journald logger

Label: +Ready to push
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5804][+Ready to push] Tests: Fix Failure of sssctl_local test

2021-10-06 Thread sssd-bot
  URL: https://github.com/SSSD/sssd/pull/5804
Title: #5804: Tests: Fix Failure of sssctl_local test

Label: +Ready to push
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5812][opened] Tests: Modify ported AD tests marker to tier1_2 and fix a restore error

2021-10-06 Thread sgoveas
   URL: https://github.com/SSSD/sssd/pull/5812
Author: sgoveas
 Title: #5812: Tests: Modify ported AD tests marker to tier1_2 and fix a 
restore error
Action: opened

PR body:
"""
Use tier1_2 marker for newly ported ad parameters tests to reduce runtime to 1 
hour and fix and ldap.conf backup restore
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5812/head:pr5812
git checkout pr5812
From bfbea33ccc8bc373662e13660bc732361dc69b3a Mon Sep 17 00:00:00 2001
From: Steeve Goveas 
Date: Wed, 6 Oct 2021 13:20:26 +0530
Subject: [PATCH 1/2] Test: Update marker to tier1_2 for some ad tier1 tests

To reduce test runtime to around 1 hour
---
 src/tests/multihost/ad/pytest.ini |  3 +-
 .../multihost/ad/test_adparameters_ported.py  | 43 +--
 2 files changed, 3 insertions(+), 43 deletions(-)

diff --git a/src/tests/multihost/ad/pytest.ini b/src/tests/multihost/ad/pytest.ini
index bd4f102151..043f6c7f24 100644
--- a/src/tests/multihost/ad/pytest.ini
+++ b/src/tests/multihost/ad/pytest.ini
@@ -8,6 +8,7 @@ markers =
smbsecretrotation: Samba Secret database rotation
sudo: Test cases related to sudo using AD backend.
cifs: Cifs test cases
-   tier1: All tier1 test cases
+   tier1: tier1 test cases with run time of aproximately 60 minutes
+   tier1_2: tier1 test cases split to keep runtime upto 60 minutes
tier2: All tier2 test cases
tier3: All tier3 test cases
diff --git a/src/tests/multihost/ad/test_adparameters_ported.py b/src/tests/multihost/ad/test_adparameters_ported.py
index 21a4739738..b84aa645cb 100644
--- a/src/tests/multihost/ad/test_adparameters_ported.py
+++ b/src/tests/multihost/ad/test_adparameters_ported.py
@@ -180,13 +180,13 @@ def set_ssh_key_ldap(session_multihost, user, pubkey, operation="replace"):
 return cmd.returncode == 0
 
 
+@pytest.mark.tier1_2
 @pytest.mark.adparameters
 @pytest.mark.usefixtures("change_client_hostname")
 class TestADParamsPorted:
 """ BZ Automated Test Cases for AD Parameters ported from bash"""
 
 @staticmethod
-@pytest.mark.tier1
 def test_0001_ad_parameters_domain(
 multihost, adjoin, create_aduser_group):
 """
@@ -260,7 +260,6 @@ def test_0001_ad_parameters_domain(
 assert su_result, "The su command failed!"
 
 @staticmethod
-@pytest.mark.tier1
 def test_0002_ad_parameters_junk_domain(
 multihost, adjoin, create_aduser_group):
 """
@@ -333,7 +332,6 @@ def test_0002_ad_parameters_junk_domain(
 assert "segfault" not in log_msg_str, "Segfault present in the log!"
 
 @staticmethod
-@pytest.mark.tier1
 def test_0003_ad_parameters_junk_domain_invalid_keytab(
 multihost, adjoin, create_aduser_group):
 """
@@ -450,7 +448,6 @@ def test_0003_ad_parameters_junk_domain_invalid_keytab(
 assert "Option krb5_realm set to JUNK" in log_str
 
 @staticmethod
-@pytest.mark.tier1
 def test_0004_ad_parameters_valid_domain_shorthost(
 multihost, adjoin, create_aduser_group):
 """
@@ -527,7 +524,6 @@ def test_0004_ad_parameters_valid_domain_shorthost(
 assert su_result, "The su command failed!"
 
 @staticmethod
-@pytest.mark.tier1
 def test_0005_ad_parameters_blank_domain(
 multihost, adjoin, create_aduser_group):
 """
@@ -607,7 +603,6 @@ def test_0005_ad_parameters_blank_domain(
 assert su_result, "The su command failed!"
 
 @staticmethod
-@pytest.mark.tier1
 def test_0006_ad_parameters_homedir_override_nss(
 multihost, adjoin, create_plain_aduser_group):
 """
@@ -657,7 +652,6 @@ def test_0006_ad_parameters_homedir_override_nss(
usr_cmd.stdout_text
 
 @staticmethod
-@pytest.mark.tier1
 def test_0007_ad_parameters_homedir_override_domain(
 multihost, adjoin, create_plain_aduser_group):
 """
@@ -706,7 +700,6 @@ def test_0007_ad_parameters_homedir_override_domain(
usr_cmd.stdout_text
 
 @staticmethod
-@pytest.mark.tier1
 def test_0008_ad_parameters_homedir_override_both(
 multihost, adjoin, create_plain_aduser_group):
 """
@@ -756,7 +749,6 @@ def test_0008_ad_parameters_homedir_override_both(
usr_cmd.stdout_text
 
 @staticmethod
-@pytest.mark.tier1
 @pytest.mark.skip(reason="The ldap sasl authid just does not work.")
 def test_0009_ad_parameters_ldap_sasl_full(
 multihost, adjoin, create_aduser_group, fetch_ca_cert):
@@ -859,7 +851,6 @@ def test_0009_ad_parameters_ldap_sasl_full(
 assert su_result, f"Su for user {aduser} failed!"
 
 @staticmethod
-@pytest.mark.tier1
 @pytest.mark.skip(reason="The ldap sasl authid just does not work.")
 def test_0010_ad_parameters_ldap_sasl_short(
 multihost, adjoin, create_aduser_group):
@@ -947,7 +938,6 @@ def test_0010_ad_parameters_ldap_sasl_short(
 

[SSSD] [sssd PR#5808][comment] Tests: Remove shadow-utils test cases from sssd repo

2021-10-06 Thread aborah-sudo
  URL: https://github.com/SSSD/sssd/pull/5808
Title: #5808: Tests: Remove shadow-utils test cases from sssd repo

aborah-sudo commented:
"""
> I think you shouldn't have merged the PR. @pbrezina has a script that does it 
> in a fancy way.

By mistake  its was merged by me . 
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/5808#issuecomment-935661297
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5808][comment] Tests: Remove shadow-utils test cases from sssd repo

2021-10-06 Thread ikerexxe
  URL: https://github.com/SSSD/sssd/pull/5808
Title: #5808: Tests: Remove shadow-utils test cases from sssd repo

ikerexxe commented:
"""
I think you shouldn't have merged the PR. @pbrezina has a script that does it 
in a fancy way.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/5808#issuecomment-935653746
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD]WARNING: MERGED [sssd PR#5808][closed] Tests: Remove shadow-utils test cases from sssd repo

2021-10-06 Thread aborah-sudo
*WARNING: this pull request has been merged!*
This is only mirrored repo thus any changes will be erased. Please push 
commit(s) to authoritative repository.

   URL: https://github.com/SSSD/sssd/pull/5808
Author: aborah-sudo
 Title: #5808: Tests: Remove shadow-utils test cases from sssd repo
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5808/head:pr5808
git checkout pr5808
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5808][+Accepted] Tests: Remove shadow-utils test cases from sssd repo

2021-10-06 Thread ikerexxe
  URL: https://github.com/SSSD/sssd/pull/5808
Title: #5808: Tests: Remove shadow-utils test cases from sssd repo

Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5808][comment] Tests: Remove shadow-utils test cases from sssd repo

2021-10-06 Thread ikerexxe
  URL: https://github.com/SSSD/sssd/pull/5808
Title: #5808: Tests: Remove shadow-utils test cases from sssd repo

ikerexxe commented:
"""
LGTM. Thanks for moving it to the shadow-utils test repository.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/5808#issuecomment-935645839
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[SSSD] [sssd PR#5806][synchronized] Tests: files provider testcases

2021-10-06 Thread shridhargadekar
   URL: https://github.com/SSSD/sssd/pull/5806
Author: shridhargadekar
 Title: #5806: Tests: files provider testcases
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5806/head:pr5806
git checkout pr5806
From dcb4b3575a6804d241a63a716d9e3a3d76383e89 Mon Sep 17 00:00:00 2001
From: Shridhar Gadekar 
Date: Tue, 5 Oct 2021 00:13:38 +0530
Subject: [PATCH] verifies: ##4295 bugzilla:

---
 src/tests/multihost/files/conftest.py |  97 +
 .../multihost/files/test_files_provider.py| 382 ++
 2 files changed, 479 insertions(+)
 create mode 100644 src/tests/multihost/files/conftest.py
 create mode 100644 src/tests/multihost/files/test_files_provider.py

diff --git a/src/tests/multihost/files/conftest.py b/src/tests/multihost/files/conftest.py
new file mode 100644
index 00..5e405839ac
--- /dev/null
+++ b/src/tests/multihost/files/conftest.py
@@ -0,0 +1,97 @@
+"""conftest.py for all tests"""
+
+from __future__ import print_function
+import subprocess
+import os
+import time
+import posixpath
+import pytest
+from sssd.testlib.common.utils import sssdTools
+from subprocess import CalledProcessError
+from pytest_multihost import make_multihost_fixture
+from sssd.testlib.common.paths import SSSD_DEFAULT_CONF, NSSWITCH_DEFAULT_CONF
+from sssd.testlib.common.qe_class import session_multihost
+from sssd.testlib.common.qe_class import create_testdir
+from datetime import datetime, timedelta
+
+
+def pytest_configure():
+""" Namespace hook to add below dict in the pytest namespace """
+pytest.num_masters = 0
+pytest.num_ad = 0
+pytest.num_atomic = 0
+pytest.num_replicas = 0
+pytest.num_clients = 1
+pytest.num_others = 0
+
+
+
+@pytest.fixture(scope="function")
+def useradd(session_multihost, request):
+tool = sssdTools(session_multihost.client[0])
+users = ['test1', 'user1']
+groups = ['localgrp', 'l_grp1', 'l_grp2', 'l_grp3']
+for user in users:
+cmd = f'useradd {user}'
+session_multihost.client[0].run_command(cmd)
+for grp in groups:
+cmd = f'groupadd {grp}'
+session_multihost.client[0].run_command(cmd)
+
+def remove_local_users():
+for user in users:
+cmd = f'userdel -rf {user}'
+session_multihost.client[0].run_command(cmd)
+for grp in groups:
+cmd = f'groupdel {grp}'
+session_multihost.client[0].run_command(cmd)
+request.addfinalizer(remove_local_users)
+
+
+@pytest.fixture(scope='function')
+def backupsssdconf(session_multihost, request):
+""" Backup and restore sssd.conf """
+bkup = 'cp -f %s %s.orig' % (SSSD_DEFAULT_CONF,
+ SSSD_DEFAULT_CONF)
+session_multihost.client[0].run_command(bkup)
+session_multihost.client[0].service_sssd('stop')
+
+def restoresssdconf():
+""" Restore sssd.conf """
+restore = 'cp -f %s.orig %s' % (SSSD_DEFAULT_CONF, SSSD_DEFAULT_CONF)
+session_multihost.client[0].run_command(restore)
+request.addfinalizer(restoresssdconf)
+#+++
+@pytest.fixture(scope="class")
+def multihost(session_multihost, request):
+""" Multihost fixture to be used by tests
+:param obj session_multihost: multihost object
+:return obj session_multihost: return multihost object
+"""
+if hasattr(request.cls(), 'class_setup'):
+request.cls().class_setup(session_multihost)
+request.addfinalizer(
+lambda: request.cls().class_teardown(session_multihost))
+return session_multihost
+
+
+@pytest.fixture(scope='class')
+def setup_sssd(session_multihost, request):
+""" Configure sssd.conf """
+tools = sssdTools(session_multihost.client[0])
+sssd_params = {'domains': 'files'}
+tools.sssd_conf('sssd', sssd_params)
+domain_section = 'domain/%s' % 'files'
+domain_params = { 'id_provider': 'files',
+ 'debug_level': '9'}
+tools.sssd_conf(domain_section, domain_params)
+start_sssd = 'systemctl start sssd'
+session_multihost.client[0].run_command(start_sssd)
+
+def removesssd():
+""" Remove sssd configuration """
+stop_sssd = 'systemctl stop sssd'
+session_multihost.client[0].run_command(stop_sssd)
+removeconf = 'rm -f %s' % (SSSD_DEFAULT_CONF)
+session_multihost.client[0].run_command(removeconf)
+request.addfinalizer(removesssd)
diff --git a/src/tests/multihost/files/test_files_provider.py b/src/tests/multihost/files/test_files_provider.py
new file mode 100644
index 00..2fa64cae79
--- /dev/null
+++ b/src/tests/multihost/files/test_files_provider.py
@@ -0,0 +1,382 @@
+from __future__ import print_function
+import pdb
+import re
+import subprocess
+import time
+from sssd.testlib.common.utils import sssdTools
+
+
+def getent_sss(multihost, obj, db):
+gtnt = f'getent {db} -s sss {obj}'
+cmd =